162003 2016-09-14 17:24:41 -0700 ASSERT_NOT_REACHED when using spread inside an array literal with Function.prototype.apply 2016-09-28 17:20:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1229843 0 joepeck 2016-09-14 17:24:41 -0700 Summary: ASSERT_NOT_REACHED when using spread inside an array literal with Function.prototype.apply Steps to Reproduce: 1. jsc> (function() {}).apply(null, [1, ...[]]) => CRASH - should not be reached Assertion: >>> function f() {}; f.apply(null, [1, ...[]]) SHOULD NEVER BE REACHED Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp(3981) : virtual JSC::RegisterID *JSC::SpreadExpressionNode::emitBytecode(JSC::BytecodeGenerator &, JSC::RegisterID *) 1 0x1134f9bed WTFCrash 2 0x11314c265 JSC::SpreadExpressionNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 3 0x1126be293 JSC::BytecodeGenerator::emitNodeInTailPosition(JSC::RegisterID*, JSC::ExpressionNode*) 4 0x11269cd2e JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::ExpressionNode*) 5 0x113131339 JSC::ArgumentListNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 6 0x1126be293 JSC::BytecodeGenerator::emitNodeInTailPosition(JSC::RegisterID*, JSC::ExpressionNode*) 7 0x11269cd2e JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::ExpressionNode*) 8 0x1126a7367 JSC::BytecodeGenerator::emitCall(JSC::OpcodeID, JSC::RegisterID*, JSC::RegisterID*, JSC::ExpectedFunction, JSC::CallArguments&, JSC::JSTextPosition const&, JSC::JSTextPosition const&, JSC::JSTextPosition const&) 9 0x1126a77d5 JSC::BytecodeGenerator::emitCallInTailPosition(JSC::RegisterID*, JSC::RegisterID*, JSC::ExpectedFunction, JSC::CallArguments&, JSC::JSTextPosition const&, JSC::JSTextPosition const&, JSC::JSTextPosition const&) 10 0x113137356 JSC::ApplyFunctionCallDotNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 11 0x1126be293 JSC::BytecodeGenerator::emitNodeInTailPosition(JSC::RegisterID*, JSC::ExpressionNode*) 12 0x11269cd2e JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::ExpressionNode*) 13 0x1131405ac JSC::ExprStatementNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 14 0x1126c6433 JSC::BytecodeGenerator::emitNodeInTailPosition(JSC::RegisterID*, JSC::StatementNode*) 15 0x1131403db JSC::SourceElements::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 16 0x1131468f7 JSC::ScopeNode::emitStatementsBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 17 0x113146635 JSC::emitProgramNodeBytecode(JSC::BytecodeGenerator&, JSC::ScopeNode&) 18 0x113146544 JSC::ProgramNode::emitBytecode(JSC::BytecodeGenerator&, JSC::RegisterID*) 19 0x11268e7f1 JSC::BytecodeGenerator::generate() 20 0x11276e105 JSC::ParserError JSC::BytecodeGenerator::generate<JSC::ProgramNode*, JSC::UnlinkedProgramCodeBlock*&, JSC::DebuggerMode&, JSC::VariableEnvironment const*&>(JSC::VM&, JSC::ProgramNode*&&, JSC::UnlinkedProgramCodeBlock*&&&, JSC::DebuggerMode&&&, JSC::VariableEnvironment const*&&&) 21 0x112766fc1 JSC::UnlinkedProgramCodeBlock* JSC::CodeCache::getGlobalCodeBlock<JSC::UnlinkedProgramCodeBlock, JSC::ProgramExecutable>(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::JSParserCommentMode, JSC::DebuggerMode, JSC::ParserError&, JSC::EvalContextType, JSC::VariableEnvironment const*) 22 0x112766580 JSC::CodeCache::getProgramCodeBlock(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserBuiltinMode, JSC::JSParserStrictMode, JSC::DebuggerMode, JSC::ParserError&) 23 0x112f9b86a JSC::JSGlobalObject::createProgramCodeBlock(JSC::ExecState*, JSC::ProgramExecutable*, JSC::JSObject**) 24 0x112c60987 JSC::ProgramExecutable::initializeGlobalProperties(JSC::VM&, JSC::ExecState*, JSC::JSScope*) 25 0x112e6191d JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) 26 0x1127bbc3d JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 27 0x10f752078 runInteractive(GlobalObject*) 28 0x10f74942b runJSC(JSC::VM*, CommandLine) 29 0x10f74811f jscmain(int, char**) 30 0x10f747fa6 main 31 0x7fff994f6255 start Notes: - Covered by a bunch of test262 tests, including: test262/test/language/expressions/array/spread-mult-empty.js 1229844 1 288902 joepeck 2016-09-14 17:32:38 -0700 Created attachment 288902 [PATCH] Proposed Fix 1229850 2 288902 joepeck 2016-09-14 17:40:11 -0700 Comment on attachment 288902 [PATCH] Proposed Fix cq- a few more test262 tests now pass that I missed. 1229851 3 288904 joepeck 2016-09-14 17:41:24 -0700 Created attachment 288904 [PATCH] Proposed Fix 1229858 4 288904 commit-queue 2016-09-14 18:16:52 -0700 Comment on attachment 288904 [PATCH] Proposed Fix Clearing flags on attachment: 288904 Committed r205944: <http://trac.webkit.org/changeset/205944> 1229859 5 commit-queue 2016-09-14 18:16:56 -0700 All reviewed patches have been landed. Closing bug. 1234633 6 mark.lam 2016-09-28 17:19:19 -0700 <rdar://problem/27404839> 288902 2016-09-14 17:32:38 -0700 2016-09-14 17:41:24 -0700 [PATCH] Proposed Fix spread-1.patch text/plain 5758 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MWIyYTQ5Ni4uZjQzOGUwMiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxNi0wOS0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCB3 aGVuIHVzaW5nIHNwcmVhZCBpbnNpZGUgYW4gYXJyYXkgbGl0ZXJhbCB3aXRoIEZ1bmN0aW9uLnBy b3RvdHlwZS5hcHBseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYyMDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBzdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanM6CisgICAgICAgICogdGVzdDI2Mi55YW1s OgorCisyMDE2LTA5LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK ICAgICAgICAgdGVzdDI2MjogVmFyaW91cyBDb25zdHJ1Y3RvcnMgbGVuZ3RoIHByb3BlcnRpZXMg c2hvdWxkIGJlIGNvbmZpZ3VyYWJsZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYxOTk4CiAKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3NwcmVh ZC1jYWxsaW5nLmpzIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanMKaW5kZXggMjUx NzJkYy4uOGI5MDVlOSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcu anMKKysrIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanMKQEAgLTY4LDYgKzY4LDgg QEAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CiAgICAgdGVzdEZ1bmN0aW9uKDAs IC4uLiIxMjM0NSIsIC4uLm9iamVjdDMpOwogICAgIHRlc3RFbXB0eSguLi5bXSk7CiAgICAgdGVz dEZ1bmN0aW9uKC4uLm9iamVjdDQsIC4uLm9iamVjdDQpOworICAgIHRlc3RGdW5jdGlvbi5jYWxs KG51bGwsIDAsIC4uLlsxLCAyLCAzXSwgNCwgNSwgNiwgNywgOCwgOSk7CisgICAgdGVzdEZ1bmN0 aW9uLmFwcGx5KG51bGwsIFswLCAuLi5bMSwgMiwgM10sIDQsIDUsIDYsIDcsIDgsIDldKQogICAg IGxldCBmYWlsZWQgPSBmYWxzZTsKICAgICB0cnkgewogICAgICAgICB0ZXN0RnVuY3Rpb24oLi4u b2JqZWN0VGhyb3cpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwgYi9KU1Rlc3Rz L3Rlc3QyNjIueWFtbAppbmRleCBhNmVhMDlhLi5mOWFhYTkwIDEwMDY0NAotLS0gYS9KU1Rlc3Rz L3Rlc3QyNjIueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIueWFtbApAQCAtNTMyMzYsMjEgKzUz MjM2LDIxIEBACiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9hcnJh eS9zcHJlYWQtZXJyLXNuZ2wtZXJyLXVucmVzb2x2YWJsZS5qcwogICBjbWQ6IHJ1blRlc3QyNjIg Om5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIs ICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KIC0gcGF0aDogdGVzdDI2 Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5L3NwcmVhZC1tdWx0LWVtcHR5LmpzCi0g IGNtZDogcnVuVGVzdDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJu ZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQorICBjbWQ6 IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNz L2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQogLSBwYXRoOiB0 ZXN0MjYyL3Rlc3QvbGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQtZW1wdHku anMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4u L2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6c3Ry aWN0XQorICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8u Li8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBb OnN0cmljdF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5 L3NwcmVhZC1tdWx0LWV4cHIuanMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRp b24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5l c3Mvc3RhLmpzIl0sIFtdCisgIGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24i LCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mv c3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9h cnJheS9zcHJlYWQtbXVsdC1leHByLmpzCi0gIGNtZDogcnVuVGVzdDI2MiA6ZmFpbCwgIk5vRXhj ZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9o YXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJO b0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4v Li4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5n dWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtbXVsdC1pdGVyLmpzCi0gIGNtZDogcnVuVGVz dDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5q cyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQorICBjbWQ6IHJ1blRlc3QyNjIg Om5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIs ICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQogLSBwYXRoOiB0ZXN0MjYyL3Rlc3Qv bGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQtaXRlci5qcwotICBjbWQ6IHJ1 blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3Nl cnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCisgIGNtZDog cnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3Mv YXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6c3RyaWN0XQogLSBw YXRoOiB0ZXN0MjYyL3Rlc3QvbGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQt bGl0ZXJhbC5qcwotICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4v Li4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMi XSwgW10KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4v Li4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwg W10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5L3NwcmVh ZC1tdWx0LWxpdGVyYWwuanMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24i LCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mv c3RhLmpzIl0sIFs6c3RyaWN0XQorICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0 aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJu ZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4 cHJlc3Npb25zL2FycmF5L3NwcmVhZC1zbmdsLWVtcHR5LmpzCiAgIGNtZDogcnVuVGVzdDI2MiA6 bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwg Ii4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9s YW5ndWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtc25nbC1lbXB0eS5qcwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggMDE1NWU3ZS4uZGZkMGJjYSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTYtMDktMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQgd2hlbiB1c2luZyBz cHJlYWQgaW5zaWRlIGFuIGFycmF5IGxpdGVyYWwgd2l0aCBGdW5jdGlvbi5wcm90b3R5cGUuYXBw bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjAw MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0 ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkFycmF5Tm9kZTo6aXNT aW1wbGVBcnJheSk6CisgICAgICAgIERvbid0IHRyZWF0IGFuIEFycmF5IHRoYXQgaGFzIGEgc3By ZWFkIGV4cHJlc3Npb24gaW5zaWRlIGl0IGFzIHNpbXBsZS4KKyAgICAgICAgVGhpcyBhdm9pZHMg YSBmYXN0IHBhdGggZm9yIGYuYXBwbHkoeCwgc2ltcGxlQXJyYXkpIHRoYXQgd2FzIG5vdCBoYW5k bGluZworICAgICAgICBzcHJlYWQgZXhwcmVzc2lvbnMgd2l0aGluIGFycmF5cywgYW5kIGluc3Rl YWQgdGFraW5nIGEgcGF0aCB0aGF0IGNhbgorICAgICAgICBoYW5kbGUgdGhlIHNwcmVhZGluZy4K KworMjAxNi0wOS0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAg ICAgICAgIHRlc3QyNjI6IFZhcmlvdXMgQ29uc3RydWN0b3JzIGxlbmd0aCBwcm9wZXJ0aWVzIHNo b3VsZCBiZSBjb25maWd1cmFibGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MTk5OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKaW5kZXggYzgwODAzYi4uZGRiNTZmMSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNw cApAQCAtNDEzLDYgKzQxMyw4IEBAIGJvb2wgQXJyYXlOb2RlOjppc1NpbXBsZUFycmF5KCkgY29u c3QKICAgICBmb3IgKEVsZW1lbnROb2RlKiBwdHIgPSBtX2VsZW1lbnQ7IHB0cjsgcHRyID0gcHRy LT5uZXh0KCkpIHsKICAgICAgICAgaWYgKHB0ci0+ZWxpc2lvbigpKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgICAgICBpZiAocHRyLT52YWx1ZSgpLT5pc1NwcmVhZEV4cHJlc3Npb24o KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgcmV0dXJuIHRydWU7CiB9 Cg== 288904 2016-09-14 17:41:24 -0700 2016-09-14 18:16:52 -0700 [PATCH] Proposed Fix spread-2.patch text/plain 6816 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MWIyYTQ5Ni4uZjQzOGUwMiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxNi0wOS0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCB3 aGVuIHVzaW5nIHNwcmVhZCBpbnNpZGUgYW4gYXJyYXkgbGl0ZXJhbCB3aXRoIEZ1bmN0aW9uLnBy b3RvdHlwZS5hcHBseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYyMDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBzdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanM6CisgICAgICAgICogdGVzdDI2Mi55YW1s OgorCisyMDE2LTA5LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK ICAgICAgICAgdGVzdDI2MjogVmFyaW91cyBDb25zdHJ1Y3RvcnMgbGVuZ3RoIHByb3BlcnRpZXMg c2hvdWxkIGJlIGNvbmZpZ3VyYWJsZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYxOTk4CiAKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3NwcmVh ZC1jYWxsaW5nLmpzIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanMKaW5kZXggMjUx NzJkYy4uOGI5MDVlOSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcu anMKKysrIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLWNhbGxpbmcuanMKQEAgLTY4LDYgKzY4LDgg QEAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7CiAgICAgdGVzdEZ1bmN0aW9uKDAs IC4uLiIxMjM0NSIsIC4uLm9iamVjdDMpOwogICAgIHRlc3RFbXB0eSguLi5bXSk7CiAgICAgdGVz dEZ1bmN0aW9uKC4uLm9iamVjdDQsIC4uLm9iamVjdDQpOworICAgIHRlc3RGdW5jdGlvbi5jYWxs KG51bGwsIDAsIC4uLlsxLCAyLCAzXSwgNCwgNSwgNiwgNywgOCwgOSk7CisgICAgdGVzdEZ1bmN0 aW9uLmFwcGx5KG51bGwsIFswLCAuLi5bMSwgMiwgM10sIDQsIDUsIDYsIDcsIDgsIDldKQogICAg IGxldCBmYWlsZWQgPSBmYWxzZTsKICAgICB0cnkgewogICAgICAgICB0ZXN0RnVuY3Rpb24oLi4u b2JqZWN0VGhyb3cpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwgYi9KU1Rlc3Rz L3Rlc3QyNjIueWFtbAppbmRleCBhNmVhMDlhLi5jOWVmMTRhIDEwMDY0NAotLS0gYS9KU1Rlc3Rz L3Rlc3QyNjIueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIueWFtbApAQCAtNTMyMzYsMjEgKzUz MjM2LDIxIEBACiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9hcnJh eS9zcHJlYWQtZXJyLXNuZ2wtZXJyLXVucmVzb2x2YWJsZS5qcwogICBjbWQ6IHJ1blRlc3QyNjIg Om5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIs ICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KIC0gcGF0aDogdGVzdDI2 Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5L3NwcmVhZC1tdWx0LWVtcHR5LmpzCi0g IGNtZDogcnVuVGVzdDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJu ZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQorICBjbWQ6 IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNz L2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQogLSBwYXRoOiB0 ZXN0MjYyL3Rlc3QvbGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQtZW1wdHku anMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4u L2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6c3Ry aWN0XQorICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8u Li8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBb OnN0cmljdF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5 L3NwcmVhZC1tdWx0LWV4cHIuanMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRp b24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5l c3Mvc3RhLmpzIl0sIFtdCisgIGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24i LCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mv c3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9h cnJheS9zcHJlYWQtbXVsdC1leHByLmpzCi0gIGNtZDogcnVuVGVzdDI2MiA6ZmFpbCwgIk5vRXhj ZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9o YXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJO b0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4v Li4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5n dWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtbXVsdC1pdGVyLmpzCi0gIGNtZDogcnVuVGVz dDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5q cyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQorICBjbWQ6IHJ1blRlc3QyNjIg Om5vcm1hbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIs ICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbXQogLSBwYXRoOiB0ZXN0MjYyL3Rlc3Qv bGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQtaXRlci5qcwotICBjbWQ6IHJ1 blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3Nl cnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCisgIGNtZDog cnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3Mv YXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6c3RyaWN0XQogLSBw YXRoOiB0ZXN0MjYyL3Rlc3QvbGFuZ3VhZ2UvZXhwcmVzc2lvbnMvYXJyYXkvc3ByZWFkLW11bHQt bGl0ZXJhbC5qcwotICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4v Li4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMi XSwgW10KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4v Li4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwg W10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4cHJlc3Npb25zL2FycmF5L3NwcmVh ZC1tdWx0LWxpdGVyYWwuanMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24i LCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mv c3RhLmpzIl0sIFs6c3RyaWN0XQorICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5vRXhjZXB0 aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJu ZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL2V4 cHJlc3Npb25zL2FycmF5L3NwcmVhZC1zbmdsLWVtcHR5LmpzCiAgIGNtZDogcnVuVGVzdDI2MiA6 bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwg Ii4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9s YW5ndWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtc25nbC1lbXB0eS5qcwpAQCAtNTMyNjAs OSArNTMyNjAsOSBAQAogLSBwYXRoOiB0ZXN0MjYyL3Rlc3QvbGFuZ3VhZ2UvZXhwcmVzc2lvbnMv YXJyYXkvc3ByZWFkLXNuZ2wtZXhwci5qcwogICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5v RXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8u Li9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1 YWdlL2V4cHJlc3Npb25zL2FycmF5L3NwcmVhZC1zbmdsLWl0ZXIuanMKLSAgY21kOiBydW5UZXN0 MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0Lmpz IiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCisgIGNtZDogcnVuVGVzdDI2MiA6 bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwg Ii4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9s YW5ndWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtc25nbC1pdGVyLmpzCi0gIGNtZDogcnVu VGVzdDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2Vy dC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0KKyAgY21kOiBy dW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9h c3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBh dGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9hcnJheS9zcHJlYWQtc25nbC1s aXRlcmFsLmpzCiAgIGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4u Ly4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpz Il0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9leHByZXNzaW9ucy9hcnJheS9z cHJlYWQtc25nbC1saXRlcmFsLmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAwMTU1ZTdl Li5kZmQwYmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAx Ni0wOS0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCB3aGVuIHVzaW5nIHNwcmVhZCBpbnNpZGUgYW4gYXJyYXkgbGl0 ZXJhbCB3aXRoIEZ1bmN0aW9uLnByb3RvdHlwZS5hcHBseQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMDAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNw cDoKKyAgICAgICAgKEpTQzo6QXJyYXlOb2RlOjppc1NpbXBsZUFycmF5KToKKyAgICAgICAgRG9u J3QgdHJlYXQgYW4gQXJyYXkgdGhhdCBoYXMgYSBzcHJlYWQgZXhwcmVzc2lvbiBpbnNpZGUgaXQg YXMgc2ltcGxlLgorICAgICAgICBUaGlzIGF2b2lkcyBhIGZhc3QgcGF0aCBmb3IgZi5hcHBseSh4 LCBzaW1wbGVBcnJheSkgdGhhdCB3YXMgbm90IGhhbmRsaW5nCisgICAgICAgIHNwcmVhZCBleHBy ZXNzaW9ucyB3aXRoaW4gYXJyYXlzLCBhbmQgaW5zdGVhZCB0YWtpbmcgYSBwYXRoIHRoYXQgY2Fu CisgICAgICAgIGhhbmRsZSB0aGUgc3ByZWFkaW5nLgorCisyMDE2LTA5LTE0ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgdGVzdDI2MjogVmFyaW91cyBD b25zdHJ1Y3RvcnMgbGVuZ3RoIHByb3BlcnRpZXMgc2hvdWxkIGJlIGNvbmZpZ3VyYWJsZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxOTk4CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2Vu LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNw cAppbmRleCBjODA4MDNiLi5kZGI1NmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCkBAIC00MTMsNiArNDEzLDggQEAgYm9v bCBBcnJheU5vZGU6OmlzU2ltcGxlQXJyYXkoKSBjb25zdAogICAgIGZvciAoRWxlbWVudE5vZGUq IHB0ciA9IG1fZWxlbWVudDsgcHRyOyBwdHIgPSBwdHItPm5leHQoKSkgewogICAgICAgICBpZiAo cHRyLT5lbGlzaW9uKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGlmIChw dHItPnZhbHVlKCktPmlzU3ByZWFkRXhwcmVzc2lvbigpKQorICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsKIH0K