161996 2016-09-14 15:37:56 -0700 Add needsPlainTextQuirk and send it to the UIProcess 2016-09-14 16:17:27 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin sam thorton wenson_hsieh oldest_to_newest 1229777 0 bdakin 2016-09-14 15:37:56 -0700 Add needsPlainTextQuirk and send it to the UIProcess rdar://problem/26013388 1229781 1 288875 bdakin 2016-09-14 15:41:31 -0700 Created attachment 288875 Patch 1229790 2 288875 simon.fraser 2016-09-14 16:02:26 -0700 Comment on attachment 288875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288875&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4820 > + String fragmentIdentifier = url.fragmentIdentifier(); Why compute this up front, when you won't use it for twitter, onedrive etc? 1229792 3 bdakin 2016-09-14 16:08:36 -0700 Thanks Anders! https://trac.webkit.org/changeset/205934 1229796 4 bdakin 2016-09-14 16:17:27 -0700 (In reply to comment #2) > Comment on attachment 288875 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288875&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4820 > > + String fragmentIdentifier = url.fragmentIdentifier(); > > Why compute this up front, when you won't use it for twitter, onedrive etc? https://trac.webkit.org/changeset/205935 Thanks Simon! 288875 2016-09-14 15:41:31 -0700 2016-09-14 15:59:49 -0700 Patch for-review-os.txt text/plain 6708 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTkzMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE2LTA5LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbmVlZHNQbGFpblRleHRRdWly ayBhbmQgc2VuZCBpdCB0byB0aGUgVUlQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE5OTYKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5n LQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yNjAxMzM4OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYlBhZ2VQcm94eSBzaG91bGQga2VlcCB0cmFj ayBvZiBtX25lZWRzUGxhaW5UZXh0UXVpcmsuCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0TmVlZHNQbGFpblRl eHRRdWlyayk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6Om5lZWRzUGxhaW5UZXh0UXVpcmspOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6Om5lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmspOiBEZWxl dGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46CisKKyAg ICAgICAgSWYgbV9uZWVkc1BsYWluVGV4dFF1aXJrIGlzIHRydWUsIHNldCBpdCBiYWNrIHRvIGZh bHNlIG9uIHBhZ2UgdHJhbnNpdGlvbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmRpZFN0YXJ0UGFnZVRyYW5zaXRp b24pOgorCisgICAgICAgIFRoZSBzaXRlcyB0aGF0IG5lZWQgdGhpcyBxdWlyay4KKyAgICAgICAg KFdlYktpdDo6bmVlZHNQbGFpblRleHRRdWlyayk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6 OmRpZENoYW5nZVNlbGVjdGlvbik6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuaDoKKwogMjAxNi0wOS0xNCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBbTWVkaWFTdHJlYW1dIE1pbm9yIGNsZWFudXAKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyMDU5MjgpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDI5NCw2ICs0Mjk0LDExIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXROZWVkc0hpZGRlbkNv bnRlbnQKICAgICBtX25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmsgPSBuZWVkc0hpZGRl bkNvbnRlbnRFZGl0YWJsZVF1aXJrOwogfQogCit2b2lkIFdlYlBhZ2VQcm94eTo6c2V0TmVlZHNQ bGFpblRleHRRdWlyayhib29sIG5lZWRzUGxhaW5UZXh0UXVpcmspCit7CisgICAgbV9uZWVkc1Bs YWluVGV4dFF1aXJrID0gbmVlZHNQbGFpblRleHRRdWlyazsKK30KKwogLy8gQmFja0ZvcndhcmRM aXN0CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpiYWNrRm9yd2FyZEFkZEl0ZW0odWludDY0X3QgaXRl bUlEKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkocmV2aXNp b24gMjA1OTI4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTE5LDYgKzExMTksNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGhh c0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9tVXNlckludGVyYWN0aW9uKCkgY29uc3QgeyByZXR1cm4g bV9oYXNIYWRTZWxlY3Rpb25DaGFuZ2VzRnJvbVVzZXJJbnRlcmFjdGlvbjsgfQogICAgIGJvb2wg bmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyaygpIGNvbnN0IHsgcmV0dXJuIG1fbmVlZHNI aWRkZW5Db250ZW50RWRpdGFibGVRdWlyazsgfQorICAgIGJvb2wgbmVlZHNQbGFpblRleHRRdWly aygpIGNvbnN0IHsgcmV0dXJuIG1fbmVlZHNQbGFpblRleHRRdWlyazsgfQogCiAgICAgYm9vbCBp c0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSBjb25zdDsKIApAQCAtMTI4OCw2ICsxMjg5LDcgQEAg cHJpdmF0ZToKICAgICB2b2lkIGNvbXBvc2l0aW9uV2FzQ2FuY2VsZWQoY29uc3QgRWRpdG9yU3Rh dGUmKTsKICAgICB2b2lkIHNldEhhc0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9tVXNlckludGVyYWN0 aW9uKGJvb2wpOwogICAgIHZvaWQgc2V0TmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyayhi b29sKTsKKyAgICB2b2lkIHNldE5lZWRzUGxhaW5UZXh0UXVpcmsoYm9vbCk7CiAKICAgICAvLyBC YWNrL0ZvcndhcmQgbGlzdCBtYW5hZ2VtZW50CiAgICAgdm9pZCBiYWNrRm9yd2FyZEFkZEl0ZW0o dWludDY0X3QgaXRlbUlEKTsKQEAgLTE4NTcsNiArMTg1OSw3IEBAIHByaXZhdGU6CiAKICAgICBi b29sIG1faGFzSGFkU2VsZWN0aW9uQ2hhbmdlc0Zyb21Vc2VySW50ZXJhY3Rpb24geyBmYWxzZSB9 OwogICAgIGJvb2wgbV9uZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrIHsgZmFsc2UgfTsK KyAgICBib29sIG1fbmVlZHNQbGFpblRleHRRdWlyayB7IGZhbHNlIH07CiAKICNpZiBFTkFCTEUo TUVESUFfU0VTU0lPTikKICAgICBib29sIG1faGFzTWVkaWFTZXNzaW9uV2l0aEFjdGl2ZU1lZGlh RWxlbWVudHMgeyBmYWxzZSB9OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5tZXNzYWdlcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCShyZXZpc2lvbiAyMDU5MjgpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCSh3b3JraW5nIGNvcHkp CkBAIC0yMzYsNiArMjM2LDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZVByb3h5IHsKICAgICBDb21w b3NpdGlvbldhc0NhbmNlbGVkKHN0cnVjdCBXZWJLaXQ6OkVkaXRvclN0YXRlIGVkaXRvclN0YXRl KQogICAgIFNldEhhc0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9tVXNlckludGVyYWN0aW9uKGJvb2wg aGFzSGFkVXNlclNlbGVjdGlvbkNoYW5nZXMpCiAgICAgU2V0TmVlZHNIaWRkZW5Db250ZW50RWRp dGFibGVRdWlyayhib29sIG5lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmspCisgICAgU2V0 TmVlZHNQbGFpblRleHRRdWlyayhib29sIG5lZWRzUGxhaW5UZXh0UXVpcmspCiAKICAgICAjIEZp bmQgbWVzc2FnZXMKICAgICBEaWRDb3VudFN0cmluZ01hdGNoZXMoU3RyaW5nIHN0cmluZywgdWlu dDMyX3QgbWF0Y2hDb3VudCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDIwNTkyOCkKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY1MCw2ICsy NjUwLDEwIEBAIHZvaWQgV2ViUGFnZTo6ZGlkU3RhcnRQYWdlVHJhbnNpdGlvbigpCiAgICAgICAg IG1fbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyayA9IGZhbHNlOwogICAgICAgICBzZW5k KE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlNldE5lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVp cmsobV9uZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKSk7CiAgICAgfQorICAgIGlmICht X25lZWRzUGxhaW5UZXh0UXVpcmspIHsKKyAgICAgICAgbV9uZWVkc1BsYWluVGV4dFF1aXJrID0g ZmFsc2U7CisgICAgICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6U2V0TmVlZHNQbGFp blRleHRRdWlyayhtX25lZWRzUGxhaW5UZXh0UXVpcmspKTsKKyAgICB9CiAjZW5kaWYKIH0KIApA QCAtNDgwNSw2ICs0ODA5LDMwIEBAIHN0YXRpYyBib29sIG5lZWRzSGlkZGVuQ29udGVudEVkaXRh YmxlUXUKICAgICBTdHJpbmcgcGF0aCA9IHVybC5wYXRoKCk7CiAgICAgcmV0dXJuIGVxdWFsTGV0 dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJkb2NzLmdvb2dsZS5jb20iKSB8fCAoZXF1YWxM ZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInd3dy5pY2xvdWQuY29tIikgJiYgcGF0aC5j b250YWlucygiL3BhZ2VzLyIpKTsKIH0KKworc3RhdGljIGJvb2wgbmVlZHNQbGFpblRleHRRdWly ayhib29sIG5lZWRzUXVpcmtzLCBjb25zdCBVUkwmIHVybCkKK3sKKyAgICBpZiAoIW5lZWRzUXVp cmtzKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBTdHJpbmcgaG9zdCA9IHVybC5ob3N0 KCk7CisgICAgU3RyaW5nIHBhdGggPSB1cmwucGF0aCgpOworICAgIFN0cmluZyBmcmFnbWVudElk ZW50aWZpZXIgPSB1cmwuZnJhZ21lbnRJZGVudGlmaWVyKCk7CisKKyAgICBpZiAoZXF1YWxMZXR0 ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInR3aXR0ZXIuY29tIikpCisgICAgICAgIHJldHVy biB0cnVlOworCisgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJv bmVkcml2ZS5saXZlLmNvbSIpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGlmIChlcXVh bExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAid3d3LmljbG91ZC5jb20iKSAmJiAocGF0 aC5jb250YWlucygibm90ZXMiKSB8fCBmcmFnbWVudElkZW50aWZpZXIuY29udGFpbnMoIm5vdGVz IikgfHwgcGF0aC5jb250YWlucygiL2tleW5vdGUvIikpKQorICAgICAgICByZXR1cm4gdHJ1ZTsK KworICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAidHJpeC1lZGl0 b3Iub3JnIikpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOworfQog I2VuZGlmCiAKIHZvaWQgV2ViUGFnZTo6ZGlkQ2hhbmdlU2VsZWN0aW9uKCkKQEAgLTQ4MjcsNiAr NDg1NSwxMiBAQCB2b2lkIFdlYlBhZ2U6OmRpZENoYW5nZVNlbGVjdGlvbigpCiAgICAgICAgICAg ICBtX25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmsgPSB0cnVlOwogICAgICAgICAgICAg c2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpTZXROZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJs ZVF1aXJrKG1fbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyaykpOwogICAgICAgICB9CisK KyAgICAgICAgaWYgKG5lZWRzUGxhaW5UZXh0UXVpcmsobV9wYWdlLT5zZXR0aW5ncygpLm5lZWRz U2l0ZVNwZWNpZmljUXVpcmtzKCksIG1fcGFnZS0+bWFpbkZyYW1lKCkuZG9jdW1lbnQoKS0+dXJs KCkpKSB7CisgICAgICAgICAgICBtX25lZWRzUGxhaW5UZXh0UXVpcmsgPSB0cnVlOworICAgICAg ICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpTZXROZWVkc1BsYWluVGV4dFF1aXJr KG1fbmVlZHNQbGFpblRleHRRdWlyaykpOworICAgICAgICB9CisKICAgICAgICAgc2VuZChNZXNz YWdlczo6V2ViUGFnZVByb3h5OjpTZXRIYXNIYWRTZWxlY3Rpb25DaGFuZ2VzRnJvbVVzZXJJbnRl cmFjdGlvbihtX2hhc0V2ZXJGb2N1c2VkRWxlbWVudER1ZVRvVXNlckludGVyYWN0aW9uU2luY2VQ YWdlVHJhbnNpdGlvbikpOwogICAgIH0KIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lvbiAyMDU5MjgpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDA4LDYg KzE0MDgsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0Fzc2lzdGluZ05vZGVEdWVUb1VzZXJJ bnRlcmFjdGlvbiB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2hhc0V2ZXJGb2N1c2VkRWxlbWVudER1 ZVRvVXNlckludGVyYWN0aW9uU2luY2VQYWdlVHJhbnNpdGlvbiB7IGZhbHNlIH07CiAgICAgYm9v bCBtX25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmsgeyBmYWxzZSB9OworICAgIGJvb2wg bV9uZWVkc1BsYWluVGV4dFF1aXJrIHsgZmFsc2UgfTsKIAogI2lmIEVOQUJMRShDT05URVhUX01F TlVTKQogICAgIGJvb2wgbV9pc1Nob3dpbmdDb250ZXh0TWVudTsK