161995 2016-09-14 14:52:45 -0700 YARR doesn't check for invalid flags for literal regular expressions 2019-03-08 23:58:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195514 InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1229756 0 msaboff 2016-09-14 14:52:45 -0700 A regular expression like /a/Z doesn't create an error. 1229758 1 msaboff 2016-09-14 14:53:27 -0700 <rdar://problem/27975736> 1229765 2 msaboff 2016-09-14 15:03:06 -0700 Note that is is only a problem for literal regular expressions in JavaScript code. When the new RegExp() constructor is used, the flags are checked. 1229766 3 288869 msaboff 2016-09-14 15:05:25 -0700 Created attachment 288869 Patch 1229769 4 288869 mark.lam 2016-09-14 15:11:51 -0700 Comment on attachment 288869 Patch r=me 1229798 5 288869 commit-queue 2016-09-14 16:20:06 -0700 Comment on attachment 288869 Patch Clearing flags on attachment: 288869 Committed r205937: <http://trac.webkit.org/changeset/205937> 1229799 6 commit-queue 2016-09-14 16:20:10 -0700 All reviewed patches have been landed. Closing bug. 288869 2016-09-14 15:05:25 -0700 2016-09-14 16:20:06 -0700 Patch 161995.patch text/plain 4224 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDU5MzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIFlBUlIgZG9lc24ndCBjaGVjayBmb3IgaW52YWxpZCBmbGFncyBm b3IgbGl0ZXJhbCByZWd1bGFyIGV4cHJlc3Npb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgdGVzdC4KKworICAgICAgICAqIHN0cmVzcy9yZWdy ZXNzLTE2MTk5NS5qczogQWRkZWQuCisgICAgICAgICh0ZXN0U3RhdGljKToKKyAgICAgICAgKGNh dGNoKToKKwogMjAxNi0wOS0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBNYWtlIHRoZSByb3VuZGluZy1yZWxhdGVkIG5vZGVzIHN1cHBv cnQgYW55IHR5cGUKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTYxOTk1LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTYxOTk1LmpzCShub25leGlzdGVudCkK KysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTYxOTk1LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTQgQEAKKy8vIFJlZ3Jlc3Npb24gdGVzdCBmb3IgMTYxOTk1LgorCitmdW5jdGlvbiB0 ZXN0U3RhdGljKCkKK3sKKyAgICByZXR1cm4gL2EvWjsKK30KKwordHJ5IHsKKyAgICB0ZXN0U3Rh dGljKCk7CisgICAgdGhyb3cgIkV4cGVjdGVkIGEgU3ludGF4RWVycm9yIGZvciBiYWQgUmVnRXhw IGZsYWdzLCBidXQgZGlkbid0IGdldCBvbmUuIjsKK30gY2F0Y2goZSkgeworICAgIGlmIChlICE9 ICJTeW50YXhFcnJvcjogSW52YWxpZCByZWd1bGFyIGV4cHJlc3Npb246IGludmFsaWQgZmxhZ3Mi KQorICAgICAgICB0aHJvdyAiSW5jb3JyZWN0IGV4Y2VwdGlvbiBmb3IgYmFkIFJlZ0V4cCBmbGFn cy4gIEdvdDogIiArIGU7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9u IDIwNTg5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwyMCBAQAorMjAxNi0wOS0xNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2Zm QGFwcGxlLmNvbT4KKworICAgICAgICBZQVJSIGRvZXNuJ3QgY2hlY2sgZm9yIGludmFsaWQgZmxh Z3MgZm9yIGxpdGVyYWwgcmVndWxhciBleHByZXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxOTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBuZXcgZXJyb3IgYW5kIGEgY2hlY2sg dGhhdCB0aGUgZmxhZ3MgYXJlIHZhbGlkIHdoZW4gd2UgY3JlYXRlIGEKKyAgICAgICAgbGl0ZXJh bCByZWd1bGFyIGV4cHJlc3Npb24uCisKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5jcHA6Cisg ICAgICAgIChKU0M6OlJlZ0V4cDo6ZmluaXNoQ3JlYXRpb24pOgorICAgICAgICAqIHlhcnIvWWFy clBhdHRlcm4uY3BwOgorICAgICAgICAoSlNDOjpZYXJyOjpZYXJyUGF0dGVybjo6ZXJyb3JNZXNz YWdlKToKKyAgICAgICAgKEpTQzo6WWFycjo6WWFyclBhdHRlcm46OmNvbXBpbGUpOgorICAgICAg ICAqIHlhcnIvWWFyclBhdHRlcm4uaDoKKwogMjAxNi0wOS0xMyAgTWljaGFlbCBTYWJvZmYgIDxt c2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9taXNlcyBhcmVuJ3QgcmVzb2x2ZWQgcHJv cGVybHkgd2hlbiBtYWtpbmcgYSBPYmpDIEFQSSBjYWxsYmFjawpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwCShyZXZpc2lvbiAyMDU4OTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMs NyArMjIzLDcgQEAgdm9pZCBSZWdFeHA6OmZpbmlzaENyZWF0aW9uKFZNJiB2bSkKIHsKICAgICBC YXNlOjpmaW5pc2hDcmVhdGlvbih2bSk7CiAgICAgWWFycjo6WWFyclBhdHRlcm4gcGF0dGVybiht X3BhdHRlcm5TdHJpbmcsIG1fZmxhZ3MsICZtX2NvbnN0cnVjdGlvbkVycm9yLCB2bS5zdGFja0xp bWl0KCkpOwotICAgIGlmIChtX2NvbnN0cnVjdGlvbkVycm9yKQorICAgIGlmICghaXNWYWxpZCgp KQogICAgICAgICBtX3N0YXRlID0gUGFyc2VFcnJvcjsKICAgICBlbHNlCiAgICAgICAgIG1fbnVt U3VicGF0dGVybnMgPSBwYXR0ZXJuLm1fbnVtU3VicGF0dGVybnM7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3lhcnIvWWFyclBhdHRlcm4uY3BwCShyZXZpc2lvbiAyMDU4OTMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTkwNyw3ICs5MDcsOCBAQCBjb25zdCBjaGFyKiBZYXJyUGF0dGVybjo6ZXJyb3JNZXNzYWdl KFlhCiAgICAgICAgIFJFR0VYUF9FUlJPUl9QUkVGSVggImludmFsaWQgdW5pY29kZSB7fSBlc2Nh cGUiLAogICAgICAgICBSRUdFWFBfRVJST1JfUFJFRklYICJpbnZhbGlkIGVzY2FwZWQgY2hhcmFj dGVyIGZvciB1bmljb2RlIHBhdHRlcm4iLAogICAgICAgICBSRUdFWFBfRVJST1JfUFJFRklYICJ0 b28gbWFueSBuZXN0ZWQgZGlzanVuY3Rpb25zIiwKLSAgICAgICAgUkVHRVhQX0VSUk9SX1BSRUZJ WCAicGF0dGVybiBleGNlZWRzIHN0cmluZyBsZW5ndGggbGltaXRzIgorICAgICAgICBSRUdFWFBf RVJST1JfUFJFRklYICJwYXR0ZXJuIGV4Y2VlZHMgc3RyaW5nIGxlbmd0aCBsaW1pdHMiLAorICAg ICAgICBSRUdFWFBfRVJST1JfUFJFRklYICJpbnZhbGlkIGZsYWdzIgogICAgIH07CiAKICAgICBy ZXR1cm4gZXJyb3JNZXNzYWdlc1tlcnJvcl07CkBAIC05MTcsNiArOTE4LDkgQEAgY29uc3QgY2hh ciogWWFyclBhdHRlcm46OmNvbXBpbGUoY29uc3QgUwogewogICAgIFlhcnJQYXR0ZXJuQ29uc3Ry dWN0b3IgY29uc3RydWN0b3IoKnRoaXMsIHN0YWNrTGltaXQpOwogCisgICAgaWYgKG1fZmxhZ3Mg PT0gSW52YWxpZEZsYWdzKQorICAgICAgICByZXR1cm4gZXJyb3JNZXNzYWdlKEludmFsaWRSZWd1 bGFyRXhwcmVzc2lvbkZsYWdzKTsKKwogICAgIGlmIChjb25zdCBjaGFyKiBlcnJvciA9IHBhcnNl KGNvbnN0cnVjdG9yLCBwYXR0ZXJuU3RyaW5nLCB1bmljb2RlKCkpKQogICAgICAgICByZXR1cm4g ZXJyb3I7CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVy bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJQYXR0ZXJu LmgJKHJldmlzaW9uIDIwNTg5MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJQ YXR0ZXJuLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyMSw2ICszMjEsNyBAQCBzdHJ1Y3QgWWFyclBh dHRlcm4gewogICAgICAgICBJbnZhbGlkSWRlbnRpdHlFc2NhcGUsCiAgICAgICAgIFRvb01hbnlE aXNqdW5jdGlvbnMsCiAgICAgICAgIE9mZnNldFRvb0xhcmdlLAorICAgICAgICBJbnZhbGlkUmVn dWxhckV4cHJlc3Npb25GbGFncywKICAgICAgICAgTnVtYmVyT2ZFcnJvckNvZGVzCiAgICAgfTsK ICAgICAK