161984 2016-09-14 13:27:03 -0700 Add needsHiddenContentEditableQuirk and send it to the UIProcess 2016-09-14 13:58:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin sam thorton wenson_hsieh oldest_to_newest 1229700 0 bdakin 2016-09-14 13:27:03 -0700 Add needsHiddenContentEditableQuirk and send it to the UIProcess rdar://problem/26013388 1229704 1 288852 bdakin 2016-09-14 13:33:05 -0700 Created attachment 288852 Patch 1229719 2 bdakin 2016-09-14 13:58:44 -0700 Thanks Anders! https://trac.webkit.org/changeset/205928 288852 2016-09-14 13:33:05 -0700 2016-09-14 13:45:13 -0700 Patch for-review-os.txt text/plain 7049 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTkyNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE2LTA5LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbmVlZHNIaWRkZW5Db250ZW50 RWRpdGFibGVRdWlyayBhbmQgc2VuZCBpdCB0byB0aGUgVUlQcm9jZXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE5ODQKKyAgICAgICAgLWFuZCBj b3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yNjAxMzM4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEtlZXAgdHJhY2sgb2YgbV9u ZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrIGluIFdlYlBhZ2VQcm94eS4KKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5OjpzZXROZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bmVl ZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyayk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6aGFzSGFkU2VsZWN0aW9uQ2hhbmdlc0Zyb21Vc2VySW50ZXJhY3Rpb24pOiBEZWxldGVk LgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46CisKKyAgICAg ICAgSWYgbV9uZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrIGlzIHRydWUsIHNldCBpdCBi YWNrIHRvIGZhbHNlIG9uIHBhZ2UgCisgICAgICAgIHRyYW5zaXRpb24uCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpk aWRTdGFydFBhZ2VUcmFuc2l0aW9uKToKKworICAgICAgICBHb29nbGUgRG9jcyBhbmQgaUNsb3Vk IFBhZ2VzIGFyZSB0aGUgc2l0ZXMgdGhhdCBuZWVkIHRoaXMgcXVpcmsuCisgICAgICAgIChXZWJL aXQ6Om5lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmspOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmg6CisKIDIwMTYtMDktMTQgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBMb25nIHRhcCBtZW51IG9uIGFuIGltYWdlIGxpbmsgbm8g bG9uZ2VyIGluY2x1ZGVzICJTYXZlIEltYWdlIiBidXR0b24KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyMDU5MTgpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI4 OSw2ICs0Mjg5LDExIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRIYXNIYWRTZWxlY3Rpb25DaGEK ICAgICBtX2hhc0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9tVXNlckludGVyYWN0aW9uID0gaGFzSGFk VXNlclNlbGVjdGlvbkNoYW5nZXM7CiB9CiAKK3ZvaWQgV2ViUGFnZVByb3h5OjpzZXROZWVkc0hp ZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKGJvb2wgbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVR dWlyaykKK3sKKyAgICBtX25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmsgPSBuZWVkc0hp ZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrOworfQorCiAvLyBCYWNrRm9yd2FyZExpc3QKIAogdm9p ZCBXZWJQYWdlUHJveHk6OmJhY2tGb3J3YXJkQWRkSXRlbSh1aW50NjRfdCBpdGVtSUQpCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAyMDU5MTgp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHdvcmtpbmcgY29w eSkKQEAgLTExMTgsNiArMTExOCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFVzZXJJbnRlcmZh Y2VMYXlvdXREaXJlY3Rpb24oV2ViQ29yZTo6VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbik7 CiAKICAgICBib29sIGhhc0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9tVXNlckludGVyYWN0aW9uKCkg Y29uc3QgeyByZXR1cm4gbV9oYXNIYWRTZWxlY3Rpb25DaGFuZ2VzRnJvbVVzZXJJbnRlcmFjdGlv bjsgfQorICAgIGJvb2wgbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyaygpIGNvbnN0IHsg cmV0dXJuIG1fbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyazsgfQogCiAgICAgYm9vbCBp c0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSBjb25zdDsKIApAQCAtMTI4Niw2ICsxMjg3LDcgQEAg cHJpdmF0ZToKICAgICB2b2lkIGVkaXRvclN0YXRlQ2hhbmdlZChjb25zdCBFZGl0b3JTdGF0ZSYp OwogICAgIHZvaWQgY29tcG9zaXRpb25XYXNDYW5jZWxlZChjb25zdCBFZGl0b3JTdGF0ZSYpOwog ICAgIHZvaWQgc2V0SGFzSGFkU2VsZWN0aW9uQ2hhbmdlc0Zyb21Vc2VySW50ZXJhY3Rpb24oYm9v bCk7CisgICAgdm9pZCBzZXROZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKGJvb2wpOwog CiAgICAgLy8gQmFjay9Gb3J3YXJkIGxpc3QgbWFuYWdlbWVudAogICAgIHZvaWQgYmFja0Zvcndh cmRBZGRJdGVtKHVpbnQ2NF90IGl0ZW1JRCk7CkBAIC0xODU0LDYgKzE4NTYsNyBAQCBwcml2YXRl OgogICAgIGJvb2wgbV9pc1Jlc291cmNlQ2FjaGluZ0Rpc2FibGVkIHsgZmFsc2UgfTsKIAogICAg IGJvb2wgbV9oYXNIYWRTZWxlY3Rpb25DaGFuZ2VzRnJvbVVzZXJJbnRlcmFjdGlvbiB7IGZhbHNl IH07CisgICAgYm9vbCBtX25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmsgeyBmYWxzZSB9 OwogCiAjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCiAgICAgYm9vbCBtX2hhc01lZGlhU2Vzc2lv bldpdGhBY3RpdmVNZWRpYUVsZW1lbnRzIHsgZmFsc2UgfTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgkocmV2aXNpb24gMjA1 OTE4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5p bgkod29ya2luZyBjb3B5KQpAQCAtMjM1LDYgKzIzNSw3IEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2VQ cm94eSB7CiAgICAgRWRpdG9yU3RhdGVDaGFuZ2VkKHN0cnVjdCBXZWJLaXQ6OkVkaXRvclN0YXRl IGVkaXRvclN0YXRlKQogICAgIENvbXBvc2l0aW9uV2FzQ2FuY2VsZWQoc3RydWN0IFdlYktpdDo6 RWRpdG9yU3RhdGUgZWRpdG9yU3RhdGUpCiAgICAgU2V0SGFzSGFkU2VsZWN0aW9uQ2hhbmdlc0Zy b21Vc2VySW50ZXJhY3Rpb24oYm9vbCBoYXNIYWRVc2VyU2VsZWN0aW9uQ2hhbmdlcykKKyAgICBT ZXROZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKGJvb2wgbmVlZHNIaWRkZW5Db250ZW50 RWRpdGFibGVRdWlyaykKIAogICAgICMgRmluZCBtZXNzYWdlcwogICAgIERpZENvdW50U3RyaW5n TWF0Y2hlcyhTdHJpbmcgc3RyaW5nLCB1aW50MzJfdCBtYXRjaENvdW50KQpJbmRleDogU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMjA1 OTE4KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNjQ2LDYgKzI2NDYsMTAgQEAgdm9pZCBXZWJQYWdlOjpkaWRTdGFy dFBhZ2VUcmFuc2l0aW9uKCkKICNpZiBQTEFURk9STShNQUMpCiAgICAgaWYgKGhhc1ByZXZpb3Vz bHlGb2N1c2VkRHVlVG9Vc2VySW50ZXJhY3Rpb24pCiAgICAgICAgIHNlbmQoTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6U2V0SGFzSGFkU2VsZWN0aW9uQ2hhbmdlc0Zyb21Vc2VySW50ZXJhY3Rpb24o bV9oYXNFdmVyRm9jdXNlZEVsZW1lbnREdWVUb1VzZXJJbnRlcmFjdGlvblNpbmNlUGFnZVRyYW5z aXRpb24pKTsKKyAgICBpZiAobV9uZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKSB7Cisg ICAgICAgIG1fbmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyayA9IGZhbHNlOworICAgICAg ICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlNldE5lZWRzSGlkZGVuQ29udGVudEVkaXRh YmxlUXVpcmsobV9uZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrKSk7CisgICAgfQogI2Vu ZGlmCiB9CiAKQEAgLTQ3OTEsNiArNDc5NSwxNiBAQCB2b2lkIFdlYlBhZ2U6OmNhbmNlbENvbXBv c2l0aW9uKCkKIH0KICNlbmRpZgogCitzdGF0aWMgYm9vbCBuZWVkc0hpZGRlbkNvbnRlbnRFZGl0 YWJsZVF1aXJrKGJvb2wgbmVlZHNRdWlya3MsIGNvbnN0IFVSTCYgdXJsKQoreworICAgIGlmICgh bmVlZHNRdWlya3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIFN0cmluZyBob3N0ID0g dXJsLmhvc3QoKTsKKyAgICBTdHJpbmcgcGF0aCA9IHVybC5wYXRoKCk7CisgICAgcmV0dXJuIGVx dWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJkb2NzLmdvb2dsZS5jb20iKSB8fCAo ZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInd3dy5pY2xvdWQuY29tIikgJiYg cGF0aC5jb250YWlucygiL3BhZ2VzLyIpKTsKK30KKwogdm9pZCBXZWJQYWdlOjpkaWRDaGFuZ2VT ZWxlY3Rpb24oKQogewogICAgIEZyYW1lJiBmcmFtZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVy KCkuZm9jdXNlZE9yTWFpbkZyYW1lKCk7CkBAIC00ODA2LDggKzQ4MjAsMTMgQEAgdm9pZCBXZWJQ YWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24oKQogICAgIGJvb2wgaGFzUHJldmlvdXNseUZvY3VzZWRE dWVUb1VzZXJJbnRlcmFjdGlvbiA9IG1faGFzRXZlckZvY3VzZWRFbGVtZW50RHVlVG9Vc2VySW50 ZXJhY3Rpb25TaW5jZVBhZ2VUcmFuc2l0aW9uOwogICAgIG1faGFzRXZlckZvY3VzZWRFbGVtZW50 RHVlVG9Vc2VySW50ZXJhY3Rpb25TaW5jZVBhZ2VUcmFuc2l0aW9uIHw9IG1fdXNlcklzSW50ZXJh Y3Rpbmc7CiAKLSAgICBpZiAoIWhhc1ByZXZpb3VzbHlGb2N1c2VkRHVlVG9Vc2VySW50ZXJhY3Rp b24gJiYgbV9oYXNFdmVyRm9jdXNlZEVsZW1lbnREdWVUb1VzZXJJbnRlcmFjdGlvblNpbmNlUGFn ZVRyYW5zaXRpb24pCisgICAgaWYgKCFoYXNQcmV2aW91c2x5Rm9jdXNlZER1ZVRvVXNlckludGVy YWN0aW9uICYmIG1faGFzRXZlckZvY3VzZWRFbGVtZW50RHVlVG9Vc2VySW50ZXJhY3Rpb25TaW5j ZVBhZ2VUcmFuc2l0aW9uKSB7CisgICAgICAgIGlmIChuZWVkc0hpZGRlbkNvbnRlbnRFZGl0YWJs ZVF1aXJrKG1fcGFnZS0+c2V0dGluZ3MoKS5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpLCBtX3Bh Z2UtPm1haW5GcmFtZSgpLmRvY3VtZW50KCktPnVybCgpKSkgeworICAgICAgICAgICAgbV9uZWVk c0hpZGRlbkNvbnRlbnRFZGl0YWJsZVF1aXJrID0gdHJ1ZTsKKyAgICAgICAgICAgIHNlbmQoTWVz c2FnZXM6OldlYlBhZ2VQcm94eTo6U2V0TmVlZHNIaWRkZW5Db250ZW50RWRpdGFibGVRdWlyayht X25lZWRzSGlkZGVuQ29udGVudEVkaXRhYmxlUXVpcmspKTsKKyAgICAgICAgfQogICAgICAgICBz ZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlNldEhhc0hhZFNlbGVjdGlvbkNoYW5nZXNGcm9t VXNlckludGVyYWN0aW9uKG1faGFzRXZlckZvY3VzZWRFbGVtZW50RHVlVG9Vc2VySW50ZXJhY3Rp b25TaW5jZVBhZ2VUcmFuc2l0aW9uKSk7CisgICAgfQogCiAgICAgLy8gQWJhbmRvbiB0aGUgY3Vy cmVudCBpbmxpbmUgaW5wdXQgc2Vzc2lvbiBpZiBzZWxlY3Rpb24gY2hhbmdlZCBmb3IgYW55IG90 aGVyIHJlYXNvbiBidXQgYW4gaW5wdXQgbWV0aG9kIGRpcmVjdCBhY3Rpb24uCiAgICAgLy8gRklY TUU6IFRoaXMgbG9naWMgc2hvdWxkIGJlIGluIFdlYkNvcmUuCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHJldmlzaW9uIDIwNTkxOCkKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtpbmcgY29weSkK QEAgLTE0MDcsNiArMTQwNyw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3VzZXJJc0ludGVyYWN0 aW5nOwogICAgIGJvb2wgbV9pc0Fzc2lzdGluZ05vZGVEdWVUb1VzZXJJbnRlcmFjdGlvbiB7IGZh bHNlIH07CiAgICAgYm9vbCBtX2hhc0V2ZXJGb2N1c2VkRWxlbWVudER1ZVRvVXNlckludGVyYWN0 aW9uU2luY2VQYWdlVHJhbnNpdGlvbiB7IGZhbHNlIH07CisgICAgYm9vbCBtX25lZWRzSGlkZGVu Q29udGVudEVkaXRhYmxlUXVpcmsgeyBmYWxzZSB9OwogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVO VVMpCiAgICAgYm9vbCBtX2lzU2hvd2luZ0NvbnRleHRNZW51Owo=