161975 2016-09-14 10:15:34 -0700 Use Options::validateExceptionChecks() instead of VM::m_verifyExceptionEvents. 2016-09-14 10:58:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1229618 0 mark.lam 2016-09-14 10:15:34 -0700 This makes it less burdensome (no longer needs a rebuild to enable checks) to do incremental work towards enabling checks all the time. 1229621 1 288827 mark.lam 2016-09-14 10:20:33 -0700 Created attachment 288827 proposed patch. 1229633 2 288827 keith_miller 2016-09-14 10:47:38 -0700 Comment on attachment 288827 proposed patch. r=me assuming no perf regressions if verifyExceptionCheckNeedIsSatisfied is even built in release. 1229638 3 mark.lam 2016-09-14 10:58:21 -0700 Thanks for the review. Landed in r205917: <http://trac.webkit.org/r205917>. 288827 2016-09-14 10:20:33 -0700 2016-09-14 10:47:38 -0700 proposed patch. bug-161975.patch text/plain 2984 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA1OTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTA5LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBV c2UgT3B0aW9uczo6dmFsaWRhdGVFeGNlcHRpb25DaGVja3MoKSBpbnN0ZWFkIG9mIFZNOjptX3Zl cmlmeUV4Y2VwdGlvbkV2ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MTk3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgbWFrZXMgaXQgbGVzcyBidXJkZW5zb21lIChubyBsb25nZXIgbmVl ZHMgYSByZWJ1aWxkIHRvIGVuYWJsZSBjaGVja3MpIHRvIGRvCisgICAgICAgIGluY3JlbWVudGFs IHdvcmsgdG93YXJkcyBlbmFibGluZyBjaGVja3MgYWxsIHRoZSB0aW1lLgorCisgICAgICAgICog cnVudGltZS9PcHRpb25zLmg6CisgICAgICAgICogcnVudGltZS9WTS5jcHA6CisgICAgICAgIChK U0M6OlZNOjp2ZXJpZnlFeGNlcHRpb25DaGVja05lZWRJc1NhdGlzZmllZCk6CisgICAgICAgICog cnVudGltZS9WTS5oOgorCiAyMDE2LTA5LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgdGVzdDI2MjogQXJyYXkucHJvdG90eXBlLnNsaWNlIHNob3Vs ZCBhbHdheXMgc2V0IGxlbmd0aApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnMuaAkocmV2aXNpb24gMjA1OTA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNDcsNiArMzQ3LDcgQEAgdHlwZWRlZiBj b25zdCBjaGFyKiBvcHRpb25TdHJpbmc7CiAgICAgdih1bnNpZ25lZCwgZmlyZUV4Y2VwdGlvbkZ1 enpBdCwgMCwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihib29sLCB2YWxpZGF0ZURGR0V4Y2Vw dGlvbkhhbmRsaW5nLCBmYWxzZSwgTm9ybWFsLCAiQ2F1c2VzIHRoZSBERkcgdG8gZW1pdCBjb2Rl IHZhbGlkYXRpbmcgZXhjZXB0aW9uIGhhbmRsaW5nIGZvciBlYWNoIG5vZGUgdGhhdCBjYW4gZXhp dCIpIC8qIFRoaXMgaXMgdHJ1ZSBieSBkZWZhdWx0IG9uIERlYnVnIGJ1aWxkcyAqL1wKICAgICB2 KGJvb2wsIGR1bXBTaW11bGF0ZWRUaHJvd3MsIGZhbHNlLCBOb3JtYWwsICJEdW1wcyB0aGUgY2Fs bCBzdGFjayBhdCBlYWNoIHNpbXVsYXRlZCB0aHJvdyBmb3IgZXhjZXB0aW9uIHNjb3BlIHZlcmlm aWNhdGlvbiIpIFwKKyAgICB2KGJvb2wsIHZhbGlkYXRlRXhjZXB0aW9uQ2hlY2tzLCBmYWxzZSwg Tm9ybWFsLCAiVmVyaWZpZXMgdGhhdCBuZWVkZWQgZXhjZXB0aW9uIGNoZWNrcyBhcmUgcGVyZm9y bWVkLiIpIFwKICAgICBcCiAgICAgdihib29sLCB1c2VFeGVjdXRhYmxlQWxsb2NhdGlvbkZ1enos IGZhbHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KHVuc2lnbmVkLCBmaXJlRXhlY3V0YWJs ZUFsbG9jYXRpb25GdXp6QXQsIDAsIE5vcm1hbCwgbnVsbHB0cikgXApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkocmV2aXNpb24gMjA1OTA5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OTYsNyArODk2LDcg QEAgYm9vbCBWTTo6aXNTYWZlVG9SZWN1cnNlU29mdENMb29wKCkgY29ucwogI2lmIEVOQUJMRShF WENFUFRJT05fU0NPUEVfVkVSSUZJQ0FUSU9OKQogdm9pZCBWTTo6dmVyaWZ5RXhjZXB0aW9uQ2hl Y2tOZWVkSXNTYXRpc2ZpZWQodW5zaWduZWQgcmVjdXJzaW9uRGVwdGgsIEV4Y2VwdGlvbkV2ZW50 TG9jYXRpb24mIGxvY2F0aW9uKQogewotICAgIGlmICghbV92ZXJpZnlFeGNlcHRpb25FdmVudHMp CisgICAgaWYgKCFPcHRpb25zOjp2YWxpZGF0ZUV4Y2VwdGlvbkNoZWNrcygpKQogICAgICAgICBy ZXR1cm47CiAKICAgICBpZiAoVU5MSUtFTFkobV9uZWVkRXhjZXB0aW9uQ2hlY2spKSB7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHJldmlzaW9uIDIwNTkwOSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHdvcmtpbmcgY29weSkKQEAgLTcwMyw5ICs3 MDMsNiBAQCBwcml2YXRlOgogICAgIEV4Y2VwdGlvbkV2ZW50TG9jYXRpb24gbV9zaW11bGF0ZWRU aHJvd1BvaW50TG9jYXRpb247CiAgICAgdW5zaWduZWQgbV9zaW11bGF0ZWRUaHJvd1BvaW50UmVj dXJzaW9uRGVwdGggeyAwIH07CiAgICAgbXV0YWJsZSBib29sIG1fbmVlZEV4Y2VwdGlvbkNoZWNr IHsgZmFsc2UgfTsKLQotICAgIC8vIERpc2FibGVkIHRlbXBvcmFyaWx5IHVudGlsIGFsbCBrbm93 biB2ZXJpZmljYXRpb24gZmFpbHVyZXMgYXJlIGZpeGVkLgotICAgIGJvb2wgbV92ZXJpZnlFeGNl cHRpb25FdmVudHMgeyBmYWxzZSB9OwogI2VuZGlmCiAKICAgICBib29sIG1fZmFpbE5leHROZXdD b2RlQmxvY2sgeyBmYWxzZSB9Owo=