161953 2016-09-14 02:18:54 -0700 test262: Array.prototype.slice should always set length 2016-09-14 09:49:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1229494 0 joepeck 2016-09-14 02:18:54 -0700 test262/test/built-ins/Array/prototype/splice/set_length_no_args.js We should always be setting the length on the this value, even if it is not changing and called with no arguments. 1229495 1 288789 joepeck 2016-09-14 02:19:43 -0700 Created attachment 288789 [PATCH] Proposed Fix 1229594 2 288789 commit-queue 2016-09-14 09:49:08 -0700 Comment on attachment 288789 [PATCH] Proposed Fix Clearing flags on attachment: 288789 Committed r205910: <http://trac.webkit.org/changeset/205910> 1229595 3 commit-queue 2016-09-14 09:49:12 -0700 All reviewed patches have been landed. Closing bug. 288789 2016-09-14 02:19:43 -0700 2016-09-14 09:49:08 -0700 [PATCH] Proposed Fix 262-1.patch text/plain 3052 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MmE2ZjFlNC4uMGE4NmZlYSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNi0wOS0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIHRlc3QyNjI6IEFycmF5LnByb3Rv dHlwZS5zbGljZSBzaG91bGQgYWx3YXlzIHNldCBsZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTk1MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdDI2Mi55YW1sOgorCisyMDE2LTA5LTE0 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgVGFnZ2Vk VGVtcGxhdGVTdHJpbmcgZnVuY3Rpb24gY2FsbHMgc2hvdWxkIGVtaXQgdGFpbCBwb3NpdGlvbiBj YWxscwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYx OTQ4CiAKZGlmZiAtLWdpdCBhL0pTVGVzdHMvdGVzdDI2Mi55YW1sIGIvSlNUZXN0cy90ZXN0MjYy LnlhbWwKaW5kZXggMWM4MmY0NS4uYjMxMTcyZiAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYy LnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYyLnlhbWwKQEAgLTEyNjg2LDkgKzEyNjg2LDkgQEAK IC0gcGF0aDogdGVzdDI2Mi90ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc3BsaWNlL25h bWUuanMKICAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4v Li4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEu anMiLCAiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9wcm9wZXJ0eUhlbHBlci5qcyJdLCBbOnN0cmlj dF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc3BsaWNl L3NldF9sZW5ndGhfbm9fYXJncy5qcwotICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2Vw dGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4v Li4vaGFybmVzcy9zdGEuanMiXSwgW10KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4 Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4v Li4vLi4vaGFybmVzcy9zdGEuanMiXSwgW10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2J1aWx0LWlu cy9BcnJheS9wcm90b3R5cGUvc3BsaWNlL3NldF9sZW5ndGhfbm9fYXJncy5qcwotICBjbWQ6IHJ1 blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9h c3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCisg IGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uLy4u L2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6 c3RyaWN0XQogLSBwYXRoOiB0ZXN0MjYyL3Rlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS90 b0xvY2FsZVN0cmluZy9TMTUuNC40LjNfQTFfVDEuanMKICAgY21kOiBydW5UZXN0MjYyIDpub3Jt YWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAi Li4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgW10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0 L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvdG9Mb2NhbGVTdHJpbmcvUzE1LjQuNC4zX0ExX1Qx LmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0ZDUwOGE5Li44ZDExM2FkIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAxNi0wOS0xNCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIHRlc3QyNjI6IEFycmF5LnBy b3RvdHlwZS5zbGljZSBzaG91bGQgYWx3YXlzIHNldCBsZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTk1MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5j cHA6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jU3BsaWNlKToKKworMjAxNi0wOS0xNCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFRhZ2dlZFRl bXBsYXRlU3RyaW5nIGZ1bmN0aW9uIGNhbGxzIHNob3VsZCBlbWl0IHRhaWwgcG9zaXRpb24gY2Fs bHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTk0 OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3Rv dHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5j cHAKaW5kZXggMmE5OGU1ZS4uZmUyMmQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtOTU0LDYgKzk1NCw3IEBAIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0Z1bmNTcGxpY2UoRXhlY1N0YXRlKiBleGVj KQogICAgICAgICB9CiAKICAgICAgICAgc2V0TGVuZ3RoKGV4ZWMsIHJlc3VsdCwgMCk7CisgICAg ICAgIHNldExlbmd0aChleGVjLCB0aGlzT2JqLCBsZW5ndGgpOwogICAgICAgICByZXR1cm4gSlNW YWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CiAgICAgfQogCg==