16195 2007-11-29 18:19:18 -0800 REGRESSION: JavaScriptCore and LayoutTest failures 2007-11-30 00:56:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P2 Normal --- 1 eric webkit-unassigned darin sam oldest_to_newest 62742 0 eric 2007-11-29 18:19:18 -0800 http://build.webkit.org/builders/trunk-mac-ppc-release/builds/9420 This was caused by: http://trac.webkit.org/projects/webkit/changeset/28186 Which was a fix for: http://trac.webkit.org/projects/webkit/changeset/28151 r28151 had incorrectly removed { } from an if/else block, leading to the crash. I fixed that, but either something was wrong in my fix (r28186) or that fix exposed some other bug. Unfortunately the fixes aren't properly ordered, so it's hard to figure out if that uncovered some other bug. I failed to run *all* of the tests after preparing r28186, I was only running the crashing test at the time. Oops. When I get around to fixing this, I'll do so by reordering the commits on a local git branch and squashing 28186 on top of 28151 and then running git-bisect against the whole set of PCRE fixes looking for where these new regressions occurred. Then I'll just stare at the diff until I find the unintended logical change, or I'll use the diffs in the test results to guide me to the right area. Unfortunately I don't have a fully functional computer and internet setup right now (I'm setting up my new apartment) so it might be a day or more before I get to sit down and fix this. If I'm on IRC (as MacDome) you might want to ask me if I'm working on it before you do. If I'm not on IRC, I won't be working on it. :) 62747 1 eric 2007-11-29 19:06:32 -0800 I seem to have broken case insensitive matching with this change. 62749 2 eric 2007-11-29 20:03:48 -0800 Ok, so git-bisect has revealed that this fix revealed a bug in r28181. The test failures are caused by problems in r28181. 62761 3 17600 eric 2007-11-30 00:45:41 -0800 Created attachment 17600 2007-11-30 Eric Seidel <eric@webkit.org> Reviewed by Maciej. Fix layout test regressions caused by r28186 http://bugs.webkit.org/show_bug.cgi?id=16195 change first_byte and req_byte back to shorts instead of chars (I think PCRE stuffs information in the high bits) * pcre/pcre_internal.h: --- JavaScriptCore/ChangeLog | 11 +++++++++++ JavaScriptCore/pcre/pcre_internal.h | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) 17600 2007-11-30 00:45:41 -0800 2007-11-30 00:48:03 -0800 2007-11-30 Eric Seidel <eric@webkit.org> 2007-11-30-Eric-Seidel-eric-webkit.org-.patch text/plain 1319 eric MWQ0MWIwNTgzNDlhZWNhNjRjNmUyMmU4YzJkNTA1MTA1MzBmYjY1NwpkaWZmIC0tZ2l0IGEvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ0 MzJiMjkuLjk3ZTVkNzEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwNy0xMS0zMCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqLgorICAgICAgICAKKyAgICAgICAgRml4IGxheW91dCB0ZXN0IHJlZ3Jlc3Npb25zIGNhdXNl ZCBieSByMjgxODYKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYxOTUKKyAgICAgICAgY2hhbmdlIGZpcnN0X2J5dGUgYW5kIHJlcV9ieXRlIGJhY2sgdG8g c2hvcnRzIGluc3RlYWQgb2YgY2hhcnMKKyAgICAgICAgKEkgdGhpbmsgUENSRSBzdHVmZnMgaW5m b3JtYXRpb24gaW4gdGhlIGhpZ2ggYml0cykgCisKKyAgICAgICAgKiBwY3JlL3BjcmVfaW50ZXJu YWwuaDoKKwogMjAwNy0xMS0yOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBhbmQgRGFyaW4uCmRpZmYgLS1naXQgYS9KYXZhU2Ny aXB0Q29yZS9wY3JlL3BjcmVfaW50ZXJuYWwuaCBiL0phdmFTY3JpcHRDb3JlL3BjcmUvcGNyZV9p bnRlcm5hbC5oCmluZGV4IDhjNjk3MzguLmE1NDc3N2QgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD b3JlL3BjcmUvcGNyZV9pbnRlcm5hbC5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3BjcmUvcGNyZV9p bnRlcm5hbC5oCkBAIC01NTgsOCArNTU4LDggQEAgc3RydWN0IEpTUmVnRXhwIHsKICAgICAvLyBq c1JlZ0V4cEV4ZWN1dGUgJiYganNSZWdFeHBDb21waWxlIGN1cnJlbnRseSBvbmx5IGhvdyB0byBo YW5kbGUgQVNDSUkKICAgICAvLyBjaGFycyBmb3IgdGhzZSBvcHRpbWl6YXRpb25zLCBob3dldmVy IGl0IHdvdWxkIGJlIHRyaXZpYWwgdG8gYWRkIHN1cHBvcnQKICAgICAvLyBmb3Igb3B0aW1pemVk IFVDaGFyIGZpcnN0X2J5dGUvcmVxX2J5dGUgc2NhbnMKLSAgICB1bnNpZ25lZCBjaGFyIGZpcnN0 X2J5dGU7Ci0gICAgdW5zaWduZWQgY2hhciByZXFfYnl0ZTsKKyAgICBwY3JlX3VpbnQxNiBmaXJz dF9ieXRlOworICAgIHBjcmVfdWludDE2IHJlcV9ieXRlOwogfTsKIAogLyogSW50ZXJuYWwgc2hh cmVkIGRhdGEgdGFibGVzLiBUaGVzZSBhcmUgdGFibGVzIHRoYXQgYXJlIHVzZWQgYnkgbW9yZSB0 aGFuIG9uZQo=