161940 2016-09-13 19:06:33 -0700 Web Inspector: Use more global color variables in TreeOutline and DataGrid 2016-09-15 17:22:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P3 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1229411 0 mattbaker 2016-09-13 19:06:33 -0700 Summary: Use more global color variables in TreeOutline and DataGrid. - Add variable for the unfocused selection color (gray), and use in grid and tree elements. - DataGrid should be using --selection-*-color variables. 1229412 1 webkit-bug-importer 2016-09-13 19:06:56 -0700 <rdar://problem/28292555> 1229414 2 288759 mattbaker 2016-09-13 19:10:28 -0700 Created attachment 288759 [Patch] Proposed Fix 1230252 3 288759 bburg 2016-09-15 17:00:27 -0700 Comment on attachment 288759 [Patch] Proposed Fix rs=me 1230259 4 288759 commit-queue 2016-09-15 17:22:11 -0700 Comment on attachment 288759 [Patch] Proposed Fix Clearing flags on attachment: 288759 Committed r206005: <http://trac.webkit.org/changeset/206005> 1230260 5 commit-queue 2016-09-15 17:22:14 -0700 All reviewed patches have been landed. Closing bug. 288759 2016-09-13 19:10:28 -0700 2016-09-15 17:22:11 -0700 [Patch] Proposed Fix bug-161940-20160913190752.patch text/plain 3792 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi MzgyMjA1MTkyZWVmZDQ4NzkyYTM5OTMwZDExY2Q2ZjIyZTcwN2I0Li5iYzNjMjRjMTZlM2UyZTVj ZmEwMjcwOTAzZWExYTEwNjJjNjY0OTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOCBAQAogMjAxNi0wOS0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNlIG1vcmUgZ2xvYmFsIGNvbG9yIHZhcmlhYmxl cyBpbiBUcmVlT3V0bGluZSBhbmQgRGF0YUdyaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTk0MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjgy OTI1NTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmNzczoKKyAgICAgICAgKC5kYXRhLWdyaWQg dHIuc2VsZWN0ZWQpOgorICAgICAgICAoLmRhdGEtZ3JpZDptYXRjaGVzKDpmb2N1cywgLmZvcmNl LWZvY3VzKSB0ci5zZWxlY3RlZCk6CisgICAgICAgIFVzZSBnbG9iYWwgY29sb3IgdmFycy4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuY3NzOgorICAgICAgICAo LnRyZWUtb3V0bGluZSAuaXRlbS5zZWxlY3RlZCk6CisgICAgICAgIFVzZSBnbG9iYWwgY29sb3Ig dmFycy4KKyAgICAgICAgKGJvZHkud2luZG93LWluYWN0aXZlIC50cmVlLW91dGxpbmUgLml0ZW0u c2VsZWN0ZWQpOiBEZWxldGVkLgorICAgICAgICBOb3QgbmVlZGVkLiBVbmZvY3VzZWQgY29sb3Ig aXMgdGhlIHNhbWUgd2hlbiB3aW5kb3cgaXMgaW5hY3RpdmUuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1ZhcmlhYmxlcy5jc3M6CisgICAgICAgICg6cm9vdCk6CisgICAgICAgIEFk ZCAtLXNlbGVjdGVkLWJhY2tncm91bmQtY29sb3ItdW5mb2N1c2VkLgorCisyMDE2LTA5LTEzICBN YXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBVc2UgQXJyYXkuc2hhbGxvd0VxdWFsIGluc3RlYWQgb2YgT2JqZWN0LnNoYWxsb3dFcXVhbCBp biBtb3JlIHBsYWNlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYxODY3CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODI2MTMyOD4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmNz cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmNz cwppbmRleCBiOWUyNmRmOGZlNjZiOTBkNWE4YzZkOTUwOWFjODdlN2Q2NGQ0ZmQxLi5hN2VhYWU2 NWUzZGE1MTg0MmQ4YzhmMmI5MTNiM2NiYTAzMTc0MDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5jc3MKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuY3NzCkBAIC0yNzIs MTMgKzI3MiwxMyBAQAogfQogCiAuZGF0YS1ncmlkIHRyLnNlbGVjdGVkIHsKLSAgICBiYWNrZ3Jv dW5kLWNvbG9yOiBoc2woMCwgMCUsIDgzJSkgIWltcG9ydGFudDsKKyAgICBiYWNrZ3JvdW5kLWNv bG9yOiB2YXIoLS1zZWxlY3RlZC1iYWNrZ3JvdW5kLWNvbG9yLXVuZm9jdXNlZCkgIWltcG9ydGFu dDsKICAgICBjb2xvcjogaW5oZXJpdCAhaW1wb3J0YW50OwogfQogCiAuZGF0YS1ncmlkOm1hdGNo ZXMoOmZvY3VzLCAuZm9yY2UtZm9jdXMpIHRyLnNlbGVjdGVkIHsKLSAgICBiYWNrZ3JvdW5kLWNv bG9yOiBoc2woMjA5LCAxMDAlLCA0OSUpICFpbXBvcnRhbnQ7Ci0gICAgY29sb3I6IHdoaXRlICFp bXBvcnRhbnQ7CisgICAgYmFja2dyb3VuZC1jb2xvcjogdmFyKC0tc2VsZWN0ZWQtYmFja2dyb3Vu ZC1jb2xvcikgIWltcG9ydGFudDsKKyAgICBjb2xvcjogdmFyKC0tc2VsZWN0ZWQtZm9yZWdyb3Vu ZC1jb2xvcikgIWltcG9ydGFudDsKIH0KIAogLmRhdGEtZ3JpZCB0cjpub3QoLnBhcmVudCkgdGQu ZGlzY2xvc3VyZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5jc3MKaW5kZXggMzUxY2EzM2E3MmE2MjliYzA1ZGE4 YTlmZjdjZGY3NWE2YTVhNWZmOC4uYmUxZGMwNmUxZTY0ZjM2ZDQyNzA5YTJhMDM0NmNkZTNlNTBj YzhmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVHJlZU91dGxpbmUuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmNzcwpAQCAtMTUyLDcgKzE1Miw3IEBACiB9CiAKIC50cmVl LW91dGxpbmUgLml0ZW0uc2VsZWN0ZWQgewotICAgIGJhY2tncm91bmQtY29sb3I6IGhzbCgwLCAw JSwgODMlKTsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS1zZWxlY3RlZC1iYWNrZ3JvdW5k LWNvbG9yLXVuZm9jdXNlZCk7CiB9CiAKIC50cmVlLW91dGxpbmU6bWF0Y2hlcyg6Zm9jdXMsIC5m b3JjZS1mb2N1cykgLml0ZW0uc2VsZWN0ZWQgewpAQCAtMTYwLDEwICsxNjAsNiBAQAogICAgIGJh Y2tncm91bmQtY29sb3I6IHZhcigtLXNlbGVjdGVkLWJhY2tncm91bmQtY29sb3IpOwogfQogCi1i b2R5LndpbmRvdy1pbmFjdGl2ZSAudHJlZS1vdXRsaW5lIC5pdGVtLnNlbGVjdGVkIHsKLSAgICBi YWNrZ3JvdW5kLWNvbG9yOiBoc2woMCwgMCUsIDgzJSk7Ci19Ci0KIC50cmVlLW91dGxpbmUgLml0 ZW0gLnRpdGxlcyB7CiAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgIHRvcDogMnB4OwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmFyaWFi bGVzLmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zhcmlh Ymxlcy5jc3MKaW5kZXggNzI2ODcwZDMyODM5MDA3YzhiOGMzZWY4OTBlMGEwMzBmMjZiOWM5Ni4u M2IzMTkzMzRmYjBjOTg0ZjM4MTYzYzc0NGQyZmM4MmNmZTAzNzI5YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmFyaWFibGVzLmNzcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WYXJpYWJsZXMuY3Nz CkBAIC0zNCw2ICszNCw3IEBACiAKICAgICAtLXNlbGVjdGVkLWZvcmVncm91bmQtY29sb3I6IHdo aXRlOwogICAgIC0tc2VsZWN0ZWQtYmFja2dyb3VuZC1jb2xvcjogaHNsKDIxMiwgOTIlLCA1NCUp OworICAgIC0tc2VsZWN0ZWQtYmFja2dyb3VuZC1jb2xvci11bmZvY3VzZWQ6IGhzbCgwLCAwJSwg ODMlKTsKICAgICAtLXNlbGVjdGVkLWJhY2tncm91bmQtY29sb3ItYWN0aXZlOiBoc2woMjE4LCA4 NSUsIDUyJSk7CiAgICAgLS1zZWxlY3RlZC1iYWNrZ3JvdW5kLWNvbG9yLWhvdmVyOiBoc2xhKDIx MiwgOTIlLCA1NCUsIDAuNSk7CiAgICAgLS1zZWxlY3RlZC1iYWNrZ3JvdW5kLWNvbG9yLWhpZ2hs aWdodDogaHNsYSgwLCAwJSwgMTAwJSwgMC4zKTsK