161929 2016-09-13 14:51:12 -0700 Promises aren't resolved properly when making a ObjC API callback 2016-09-13 19:31:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff benjamin cdumez cmarcelo commit-queue dbates keith_miller mark.lam saam oldest_to_newest 1229318 0 msaboff 2016-09-13 14:51:12 -0700 If a promise is resolved or rejected and the resolution handler is queue but hasn't been processed when an ObjC function callback is invoked, the promise resolution internal builtins may not compile properly. 1229319 1 msaboff 2016-09-13 14:51:38 -0700 rdar://problem/27992169 1229329 2 288735 msaboff 2016-09-13 15:17:10 -0700 Created attachment 288735 Patch 1229333 3 288735 ggaren 2016-09-13 15:21:42 -0700 Comment on attachment 288735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288735&action=review r=me It occurs to me that it is also a bug that we drain the micro task queue at all when calling out to ObjC. That should only happen when we exit the VM. > Source/JavaScriptCore/ChangeLog:3 > + Promises aren't resolved properly when making a ObcC API callback ObjC > Source/JavaScriptCore/ChangeLog:8 > + When we go to call out to an Objective C functions registered via the API, function 1229422 4 msaboff 2016-09-13 19:30:37 -0700 (In reply to comment #3) > Comment on attachment 288735 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288735&action=review > > r=me > > It occurs to me that it is also a bug that we drain the micro task queue at > all when calling out to ObjC. That should only happen when we exit the VM. I filed https://bugs.webkit.org/show_bug.cgi?id=161942 to track this. > > Source/JavaScriptCore/ChangeLog:3 > > + Promises aren't resolved properly when making a ObcC API callback > > ObjC Fixed. > > Source/JavaScriptCore/ChangeLog:8 > > + When we go to call out to an Objective C functions registered via the API, > > function Fixed. 1229423 5 msaboff 2016-09-13 19:31:28 -0700 Committed r205895: <http://trac.webkit.org/changeset/205895> 288735 2016-09-13 15:17:10 -0700 2016-09-13 15:21:42 -0700 Patch 161929.patch text/plain 4981 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA1ODgxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDE2LTA5LTEzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFByb21pc2VzIGFyZW4ndCByZXNvbHZlZCBwcm9wZXJseSB3aGVuIG1ha2luZyBhIE9iY0Mg QVBJIGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjE5MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIHdlIGdvIHRvIGNhbGwgb3V0IHRvIGFuIE9iamVjdGl2ZSBDIGZ1bmN0aW9ucyBy ZWdpc3RlcmVkIHZpYSB0aGUgQVBJLAorICAgICAgICB3ZSBmaXJzdCBkcm9wIGFsbCBKU0MgbG9j a3MgdG8gbWFrZSB0aGUgY2FsbC4gIEFzIHBhcnQgb2YgZHJvcHBpbmcgdGhlIGxvY2tzLAorICAg ICAgICB3ZSBkcmFpbiB0aGUgbWljcm90YXNrIHF1ZXVlIHRoYXQgaXMgdXNlZCBhbW9uZyBvdGhl ciB0aGluZ3MgZm9yIGhhbmRsaW5nIGRlZmVycmVkCisgICAgICAgIHByb21pc2UgcmVzb2x1dGlv bi4gIFRoZSBEcm9wQWxsTG9ja3Mgc2NvcGUgY2xhc3MgdGhhdCBkcm9wcyB0aGUgbG9ja3Mgd2hp bGUgaW4KKyAgICAgICAgc2NvcGUsIHJlc2V0cyB0aGUgY3VycmVudCB0aHJlYWQncyBBdG9taWNT dHJpbmdUYWJsZSB0byB0aGUgZGVmYXVsdCB0YWJsZS4gIFRoaXMKKyAgICAgICAgaXMgd3Jvbmcg Zm9yIHR3byByZWFzb25zLCBmaXJzdCBpdCBoYXBwZW5zIGJlZm9yZSB3ZSBkcmFpbiB0aGUgbWlj cm90YXNrIHF1ZXVlIGFuZAorICAgICAgICBzZWNvbmQgaXQgaXNuJ3QgbmVlZGVkIGFzIEpTTG9j azo6d2lsbFJlbGVhc2VMb2NrKCkgcmVzdG9yZXMgdGhlIGN1cnJlbnQgdGhyZWFkJ3MKKyAgICAg ICAgQXRvbWljU3RyaW5nVGFibGUgdG8gdGhlIHRhYmxlIGJlZm9yZSB0aGUgbG9jayB3YXMgYWNx dWlyZWQuCisKKyAgICAgICAgSW4gZmFjdCwgdGhlIG1hbmlwdWxhdGlvbiBvZiB0aGUgY3VycmVu dCB0aHJlYWQncyBBdG9taWNTdHJpbmdUYWJsZSBpcyBhbHJlYWR5IAorICAgICAgICBwcm9wZXJs eSBoYW5kbGVkIGFzIGEgc3RhY2sgaW4gSlNMb2NrOjpkaWRBY3F1aXJlTG9jaygpIGFuZCB3aWxs UmVsZWFzZUxvY2soKS4KKyAgICAgICAgVGhlcmVmb3JlIHRoZSBtYW5pcHVsYXRpb24gb2YgdGhl IEF0b21pY1N0cmluZ1RhYmxlIGluIERyb3BBbGxMb2NrcyBjb25zdHJ1Y3RvcgorICAgICAgICBh bmQgZGVzdHJ1Y3RvciBzaG91bGQgYmUgcmVtb3ZlZC4KKworICAgICAgICAqIEFQSS90ZXN0cy90 ZXN0YXBpLm1tOgorICAgICAgICAodGVzdE9iamVjdGl2ZUNBUElNYWluKTogQWRkZWQgYSBuZXcg dGVzdC4KKyAgICAgICAgKiBydW50aW1lL0pTTG9jay5jcHA6CisgICAgICAgIChKU0M6OkpTTG9j azo6RHJvcEFsbExvY2tzOjpEcm9wQWxsTG9ja3MpOgorICAgICAgICAoSlNDOjpKU0xvY2s6OkRy b3BBbGxMb2Nrczo6fkRyb3BBbGxMb2Nrcyk6CisKIDIwMTYtMDktMTMgIEpGIEJhc3RpZW4gIDxq ZmJhc3RpZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQganNjIHNoZWxsIGJ1aWx0aW4g YHJlYWRgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1t CShyZXZpc2lvbiAyMDU3NzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rl c3RhcGkubW0JKHdvcmtpbmcgY29weSkKQEAgLTU1Miw2ICs1NTIsMTUgQEAgc3RhdGljIHZvaWQg dGVzdE9iamVjdGl2ZUNBUElNYWluKCkKICAgICB9CiAKICAgICBAYXV0b3JlbGVhc2Vwb29sIHsK KyAgICAgICAgSlNWaXJ0dWFsTWFjaGluZSogdm0gPSBbW0pTVmlydHVhbE1hY2hpbmUgYWxsb2Nd IGluaXRdOworICAgICAgICBKU0NvbnRleHQqIGNvbnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10g aW5pdFdpdGhWaXJ0dWFsTWFjaGluZTp2bV07CisgICAgICAgIFRlc3RPYmplY3QqIHRlc3RPYmpl Y3QgPSBbVGVzdE9iamVjdCB0ZXN0T2JqZWN0XTsKKyAgICAgICAgY29udGV4dFtAInRlc3RPYmpl Y3QiXSA9IHRlc3RPYmplY3Q7CisgICAgICAgIFtjb250ZXh0IGV2YWx1YXRlU2NyaXB0OkAicmVz dWx0ID0gMDsgY2FsbGJhY2tSZXN1bHQgPSAwOyBQcm9taXNlLnJlc29sdmUoNDIpLnRoZW4oZnVu Y3Rpb24gKHZhbHVlKSB7IHJlc3VsdCA9IHZhbHVlOyB9KTsgY2FsbGJhY2tSZXN1bHQgPSB0ZXN0 T2JqZWN0LmdldFN0cmluZygpOyJdOworICAgICAgICBjaGVja1Jlc3VsdChAIk1pY3JvdGFzayBp cyBkcmFpbmVkIHdpdGggc2FtZSBWTSIsIFtjb250ZXh0W0AicmVzdWx0Il0gIGlzRXF1YWxUb09i amVjdDpANDJdICYmIFtjb250ZXh0W0AiY2FsbGJhY2tSZXN1bHQiXSBpc0VxdWFsVG9PYmplY3Q6 QCI0MiJdKTsKKyAgICB9CisKKyAgICBAYXV0b3JlbGVhc2Vwb29sIHsKICAgICAgICAgSlNDb250 ZXh0ICpjb250ZXh0ID0gW1tKU0NvbnRleHQgYWxsb2NdIGluaXRdOwogICAgICAgICBKU1ZhbHVl ICpyZXN1bHQgPSBbY29udGV4dCBldmFsdWF0ZVNjcmlwdDpAIih7IHg6NDIgfSkiXTsKICAgICAg ICAgY2hlY2tSZXN1bHQoQCIoeyB4OjQyIH0pIiwgcmVzdWx0LmlzT2JqZWN0ICYmIFtyZXN1bHRb QCJ4Il0gaXNFcXVhbFRvT2JqZWN0OkA0Ml0pOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNMb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0xvY2suY3BwCShyZXZpc2lvbiAyMDU3NzcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0xvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjcsNyArMjY3LDYg QEAgSlNMb2NrOjpEcm9wQWxsTG9ja3M6OkRyb3BBbGxMb2NrcyhWTSogdgogewogICAgIGlmICgh bV92bSkKICAgICAgICAgcmV0dXJuOwotICAgIHd0ZlRocmVhZERhdGEoKS5yZXNldEN1cnJlbnRB dG9taWNTdHJpbmdUYWJsZSgpOwogICAgIFJFTEVBU0VfQVNTRVJUKCFtX3ZtLT5hcGlMb2NrKCku Y3VycmVudFRocmVhZElzSG9sZGluZ0xvY2soKSB8fCAhbV92bS0+aXNDb2xsZWN0b3JCdXN5KCkp OwogICAgIG1fZHJvcHBlZExvY2tDb3VudCA9IG1fdm0tPmFwaUxvY2soKS5kcm9wQWxsTG9ja3Mo dGhpcyk7CiB9CkBAIC0yODcsNyArMjg2LDYgQEAgSlNMb2NrOjpEcm9wQWxsTG9ja3M6On5Ecm9w QWxsTG9ja3MoKQogICAgIGlmICghbV92bSkKICAgICAgICAgcmV0dXJuOwogICAgIG1fdm0tPmFw aUxvY2soKS5ncmFiQWxsTG9ja3ModGhpcywgbV9kcm9wcGVkTG9ja0NvdW50KTsKLSAgICB3dGZU aHJlYWREYXRhKCkuc2V0Q3VycmVudEF0b21pY1N0cmluZ1RhYmxlKG1fdm0tPmF0b21pY1N0cmlu Z1RhYmxlKCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBKU0MKSW5kZXg6IFNvdXJjZS9XVEYvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDU3 NzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTA5LTEzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisg ICAgICAgIFByb21pc2VzIGFyZW4ndCByZXNvbHZlZCBwcm9wZXJseSB3aGVuIG1ha2luZyBhIE9i Y0MgQVBJIGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjE5MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmVkIHJlc2V0Q3VycmVudEF0b21pY1N0cmluZ1RhYmxlKCkgd2hpY2ggaXMg bm8gbG9uZ2VyIHJlZmVyZW5jZWQuCisKKyAgICAgICAgKiB3dGYvV1RGVGhyZWFkRGF0YS5oOgor ICAgICAgICAoV1RGOjpXVEZUaHJlYWREYXRhOjpyZXNldEN1cnJlbnRBdG9taWNTdHJpbmdUYWJs ZSk6IERlbGV0ZWQuCisKIDIwMTYtMDktMDkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIEdhcmRlbmluZzogZml4aW5nIGEgZmV3IEpTQyB0ZXN0IGZhaWx1cmVzLgpJ bmRleDogU291cmNlL1dURi93dGYvV1RGVGhyZWFkRGF0YS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1dURlRocmVhZERhdGEuaAkocmV2aXNpb24gMjA1Nzc3KQorKysgU291cmNlL1dU Ri93dGYvV1RGVGhyZWFkRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC03MSwxMSArNzEsNiBAQCBw dWJsaWM6CiAgICAgICAgIHJldHVybiBvbGRBdG9taWNTdHJpbmdUYWJsZTsKICAgICB9CiAKLSAg ICB2b2lkIHJlc2V0Q3VycmVudEF0b21pY1N0cmluZ1RhYmxlKCkKLSAgICB7Ci0gICAgICAgIG1f Y3VycmVudEF0b21pY1N0cmluZ1RhYmxlID0gbV9kZWZhdWx0QXRvbWljU3RyaW5nVGFibGU7Ci0g ICAgfQotCiAgICAgY29uc3QgU3RhY2tCb3VuZHMmIHN0YWNrKCkKICAgICB7CiAgICAgICAgIC8v IFdlIG5lZWQgdG8gYWx3YXlzIGdldCBhIGZyZXNoIFN0YWNrQm91bmRzIGZyb20gdGhlIE9TIGR1 ZSB0byBob3cgZmliZXJzIHdvcmsuCg==