161904 2016-09-13 04:09:39 -0700 [GTK] Drop redundant wl_display_flush_clients() call 2016-10-08 16:14:53 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 emanuele.aina webkit-unassigned bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1229132 0 emanuele.aina 2016-09-13 04:09:39 -0700 The Wayland GSource::prepare() function already calls wl_display_flush_clients() at every mainloop iteration, so there's no need to further call it on Surface::commit(). 1229133 1 288684 emanuele.aina 2016-09-13 04:11:12 -0700 Created attachment 288684 Patch 1229142 2 288684 cgarcia 2016-09-13 05:05:38 -0700 Comment on attachment 288684 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288684&action=review > Source/WebKit2/ChangeLog:10 > + The Wayland GSource::prepare() function already calls > + wl_display_flush_clients() at every mainloop iteration, so there's no > + need to further call it on Surface::commit(). That's not equivalent, prepare is called before dispatch, and commit happens on dispatch. I'm not saying we need to flush on commit, because I don't know, I copied that from previous patches, but this explanation is not clear to me. 1229150 3 emanuele.aina 2016-09-13 05:41:56 -0700 Yep, I didn't mean to imply that it was equivalent, just that as far as I can tell, even by asking to Wayland developer around here, there's no reason to call wl_display_flush_clients() in ::commit(), and that the call in ::prepare() is the place where they expected the call to be. For further reference, the Wakefield experimental compositor only does it in the ::prepare() function: https://github.com/alexlarsson/wakefield/blob/master/wakefield-compositor.c#L1919 Let me know how I can make the ChangeLog entry more clear. 1238023 4 288684 commit-queue 2016-10-08 16:14:50 -0700 Comment on attachment 288684 Patch Clearing flags on attachment: 288684 Committed r206961: <http://trac.webkit.org/changeset/206961> 1238024 5 commit-queue 2016-10-08 16:14:53 -0700 All reviewed patches have been landed. Closing bug. 288684 2016-09-13 04:11:12 -0700 2016-10-08 16:14:50 -0700 Patch bug-161904-20160913130837.patch text/plain 3196 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1ODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDY3ZWRmMmRiNmZiNjFi YzE4NGJiZjBiMDUyZjgzMGZjYWI0NDA4My4uYTMwNjVhMGNlNjM4YjYwMzFkODU4MTkzMzgzNjE2 ZjM5ZTcxNmExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTEzICBFbWFu dWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtHVEtd IERyb3AgcmVkdW5kYW50IHdsX2Rpc3BsYXlfZmx1c2hfY2xpZW50cygpIGNhbGwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTkwNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXYXlsYW5kIEdTb3Vy Y2U6OnByZXBhcmUoKSBmdW5jdGlvbiBhbHJlYWR5IGNhbGxzCisgICAgICAgIHdsX2Rpc3BsYXlf Zmx1c2hfY2xpZW50cygpIGF0IGV2ZXJ5IG1haW5sb29wIGl0ZXJhdGlvbiwgc28gdGhlcmUncyBu bworICAgICAgICBuZWVkIHRvIGZ1cnRoZXIgY2FsbCBpdCBvbiBTdXJmYWNlOjpjb21taXQoKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXYXlsYW5kQ29tcG9zaXRvcjo6U3VyZmFjZTo6Y29tbWl0KToKKyAgICAgICAg KiBVSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmg6CisKIDIwMTYtMDktMTIgIERBTiBT QVVOREVSUyAgPGRhc2F1QG1pY3Jvc29mdC5jb20+CiAKICAgICAgICAgQVg6IFdLV2ViVmlldyBm b3IgbWFjT1MgZG9lcyBub3QgYWxsb3cgY29uZmlndXJhdGlvbiBvZiB0YWJzVG9MaW5rcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRvci5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmNwcApp bmRleCA0ZDU5ODA1NWRkMjM3MWYyOTYxOTAzZWE5ZmYyZTllMDJkMTc4YTM5Li4yN2Y3ODBlZTIw NmJmY2Y1ZDhiZTZjYWMyZTg1NjY1NjYwNDY4YjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmNwcApAQCAtMjE4LDE0ICsyMTgsMTQg QEAgYm9vbCBXYXlsYW5kQ29tcG9zaXRvcjo6U3VyZmFjZTo6cHJlcGFyZVRleHR1cmVGb3JQYWlu dGluZyh1bnNpZ25lZCYgdGV4dHVyZSwgSW4KICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotYm9vbCBX YXlsYW5kQ29tcG9zaXRvcjo6U3VyZmFjZTo6Y29tbWl0KCkKK3ZvaWQgV2F5bGFuZENvbXBvc2l0 b3I6OlN1cmZhY2U6OmNvbW1pdCgpCiB7CiAgICAgRUdMRGlzcGxheSBlZ2xEaXNwbGF5ID0gUGxh dGZvcm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5KCkuZWdsRGlzcGxheSgpOwogICAgIGlmIChtX2lt YWdlICE9IEVHTF9OT19JTUFHRV9LSFIpCiAgICAgICAgIGVnbERlc3Ryb3lJbWFnZShlZ2xEaXNw bGF5LCBtX2ltYWdlKTsKICAgICBtX2ltYWdlID0gbV9wZW5kaW5nQnVmZmVyLT5jcmVhdGVJbWFn ZSgpOwogICAgIGlmIChtX2ltYWdlID09IEVHTF9OT19JTUFHRV9LSFIpCi0gICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAgICAgcmV0dXJuOwogCiAgICAgbWFrZVBlbmRpbmdCdWZmZXJDdXJyZW50 KCk7CiAgICAgaWYgKG1fd2ViUGFnZSkKQEAgLTI0MCw4ICsyNDAsNiBAQCBib29sIFdheWxhbmRD b21wb3NpdG9yOjpTdXJmYWNlOjpjb21taXQoKQogICAgICAgICB3bF9jYWxsYmFja19zZW5kX2Rv bmUocmVzb3VyY2UsIDApOwogICAgICAgICB3bF9yZXNvdXJjZV9kZXN0cm95KHJlc291cmNlKTsK ICAgICB9Ci0KLSAgICByZXR1cm4gdHJ1ZTsKIH0KIAogc3RhdGljIGNvbnN0IHN0cnVjdCB3bF9z dXJmYWNlX2ludGVyZmFjZSBzdXJmYWNlSW50ZXJmYWNlID0gewpAQCAtMjg4LDkgKzI4Niw3IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgd2xfc3VyZmFjZV9pbnRlcmZhY2Ugc3VyZmFjZUludGVyZmFj ZSA9IHsKICAgICAgICAgYXV0byogc3VyZmFjZSA9IHN0YXRpY19jYXN0PFdheWxhbmRDb21wb3Np dG9yOjpTdXJmYWNlKj4od2xfcmVzb3VyY2VfZ2V0X3VzZXJfZGF0YShyZXNvdXJjZSkpOwogICAg ICAgICBpZiAoIXN1cmZhY2UpCiAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgaWYgKHN1 cmZhY2UtPmNvbW1pdCgpKQotICAgICAgICAgICAgd2xfZGlzcGxheV9mbHVzaF9jbGllbnRzKHds X2NsaWVudF9nZXRfZGlzcGxheShjbGllbnQpKTsKKyAgICAgICAgc3VyZmFjZS0+Y29tbWl0KCk7 CiAgICAgfSwKICAgICAvLyBzZXRCdWZmZXJUcmFuc2Zvcm1DYWxsYmFjawogICAgIFtdKHN0cnVj dCB3bF9jbGllbnQqLCBzdHJ1Y3Qgd2xfcmVzb3VyY2UqLCBpbnQzMl90KSB7IH0sCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmgKaW5kZXggMGQy OGFhNzY1MTc5NWU3MDczM2NmMTI4NzhjMjU4YWVlYjk4NDcxNi4uNjI2ZWMzYTc4N2Q5NzRjZmM3 MmI5NGRhYzU5YWViODU5ZTA0M2ViNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuaApAQCAtODUsNyArODUsNyBAQCBwdWJsaWM6CiAKICAg ICAgICAgdm9pZCBhdHRhY2hCdWZmZXIoc3RydWN0IHdsX3Jlc291cmNlKik7CiAgICAgICAgIHZv aWQgcmVxdWVzdEZyYW1lKHN0cnVjdCB3bF9yZXNvdXJjZSopOwotICAgICAgICBib29sIGNvbW1p dCgpOworICAgICAgICB2b2lkIGNvbW1pdCgpOwogCiAgICAgICAgIHZvaWQgc2V0V2ViUGFnZShX ZWJQYWdlUHJveHkqIHdlYlBhZ2UpIHsgbV93ZWJQYWdlID0gd2ViUGFnZTsgfQogICAgICAgICBi b29sIHByZXBhcmVUZXh0dXJlRm9yUGFpbnRpbmcodW5zaWduZWQmLCBXZWJDb3JlOjpJbnRTaXpl Jik7Cg==