161903 2016-09-13 04:07:48 -0700 [css-grid] Fix intrinsic size computation with flexible sized tracks 2016-09-15 01:44:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar commit-queue esprehn+autocc glenn jfernandez kondapallykalyan rego oldest_to_newest 1229130 0 svillar 2016-09-13 04:07:48 -0700 [css-grid] Fix intrinsic size computation with flexible sized tracks 1229134 1 288685 svillar 2016-09-13 04:13:19 -0700 Created attachment 288685 Patch 1229139 2 288685 jfernandez 2016-09-13 04:37:47 -0700 Comment on attachment 288685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288685&action=review The patch looks good. > Source/WebCore/ChangeLog:10 > + stated in the early versions of the spec that size is the sum of the tracks' base sizes typo -> s/tracks'/track's 1229948 3 288685 commit-queue 2016-09-15 01:44:18 -0700 Comment on attachment 288685 Patch Clearing flags on attachment: 288685 Committed r205960: <http://trac.webkit.org/changeset/205960> 1229949 4 commit-queue 2016-09-15 01:44:22 -0700 All reviewed patches have been landed. Closing bug. 288685 2016-09-13 04:13:19 -0700 2016-09-15 01:44:18 -0700 Patch bug-161903-20160913130940.patch text/plain 6074 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1ODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmNmJjNmJlNzk4NTkw NWZkODdjNzMyMDAyNjRiNTdjOWJhM2IzMy4uMDUyNzg3NGI5NWMwZGFjM2JiYzMxMjVmMmE5MzQ4 ZmVjYWFhZTFiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA5LTEzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gRml4IGludHJpbnNpYyBzaXplIGNvbXB1dGF0aW9uIHdpdGggZmxleGlibGUgc2l6ZWQgdHJh Y2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE5 MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGlzIGZpeGluZyBhIHJlZ3Jlc3Npb24gYWRkZWQgaW4gcjE5MjE1NC4gV2hlbiBjb21wdXRpbmcg dGhlIG1pbiBjb250ZW50IHNpemUgb2YgYSBncmlkCisgICAgICAgIGNvbnRhaW5lciAobWluIHBy ZWZlcnJlZCBsb2dpY2FsIHdpZHRoKSB3ZSBzaG91bGQgbm90IHRha2UgaW50byBhY2NvdW50IHRo ZSBmciB0cmFja3MuIEFzCisgICAgICAgIHN0YXRlZCBpbiB0aGUgZWFybHkgdmVyc2lvbnMgb2Yg dGhlIHNwZWMgdGhhdCBzaXplIGlzIHRoZSBzdW0gb2YgdGhlIHRyYWNrcycgYmFzZSBzaXplcwor ICAgICAgICBiZWZvcmUgcnVubmluZyB0aGUgbWF4aW1pemUgdHJhY2tzIHN0ZXAuCisKKyAgICAg ICAgVGhhdCByZWdyZXNzaW9uIHdhcyBjYXVzaW5nIHNpemluZyBpc3N1ZXMgaW4gZ3JpZHMgd2l0 aCBmciB0cmFja3MgYm90aCB3aGVuIHVuZGVyCisgICAgICAgIG1pbnxtYXgtY29udGVudCBjb25z dHJhaW5zIGFuZCBhbHNvIHdoZW4gdXNlZCBhcyBncmlkIGl0ZW1zIChpbiBuZXN0ZWQgZ3JpZHMp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyR3JpZDo6Y29tcHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKToKKwogMjAxNi0w OS0xMiAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dp bl0gV2FybmluZyBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKaW5k ZXggNWYwNzhiYzgyZTExOWY3NDQ5ZDdmOGU3MWUyZWQ2MjhlNGRiZmRiOS4uNjIzYTljMWYyYmVm ZWU5NzQ5NDRiOTUxY2JkYmVmNGRiOGQxMjFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJHcmlkLmNwcApAQCAtNzU2LDggKzc1Niw2IEBAIHZvaWQgUmVuZGVyR3JpZDo6Y29tcHV0 ZVVzZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJlY3Rp CiAgICAgICAgIGlmIChMYXlvdXRVbml0IGluY3JlbWVudCA9IGJhc2VTaXplIC0gb2xkQmFzZVNp emUpIHsKICAgICAgICAgICAgIHRyYWNrLnNldEJhc2VTaXplKGJhc2VTaXplKTsKICAgICAgICAg ICAgIGZyZWVTcGFjZSAtPSBpbmNyZW1lbnQ7Ci0KLSAgICAgICAgICAgIGJhc2VTaXplc1dpdGhv dXRNYXhpbWl6YXRpb24gKz0gaW5jcmVtZW50OwogICAgICAgICAgICAgZ3Jvd3RoTGltaXRzV2l0 aG91dE1heGltaXphdGlvbiArPSBpbmNyZW1lbnQ7CiAgICAgICAgIH0KICAgICB9CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MjM0NzI1MTZiZTkzNDFmNzdmZTYyMTMxYjI1MjNmMmFhNjYzOWIxNi4uNjdmZWM3OGQ5ZTAxMjIy MDBkYTc1MzBjNjZlMGNiNWY1NjAwZWU3OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5 LTEzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAg IFtjc3MtZ3JpZF0gRml4IGludHJpbnNpYyBzaXplIGNvbXB1dGF0aW9uIHdpdGggZmxleGlibGUg c2l6ZWQgdHJhY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjE5MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRlZCBhIGNvdXBsZSBvZiBuZXcgdGVzdCBjYXNlcywgZ3JpZCB3aXRoIGZyIHRyYWNr cyBpbnNpZGUgYSBjb250YWluZXIgd2l0aCBpbnRyaW5zaWMKKyAgICAgICAgZGltZW5zaW9ucyBh bmQgYW5kIGdyaWQgd2l0aCBmciB0cmFja3MgaW5zaWRlIGFub3RoZXIgZ3JpZCB3aXRoIGZyIHRy YWNrcy4KKworICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2ZsZXgtYW5kLWludHJpbnNp Yy1zaXplcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZmxl eC1hbmQtaW50cmluc2ljLXNpemVzLmh0bWw6CisKIDIwMTYtMDktMTMgIFNrYWNoa292IE9sZWtz YW5kciAgPGdza2FjaGtvdkBnbWFpbC5jb20+CiAKICAgICAgICAgRVM2OiBDbGFzc2VzOiBTaG91 bGQgYmUgYWxsb3dlZCB0byBjcmVhdGUgYSBzdGF0aWMgbWV0aG9kIHdpdGggbmFtZSAiYXJndW1l bnRzIgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZmxleC1h bmQtaW50cmluc2ljLXNpemVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdy aWQtbGF5b3V0L2ZsZXgtYW5kLWludHJpbnNpYy1zaXplcy1leHBlY3RlZC50eHQKaW5kZXggZjYz NzcwNGU0MDJlMjc5OTk3Nzc5YzkzYTU5NjlkNDY0MjBjMGMwMy4uODE0OWRjNjMzMzFlM2I0ZTEy OWJhNWNhZGY3MDNmNjAzYzVmYjUwYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3Mt Z3JpZC1sYXlvdXQvZmxleC1hbmQtaW50cmluc2ljLXNpemVzLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9mbGV4LWFuZC1pbnRyaW5zaWMtc2l6ZXMt ZXhwZWN0ZWQudHh0CkBAIC0zLDE3ICszLDE5IEBAIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBmciB0 cmFja3MgYXJlIHByb3Blcmx5IHNpemVkIHdoZW5ldmVyIGdyaWQgaGF2ZSBpbnRyaW5zaWMKIFhY WCBYWFgKIFBBU1MKIFhYWCBYWFgKLUZBSUw6Ci1FeHBlY3RlZCAzMCBmb3Igd2lkdGgsIGJ1dCBn b3QgNzAuIAotCi08ZGl2IGNsYXNzPSJjb250YWluZXIiPgotICA8ZGl2IGNsYXNzPSJncmlkIG1p bi1jb250ZW50IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIzMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9 IjEwIj4KLSAgICA8ZGl2PlhYWCBYWFg8L2Rpdj4KLSAgPC9kaXY+Ci08L2Rpdj4KK1BBU1MKIFhY WCBYWFgKIFBBU1MKIFhYWCBYWFgKIFBBU1MKIFhYWCBYWFgKIFBBU1MKK1hYWCBYWFhYIFhYIFgg WFggWFhYCitQQVNTCitYWFggWFhYWCBYWCBYIFhYIFhYWAorUEFTUworWFhYWAorWFhYWCBYWCBY WAorWFhYIFhYIFgKK1hYWFggWFhYIFhYWFggWFhYIFhYWFgKK1BBU1MKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2ZsZXgtYW5kLWludHJpbnNpYy1zaXplcy5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZmxleC1hbmQtaW50cmluc2lj LXNpemVzLmh0bWwKaW5kZXggMzUxMGRjOTVhNjQ0YTlhMDU3MGE4ZDkyNTVjNmNmNzg3ZGI3MWFh NS4uNGM5NTE3Mjg0ZDZhMjY5M2Q0OTEyMjBjZDQ3YzhiZjk0MDUwNTVkMSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZmxleC1hbmQtaW50cmluc2ljLXNpemVz Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZmxleC1hbmQtaW50 cmluc2ljLXNpemVzLmh0bWwKQEAgLTE2LDcgKzE2LDYgQEAKIH0KIAogZGl2IHsgZm9udDogMTBw eC8xIEFoZW07IH0KLQogPC9zdHlsZT4KIAogPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9j aGVjay1sYXlvdXQuanMiPjwvc2NyaXB0PgpAQCAtMzEsOSArMzAsOCBAQCBkaXYgeyBmb250OiAx MHB4LzEgQWhlbTsgfQogICA8L2Rpdj4KIDwvZGl2PgogCi08IS0tIFRoaXMgZmFpbHMgZHVlIHRv IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2NzQgLS0+CiA8ZGl2 IGNsYXNzPSJjb250YWluZXIiPgotICA8ZGl2IGNsYXNzPSJncmlkIG1pbi1jb250ZW50IiBkYXRh LWV4cGVjdGVkLXdpZHRoPSIzMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjEwIj4KKyAgPGRpdiBj bGFzcz0iZ3JpZCBtaW4tY29udGVudCIgZGF0YS1leHBlY3RlZC13aWR0aD0iMzAiIGRhdGEtZXhw ZWN0ZWQtaGVpZ2h0PSIyMCI+CiAgICAgPGRpdj5YWFggWFhYPC9kaXY+CiAgIDwvZGl2PgogPC9k aXY+CkBAIC01Niw0ICs1NCwyOCBAQCBkaXYgeyBmb250OiAxMHB4LzEgQWhlbTsgfQogICA8L2Rp dj4KIDwvZGl2PgogCis8ZGl2IGNsYXNzPSJtaW4tY29udGVudCI+CisgICAgPGRpdiBjbGFzcz0i Z3JpZCIgZGF0YS1leHBlY3RlZC13aWR0aD0iNDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI1MCI+ CisgICAgICAgIDxkaXY+WFhYIFhYWFggWFggWCBYWCBYWFg8L2Rpdj4KKyAgICA8L2Rpdj4KKzwv ZGl2PgorCis8ZGl2IGNsYXNzPSJncmlkIGNvbnRhaW5lciIgZGF0YS1leHBlY3RlZC13aWR0aD0i MTAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMTAwIj4KKyAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5 OiBncmlkOyBncmlkLXRlbXBsYXRlLWNvbHVtbnM6IDNmcjsgZ3JpZC10ZW1wbGF0ZS1yb3dzOiAy ZnI7IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIxMDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIxMDAi PgorICAgICAgICA8ZGl2PlhYWCBYWFhYIFhYIFggWFggWFhYPC9kaXY+CisgICAgPC9kaXY+Cis8 L2Rpdj4KKworPGRpdiBjbGFzcz0iZ3JpZCIgc3R5bGU9ImdyaWQ7IGdyaWQ6IDFmciAyZnIgLyAy ZnIgMWZyOyB3aWR0aDogMzAwcHg7IGhlaWdodDogMzAwcHg7IiBkYXRhLWV4cGVjdGVkLXdpZHRo PSIzMDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIzMDAiPgorICAgIDxkaXYgY2xhc3M9ImZpcnN0 Um93Rmlyc3RDb2x1bW4iIHN0eWxlPSJkaXNwbGF5OiBncmlkOyBncmlkOiAxZnIgM2ZyIC8gM2Zy IDFmcjsiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjIwMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjEw MCI+CisgICAgICAgIDxkaXYgc3R5bGU9ImJvcmRlcjogMnB4IHNvbGlkIG1hZ2VudGE7IiBkYXRh LWV4cGVjdGVkLXdpZHRoPSIxNTAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIyNSI+WFhYWDwvZGl2 PgorICAgICAgICA8ZGl2IGNsYXNzPSJzZWNvbmRSb3dTZWNvbmRDb2x1bW4iIHN0eWxlPSJib3Jk ZXI6IDJweCBzb2xpZCBjeWFuOyIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAiIGRhdGEtZXhwZWN0 ZWQtaGVpZ2h0PSI3NSI+WFhYWCBYWCBYWDwvZGl2PgorICAgIDwvZGl2PgorICAgIDxkaXYgY2xh c3M9InNlY29uZFJvd1NlY29uZENvbHVtbiIgc3R5bGU9ImRpc3BsYXk6IGdyaWQ7IGdyaWQ6IDNm ciA0ZnIgLyA0ZnIgM2ZyOyIgZGF0YS1leHBlY3RlZC13aWR0aD0iMTAwIiBkYXRhLWV4cGVjdGVk LWhlaWdodD0iMjAwIj4KKyAgICAgICAgPGRpdiBzdHlsZT0iYm9yZGVyOiAycHggc29saWQgbGlt ZTsiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjU2IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iODYiPlhY WCBYWCBYPC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InNlY29uZFJvd1NlY29uZENvbHVtbiIg c3R5bGU9ImJvcmRlcjogMnB4IHNvbGlkIG5hdnk7IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI0NCIg ZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjExNCI+WFhYWCBYWFggWFhYWCBYWFggWFhYWDwvZGl2Pgor ICAgIDwvZGl2PgorPC9kaXY+CisKKwogPC9ib2R5Pgo=