161874 2016-09-12 15:05:06 -0700 HTMLButtonElement.prototype.click should be HTMLElement.prototype.click 2016-09-12 16:36:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck cdumez commit-queue esprehn+autocc gyuyoung.kim kondapallykalyan oldest_to_newest 1228924 0 joepeck 2016-09-12 15:05:06 -0700 Summary: HTMLButtonElement.prototype.click should be HTMLElement.prototype.click Seems we have "void click()" in HTMLButtonElement's IDL even though its already handled by HTMLElement. My guess is this was for ObjC bindings generation, but that is no longer necessary. However, this extra declaration causes an unexpected observable affect on the page. Eliminate it. 1228928 1 288617 joepeck 2016-09-12 15:07:32 -0700 Created attachment 288617 [PATCH] Proposed Fix 1228975 2 288617 cdumez 2016-09-12 16:14:43 -0700 Comment on attachment 288617 [PATCH] Proposed Fix r=me 1228984 3 288617 commit-queue 2016-09-12 16:36:04 -0700 Comment on attachment 288617 [PATCH] Proposed Fix Clearing flags on attachment: 288617 Committed r205839: <http://trac.webkit.org/changeset/205839> 1228985 4 commit-queue 2016-09-12 16:36:09 -0700 All reviewed patches have been landed. Closing bug. 288617 2016-09-12 15:07:32 -0700 2016-09-12 16:36:04 -0700 [PATCH] Proposed Fix click-1.patch text/plain 3082 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzY2RlZGRlLi5kY2E1ZjEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDkt MTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBIVE1M QnV0dG9uRWxlbWVudC5wcm90b3R5cGUuY2xpY2sgc2hvdWxkIGJlIEhUTUxFbGVtZW50LnByb3Rv dHlwZS5jbGljaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYxODc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBmYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jbGljay1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NsaWNrLmh0bWw6IEFkZGVk LgorCiAyMDE2LTA5LTEyICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBPYmplY3Quc2hhbGxvd0VxdWFsKCkgc2hvdWxkIHJldHVybiBm YWxzZSBpZiBvYmplY3QgcHJvdG90eXBlIGNoYWlucyBkaWZmZXIKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NsaWNrLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NsaWNrLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lMWQzNmE5Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVsZW1lbnQvY2xpY2stZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3RzIEhUTUxCdXR0b25FbGVtZW50J3MgY2xpY2sg aXMganVzdCBIVE1MRWxlbWVudCBjbGljaworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBIVE1MRWxlbWVudC5wcm90b3R5cGUuY2xpY2sgaXMgSFRNTEJ1dHRvbkVsZW1lbnQu cHJvdG90eXBlLmNsaWNrCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVs ZW1lbnQvY2xpY2suaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50 L2NsaWNrLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2ZiZGI0Ywot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50 L2NsaWNrLmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxi b2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIEhUTUxCdXR0b25FbGVtZW50J3Mg Y2xpY2sgaXMganVzdCBIVE1MRWxlbWVudCBjbGljayIpOworc2hvdWxkQmUoIkhUTUxFbGVtZW50 LnByb3RvdHlwZS5jbGljayIsICJIVE1MQnV0dG9uRWxlbWVudC5wcm90b3R5cGUuY2xpY2siKTsK Kzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGE2MGM4YmYuLjk1 ZTcxNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNi0wOS0xMiAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxCdXR0b25FbGVtZW50 LnByb3RvdHlwZS5jbGljayBzaG91bGQgYmUgSFRNTEVsZW1lbnQucHJvdG90eXBlLmNsaWNrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE4NzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0 L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jbGljay5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxC dXR0b25FbGVtZW50LmlkbDoKKyAgICAgICAgUmVtb3ZlIHRoZSB1bm5lY2Vzc2FyeSAnY2xpY2sn IGRlZmluaXRpb24uIEl0IGFscmVhZHkgZXhpc3RzIGluIEhUTUxFbGVtZW50LgorICAgICAgICBJ ZiB0aGlzIHdhcyBuZWVkZWQgZm9yIE9iakMgY29kZSBnZW5lcmF0aW9uIG9uIERPTUhUTUxCdXR0 b25FbGVtZW50LCB0aGVuCisgICAgICAgIHRoZSBleHRyYSBkZWZpbml0aW9uIGlzIG5vIGxvbmdl ciBuZWVkZWQgbm93IHRoYXQgT2JqQyBiaW5kaW5ncyBoYXZlIG1vdmVkLgorCiAyMDE2LTA5LTEy ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3dpdGNoIHJlbWFp bmluZyB1c2VycyBvZiBEb2N1bWVudDo6aW5QYWdlQ2FjaGUoKSB0byBwYWdlQ2FjaGVTdGF0ZSgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmlkbCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuaWRsCmluZGV4IDgwNGM4ZWYu LjdlODZjYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1l bnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuaWRsCkBA IC00MCw2ICs0MCw0IEBAIGludGVyZmFjZSBIVE1MQnV0dG9uRWxlbWVudCA6IEhUTUxFbGVtZW50 IHsKICAgICB2b2lkIHNldEN1c3RvbVZhbGlkaXR5KERPTVN0cmluZz8gZXJyb3IpOwogCiAgICAg cmVhZG9ubHkgYXR0cmlidXRlIE5vZGVMaXN0IGxhYmVsczsKLQotICAgIHZvaWQgY2xpY2soKTsK IH07Cg==