<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>16186</bug_id>
          
          <creation_ts>2007-11-29 04:12:23 -0800</creation_ts>
          <short_desc>Reduce number of c-stack-based MatchFrames</short_desc>
          <delta_ts>2011-09-06 22:31:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>16185</dependson>
    
    <dependson>16187</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>darin</cc>
    
    <cc>ggaren</cc>
    
    <cc>mjs</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>62681</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2007-11-29 04:12:23 -0800</bug_when>
    <thetext>Reduce number of c-stack-based MatchFrames

I believe the credit for this idea goes to Darin, I heard about it through Maciej.  Currently we allocate space for 16 match frames every time we call into match().  That&apos;s excessive, since very very very few regexps ever go beyond a few frames.

Supposedly darin tried this and found that reducing to 4 frames was a big speedup.  I expect we could probably reduce to 8 frames w/o worrying too much about affecting real-world performance.  Until bug 16185 is fixed, we always use 2 frames for every regexp. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62685</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2007-11-29 05:06:11 -0800</bug_when>
    <thetext>I just tested reducing FRAMES_ON_STACK to 8 and 4, and saw no change in SunSpider.  Unless I missed something, we might just want to close this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463155</commentid>
    <comment_count>2</comment_count>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2011-09-06 22:31:16 -0700</bug_when>
    <thetext>This is a proposed optimization for PCRE; we no longer use PCRE.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>