161858 2016-09-12 04:01:09 -0700 [Win] Warning fix. 2016-09-12 23:54:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue mmaxfield oldest_to_newest 1228718 0 pvollan 2016-09-12 04:01:09 -0700 We should fix the following warning: Source\WebCore\platform\spi\win\CoreTextSPIWin.h(39): warning C4273: 'kCTFontAttributeName': inconsistent dll linkage 1228719 1 288565 pvollan 2016-09-12 04:06:06 -0700 Created attachment 288565 Patch 1228726 2 288567 pvollan 2016-09-12 05:02:42 -0700 Created attachment 288567 Patch 1228769 3 288567 bfulgham 2016-09-12 09:58:48 -0700 Comment on attachment 288567 Patch r=me. 1229104 4 pvollan 2016-09-12 23:51:23 -0700 (In reply to comment #3) > Comment on attachment 288567 [details] > Patch > > r=me. Thanks for reviewing! 1229105 5 288567 commit-queue 2016-09-12 23:54:38 -0700 Comment on attachment 288567 Patch Clearing flags on attachment: 288567 Committed r205855: <http://trac.webkit.org/changeset/205855> 1229106 6 commit-queue 2016-09-12 23:54:41 -0700 All reviewed patches have been landed. Closing bug. 288565 2016-09-12 04:06:06 -0700 2016-09-12 05:02:38 -0700 Patch bug-161858-20160912040338.patch text/plain 1881 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTgwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTEyICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZp eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTg1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBl eHBvcnRlZCBjb25zdGFudHMgZnJvbSBDb3JlVGV4dC5kbGwgaW5zdGVhZCBvZiBjcmVhdGluZyBj b3BpZXMuCisgICAgICAgIAorICAgICAgICAqIFBsYXRmb3JtQXBwbGVXaW4uY21ha2U6CisgICAg ICAgICogcGxhdGZvcm0vc3BpL3dpbi9Db3JlVGV4dFNQSVdpbi5oOgorCiAyMDE2LTA5LTEyICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgb2wuc3RhcnQgbWF5IHJl dHVybiBpbmNvcnJlY3QgdmFsdWUgZm9yIHJldmVyc2VkIGxpc3RzIHdoZW4gbm90IGV4cGxpY2l0 bHkgc2V0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21ha2UJKHJldmlzaW9u IDIwNTc0MCkKKysrIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21ha2UJKHdvcmtp bmcgY29weSkKQEAgLTEwNyw4ICsxMDcsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMK ICAgICBwbGF0Zm9ybS9uZXR3b3JrL2NmL1N5bmNocm9ub3VzTG9hZGVyQ2xpZW50Q0ZOZXQuY3Bw CiAgICAgcGxhdGZvcm0vbmV0d29yay9jZi9TeW5jaHJvbm91c1Jlc291cmNlSGFuZGxlQ0ZVUkxD b25uZWN0aW9uRGVsZWdhdGUuY3BwCiAKLSAgICBwbGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJ V2luLmNwcAotCiAgICAgcGxhdGZvcm0vd2luL0RyYWdJbWFnZUNHV2luLmNwcAogKQogCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJV2luLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL3dpbi9Db3JlVGV4dFNQSVdpbi5o CShyZXZpc2lvbiAyMDU3NDApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvd2luL0Nv cmVUZXh0U1BJV2luLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDggKzM2LDggQEAgdHlwZWRlZiBj b25zdCBzdHJ1Y3QgX19DVExpbmUqIENUTGluZVJlZgogdHlwZWRlZiBVSW50MzIgRm91ckNoYXJD b2RlOwogdHlwZWRlZiBGb3VyQ2hhckNvZGUgQ1RGb250VGFibGVUYWc7CiAKLWV4dGVybiBjb25z dCBDRlN0cmluZ1JlZiBrQ1RGb250QXR0cmlidXRlTmFtZTsKLWV4dGVybiBjb25zdCBDRlN0cmlu Z1JlZiBrQ1RGb3JlZ3JvdW5kQ29sb3JGcm9tQ29udGV4dEF0dHJpYnV0ZU5hbWU7CitDVF9FWFBP UlQgY29uc3QgQ0ZTdHJpbmdSZWYga0NURm9udEF0dHJpYnV0ZU5hbWU7CitDVF9FWFBPUlQgY29u c3QgQ0ZTdHJpbmdSZWYga0NURm9yZWdyb3VuZENvbG9yRnJvbUNvbnRleHRBdHRyaWJ1dGVOYW1l OwogCiB0eXBlZGVmIENGX09QVElPTlModWludDMyX3QsIENURm9udFRhYmxlT3B0aW9ucykKIHsK 288567 2016-09-12 05:02:42 -0700 2016-09-12 23:54:38 -0700 Patch bug-161858-20160912050014.patch text/plain 3865 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTgwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTEyICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZp eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTg1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBl eHBvcnRlZCBjb25zdGFudHMgZnJvbSBDb3JlVGV4dC5kbGwsIGluc3RlYWQgb2YgY3JlYXRpbmcg Y29waWVzLgorCisgICAgICAgICogUGxhdGZvcm1BcHBsZVdpbi5jbWFrZToKKyAgICAgICAgKiBw bGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJV2luLmNwcDogUmVtb3ZlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJV2luLmg6CisKIDIwMTYtMDktMTIgIEphdmllciBG ZXJuYW5kZXogIDxqZmVybmFuZGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1hbGlnbl0g SW5pdGlhbCB2YWx1ZXMgYXJlIHBhcnNlZCBhcyBpbnZhbGlkIGZvciBzb21lIEFsaWdubWVudCBw cm9wZXJ0aWVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21ha2UJKHJldmlz aW9uIDIwNTgwNikKKysrIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21ha2UJKHdv cmtpbmcgY29weSkKQEAgLTEwNyw4ICsxMDcsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJD RVMKICAgICBwbGF0Zm9ybS9uZXR3b3JrL2NmL1N5bmNocm9ub3VzTG9hZGVyQ2xpZW50Q0ZOZXQu Y3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9jZi9TeW5jaHJvbm91c1Jlc291cmNlSGFuZGxlQ0ZV UkxDb25uZWN0aW9uRGVsZWdhdGUuY3BwCiAKLSAgICBwbGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0 U1BJV2luLmNwcAotCiAgICAgcGxhdGZvcm0vd2luL0RyYWdJbWFnZUNHV2luLmNwcAogKQogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJV2luLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvd2luL0NvcmVUZXh0U1BJ V2luLmNwcAkocmV2aXNpb24gMjA1ODA2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3Bp L3dpbi9Db3JlVGV4dFNQSVdpbi5jcHAJKG5vbmV4aXN0ZW50KQpAQCAtMSwzNSArMCwwIEBACi0v KgotICogQ29weXJpZ2h0IChDKSAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K LSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIuCi0gKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCBy ZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotICogICAgZG9j dW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3Ry aWJ1dGlvbi4KLSAqCi0gKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4g QU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnCi0gKiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1Q TElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSAqIFRIRSBJ TVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBB UlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQ UExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUwotICogQkUgTElBQkxFIEZPUiBBTlkgRElSRUNU LCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUgotICogQ09OU0VR VUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1F TlQgT0YKLSAqIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRB LCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUwotICogSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNF RCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4KLSAqIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhF UldJU0UpCi0gKiBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZU V0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCi0gKiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCi0gKi8KLQotI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIkNvcmVUZXh0U1BJV2lu LmgiCi0KLVdURl9FWFRFUk5fQ19CRUdJTgotCi1jb25zdCBDRlN0cmluZ1JlZiBrQ1RGb250QXR0 cmlidXRlTmFtZSA9IENGU1RSKCJOU0ZvbnQiKTsKLWNvbnN0IENGU3RyaW5nUmVmIGtDVEZvcmVn cm91bmRDb2xvckZyb21Db250ZXh0QXR0cmlidXRlTmFtZSA9IENGU1RSKCJDVEZvcmVncm91bmRD b2xvckZyb21Db250ZXh0Iik7Ci0KLVdURl9FWFRFUk5fQ19FTkQKLQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vc3BpL3dpbi9Db3JlVGV4dFNQSVdpbi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS93aW4vQ29yZVRleHRTUElXaW4uaAkocmV2aXNpb24g MjA1ODA2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL3dpbi9Db3JlVGV4dFNQSVdp bi5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw4ICszNiw4IEBAIHR5cGVkZWYgY29uc3Qgc3RydWN0 IF9fQ1RMaW5lKiBDVExpbmVSZWYKIHR5cGVkZWYgVUludDMyIEZvdXJDaGFyQ29kZTsKIHR5cGVk ZWYgRm91ckNoYXJDb2RlIENURm9udFRhYmxlVGFnOwogCi1leHRlcm4gY29uc3QgQ0ZTdHJpbmdS ZWYga0NURm9udEF0dHJpYnV0ZU5hbWU7Ci1leHRlcm4gY29uc3QgQ0ZTdHJpbmdSZWYga0NURm9y ZWdyb3VuZENvbG9yRnJvbUNvbnRleHRBdHRyaWJ1dGVOYW1lOworQ1RfRVhQT1JUIGNvbnN0IENG U3RyaW5nUmVmIGtDVEZvbnRBdHRyaWJ1dGVOYW1lOworQ1RfRVhQT1JUIGNvbnN0IENGU3RyaW5n UmVmIGtDVEZvcmVncm91bmRDb2xvckZyb21Db250ZXh0QXR0cmlidXRlTmFtZTsKIAogdHlwZWRl ZiBDRl9PUFRJT05TKHVpbnQzMl90LCBDVEZvbnRUYWJsZU9wdGlvbnMpCiB7Cg==