161852 2016-09-11 16:53:10 -0700 Web Inspector: Object.shallowEqual() should return false if object prototype chains differ 2016-09-12 11:37:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1228640 0 mattbaker 2016-09-11 16:53:10 -0700 A simple solution would be to just compare constructor names. This will at least catch cases like: Object.shallowEqual([], {}); class A {}; class B extends A {}; Object.shallowEqual(new A, new B); 1228798 1 288585 mattbaker 2016-09-12 10:58:14 -0700 Created attachment 288585 [Patch] Proposed Fix 1228799 2 webkit-bug-importer 2016-09-12 10:58:33 -0700 <rdar://problem/28262106> 1228810 3 288585 joepeck 2016-09-12 11:15:39 -0700 Comment on attachment 288585 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=288585&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Utilities.js:63 > + if (a.constructor !== b.constructor) > return false; We discussed an alternative checking (__proto__ / Object.getPrototypeOf). I'm fine with either because we shouldn't be modifying object instance __proto__ properties anywhere. 1228822 4 288585 commit-queue 2016-09-12 11:37:45 -0700 Comment on attachment 288585 [Patch] Proposed Fix Clearing flags on attachment: 288585 Committed r205815: <http://trac.webkit.org/changeset/205815> 1228823 5 commit-queue 2016-09-12 11:37:49 -0700 All reviewed patches have been landed. Closing bug. 288585 2016-09-12 10:58:14 -0700 2016-09-12 11:37:45 -0700 [Patch] Proposed Fix bug-161852-20160912105541.patch text/plain 7438 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1NzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz ODk3YWUyYzUwNDI3ZjYwYTM4ZDYzZDBjMmU0MzNkMDg3MDQ1NzZlLi5lN2UzMzhlMGNiNjYzODE0 ZGFiY2Y0MGI1MTY5NjQ3MGE5NGIyZDlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wOS0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT2JqZWN0LnNoYWxsb3dFcXVhbCgpIHNob3VsZCBy ZXR1cm4gZmFsc2UgaWYgb2JqZWN0IHByb3RvdHlwZSBjaGFpbnMgZGlmZmVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE4NTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXByb3ZlIE9iamVjdC5zaGFs bG93RXF1YWwgc28gaXQgd29uJ3QgcHJvZHVjZSBmYWxzZSBwb3NpdGl2ZXMuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzOgorICAgICAgICAodmFsdWUpOgorICAg ICAgICBPYmplY3Quc2hhbGxvd0VxdWFsIHNob3VsZCByZXR1cm4gZmFsc2UgZm9yIG5vbi1hcnJh eSBhcmd1bWVudHMuCisgICAgICAgIFNpbmNlIHR5cGVvZiBudWxsID09PSAib2JqZWN0IiwgdXNl IGBpbnN0YW5jZW9mYCBpbnN0ZWFkIHRvIGF2b2lkIHNlcGFyYXRlCisgICAgICAgIG51bGwgY2hl Y2tzLiBBbHNvIHVzZSBBcnJheS5zaGFsbG93RXF1YWwgZmFzdCBwYXRoIHdoZW4gYm90aCBhcmd1 bWVudHMgYXJlIGFycmF5cy4KKwogMjAxNi0wOS0xMSAgRGV2aW4gUm91c3NvICA8ZGNyb3Vzc28r d2Via2l0QGdtYWlsLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjA1NzU0KTogV2ViIElu c3BlY3RvcjogQ2Fubm90IGNsaWNrIG9uIGxpbmtzIHRvIHN0eWxlc2hlZXRzIGluIFJ1bGVzIHNp ZGViYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jh c2UvVXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9VdGlsaXRpZXMuanMKaW5kZXggMWQ4OWViZTY1YmRiZjNmMTA5MzFjZGFkMjdiYzQyMzMyYzQ2 Y2NmYS4uNmVkZmI1YzA4ZDJjN2JjNzNiY2JiMWUwYzBmNWUyM2MwZDBjMzZmMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMu anMKQEAgLTQ3LDEyICs0NywxOSBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoT2JqZWN0LCAic2hh bGxvd0VxdWFsIiwKICAgICB7CiAgICAgICAgIC8vIENoZWNrcyBpZiB0d28gb2JqZWN0cyBoYXZl IHRoZSBzYW1lIHRvcC1sZXZlbCBwcm9wZXJ0aWVzLgogCisgICAgICAgIC8vIE9ubHkgb2JqZWN0 cyBjYW4gcHJvY2VlZC4KKyAgICAgICAgaWYgKCEoYSBpbnN0YW5jZW9mIE9iamVjdCkgfHwgIShi IGluc3RhbmNlb2YgT2JqZWN0KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgICAg ICAvLyBDaGVjayBmb3Igc3RyaWN0IGVxdWFsaXR5IGluIGNhc2UgdGhleSBhcmUgdGhlIHNhbWUg b2JqZWN0LgogICAgICAgICBpZiAoYSA9PT0gYikKICAgICAgICAgICAgIHJldHVybiB0cnVlOwog Ci0gICAgICAgIC8vIE9ubHkgb2JqZWN0cyBjYW4gcHJvY2VlZC4gbnVsbCBpcyBhbiBvYmplY3Qs IGJ1dCBPYmplY3Qua2V5cyB0aHJvd3MgZm9yIG51bGwuCi0gICAgICAgIGlmICh0eXBlb2YgYSAh PT0gIm9iamVjdCIgfHwgdHlwZW9mIGIgIT09ICJvYmplY3QiIHx8IGEgPT09IG51bGwgfHwgYiA9 PT0gbnVsbCkKKyAgICAgICAgLy8gVXNlIGFuIG9wdGltaXplZCB2ZXJzaW9uIG9mIHNoYWxsb3dF cXVhbCBmb3IgYXJyYXlzLgorICAgICAgICBpZiAoKGEgaW5zdGFuY2VvZiBBcnJheSkgJiYgKGIg aW5zdGFuY2VvZiBBcnJheSkpCisgICAgICAgICAgICByZXR1cm4gQXJyYXkuc2hhbGxvd0VxdWFs KGEsIGIpOworCisgICAgICAgIGlmIChhLmNvbnN0cnVjdG9yICE9PSBiLmNvbnN0cnVjdG9yKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIHZhciBhS2V5cyA9IE9iamVjdC5r ZXlzKGEpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDg0ZWY3NTRlMWM3MjQxMDFhZTZmMjljYzg4NmQ3OWZmNDk1Yzg5NjMu LjUxNTI5MjgyMjIyMjFmYzVkYzk4YTJlZDYyMjRmYzViYzEwOWZlMWIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNi0wOS0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CisK KyAgICAgICAgV2ViIEluc3BlY3RvcjogT2JqZWN0LnNoYWxsb3dFcXVhbCgpIHNob3VsZCByZXR1 cm4gZmFsc2UgaWYgb2JqZWN0IHByb3RvdHlwZSBjaGFpbnMgZGlmZmVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE4NTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci91bml0LXRlc3Rz L29iamVjdC11dGlsaXRpZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0 b3IvdW5pdC10ZXN0cy9vYmplY3QtdXRpbGl0aWVzLmh0bWw6IEFkZGVkLgorICAgICAgICBBZGQg dGVzdCBjb3ZlcmFnZSBmb3IgT2JqZWN0LnNoYWxsb3dFcXVhbC4KKwogMjAxNi0wOS0xMSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEhUTUxUcmFja0VsZW1lbnQu a2luZCdzIGludmFsaWQgdmFsdWUgZGVmYXVsdCBzaG91bGQgYmUgdGhlIG1ldGFkYXRhIHN0YXRl CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9vYmplY3QtdXRp bGl0aWVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL29i amVjdC11dGlsaXRpZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ3YTFkMjRiYzY4ZTBjMjVj ODNhYjQ0NTlkYTIzOTM0YTA4ZmVmMGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvdW5pdC10ZXN0cy9vYmplY3QtdXRpbGl0aWVzLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDE5IEBACisKKz09IFJ1bm5pbmcgdGVzdCBzdWl0ZTogT2JqZWN0VXRpbGl0aWVzCistLSBS dW5uaW5nIHRlc3QgY2FzZTogT2JqZWN0LnNoYWxsb3dFcXVhbAorUEFTUzogc2hhbGxvd0VxdWFs IG9mIGVtcHR5IG9iamVjdCBsaXRlcmFscyBzaG91bGQgYmUgdHJ1ZS4KK1BBU1M6IHNoYWxsb3dF cXVhbCBvZiBlbXB0eSBhcnJheSBsaXRlcmFscyBzaG91bGQgYmUgdHJ1ZS4KK1BBU1M6IHNoYWxs b3dFcXVhbCBvZiBlbXB0eSBhcnJheSBhbmQgb2JqZWN0IGxpdGVyYWxzIHNob3VsZCBiZSBmYWxz ZS4KK1BBU1M6IHNoYWxsb3dFcXVhbCBvZiBhbiBvYmplY3Qgd2l0aCBpdHNlbGYgc2hvdWxkIGJl IHRydWUuCitQQVNTOiBzaGFsbG93RXF1YWwgb2YgZXF1YWwgb2JqZWN0cyBzaG91bGQgYmUgdHJ1 ZS4KK1BBU1M6IHNoYWxsb3dFcXVhbCBvZiBlcXVhbCBvYmplY3RzIHNob3VsZCBiZSB0cnVlLgor UEFTUzogc2hhbGxvd0VxdWFsIG9mIGluZXF1YWwgb2JqZWN0cyBzaG91bGQgYmUgZmFsc2UuCitQ QVNTOiBzaGFsbG93RXF1YWwgb2YgaW5lcXVhbCBvYmplY3RzIHNob3VsZCBiZSBmYWxzZS4KK1BB U1M6IHNoYWxsb3dFcXVhbCBvZiBhbiBvYmplY3QgYW5kIG51bGwgc2hvdWxkIGJlIGZhbHNlLgor UEFTUzogc2hhbGxvd0VxdWFsIG9mIGFuIG9iamVjdCBhbmQgbm9uLW9iamVjdCBzaG91bGQgYmUg ZmFsc2UuCitQQVNTOiBzaGFsbG93RXF1YWwgb2YgYSBub24tb2JqZWN0IHdpdGggaXRzZWxmIHNo b3VsZCBiZSBmYWxzZS4KK1BBU1M6IHNoYWxsb3dFcXVhbCBvZiBub24tb2JqZWN0cyBzaG91bGQg YmUgZmFsc2UuCitQQVNTOiBzaGFsbG93RXF1YWwgb2Ygb2JqZWN0cyB3aXRoIGVxdWFsIGNvbnN0 cnVjdG9ycyBzaG91bGQgYmUgdHJ1ZS4KK1BBU1M6IHNoYWxsb3dFcXVhbCBvZiBvYmplY3RzIHdp dGggZGlmZmVyZW50IGNvbnN0cnVjdG9ycyBzaG91bGQgYmUgZmFsc2UuCitQQVNTOiBzaGFsbG93 RXF1YWwgb2Ygb2JqZWN0cyB3aXRoIGRpZmZlcmVudCBjb25zdHJ1Y3RvcnMgc2hvdWxkIGJlIGZh bHNlLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9vYmpl Y3QtdXRpbGl0aWVzLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9vYmpl Y3QtdXRpbGl0aWVzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTQxMTIwM2U4NzFmYzk2YjEwM2VhYjViNDRl ODEzMmU5MWRhM2Y5ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91 bml0LXRlc3RzL29iamVjdC11dGlsaXRpZXMuaHRtbApAQCAtMCwwICsxLDU0IEBACis8IWRvY3R5 cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9p bnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIGxldCBzdWl0ZSA9IEluc3BlY3RvclRlc3QuY3Jl YXRlU3luY1N1aXRlKCJPYmplY3RVdGlsaXRpZXMiKTsKKworICAgIHN1aXRlLmFkZFRlc3RDYXNl KHsKKyAgICAgICAgbmFtZTogIk9iamVjdC5zaGFsbG93RXF1YWwiLAorICAgICAgICB0ZXN0OiAo KSA9PiB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoT2JqZWN0LnNoYWxs b3dFcXVhbCh7fSwge30pLCAic2hhbGxvd0VxdWFsIG9mIGVtcHR5IG9iamVjdCBsaXRlcmFscyBz aG91bGQgYmUgdHJ1ZS4iKTsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChP YmplY3Quc2hhbGxvd0VxdWFsKFtdLCBbXSksICJzaGFsbG93RXF1YWwgb2YgZW1wdHkgYXJyYXkg bGl0ZXJhbHMgc2hvdWxkIGJlIHRydWUuIik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4 cGVjdFRoYXQoIU9iamVjdC5zaGFsbG93RXF1YWwoW10sIHt9KSwgInNoYWxsb3dFcXVhbCBvZiBl bXB0eSBhcnJheSBhbmQgb2JqZWN0IGxpdGVyYWxzIHNob3VsZCBiZSBmYWxzZS4iKTsKKworICAg ICAgICAgICAgbGV0IG9iajEgPSB7YTogMSwgYjogMn07CisgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmV4cGVjdFRoYXQoT2JqZWN0LnNoYWxsb3dFcXVhbChvYmoxLCBvYmoxKSwgInNoYWxsb3dF cXVhbCBvZiBhbiBvYmplY3Qgd2l0aCBpdHNlbGYgc2hvdWxkIGJlIHRydWUuIik7CisKKyAgICAg ICAgICAgIGxldCBvYmoyID0ge2E6IDEsIGI6IDJ9OworICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5leHBlY3RUaGF0KE9iamVjdC5zaGFsbG93RXF1YWwob2JqMSwgb2JqMiksICJzaGFsbG93RXF1 YWwgb2YgZXF1YWwgb2JqZWN0cyBzaG91bGQgYmUgdHJ1ZS4iKTsKKyAgICAgICAgICAgIEluc3Bl Y3RvclRlc3QuZXhwZWN0VGhhdChPYmplY3Quc2hhbGxvd0VxdWFsKG9iajIsIG9iajEpLCAic2hh bGxvd0VxdWFsIG9mIGVxdWFsIG9iamVjdHMgc2hvdWxkIGJlIHRydWUuIik7CisKKyAgICAgICAg ICAgIGxldCBvYmozID0ge2E6IDEsIGI6IDIsIGM6IDN9OworICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5leHBlY3RUaGF0KCFPYmplY3Quc2hhbGxvd0VxdWFsKG9iajEsIG9iajMpLCAic2hhbGxv d0VxdWFsIG9mIGluZXF1YWwgb2JqZWN0cyBzaG91bGQgYmUgZmFsc2UuIik7CisgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoIU9iamVjdC5zaGFsbG93RXF1YWwob2JqMywgb2Jq MSksICJzaGFsbG93RXF1YWwgb2YgaW5lcXVhbCBvYmplY3RzIHNob3VsZCBiZSBmYWxzZS4iKTsK KworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RUaGF0KCFPYmplY3Quc2hhbGxvd0Vx dWFsKHt9LCBudWxsKSwgInNoYWxsb3dFcXVhbCBvZiBhbiBvYmplY3QgYW5kIG51bGwgc2hvdWxk IGJlIGZhbHNlLiIpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RUaGF0KCFPYmpl Y3Quc2hhbGxvd0VxdWFsKHt9LCAxLjIzKSwgInNoYWxsb3dFcXVhbCBvZiBhbiBvYmplY3QgYW5k IG5vbi1vYmplY3Qgc2hvdWxkIGJlIGZhbHNlLiIpOworCisgICAgICAgICAgICBsZXQgc3RyID0g ImFiYyI7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoIU9iamVjdC5zaGFs bG93RXF1YWwoc3RyLCBzdHIpLCAic2hhbGxvd0VxdWFsIG9mIGEgbm9uLW9iamVjdCB3aXRoIGl0 c2VsZiBzaG91bGQgYmUgZmFsc2UuIik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVj dFRoYXQoIU9iamVjdC5zaGFsbG93RXF1YWwoImFiYyIsICJhYmMiKSwgInNoYWxsb3dFcXVhbCBv ZiBub24tb2JqZWN0cyBzaG91bGQgYmUgZmFsc2UuIik7CisKKyAgICAgICAgICAgIGNsYXNzIEEg e307CisgICAgICAgICAgICBjbGFzcyBCIHt9OworICAgICAgICAgICAgY2xhc3MgQyBleHRlbmRz IEEge307CisKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChPYmplY3Quc2hh bGxvd0VxdWFsKG5ldyBBLCBuZXcgQSksICJzaGFsbG93RXF1YWwgb2Ygb2JqZWN0cyB3aXRoIGVx dWFsIGNvbnN0cnVjdG9ycyBzaG91bGQgYmUgdHJ1ZS4iKTsKKyAgICAgICAgICAgIEluc3BlY3Rv clRlc3QuZXhwZWN0VGhhdCghT2JqZWN0LnNoYWxsb3dFcXVhbChuZXcgQSwgbmV3IEIpLCAic2hh bGxvd0VxdWFsIG9mIG9iamVjdHMgd2l0aCBkaWZmZXJlbnQgY29uc3RydWN0b3JzIHNob3VsZCBi ZSBmYWxzZS4iKTsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdCghT2JqZWN0 LnNoYWxsb3dFcXVhbChuZXcgQSwgbmV3IEMpLCAic2hhbGxvd0VxdWFsIG9mIG9iamVjdHMgd2l0 aCBkaWZmZXJlbnQgY29uc3RydWN0b3JzIHNob3VsZCBiZSBmYWxzZS4iKTsKKworICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAgICB9KTsKKworICAgIHN1aXRlLnJ1blRlc3RD YXNlc0FuZEZpbmlzaCgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbkxvYWQ9InJ1 blRlc3QoKSI+Cis8L2JvZHk+Cis8L2h0bWw+Cg==