161849 2016-09-11 12:54:28 -0700 DFG::forAllKilledOperands() could use a faster bitvector scan in the same-inline-stack fast path 2016-09-12 09:11:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 161847 1 fpizlo fpizlo benjamin cdumez cmarcelo commit-queue dbates keith_miller mark.lam msaboff saam oldest_to_newest 1228621 0 fpizlo 2016-09-11 12:54:28 -0700 ... 1228683 1 288551 fpizlo 2016-09-11 22:59:33 -0700 Created attachment 288551 the patch 1228688 2 288551 saam 2016-09-11 23:18:03 -0700 Comment on attachment 288551 the patch r=me 1228757 3 fpizlo 2016-09-12 09:11:35 -0700 Landed in https://trac.webkit.org/changeset/205810 288551 2016-09-11 22:59:33 -0700 2016-09-11 23:18:03 -0700 the patch blah.patch text/plain 5937 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA1Nzk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTA5LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpmb3JBbGxLaWxsZWRPcGVyYW5kcygpIGNvdWxkIHVzZSBhIGZhc3RlciBiaXR2ZWN0b3Ig c2NhbiBpbiB0aGUgc2FtZS1pbmxpbmUtc3RhY2sgZmFzdCBwYXRoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE4NDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgaXMgYSBmYWlybHkg b2J2aW91cyBjaGFuZ2UuIFRoaXMgdHVybnMgYSBsb29wIHRoYXQgd291bGQgcXVlcnkgZWFjaCBi aXQgaW5kaXZpZHVhbGx5CisgICAgICAgIGludG8gYSBsb29wIHRoYXQgd2lsbCBwcm9jZXNzIGEg d29yZCBhdCBhIHRpbWUuIEkgd291bGQgZXhwZWN0IGEgdmVyeSB0aW55IHByb2dyZXNzaW9uIGlu CisgICAgICAgIERGRyBjb21waWxlIHRpbWVzLgorICAgICAgICAKKyAgICAgICAgVGhpcyBhbHNv IGdhdmUgbWUgYW4gb3Bwb3J0dW5pdHkgdG8gdGVzdCBhbmQgZml4IHRoZSBuZXcgRmFzdEJpdFZl Y3RvciBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogZGZnL0RGR0ZvckFsbEtpbGxzLmg6Cisg ICAgICAgIChKU0M6OkRGRzo6Zm9yQWxsS2lsbGVkT3BlcmFuZHMpOgorCiAyMDE2LTA5LTExICBG aWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRmFzdEJpdFZlY3RvciBz aG91bGQgaGF2ZSBlZmZpY2llbnQgYW5kIGVhc3ktdG8tdXNlIHZlY3Rvci12ZWN0b3Igb3BlcmF0 aW9ucwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGb3JBbGxLaWxscy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRm9yQWxsS2lsbHMuaAko cmV2aXNpb24gMjA1Nzk0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGb3JBbGxL aWxscy5oCSh3b3JraW5nIGNvcHkpCkBAIC03NiwxNCArNzYsMTAgQEAgdm9pZCBmb3JBbGxLaWxs ZWRPcGVyYW5kcyhHcmFwaCYgZ3JhcGgsIAogICAgICAgICBjb25zdCBGYXN0Qml0VmVjdG9yJiBs aXZlQmVmb3JlID0gZnVsbExpdmVuZXNzLmdldExpdmVuZXNzKGJlZm9yZS5ieXRlY29kZUluZGV4 KTsKICAgICAgICAgY29uc3QgRmFzdEJpdFZlY3RvciYgbGl2ZUFmdGVyID0gZnVsbExpdmVuZXNz LmdldExpdmVuZXNzKGFmdGVyLmJ5dGVjb2RlSW5kZXgpOwogICAgICAgICAKLSAgICAgICAgLy8g RklYTUU6IENvbnNpZGVyIGRvaW5nIHRoaXMgaW5zdGVhZDoKLSAgICAgICAgLy8gKGxpdmVCZWZv cmUgJiB+bGl2ZUFmdGVyKS5mb3JFYWNoU2V0Qml0KC4uLikKLSAgICAgICAgLy8gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTg0OQotICAgICAgICBmb3IgKHVuc2ln bmVkIHJlbGF0aXZlTG9jYWwgPSBjb2RlQmxvY2stPm1fbnVtQ2FsbGVlTG9jYWxzOyByZWxhdGl2 ZUxvY2FsLS07KSB7Ci0gICAgICAgICAgICBpZiAobGl2ZUJlZm9yZVtyZWxhdGl2ZUxvY2FsXSAm JiAhbGl2ZUFmdGVyW3JlbGF0aXZlTG9jYWxdKQorICAgICAgICAobGl2ZUJlZm9yZSAmIH5saXZl QWZ0ZXIpLmZvckVhY2hTZXRCaXQoCisgICAgICAgICAgICBbJl0gKHNpemVfdCByZWxhdGl2ZUxv Y2FsKSB7CiAgICAgICAgICAgICAgICAgZnVuY3Rvcih2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbChy ZWxhdGl2ZUxvY2FsKSArIHN0YWNrT2Zmc2V0KTsKLSAgICAgICAgfQotICAgICAgICAKKyAgICAg ICAgICAgIH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIApJbmRleDogU291cmNlL1dU Ri9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9u IDIwNTc5NCkKKysrIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjEgQEAKKzIwMTYtMDktMTEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKwor ICAgICAgICBERkc6OmZvckFsbEtpbGxlZE9wZXJhbmRzKCkgY291bGQgdXNlIGEgZmFzdGVyIGJp dHZlY3RvciBzY2FuIGluIHRoZSBzYW1lLWlubGluZS1zdGFjayBmYXN0IHBhdGgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTg0OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSXQgdHVybnMg b3V0IHRoYXQgdGVtcGxhdGVzIG1ha2UgcHJpdmF0ZSBmaWVsZHMgd2VpcmQuIEZhc3RCaXRWZWN0 b3JJbXBsIGNhbid0IG5lY2Vzc2FyaWx5CisgICAgICAgIHRvdWNoIHByaXZhdGVzIGluIGluc3Rh bmNlcyBvZiBkaWZmZXJlbnQgdGVtcGxhdGUgc3BlY2lhbGl6YXRpb25zIG9mIGl0c2VsZi4gU28s IEkgYWRkZWQgYQorICAgICAgICBwdWJsaWMgbWV0aG9kIGNhbGxlZCB3b3JkVmlldygpIHRoYXQg ZXhwb3NlcyB0aGUgbmVjZXNzYXJ5IHByaXZhdGUgZmllbGQuCisKKyAgICAgICAgKiB3dGYvRmFz dEJpdFZlY3Rvci5oOgorICAgICAgICAoV1RGOjpGYXN0Qml0VmVjdG9ySW1wbDo6b3BlcmF0b3Im KToKKyAgICAgICAgKFdURjo6RmFzdEJpdFZlY3RvckltcGw6Om9wZXJhdG9yfCk6CisgICAgICAg IChXVEY6OkZhc3RCaXRWZWN0b3JJbXBsOjpvcGVyYXRvcn4pOgorICAgICAgICAoV1RGOjpGYXN0 Qml0VmVjdG9ySW1wbDo6Zm9yRWFjaFNldEJpdCk6CisgICAgICAgIChXVEY6OkZhc3RCaXRWZWN0 b3JJbXBsOjp3b3JkVmlldyk6CisKIDIwMTYtMDktMTEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KIAogICAgICAgICBGYXN0Qml0VmVjdG9yIHNob3VsZCBoYXZlIGVmZmljaWVudCBh bmQgZWFzeS10by11c2UgdmVjdG9yLXZlY3RvciBvcGVyYXRpb25zCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9GYXN0Qml0VmVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRmFzdEJp dFZlY3Rvci5oCShyZXZpc2lvbiAyMDU3OTQpCisrKyBTb3VyY2UvV1RGL3d0Zi9GYXN0Qml0VmVj dG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1OCw3ICsyNTgsNyBAQCBwdWJsaWM6CiBwcml2YXRl OgogICAgIFZpZXcgbV92aWV3OwogfTsKLSAgICAKKwogY2xhc3MgRmFzdEJpdFZlY3RvcjsKIAog dGVtcGxhdGU8dHlwZW5hbWUgV29yZHM+CkBAIC0zMjMsMjQgKzMyMywyNCBAQCBwdWJsaWM6CiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgT3RoZXJXb3Jkcz4KICAgICBGYXN0Qml0VmVjdG9ySW1wbDxG YXN0Qml0VmVjdG9yQW5kV29yZHM8dHlwZW5hbWUgV29yZHM6OlZpZXdUeXBlLCB0eXBlbmFtZSBP dGhlcldvcmRzOjpWaWV3VHlwZT4+IG9wZXJhdG9yJihjb25zdCBGYXN0Qml0VmVjdG9ySW1wbDxP dGhlcldvcmRzPiYgb3RoZXIpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gRmFzdEJpdFZl Y3RvckltcGw8RmFzdEJpdFZlY3RvckFuZFdvcmRzPHR5cGVuYW1lIFdvcmRzOjpWaWV3VHlwZSwg dHlwZW5hbWUgT3RoZXJXb3Jkczo6Vmlld1R5cGU+PihGYXN0Qml0VmVjdG9yQW5kV29yZHM8dHlw ZW5hbWUgV29yZHM6OlZpZXdUeXBlLCB0eXBlbmFtZSBPdGhlcldvcmRzOjpWaWV3VHlwZT4obV93 b3Jkcy52aWV3KCksIG90aGVyLm1fd29yZHMudmlldygpKSk7CisgICAgICAgIHJldHVybiBGYXN0 Qml0VmVjdG9ySW1wbDxGYXN0Qml0VmVjdG9yQW5kV29yZHM8dHlwZW5hbWUgV29yZHM6OlZpZXdU eXBlLCB0eXBlbmFtZSBPdGhlcldvcmRzOjpWaWV3VHlwZT4+KEZhc3RCaXRWZWN0b3JBbmRXb3Jk czx0eXBlbmFtZSBXb3Jkczo6Vmlld1R5cGUsIHR5cGVuYW1lIE90aGVyV29yZHM6OlZpZXdUeXBl Pih3b3JkVmlldygpLCBvdGhlci53b3JkVmlldygpKSk7CiAgICAgfQogICAgIAogICAgIHRlbXBs YXRlPHR5cGVuYW1lIE90aGVyV29yZHM+CiAgICAgRmFzdEJpdFZlY3RvckltcGw8RmFzdEJpdFZl Y3Rvck9yV29yZHM8dHlwZW5hbWUgV29yZHM6OlZpZXdUeXBlLCB0eXBlbmFtZSBPdGhlcldvcmRz OjpWaWV3VHlwZT4+IG9wZXJhdG9yfChjb25zdCBGYXN0Qml0VmVjdG9ySW1wbDxPdGhlcldvcmRz PiYgb3RoZXIpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gRmFzdEJpdFZlY3RvckltcGw8 RmFzdEJpdFZlY3Rvck9yV29yZHM8dHlwZW5hbWUgV29yZHM6OlZpZXdUeXBlLCB0eXBlbmFtZSBP dGhlcldvcmRzOjpWaWV3VHlwZT4+KEZhc3RCaXRWZWN0b3JPcldvcmRzPHR5cGVuYW1lIFdvcmRz OjpWaWV3VHlwZSwgdHlwZW5hbWUgT3RoZXJXb3Jkczo6Vmlld1R5cGU+KG1fd29yZHMudmlldygp LCBvdGhlci5tX3dvcmRzLnZpZXcoKSkpOworICAgICAgICByZXR1cm4gRmFzdEJpdFZlY3Rvcklt cGw8RmFzdEJpdFZlY3Rvck9yV29yZHM8dHlwZW5hbWUgV29yZHM6OlZpZXdUeXBlLCB0eXBlbmFt ZSBPdGhlcldvcmRzOjpWaWV3VHlwZT4+KEZhc3RCaXRWZWN0b3JPcldvcmRzPHR5cGVuYW1lIFdv cmRzOjpWaWV3VHlwZSwgdHlwZW5hbWUgT3RoZXJXb3Jkczo6Vmlld1R5cGU+KHdvcmRWaWV3KCks IG90aGVyLndvcmRWaWV3KCkpKTsKICAgICB9CiAgICAgCiAgICAgRmFzdEJpdFZlY3RvckltcGw8 RmFzdEJpdFZlY3Rvck5vdFdvcmRzPHR5cGVuYW1lIFdvcmRzOjpWaWV3VHlwZT4+IG9wZXJhdG9y figpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gRmFzdEJpdFZlY3RvckltcGw8RmFzdEJp dFZlY3Rvck5vdFdvcmRzPHR5cGVuYW1lIFdvcmRzOjpWaWV3VHlwZT4+KEZhc3RCaXRWZWN0b3JO b3RXb3Jkczx0eXBlbmFtZSBXb3Jkczo6Vmlld1R5cGU+KG1fd29yZHMudmlldygpKSk7CisgICAg ICAgIHJldHVybiBGYXN0Qml0VmVjdG9ySW1wbDxGYXN0Qml0VmVjdG9yTm90V29yZHM8dHlwZW5h bWUgV29yZHM6OlZpZXdUeXBlPj4oRmFzdEJpdFZlY3Rvck5vdFdvcmRzPHR5cGVuYW1lIFdvcmRz OjpWaWV3VHlwZT4od29yZFZpZXcoKSkpOwogICAgIH0KICAgICAKICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBGdW5jPgogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBmb3JFYWNoU2V0Qml0KGNvbnN0IEZ1 bmMmIGZ1bmMpIGNvbnN0CiAgICAgewotICAgICAgICBzaXplX3QgbiA9IG1fd29yZHMuYXJyYXlM ZW5ndGgoKTsKKyAgICAgICAgc2l6ZV90IG4gPSBhcnJheUxlbmd0aCgpOwogICAgICAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IG47ICsraSkgewogICAgICAgICAgICAgdWludDMyX3Qgd29yZCA9 IG1fd29yZHMud29yZChpKTsKICAgICAgICAgICAgIHNpemVfdCBqID0gaSAqIDMyOwpAQCAtNDE2 LDYgKzQxNiw4IEBAIHB1YmxpYzoKICAgICAgICAgICAgIG91dC5wcmludCgoKnRoaXMpW2ldID8g IjEiIDogIi0iKTsKICAgICB9CiAgICAgCisgICAgdHlwZW5hbWUgV29yZHM6OlZpZXdUeXBlIHdv cmRWaWV3KCkgY29uc3QgeyByZXR1cm4gbV93b3Jkcy52aWV3KCk7IH0KKyAgICAKIHByaXZhdGU6 CiAgICAgLy8gWW91J2QgdGhpbmsgdGhhdCB3ZSBjb3VsZCByZW1vdmUgdGhpcyBmcmllbmQgaWYg d2UgdXNlZCBwcm90ZWN0ZWQsIGJ1dCB5b3UnZCBiZSB3cm9uZywKICAgICAvLyBiZWNhdXNlIHRl bXBsYXRlcy4K