161841 2016-09-10 09:19:13 -0700 URLParser: uidna_IDNToASCII_56 is deprecated 2016-09-20 13:27:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144194 P2 Minor --- 1 mcatanzaro mcatanzaro achristensen ap mcatanzaro oldest_to_newest 1228503 0 mcatanzaro 2016-09-10 09:19:13 -0700 Would be good to avoid this -Wdeprecated-declarations warning in URLParser.cpp: ../../Source/WebCore/platform/URLParser.cpp: In function ‘WTF::Optional<WTF::String> WebCore::domainToASCII(const WTF::String&)’: ../../Source/WebCore/platform/URLParser.cpp:1352:193: warning: ‘int32_t uidna_IDNToASCII_56(const UChar*, int32_t, UChar*, int32_t, int32_t, UParseError*, UErrorCode*)’ is deprecated [-Wdeprecated-declarations] int32_t numCharactersConverted = uidna_IDNToASCII(StringView(domain).upconvertedCharacters(), domain.length(), hostnameBuffer, hostnameBufferLength, UIDNA_ALLOW_UNASSIGNED, nullptr, &error); ^ In file included from /usr/include/unicode/platform.h:23:0, from /usr/include/unicode/ptypes.h:50, from /usr/include/unicode/umachine.h:44, from /usr/include/unicode/utypes.h:36, from ../../Source/WTF/wtf/text/ASCIIFastPath.h:26, from ../../Source/WTF/wtf/text/WTFString.h:28, from ../../Source/WebCore/platform/text/TextCodec.h:33, from ../../Source/WebCore/platform/text/TextEncoding.h:29, from ../../Source/WebCore/platform/URLParser.h:28, from ../../Source/WebCore/platform/URLParser.cpp:27: /usr/include/unicode/uidna.h:673:1: note: declared here uidna_IDNToASCII( const UChar* src, int32_t srcLength, ^ 1228505 1 mcatanzaro 2016-09-10 09:31:42 -0700 The header says: @deprecated ICU 55 Use UTS #46 instead via uidna_openUTS46() or class IDNA. 1229652 2 achristensen 2016-09-14 11:30:18 -0700 I wondered why we had those #pragma GCC diagnostic ignored "-Wdeprecated-declarations" in URL.cpp. The copy of the ICU headers we use on Cocoa platforms hasn't deprecated that yet. I think a better solution would be to just use uidna_openUTS46 / uidna_close instead. 1229684 3 ap 2016-09-14 13:09:34 -0700 Upgrading the version of standard that we use is definitely better. Bug 144194 has some open questions about that. 1229709 4 mcatanzaro 2016-09-14 13:47:38 -0700 I'd like a quick fix for the warning, and I doubt upgrading the standard is going to be it. So if switching to uidna_openUTS46/uidna_close is not easy (I have no idea) then I will just add pragmas there, OK? 1229722 5 ap 2016-09-14 14:01:52 -0700 Yes. 1230070 6 achristensen 2016-09-15 10:33:31 -0700 Adding pragmas with "// FIXME: This should use uidna_openUTS46 / uidna_close instead" would be fine for now. 1230748 7 289156 mcatanzaro 2016-09-16 20:16:22 -0700 Created attachment 289156 Patch 1231836 8 achristensen 2016-09-20 13:27:42 -0700 http://trac.webkit.org/changeset/206169 289156 2016-09-16 20:16:22 -0700 2016-09-20 13:27:29 -0700 Patch bug-161841-20160916221342.patch text/plain 1927 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY2MjJhNzJkNjBmODJl NjdjMzk0NmJmMjEwOWE4MjUzMjg3OTYzZC4uYTk4MmYxZWU3MTRkOGI1MmI0OGU0NGZkYzc4MTQw MzRlMGQwNDJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA5LTE2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBVUkxQYXJz ZXI6IHVpZG5hX0lETlRvQVNDSUlfNTYgaXMgZGVwcmVjYXRlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxODQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHByYWdtYXMgdG8gc2lsZW5jZSB0aGUg d2FybmluZywgcGx1cyBhIEZJWE1FLgorCisgICAgICAgICogcGxhdGZvcm0vVVJMUGFyc2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmRvbWFpblRvQVNDSUkpOgorCisyMDE2LTA5LTE2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBBU1NFUlRJ T04gRkFJTEVEOiBUaGUgc3RyaW5nIGJlaW5nIHJlbW92ZWQgaXMgYXRvbWljIGluIHRoZSBzdHJp bmcgdGFibGUgb2YgYW4gb3RoZXIgdGhyZWFkISBpdGVyYXRvciAhPSBhdG9taWNTdHJpbmdUYWJs ZS5lbmQoKSBhdCBTb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZ0ltcGwuY3BwKDQ1MykK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTgwMAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAppbmRleCAzZjk5ODhlMzU0OWUyY2Ni YTExMjE5MjcyNDM5YjI5YzhjYmMyZDVkLi40NGE5ODY3YjMxM2E3MTYzYmZjYWNiNzc2NzcwYjdk NWI4Mzg5ZTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAKQEAgLTE5MDQs OCArMTkwNCwxNiBAQCBzdGF0aWMgT3B0aW9uYWw8U3RyaW5nPiBkb21haW5Ub0FTQ0lJKGNvbnN0 IFN0cmluZyYgZG9tYWluKQogICAgIAogICAgIFVDaGFyIGhvc3RuYW1lQnVmZmVyW2hvc3RuYW1l QnVmZmVyTGVuZ3RoXTsKICAgICBVRXJyb3JDb2RlIGVycm9yID0gVV9aRVJPX0VSUk9SOwotICAg IAorCisjaWYgQ09NUElMRVIoR0NDKSB8fCBDT01QSUxFUihDTEFORykKKyNwcmFnbWEgR0NDIGRp YWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV2RlcHJlY2F0 ZWQtZGVjbGFyYXRpb25zIgorI2VuZGlmCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHVzZSB1 aWRuYV9vcGVuVVRTNDYgLyB1aWRuYV9jbG9zZSBpbnN0ZWFkCiAgICAgaW50MzJfdCBudW1DaGFy YWN0ZXJzQ29udmVydGVkID0gdWlkbmFfSUROVG9BU0NJSShTdHJpbmdWaWV3KGRvbWFpbikudXBj b252ZXJ0ZWRDaGFyYWN0ZXJzKCksIGRvbWFpbi5sZW5ndGgoKSwgaG9zdG5hbWVCdWZmZXIsIGhv c3RuYW1lQnVmZmVyTGVuZ3RoLCBVSUROQV9BTExPV19VTkFTU0lHTkVELCBudWxscHRyLCAmZXJy b3IpOworI2lmIENPTVBJTEVSKEdDQykgfHwgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIEdDQyBk aWFnbm9zdGljIHBvcAorI2VuZGlmCiAKICAgICBpZiAoZXJyb3IgPT0gVV9aRVJPX0VSUk9SKSB7 CiAgICAgICAgIExDaGFyIGJ1ZmZlcltob3N0bmFtZUJ1ZmZlckxlbmd0aF07Cg==