161784 2016-09-08 20:13:33 -0700 Web Inspector: Stack overflow when searching a timeline recording for JS function names 2016-11-03 14:23:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 saam nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1228018 0 saam 2016-09-08 20:13:33 -0700 Steps to repro: 1. Go to http://browserbench.org/Speedometer/InteractiveRunner.html 2. start a timeline recording for the sampling profiler 3. press "Run" on the page 4. Wait for it to finish 5. stop the recording 6. Go to call trees view 7. (I have Inverted and Top Functions selected, I'm not sure if this is necessary) 8. search for "updateDOM" 9. Boom, stack overflow I'm on r205494 See stack trace here: https://gist.github.com/anonymous/10426d2dad092ab21dfa0a8b054d33bf 1228019 1 webkit-bug-importer 2016-09-08 20:13:51 -0700 <rdar://problem/28219498> 1247474 2 nvasilyev 2016-11-02 14:15:23 -0700 *** Bug 163818 has been marked as a duplicate of this bug. *** 1247567 3 293716 nvasilyev 2016-11-02 16:45:36 -0700 Created attachment 293716 Patch 1247856 4 293716 commit-queue 2016-11-03 14:23:11 -0700 Comment on attachment 293716 Patch Clearing flags on attachment: 293716 Committed r208348: <http://trac.webkit.org/changeset/208348> 1247857 5 commit-queue 2016-11-03 14:23:14 -0700 All reviewed patches have been landed. Closing bug. 293716 2016-11-02 16:45:36 -0700 2016-11-03 14:23:11 -0700 Patch patch.txt text/plain 3195 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEyYzBhMmUuLjYwN2U0NTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTExLTAyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0YWNr IG92ZXJmbG93IHdoZW4gc2VhcmNoaW5nIGEgdGltZWxpbmUgcmVjb3JkaW5nIGZvciBKUyBmdW5j dGlvbiBuYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYxNzg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODIxOTQ5OD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBfcG9wdWxhdGUgbWV0aG9kIG9m IFByb2ZpbGVOb2RlRGF0YUdyaWROb2RlIGFuZCBQcm9maWxlRGF0YUdyaWROb2RlIHRyYXZlcnNl cworICAgICAgICBhbGwgY2hpbGRyZW4gb2YgYSBnaXZlbiBub2RlLiBtYWtlVmlzaWJsZSBmdW5j dGlvbiBvZiBEYXRhR3JpZCNfYXBwbHlGaWx0ZXJzVG9Ob2RlCisgICAgICAgIHRyYXZlcnNlcyBh bGwgaXRzIHBhcmVudHMgdG8gZXhwYW5kIHRoZW0uIFRoaXMgY3JlYXRlcyBhbiBpbmZpbml0ZSBy ZWN1cnNpb24uCisgICAgICAgIFJlbW92ZSAicG9wdWxhdGUiIGV2ZW50IGJlZm9yZSBhcHBlbmRp bmcgY2hpbGQgbm9kZXMgdG8gcHJldmVudCBpdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvUHJvZmlsZURhdGFHcmlkTm9kZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9m aWxlRGF0YUdyaWROb2RlLnByb3RvdHlwZS5fcG9wdWxhdGUpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlByb2ZpbGVEYXRhR3JpZE5vZGUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv UHJvZmlsZU5vZGVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmls ZU5vZGVEYXRhR3JpZE5vZGUucHJvdG90eXBlLl9wb3B1bGF0ZSk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuUHJvZmlsZU5vZGVEYXRhR3JpZE5vZGUpOgorCiAyMDE2LTExLTAxICBEZXZpbiBSb3Vz c28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IENyZWF0aW5nIGEgbmV3IHBzZXVkby1zZWxlY3RvciBpbiB0aGUgU3R5bGVzIHNpZGViYXIgZG9l c24ndCB3b3JrIG9uIGZpcnN0IGF0dGVtcHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Byb2ZpbGVEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxlRGF0YUdyaWROb2RlLmpz CmluZGV4IGY0ODA4NWYuLmUyYzU5MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Byb2ZpbGVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJvZmlsZURhdGFHcmlkTm9kZS5q cwpAQCAtMjU1LDYgKzI1NSw4IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWROb2RlID0g Y2xhc3MgUHJvZmlsZURhdGFHcmlkTm9kZSBleHRlbmRzIFdlYkluc3BlY3RvCiAgICAgICAgIGlm ICghdGhpcy5zaG91bGRSZWZyZXNoQ2hpbGRyZW4pCiAgICAgICAgICAgICByZXR1cm47CiAKKyAg ICAgICAgdGhpcy5yZW1vdmVFdmVudExpc3RlbmVyKCJwb3B1bGF0ZSIsIHRoaXMuX3BvcHVsYXRl LCB0aGlzKTsKKwogICAgICAgICB0aGlzLl9ub2RlLmZvckVhY2hDaGlsZCgoY2hpbGQpID0+IHsK ICAgICAgICAgICAgIGlmICghdGhpcy5fY2hpbGRyZW5Ub0NoYXJnZVRvU2VsZi5oYXMoY2hpbGQp KSB7CiAgICAgICAgICAgICAgICAgaWYgKGNoaWxkLmhhc1N0YWNrVHJhY2VJblRpbWVSYW5nZSh0 aGlzLl90cmVlLnN0YXJ0VGltZSwgdGhpcy5fdHJlZS5lbmRUaW1lKSkKQEAgLTI2Myw3ICsyNjUs NSBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZURhdGFHcmlkTm9kZSA9IGNsYXNzIFByb2ZpbGVEYXRh R3JpZE5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0bwogICAgICAgICB9KTsKIAogICAgICAgICB0aGlz LnNvcnQoKTsKLQotICAgICAgICB0aGlzLnJlbW92ZUV2ZW50TGlzdGVuZXIoInBvcHVsYXRlIiwg dGhpcy5fcG9wdWxhdGUsIHRoaXMpOwogICAgIH0KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9maWxlTm9kZURhdGFHcmlkTm9kZS5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Byb2ZpbGVOb2Rl RGF0YUdyaWROb2RlLmpzCmluZGV4IDE3ZjYwOWIuLmI2MjBhNGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Byb2ZpbGVOb2RlRGF0YUdyaWRO b2RlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1By b2ZpbGVOb2RlRGF0YUdyaWROb2RlLmpzCkBAIC0xODIsMTEgKzE4MiwxMCBAQCBXZWJJbnNwZWN0 b3IuUHJvZmlsZU5vZGVEYXRhR3JpZE5vZGUgPSBjbGFzcyBQcm9maWxlTm9kZURhdGFHcmlkTm9k ZSBleHRlbmRzIFdlYgogICAgICAgICBpZiAoIXRoaXMuc2hvdWxkUmVmcmVzaENoaWxkcmVuKQog ICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIHRoaXMucmVtb3ZlRXZlbnRMaXN0ZW5lcigi cG9wdWxhdGUiLCB0aGlzLl9wb3B1bGF0ZSwgdGhpcyk7CiAgICAgICAgIHRoaXMucmVtb3ZlQ2hp bGRyZW4oKTsKIAogICAgICAgICBmb3IgKGxldCBub2RlIG9mIHRoaXMuX3Byb2ZpbGVOb2RlLmNo aWxkTm9kZXMpCiAgICAgICAgICAgICB0aGlzLmFwcGVuZENoaWxkKG5ldyBXZWJJbnNwZWN0b3Iu UHJvZmlsZU5vZGVEYXRhR3JpZE5vZGUobm9kZSwgdGhpcy5iYXNlU3RhcnRUaW1lLCB0aGlzLnJh bmdlU3RhcnRUaW1lLCB0aGlzLnJhbmdlRW5kVGltZSkpOwotCi0gICAgICAgIHRoaXMucmVtb3Zl RXZlbnRMaXN0ZW5lcigicG9wdWxhdGUiLCB0aGlzLl9wb3B1bGF0ZSwgdGhpcyk7CiAgICAgfQog fTsK