161781 2016-09-08 18:29:38 -0700 URLParser: Handle \ in paths of special URLs according to spec 2016-09-08 18:34:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1227978 0 achristensen 2016-09-08 18:29:38 -0700 URLParser: Handle \ in paths of special URLs according to spec 1227979 1 288373 achristensen 2016-09-08 18:30:18 -0700 Created attachment 288373 Patch 1227981 2 commit-queue 2016-09-08 18:31:37 -0700 Attachment 288373 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:259: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:259: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:402: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:402: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:403: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:403: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 6 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1227983 3 achristensen 2016-09-08 18:34:30 -0700 http://trac.webkit.org/changeset/205684 288373 2016-09-08 18:30:18 -0700 2016-09-08 18:33:12 -0700 Patch bug-161781-20160908182751.patch text/plain 6880 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTY3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTA4ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy OiBIYW5kbGUgXCBpbiBwYXRocyBvZiBzcGVjaWFsIFVSTHMgYWNjb3JkaW5nIHRvIHNwZWMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTc4MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkg bmV3IEFQSSB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1VSTFBhcnNlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpidWZmZXJWaWV3KToKKyAgICAgICAgKFdlYkNvcmU6OlVSTFBhcnNlcjo6 Y29weVVSTFBhcnRzVW50aWwpOgorICAgICAgICAoV2ViQ29yZTo6VVJMUGFyc2VyOjpwYXJzZSk6 CisgICAgICAgICogcGxhdGZvcm0vVVJMUGFyc2VyLmg6CisKIDIwMTYtMDktMDggIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVUkxQYXJzZXI6 IFBhcnNpbmcgZW1wdHkgVVJMcyB3aXRoIGEgYmFzZSBVUkwgc2hvdWxkIHJldHVybiB0aGUgYmFz ZSBVUkwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkocmV2aXNpb24g MjA1Njc5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTUwLDExICsxNTAsMTIgQEAgc3RhdGljIGJvb2wgaXNTcGVjaWFsU2NoZW1l KFN0cmluZ1ZpZXcgcwogICAgICAgICB8fCBzY2hlbWUgPT0gIndzcyI7CiB9CiAKLXN0YXRpYyBT dHJpbmdWaWV3IGJ1ZmZlclZpZXcoY29uc3QgU3RyaW5nQnVpbGRlciYgYnVpbGRlcikKK3N0YXRp YyBTdHJpbmdWaWV3IGJ1ZmZlclZpZXcoY29uc3QgU3RyaW5nQnVpbGRlciYgYnVpbGRlciwgdW5z aWduZWQgbGVuZ3RoKQogeworICAgIEFTU0VSVChidWlsZGVyLmxlbmd0aCgpID49IGxlbmd0aCk7 CiAgICAgaWYgKGJ1aWxkZXIuaXM4Qml0KCkpCi0gICAgICAgIHJldHVybiBTdHJpbmdWaWV3KGJ1 aWxkZXIuY2hhcmFjdGVyczgoKSwgYnVpbGRlci5sZW5ndGgoKSk7Ci0gICAgcmV0dXJuIFN0cmlu Z1ZpZXcoYnVpbGRlci5jaGFyYWN0ZXJzMTYoKSwgYnVpbGRlci5sZW5ndGgoKSk7CisgICAgICAg IHJldHVybiBTdHJpbmdWaWV3KGJ1aWxkZXIuY2hhcmFjdGVyczgoKSwgbGVuZ3RoKTsKKyAgICBy ZXR1cm4gU3RyaW5nVmlldyhidWlsZGVyLmNoYXJhY3RlcnMxNigpLCBsZW5ndGgpOwogfQogCiBl bnVtIGNsYXNzIFVSTFBhcnNlcjo6VVJMUGFydCB7CkBAIC0yMzUsNiArMjM2LDcgQEAgdm9pZCBV UkxQYXJzZXI6OmNvcHlVUkxQYXJ0c1VudGlsKGNvbnN0IAogICAgICAgICBtX3VybC5tX3Byb3Rv Y29sSXNJbkhUVFBGYW1pbHkgPSBiYXNlLm1fcHJvdG9jb2xJc0luSFRUUEZhbWlseTsKICAgICAg ICAgbV91cmwubV9zY2hlbWVFbmQgPSBiYXNlLm1fc2NoZW1lRW5kOwogICAgIH0KKyAgICBtX3Vy bElzU3BlY2lhbCA9IGlzU3BlY2lhbFNjaGVtZShidWZmZXJWaWV3KG1fYnVmZmVyLCBtX3VybC5t X3NjaGVtZUVuZCkpOwogfQogCiBzdGF0aWMgY29uc3QgY2hhciogZG90QVNDSUlDb2RlID0gIjJl IjsKQEAgLTQyMCw3ICs0MjIsNiBAQCBVUkwgVVJMUGFyc2VyOjpwYXJzZShjb25zdCBTdHJpbmcm IGlucHV0CiAjZGVmaW5lIExPR19TVEFURSh4KSBMT0coVVJMUGFyc2VyLCAiU3RhdGUgJXMsIGNv ZGUgcG9pbnQgJWMsIGJ1ZmZlciBsZW5ndGggJWQiLCB4LCAqYywgbV9idWZmZXIubGVuZ3RoKCkp CiAjZGVmaW5lIExPR19GSU5BTF9TVEFURSh4KSBMT0coVVJMUGFyc2VyLCAiRmluYWwgU3RhdGU6 ICVzIiwgeCkKIAotICAgIGJvb2wgdXJsSXNTcGVjaWFsID0gZmFsc2U7CiAgICAgU3RhdGUgc3Rh dGUgPSBTdGF0ZTo6U2NoZW1lU3RhcnQ7CiAgICAgd2hpbGUgKGMgIT0gZW5kKSB7CiAgICAgICAg IGlmIChpc1RhYk9yTmV3bGluZSgqYykpIHsKQEAgLTQ0NCwxNyArNDQ1LDE3IEBAIFVSTCBVUkxQ YXJzZXI6OnBhcnNlKGNvbnN0IFN0cmluZyYgaW5wdXQKICAgICAgICAgICAgICAgICBtX2J1ZmZl ci5hcHBlbmQodG9BU0NJSUxvd2VyKCpjKSk7CiAgICAgICAgICAgICBlbHNlIGlmICgqYyA9PSAn OicpIHsKICAgICAgICAgICAgICAgICBtX3VybC5tX3NjaGVtZUVuZCA9IG1fYnVmZmVyLmxlbmd0 aCgpOwotICAgICAgICAgICAgICAgIFN0cmluZ1ZpZXcgdXJsU2NoZW1lID0gYnVmZmVyVmlldyht X2J1ZmZlcik7CisgICAgICAgICAgICAgICAgU3RyaW5nVmlldyB1cmxTY2hlbWUgPSBidWZmZXJW aWV3KG1fYnVmZmVyLCBtX3VybC5tX3NjaGVtZUVuZCk7CiAgICAgICAgICAgICAgICAgbV91cmwu bV9wcm90b2NvbElzSW5IVFRQRmFtaWx5ID0gdXJsU2NoZW1lID09ICJodHRwIiB8fCB1cmxTY2hl bWUgPT0gImh0dHBzIjsKICAgICAgICAgICAgICAgICBpZiAodXJsU2NoZW1lID09ICJmaWxlIikg ewotICAgICAgICAgICAgICAgICAgICB1cmxJc1NwZWNpYWwgPSB0cnVlOworICAgICAgICAgICAg ICAgICAgICBtX3VybElzU3BlY2lhbCA9IHRydWU7CiAgICAgICAgICAgICAgICAgICAgIHN0YXRl ID0gU3RhdGU6OkZpbGU7CiAgICAgICAgICAgICAgICAgICAgIG1fYnVmZmVyLmFwcGVuZCgnOicp OwogICAgICAgICAgICAgICAgICAgICArK2M7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBpZiAoaXNTcGVjaWFsU2NoZW1lKHVy bFNjaGVtZSkpIHsKLSAgICAgICAgICAgICAgICAgICAgdXJsSXNTcGVjaWFsID0gdHJ1ZTsKKyAg ICAgICAgICAgICAgICAgICAgbV91cmxJc1NwZWNpYWwgPSB0cnVlOwogICAgICAgICAgICAgICAg ICAgICBpZiAoYmFzZS5wcm90b2NvbCgpID09IHVybFNjaGVtZSkKICAgICAgICAgICAgICAgICAg ICAgICAgIHN0YXRlID0gU3RhdGU6OlNwZWNpYWxSZWxhdGl2ZU9yQXV0aG9yaXR5OwogICAgICAg ICAgICAgICAgICAgICBlbHNlCkBAIC03NzUsNyArNzc2LDcgQEAgVVJMIFVSTFBhcnNlcjo6cGFy c2UoY29uc3QgU3RyaW5nJiBpbnB1dAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug U3RhdGU6OlBhdGg6CiAgICAgICAgICAgICBMT0dfU1RBVEUoIlBhdGgiKTsKLSAgICAgICAgICAg IGlmICgqYyA9PSAnLycgfHwgKHVybElzU3BlY2lhbCAmJiAqYyA9PSAnXFwnKSkgeworICAgICAg ICAgICAgaWYgKCpjID09ICcvJyB8fCAobV91cmxJc1NwZWNpYWwgJiYgKmMgPT0gJ1xcJykpIHsK ICAgICAgICAgICAgICAgICBtX2J1ZmZlci5hcHBlbmQoJy8nKTsKICAgICAgICAgICAgICAgICBt X3VybC5tX3BhdGhBZnRlckxhc3RTbGFzaCA9IG1fYnVmZmVyLmxlbmd0aCgpOwogICAgICAgICAg ICAgICAgICsrYzsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5oCShyZXZpc2lv biAyMDU2NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFVSTCBtX3Vy bDsKICAgICBTdHJpbmdCdWlsZGVyIG1fYnVmZmVyOworICAgIGJvb2wgbV91cmxJc1NwZWNpYWwg eyBmYWxzZSB9OwogICAgIHZvaWQgcGFyc2VBdXRob3JpdHkoU3RyaW5nVmlldzo6Q29kZVBvaW50 czo6SXRlcmF0b3ImLCBjb25zdCBTdHJpbmdWaWV3OjpDb2RlUG9pbnRzOjpJdGVyYXRvciYgZW5k KTsKICAgICBib29sIHBhcnNlSG9zdChTdHJpbmdWaWV3OjpDb2RlUG9pbnRzOjpJdGVyYXRvciYs IGNvbnN0IFN0cmluZ1ZpZXc6OkNvZGVQb2ludHM6Okl0ZXJhdG9yJiBlbmQpOwogICAgIGJvb2wg cGFyc2VQb3J0KFN0cmluZ1ZpZXc6OkNvZGVQb2ludHM6Okl0ZXJhdG9yJiwgY29uc3QgU3RyaW5n Vmlldzo6Q29kZVBvaW50czo6SXRlcmF0b3ImIGVuZCk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDU2ODMpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0wOCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIFVS TFBhcnNlcjogSGFuZGxlIFwgaW4gcGF0aHMgb2Ygc3BlY2lhbCBVUkxzIGFjY29yZGluZyB0byBz cGVjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE3 ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6VEVTVF9GKToKKwogMjAxNi0wOS0wOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdGhlIGNvbnRlbnQtYW5pbWF0aW9uLnBs YW4gZmlsZSB0byBydW4gY3NzLWFjY2VsZXJhdGVkLWFuaW1hdGlvbi5odG1sCkluZGV4OiBUb29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAkocmV2aXNp b24gMjA1Njc5KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VSTFBhcnNl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1Niw2ICsyNTYsNyBAQCBURVNUX0YoVVJMUGFyc2Vy VGVzdCwgUGFyc2VSZWxhdGl2ZSkKICAgICBjaGVja1JlbGF0aXZlVVJMKCIvcGF0aDMiLCAiaHR0 cDovL3VzZXJAZXhhbXBsZS5vcmcvcGF0aDEvcGF0aDIiLCB7Imh0dHAiLCAidXNlciIsICIiLCAi ZXhhbXBsZS5vcmciLCAwLCAiL3BhdGgzIiwgIiIsICIiLCAiaHR0cDovL3VzZXJAZXhhbXBsZS5v cmcvcGF0aDMifSk7CiAgICAgY2hlY2tSZWxhdGl2ZVVSTCgiIiwgImh0dHA6Ly9leGFtcGxlLm9y Zy9mb28vYmFyIiwgeyJodHRwIiwgIiIsICIiLCAiZXhhbXBsZS5vcmciLCAwLCAiL2Zvby9iYXIi LCAiIiwgIiIsICJodHRwOi8vZXhhbXBsZS5vcmcvZm9vL2JhciJ9KTsKICAgICBjaGVja1JlbGF0 aXZlVVJMKCIgIFxhICBcdFxuIiwgImh0dHA6Ly9leGFtcGxlLm9yZy9mb28vYmFyIiwgeyJodHRw IiwgIiIsICIiLCAiZXhhbXBsZS5vcmciLCAwLCAiL2Zvby9iYXIiLCAiIiwgIiIsICJodHRwOi8v ZXhhbXBsZS5vcmcvZm9vL2JhciJ9KTsKKyAgICBjaGVja1JlbGF0aXZlVVJMKCI6Zm9vLmNvbVxc IiwgImh0dHA6Ly9leGFtcGxlLm9yZy9mb28vYmFyIiwgeyJodHRwIiwgIiIsICIiLCAiZXhhbXBs ZS5vcmciLCAwLCAiL2Zvby86Zm9vLmNvbS8iLCAiIiwgIiIsICJodHRwOi8vZXhhbXBsZS5vcmcv Zm9vLzpmb28uY29tLyJ9KTsKIH0KIAogc3RhdGljIHZvaWQgY2hlY2tVUkxEaWZmZXJlbmNlcyhj b25zdCBTdHJpbmcmIHVybFN0cmluZywgY29uc3QgRXhwZWN0ZWRQYXJ0cyYgcGFydHNOZXcsIGNv bnN0IEV4cGVjdGVkUGFydHMmIHBhcnRzT2xkKQpAQCAtMzk4LDYgKzM5OSw5IEBAIFRFU1RfRihV UkxQYXJzZXJUZXN0LCBQYXJzZXJEaWZmZXJlbmNlcykKICAgICBjaGVja1VSTERpZmZlcmVuY2Vz KCJodHRwOi8vWzA6Zjo6ZjpmOjA6MF06NjU1MzYiLAogICAgICAgICB7IiIsICIiLCAiIiwgIiIs IDAsICIiLCAiIiwgIiIsICJodHRwOi8vWzA6Zjo6ZjpmOjA6MF06NjU1MzYifSwKICAgICAgICAg eyJodHRwIiwgIiIsICIiLCAiWzA6Zjo6ZjpmOjA6MF0iLCA2NTUzNSwgIi8iLCAiIiwgIiIsICJo dHRwOi8vWzA6Zjo6ZjpmOjA6MF06NjU1MzYvIn0pOworICAgIGNoZWNrUmVsYXRpdmVVUkxEaWZm ZXJlbmNlcygiOmZvby5jb21cXCIsICJub3RzcGVjaWFsOi8vZXhhbXBsZS5vcmcvZm9vL2JhciIs CisgICAgICAgIHsibm90c3BlY2lhbCIsICIiLCAiIiwgImV4YW1wbGUub3JnIiwgMCwgIi9mb28v OmZvby5jb21cXCIsICIiLCAiIiwgIm5vdHNwZWNpYWw6Ly9leGFtcGxlLm9yZy9mb28vOmZvby5j b21cXCJ9LAorICAgICAgICB7Im5vdHNwZWNpYWwiLCAiIiwgIiIsICJleGFtcGxlLm9yZyIsIDAs ICIvZm9vLzpmb28uY29tLyIsICIiLCAiIiwgIm5vdHNwZWNpYWw6Ly9leGFtcGxlLm9yZy9mb28v OmZvby5jb20vIn0pOwogICAgIAogICAgIC8vIFRoaXMgYmVoYXZpb3IgbWF0Y2hlcyBDaHJvbWUg YW5kIEZpcmVmb3gsIGJ1dCBub3QgV2ViS2l0IHVzaW5nIFVSTDo6cGFyc2UuCiAgICAgLy8gVGhl IGJlaGF2aW9yIG9mIFVSTDo6cGFyc2UgaXMgY2xlYXJseSB3cm9uZyBiZWNhdXNlIHJlcGFyc2lu ZyBmaWxlOi8vcGF0aCB3b3VsZCBtYWtlIHBhdGggdGhlIGhvc3QuCg==