161774 2016-09-08 17:07:29 -0700 REGRESSION: [mac-wk2] LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure 2017-01-11 21:16:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad joepeck commit-queue inspector-bugzilla-changes joepeck mark.lam saam webkit-bug-importer oldest_to_newest 1227950 0 ryanhaddad 2016-09-08 17:07:29 -0700 LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/14880 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreakpoint-columns.html --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/debugger/breakpoint-columns-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/debugger/breakpoint-columns-actual.txt @@ -10,6 +10,7 @@ CONSOLE MESSAGE: line 12: column test 5 Testing that breakpoints can be set at various line / column combinations. +ERROR: Received a command response without a corresponding callback or promise. [object Object] Hit breakpoint at line: 0, column: 79 Hit breakpoint at line: 6, column: 21 Hit breakpoint at line: 15, column: 8 1227952 1 webkit-bug-importer 2016-09-08 17:08:09 -0700 <rdar://problem/28217256> 1227954 2 ryanhaddad 2016-09-08 17:10:18 -0700 First failure on the dashboard was ~r204952, but the test has been quite flaky since ~r204896 on 8/24/18 1228051 3 joepeck 2016-09-08 21:50:42 -0700 > +ERROR: Received a command response without a corresponding callback or promise. [object Object] Seems concerning. I don't think we've made any changes here (yet), so I wonder if this is actually a regression with `Map`? I know some changes just landed there (both GC storage, and the implementation). 1228164 4 ryanhaddad 2016-09-09 09:53:41 -0700 Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/205747 1265953 5 joepeck 2017-01-11 16:29:38 -0800 The Flakiness Dashboard shows this test as all green for an entire month: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fbreakpoint-columns.html I suggest unskipping this. Given the bizarness of the error message seen previously, one I've _never_ seen while running tests or the Inspector itself, I think this was a lower level issue that likely got resolved. 1265957 6 298628 joepeck 2017-01-11 16:35:24 -0800 Created attachment 298628 [PATCH] Proposed Fix 1265969 7 298628 mark.lam 2017-01-11 16:54:52 -0800 Comment on attachment 298628 [PATCH] Proposed Fix rs=me 1266065 8 298628 commit-queue 2017-01-11 21:16:52 -0800 Comment on attachment 298628 [PATCH] Proposed Fix Clearing flags on attachment: 298628 Committed r210620: <http://trac.webkit.org/changeset/210620> 1266066 9 commit-queue 2017-01-11 21:16:56 -0800 All reviewed patches have been landed. Closing bug. 298628 2017-01-11 16:35:24 -0800 2017-01-11 21:16:52 -0800 [PATCH] Proposed Fix unflake-1.patch text/plain 1619 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YWE3NWRmLi5mZWU1NTE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTctMDEt MTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdS RVNTSU9OOiBbbWFjLXdrMl0gTGF5b3V0VGVzdCBpbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2lu dC1jb2x1bW5zLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE3NzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzI4MjE3MjU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBSZW1vdmUg Zmxha3kgZXhwZWN0YXRpb25zIGZvciBhIHRlc3QgdGhhdCBoYXNuJ3QgZmFpbGVkIGluIGEgbW9u dGguCisKKzIwMTctMDEtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICBSRUdSRVNTSU9OKHIyMDYxMzMpOiBMYXlvdXRUZXN0IGluc3BlY3Rvci9jc3Mv bWFuYWdlci1wcmVmZXJyZWRJbnNwZWN0b3JTdHlsZVNoZWV0Rm9yRnJhbWUuaHRtbCBpcyBhIGZs YWt5IGZhaWx1cmUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MjMwNQogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjgzODkzNjQ+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYTBiYTk3OC4uNDY2 MTc1YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u cwpAQCAtNTQ0LDcgKzU0NCw2IEBAIHdlYmtpdC5vcmcvYi8xNjA0NDUgWyBTaWVycmErIF0gaHR0 cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvdXBncmFkCiB3ZWJraXQub3Jn L2IvMTYzOTMyIGluc3BlY3Rvci9jc3MvcHNldWRvLWVsZW1lbnQtbWF0Y2hlcy5odG1sIFsgUGFz cyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2MzYwNCBpbnNwZWN0b3IvZGVidWdnZXIvYnJl YWtwb2ludC1hY3Rpb24tZXZhbC5odG1sIFsgUGFzcyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8x NjE3NzQgaW5zcGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnQtY29sdW1ucy5odG1sIFsgUGFzcyBG YWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNTk0NDcgWyBEZWJ1ZyBdIGluc3BlY3Rvci9kZWJ1Z2dl ci90YWlsLWRlbGV0ZWQtZnJhbWVzLWZyb20tdm0tZW50cnkuaHRtbCBbIFBhc3MgRmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMTY1NTgyIGluc3BlY3Rvci93b3JrZXIvZGVidWdnZXItc2NyaXB0cy5o dG1sIFsgUGFzcyBGYWlsdXJlIF0KIAo=