161765 2016-09-08 15:38:32 -0700 Web Inspector: TimelineDataGridNode should refresh when graph column is resized 2016-09-08 16:23:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1227881 0 mattbaker 2016-09-08 15:38:32 -0700 Summary: TimelineDataGridNode should refresh when graph column is resized. Currently graphs only refresh when the entire view tree is being updated due to a window resize or sidebar expand/collapse. Now that OverviewTimelineView has two columns (the Name column was added when the navigation sidebar was removed), it's possible for the graph column to be resized without the nodes ever being refreshed. Steps to Reproduce: 1. Record a timeline 2. Show the overview 3. Change width of the graph column using the column resizer between the Name and Graph columns => Record bars aren't recombined as the column size changed 1227883 1 webkit-bug-importer 2016-09-08 15:38:52 -0700 <rdar://problem/28215674> 1227890 2 288344 mattbaker 2016-09-08 15:51:43 -0700 Created attachment 288344 [Patch] Proposed Fix 1227898 3 288344 bburg 2016-09-08 16:01:09 -0700 Comment on attachment 288344 [Patch] Proposed Fix r=me 1227910 4 288344 commit-queue 2016-09-08 16:23:27 -0700 Comment on attachment 288344 [Patch] Proposed Fix Clearing flags on attachment: 288344 Committed r205676: <http://trac.webkit.org/changeset/205676> 1227911 5 commit-queue 2016-09-08 16:23:31 -0700 All reviewed patches have been landed. Closing bug. 288344 2016-09-08 15:51:43 -0700 2016-09-08 16:23:27 -0700 [Patch] Proposed Fix bug-161765-20160908154916.patch text/plain 7125 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj YTQ5ODg2MTg2MjRjM2ZjZmY4MTAxMDgxODZmZDBhMDEzYzA3NWViLi4wYmE2YTdhNGIyZDFjMjU1 ZjExZjcyYzFhM2M5MWViYTAzY2RkNzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wOS0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVEYXRhR3JpZE5vZGUgc2hvdWxkIHJl ZnJlc2ggd2hlbiBncmFwaCBjb2x1bW4gaXMgcmVzaXplZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNzY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8yODIxNTY3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLnJlc2l6ZXJEcmFnZ2luZyk6CisgICAgICAgIENhbGwg YERhdGFHcmlkTm9kZS5kaWRSZXNpemVDb2x1bW5gIGZvciBhbGwgdmlzaWJsZSBub2RlcyBpbiB0 aGUgY29sdW1ucworICAgICAgICB0byB0aGUgbGVmdCBhbmQgcmlnaHQgb2YgdGhlIGNvbHVtbiBy ZXNpemVyLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZE5vZGUuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZS5kaWRSZXNpemVD b2x1bW4pOgorICAgICAgICBBZGQgcHJvdGVjdGVkIGJhc2UgY2xhc3MgbWV0aG9kIGZvciBzdWJj bGFzc2VzIHRvIG92ZXJyaWRlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZURhdGFHcmlkTm9kZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFH cmlkTm9kZS5wcm90b3R5cGUuZGlkUmVzaXplQ29sdW1uKToKKyAgICAgICAgUmVmcmVzaCB0aGUg bm9kZSdzIGdyYXBoIHdoZW4gdGhlICJncmFwaCIgY29sdW1uIGlzIHJlc2l6ZWQuCisgICAgICAg IFJlbmFtZWQgYGxlZnQvcmlnaHRDZWxsSW5kZXhgIC0+IGBsZWZ0L3JpZ2h0Q29sdW1uSW5kZXhg LgorCiAyMDE2LTA5LTA3ICBKb2hhbiBLLiBKZW5zZW4gIDxqb2hhbl9qZW5zZW5AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3cgcmVzb3VyY2UgdGltaW5nIGRldGFpbHMg aW4gTmV0d29yayB3YXRlcmZhbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKaW5kZXggMWIwMWFjMjRiZGJmNmY0ODY0MmZm YjMyZmEyMjhiY2IyODI2YjVkNC4uOTBmZDg2OTAzYzA4MDNlNmE3MWI0N2ZlNjRiYzM0ZDNhZDk0 N2MzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGF0YUdyaWQuanMKQEAgLTE3ODMsMjIgKzE3ODMsMjIgQEAgV2ViSW5zcGVjdG9yLkRh dGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAg ICB2YXIgZHJhZ1BvaW50ID0gKHJlc2l6ZXIuaW5pdGlhbFBvc2l0aW9uIC0gcG9zaXRpb25EZWx0 YSkgLSB0aGlzLmVsZW1lbnQudG90YWxPZmZzZXRMZWZ0OwogICAgICAgICAvLyBDb25zdHJhaW4g dGhlIGRyYWdwb2ludCB0byBiZSB3aXRoaW4gdGhlIHNwYWNlIG1hZGUgdXAgYnkgdGhlCiAgICAg ICAgIC8vIGNvbHVtbiBkaXJlY3RseSB0byB0aGUgbGVmdCBhbmQgdGhlIGNvbHVtbiBkaXJlY3Rs eSB0byB0aGUgcmlnaHQuCi0gICAgICAgIHZhciBsZWZ0Q2VsbEluZGV4ID0gcmVzaXplcltXZWJJ bnNwZWN0b3IuRGF0YUdyaWQuUHJldmlvdXNDb2x1bW5PcmRpbmFsU3ltYm9sXTsKLSAgICAgICAg dmFyIHJpZ2h0Q2VsbEluZGV4ID0gcmVzaXplcltXZWJJbnNwZWN0b3IuRGF0YUdyaWQuTmV4dENv bHVtbk9yZGluYWxTeW1ib2xdOworICAgICAgICB2YXIgbGVmdENvbHVtbkluZGV4ID0gcmVzaXpl cltXZWJJbnNwZWN0b3IuRGF0YUdyaWQuUHJldmlvdXNDb2x1bW5PcmRpbmFsU3ltYm9sXTsKKyAg ICAgICAgdmFyIHJpZ2h0Q29sdW1uSW5kZXggPSByZXNpemVyW1dlYkluc3BlY3Rvci5EYXRhR3Jp ZC5OZXh0Q29sdW1uT3JkaW5hbFN5bWJvbF07CiAgICAgICAgIHZhciBmaXJzdFJvd0NlbGxzID0g dGhpcy5faGVhZGVyVGFibGVCb2R5RWxlbWVudC5yb3dzWzBdLmNlbGxzOwogICAgICAgICB2YXIg bGVmdEVkZ2VPZlByZXZpb3VzQ29sdW1uID0gMDsKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBsZWZ0Q2VsbEluZGV4OyBpKyspCisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGVmdENv bHVtbkluZGV4OyBpKyspCiAgICAgICAgICAgICBsZWZ0RWRnZU9mUHJldmlvdXNDb2x1bW4gKz0g Zmlyc3RSb3dDZWxsc1tpXS5vZmZzZXRXaWR0aDsKIAogICAgICAgICAvLyBEaWZmZXJlbmNlcyBm b3Igb3RoZXIgcmVzaXplIG1ldGhvZHMKICAgICAgICAgaWYgKHRoaXMucmVzaXplTWV0aG9kID09 PSBXZWJJbnNwZWN0b3IuRGF0YUdyaWQuUmVzaXplTWV0aG9kLkxhc3QpIHsKLSAgICAgICAgICAg IHJpZ2h0Q2VsbEluZGV4ID0gdGhpcy5yZXNpemVycy5sZW5ndGg7CisgICAgICAgICAgICByaWdo dENvbHVtbkluZGV4ID0gdGhpcy5yZXNpemVycy5sZW5ndGg7CiAgICAgICAgIH0gZWxzZSBpZiAo dGhpcy5yZXNpemVNZXRob2QgPT09IFdlYkluc3BlY3Rvci5EYXRhR3JpZC5SZXNpemVNZXRob2Qu Rmlyc3QpIHsKLSAgICAgICAgICAgIGxlZnRFZGdlT2ZQcmV2aW91c0NvbHVtbiArPSBmaXJzdFJv d0NlbGxzW2xlZnRDZWxsSW5kZXhdLm9mZnNldFdpZHRoIC0gZmlyc3RSb3dDZWxsc1swXS5vZmZz ZXRXaWR0aDsKLSAgICAgICAgICAgIGxlZnRDZWxsSW5kZXggPSAwOworICAgICAgICAgICAgbGVm dEVkZ2VPZlByZXZpb3VzQ29sdW1uICs9IGZpcnN0Um93Q2VsbHNbbGVmdENvbHVtbkluZGV4XS5v ZmZzZXRXaWR0aCAtIGZpcnN0Um93Q2VsbHNbMF0ub2Zmc2V0V2lkdGg7CisgICAgICAgICAgICBs ZWZ0Q29sdW1uSW5kZXggPSAwOwogICAgICAgICB9CiAKLSAgICAgICAgdmFyIHJpZ2h0RWRnZU9m TmV4dENvbHVtbiA9IGxlZnRFZGdlT2ZQcmV2aW91c0NvbHVtbiArIGZpcnN0Um93Q2VsbHNbbGVm dENlbGxJbmRleF0ub2Zmc2V0V2lkdGggKyBmaXJzdFJvd0NlbGxzW3JpZ2h0Q2VsbEluZGV4XS5v ZmZzZXRXaWR0aDsKKyAgICAgICAgdmFyIHJpZ2h0RWRnZU9mTmV4dENvbHVtbiA9IGxlZnRFZGdl T2ZQcmV2aW91c0NvbHVtbiArIGZpcnN0Um93Q2VsbHNbbGVmdENvbHVtbkluZGV4XS5vZmZzZXRX aWR0aCArIGZpcnN0Um93Q2VsbHNbcmlnaHRDb2x1bW5JbmRleF0ub2Zmc2V0V2lkdGg7CiAKICAg ICAgICAgLy8gR2l2ZSBlYWNoIGNvbHVtbiBzb21lIHBhZGRpbmcgc28gdGhhdCB0aGV5IGRvbid0 IGRpc2FwcGVhci4KICAgICAgICAgdmFyIGxlZnRNaW5pbXVtID0gbGVmdEVkZ2VPZlByZXZpb3Vz Q29sdW1uICsgdGhpcy5Db2x1bW5SZXNpemVQYWRkaW5nOwpAQCAtMTgwOSwxNSArMTgwOSwyOSBA QCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdlYkluc3Bl Y3Rvci5WaWV3CiAgICAgICAgIHJlc2l6ZXIuZWxlbWVudC5zdHlsZS5sZWZ0ID0gKGRyYWdQb2lu dCAtIHRoaXMuQ2VudGVyUmVzaXplck92ZXJCb3JkZXJBZGp1c3RtZW50KSArICJweCI7CiAKICAg ICAgICAgdmFyIHBlcmNlbnRMZWZ0Q29sdW1uID0gKCgoZHJhZ1BvaW50IC0gbGVmdEVkZ2VPZlBy ZXZpb3VzQ29sdW1uKSAvIHRoaXMuX2RhdGFUYWJsZUVsZW1lbnQub2Zmc2V0V2lkdGgpICogMTAw KSArICIlIjsKLSAgICAgICAgdGhpcy5faGVhZGVyVGFibGVDb2x1bW5Hcm91cEVsZW1lbnQuY2hp bGRyZW5bbGVmdENlbGxJbmRleF0uc3R5bGUud2lkdGggPSBwZXJjZW50TGVmdENvbHVtbjsKLSAg ICAgICAgdGhpcy5fZGF0YVRhYmxlQ29sdW1uR3JvdXBFbGVtZW50LmNoaWxkcmVuW2xlZnRDZWxs SW5kZXhdLnN0eWxlLndpZHRoID0gcGVyY2VudExlZnRDb2x1bW47CisgICAgICAgIHRoaXMuX2hl YWRlclRhYmxlQ29sdW1uR3JvdXBFbGVtZW50LmNoaWxkcmVuW2xlZnRDb2x1bW5JbmRleF0uc3R5 bGUud2lkdGggPSBwZXJjZW50TGVmdENvbHVtbjsKKyAgICAgICAgdGhpcy5fZGF0YVRhYmxlQ29s dW1uR3JvdXBFbGVtZW50LmNoaWxkcmVuW2xlZnRDb2x1bW5JbmRleF0uc3R5bGUud2lkdGggPSBw ZXJjZW50TGVmdENvbHVtbjsKIAogICAgICAgICB2YXIgcGVyY2VudFJpZ2h0Q29sdW1uID0gKCgo cmlnaHRFZGdlT2ZOZXh0Q29sdW1uIC0gZHJhZ1BvaW50KSAvIHRoaXMuX2RhdGFUYWJsZUVsZW1l bnQub2Zmc2V0V2lkdGgpICogMTAwKSArICIlIjsKLSAgICAgICAgdGhpcy5faGVhZGVyVGFibGVD b2x1bW5Hcm91cEVsZW1lbnQuY2hpbGRyZW5bcmlnaHRDZWxsSW5kZXhdLnN0eWxlLndpZHRoID0g cGVyY2VudFJpZ2h0Q29sdW1uOwotICAgICAgICB0aGlzLl9kYXRhVGFibGVDb2x1bW5Hcm91cEVs ZW1lbnQuY2hpbGRyZW5bcmlnaHRDZWxsSW5kZXhdLnN0eWxlLndpZHRoID0gcGVyY2VudFJpZ2h0 Q29sdW1uOworICAgICAgICB0aGlzLl9oZWFkZXJUYWJsZUNvbHVtbkdyb3VwRWxlbWVudC5jaGls ZHJlbltyaWdodENvbHVtbkluZGV4XS5zdHlsZS53aWR0aCA9IHBlcmNlbnRSaWdodENvbHVtbjsK KyAgICAgICAgdGhpcy5fZGF0YVRhYmxlQ29sdW1uR3JvdXBFbGVtZW50LmNoaWxkcmVuW3JpZ2h0 Q29sdW1uSW5kZXhdLnN0eWxlLndpZHRoID0gcGVyY2VudFJpZ2h0Q29sdW1uOwogCiAgICAgICAg IHRoaXMuX3Bvc2l0aW9uUmVzaXplckVsZW1lbnRzKCk7CiAgICAgICAgIHRoaXMuX3Bvc2l0aW9u SGVhZGVyVmlld3MoKTsKKworICAgICAgICBjb25zdCBza2lwSGlkZGVuID0gdHJ1ZTsKKyAgICAg ICAgY29uc3QgZG9udFBvcHVsYXRlID0gdHJ1ZTsKKworICAgICAgICBsZXQgbGVmdENvbHVtbklk ZW50aWZpZXIgPSB0aGlzLm9yZGVyZWRDb2x1bW5zW2xlZnRDb2x1bW5JbmRleF07CisgICAgICAg IGxldCByaWdodENvbHVtbklkZW50aWZpZXIgPSB0aGlzLm9yZGVyZWRDb2x1bW5zW3JpZ2h0Q29s dW1uSW5kZXhdOworICAgICAgICBsZXQgY2hpbGQgPSB0aGlzLmNoaWxkcmVuWzBdOworCisgICAg ICAgIHdoaWxlIChjaGlsZCkgeworICAgICAgICAgICAgY2hpbGQuZGlkUmVzaXplQ29sdW1uKGxl ZnRDb2x1bW5JZGVudGlmaWVyKTsKKyAgICAgICAgICAgIGNoaWxkLmRpZFJlc2l6ZUNvbHVtbihy aWdodENvbHVtbklkZW50aWZpZXIpOworICAgICAgICAgICAgY2hpbGQgPSBjaGlsZC50cmF2ZXJz ZU5leHROb2RlKHNraXBIaWRkZW4sIHRoaXMsIGRvbnRQb3B1bGF0ZSk7CisgICAgICAgIH0KKwog ICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWROb2RlLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWROb2RlLmpz CmluZGV4IDVmZDA3YzU4NGQxYTYyODZlMWM1NmEyZGQ2OTdmY2NhM2I5M2Y0MzkuLjI3MTMwODA2 Y2FiZTU1OTU2NTcyNWUzM2NjYzY4NGU5NzllNzgwYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkTm9kZS5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZE5vZGUuanMKQEAg LTczMiw2ICs3MzIsMTEgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkTm9kZSA9IGNsYXNzIERhdGFH cmlkTm9kZSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgbGV0IHZhbHVlID0g dGhpcy5kYXRhW2NvbHVtbklkZW50aWZpZXJdOwogICAgICAgICByZXR1cm4gdHlwZW9mIHZhbHVl ID09PSAic3RyaW5nIiA/IHZhbHVlIDogbnVsbDsKICAgICB9CisKKyAgICBkaWRSZXNpemVDb2x1 bW4oY29sdW1uSWRlbnRpZmllcikKKyAgICB7CisgICAgICAgIC8vIE92ZXJyaWRlIGJ5IHN1YmNs YXNzZXMuCisgICAgfQogfTsKIAogLy8gVXNlZCB0byBjcmVhdGUgYSBuZXcgdGFibGUgcm93IHdo ZW4gZW50ZXJpbmcgbmV3IGRhdGEgYnkgZWRpdGluZyBjZWxscy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWROb2Rl LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVE YXRhR3JpZE5vZGUuanMKaW5kZXggZmJlZDA5ZjIzMTUzODVhNGQ1ZTQyMTQ2NDhiNWQ2MDU1NDI0 MTBkNC4uMDljNzczOTE2ZjBkMWZiZmU0YzhkOTAxZWYxZThmOWUzMjhjOGRlZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRh R3JpZE5vZGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKQEAgLTM4OSw0ICszODksMTIgQEAgV2ViSW5zcGVj dG9yLlRpbWVsaW5lRGF0YUdyaWROb2RlID0gY2xhc3MgVGltZWxpbmVEYXRhR3JpZE5vZGUgZXh0 ZW5kcyBXZWJJbnNwZWMKICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1YmNsYXNz ZXMuCiAgICAgfQorCisgICAgZGlkUmVzaXplQ29sdW1uKGNvbHVtbklkZW50aWZpZXIpCisgICAg eworICAgICAgICBpZiAoY29sdW1uSWRlbnRpZmllciAhPT0gImdyYXBoIikKKyAgICAgICAgICAg IHJldHVybjsKKworICAgICAgICB0aGlzLm5lZWRzR3JhcGhSZWZyZXNoKCk7CisgICAgfQogfTsK