161761 2016-09-08 14:08:49 -0700 Long tap menu on an image link no longer includes "Save Image" button 2016-10-12 04:45:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner webkit-unassigned achristensen bdakin commit-queue jesscraunfield simon.fraser thorton oldest_to_newest 1227797 0 megan_gardner 2016-09-08 14:08:49 -0700 Long tap menu on an image link no longer includes "Save Image" button 1227809 1 288320 megan_gardner 2016-09-08 14:21:15 -0700 Created attachment 288320 Patch 1228297 2 288320 thorton 2016-09-09 12:36:34 -0700 Comment on attachment 288320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288320&action=review > Source/WebKit2/ChangeLog:3 > + Long tap menu on an image link no longer includes "Save Image" button Is it possible to write a test for this? > Source/WebKit2/ChangeLog:14 > + Gather information for images as well as links, and they can be both "and they can be both"? 1228304 3 288320 simon.fraser 2016-09-09 13:04:07 -0700 Comment on attachment 288320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288320&action=review >> Source/WebKit2/ChangeLog:3 >> + Long tap menu on an image link no longer includes "Save Image" button > > Is it possible to write a test for this? Probably not but we should make a way to do so. 1229623 4 288320 bdakin 2016-09-14 10:27:11 -0700 Comment on attachment 288320 Patch Megan is working on a follow-up patch to add test infrastructure and tests. 1229630 5 288320 commit-queue 2016-09-14 10:46:38 -0700 Comment on attachment 288320 Patch Clearing flags on attachment: 288320 Committed r205915: <http://trac.webkit.org/changeset/205915> 1229631 6 commit-queue 2016-09-14 10:46:42 -0700 All reviewed patches have been landed. Closing bug. 1239236 7 jesscraunfield 2016-10-12 04:45:23 -0700 Megan did awesome job here with the patch. As a follow-up at http://pimion.com I've saved a backup copy. 288320 2016-09-08 14:21:15 -0700 2016-09-14 10:46:38 -0700 Patch bug-161761-20160908141849.patch text/plain 2720 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTY2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTA4ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgTG9uZyB0YXAgbWVu dSBvbiBhbiBpbWFnZSBsaW5rIG5vIGxvbmdlciBpbmNsdWRlcyAiU2F2ZSBJbWFnZSIgYnV0dG9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE3NjEK KyAgICAgICAgPHJkYXI6Ly8yNzIwMjcxNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFu dC5tbToKKyAgICAgICAgKC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBkZWZhdWx0QWN0aW9uc0Zv ckltYWdlU2hlZXQ6XSk6CisgICAgICAgIEFkZGVkIHNoYXJlIHRvIGltYWdlIHNoZWV0IGFzIHRv IG5vdCByZWdyZXNzIGN1cnJlbnQgZnVuY3Rpb25hbGl0eQorICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0 UG9zaXRpb25JbmZvcm1hdGlvbik6CisgICAgICAgIEdhdGhlciBpbmZvcm1hdGlvbiBmb3IgaW1h Z2VzIGFzIHdlbGwgYXMgbGlua3MsIGFuZCB0aGV5IGNhbiBiZSBib3RoCisKIDIwMTYtMDktMDgg IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIE1vdmUgd2Vi a2l0Mmd0ay5wYy5pbiwgd2Via2l0Mmd0ay13ZWItZXh0ZW5zaW9uLnBjLmluIGZpbGVzIHVuZGVy IFNvdXJjZS9XZWJLaXQyL2d0ay8KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHJldmlzaW9uIDIwNTI2MCkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5t bQkod29ya2luZyBjb3B5KQpAQCAtMzY3LDggKzM2NywxMCBAQCAtIChSZXRhaW5QdHI8TlNBcnJh eT4pZGVmYXVsdEFjdGlvbnNGb3JJCiAgICAgTlNVUkwgKnRhcmdldFVSTCA9IFtOU1VSTCBfd2Vi X1VSTFdpdGhXVEZTdHJpbmc6cG9zaXRpb25JbmZvcm1hdGlvbi51cmxdOwogCiAgICAgYXV0byBk ZWZhdWx0QWN0aW9ucyA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF0pOwot ICAgIGlmICghcG9zaXRpb25JbmZvcm1hdGlvbi51cmwuaXNFbXB0eSgpKQorICAgIGlmICghcG9z aXRpb25JbmZvcm1hdGlvbi51cmwuaXNFbXB0eSgpKSB7CiAgICAgICAgIFtzZWxmIF9hcHBlbmRP cGVuQWN0aW9uc0ZvclVSTDp0YXJnZXRVUkwgYWN0aW9uczpkZWZhdWx0QWN0aW9ucy5nZXQoKSBl bGVtZW50SW5mbzplbGVtZW50SW5mb107CisgICAgICAgIFtkZWZhdWx0QWN0aW9ucyBhZGRPYmpl Y3Q6W19XS0VsZW1lbnRBY3Rpb24gX2VsZW1lbnRBY3Rpb25XaXRoVHlwZTpfV0tFbGVtZW50QWN0 aW9uVHlwZVNoYXJlIGFzc2lzdGFudDpzZWxmXV07CisgICAgfQogCiAjaWYgSEFWRShTQUZBUklf U0VSVklDRVNfRlJBTUVXT1JLKQogICAgIGlmIChbZ2V0U1NSZWFkaW5nTGlzdENsYXNzKCkgc3Vw cG9ydHNVUkw6dGFyZ2V0VVJMXSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDIwNTI2MCkKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMjM0Myw3ICsyMzQzLDggQEAgdm9pZCBXZWJQYWdlOjpnZXRQb3NpdGlvbklu Zm9ybWF0aW9uKGNvbgogICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg ICAgICB9CiAjZW5kaWYKLSAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGVsZW1lbnQtPnJlbmRl cmVyKCkgJiYgZWxlbWVudC0+cmVuZGVyZXIoKS0+aXNSZW5kZXJJbWFnZSgpKSB7CisgICAgICAg ICAgICAgICAgfQorICAgICAgICAgICAgICAgIGlmIChlbGVtZW50LT5yZW5kZXJlcigpICYmIGVs ZW1lbnQtPnJlbmRlcmVyKCktPmlzUmVuZGVySW1hZ2UoKSkgewogICAgICAgICAgICAgICAgICAg ICBpbmZvLmlzSW1hZ2UgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgICBhdXRvJiByZW5kZXJJ bWFnZSA9IGRvd25jYXN0PFJlbmRlckltYWdlPigqKGVsZW1lbnQtPnJlbmRlcmVyKCkpKTsKICAg ICAgICAgICAgICAgICAgICAgaWYgKHJlbmRlckltYWdlLmNhY2hlZEltYWdlKCkgJiYgIXJlbmRl ckltYWdlLmNhY2hlZEltYWdlKCktPmVycm9yT2NjdXJyZWQoKSkgewo=