161719 2016-09-07 16:47:04 -0700 bitwise_cast: allow const destination type 2016-09-07 17:42:21 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien benjamin cdumez cmarcelo commit-queue dbates oldest_to_newest 1227410 0 jfbastien 2016-09-07 16:47:04 -0700 I was playing around with a bitwise_cast that could be added to the C++ standard (separate implementation and tests from WTF's), and this should be made to work: const To to = bitwise_cast<const To>(from); It's not super useful, but can happen when template-galore hits. 1227411 1 288205 jfbastien 2016-09-07 16:49:15 -0700 Created attachment 288205 patch 1227412 2 commit-queue 2016-09-07 16:50:40 -0700 Attachment 288205 did not pass style-queue: ERROR: Source/WTF/wtf/StdLibExtras.h:154: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1227421 3 288208 jfbastien 2016-09-07 17:03:18 -0700 Created attachment 288208 patch Fix style. 1227437 4 288208 commit-queue 2016-09-07 17:42:17 -0700 Comment on attachment 288208 patch Clearing flags on attachment: 288208 Committed r205577: <http://trac.webkit.org/changeset/205577> 1227438 5 commit-queue 2016-09-07 17:42:21 -0700 All reviewed patches have been landed. Closing bug. 288205 2016-09-07 16:49:15 -0700 2016-09-07 17:03:18 -0700 patch 0001-const-to-bitwise-cast.patch text/plain 1531 jfbastien RnJvbSAxOGU0YTQ3YmU1YTE1OWZlN2M5OGRlM2U4YTBiOTM3YzdiNDQ4NTY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDcgU2VwIDIwMTYgMTY6NDY6MDYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBjb25zdC10 by1iaXR3aXNlLWNhc3QKCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICAgICAgfCAxMCAr KysrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaCB8ICAyICstCiAyIGZpbGVz IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI1OGFkNDYu Ljg1MTY0ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X VEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDktMDcgIEpGIEJhc3RpZW4gIDxq ZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIGJpdHdpc2VfY2FzdDogYWxsb3cgY29uc3Qg ZGVzdGluYXRpb24gdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYxNzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvU3RkTGliRXh0cmFzLmg6CisgICAgICAgIChXVEY6OmJpdHdpc2VfY2Fz dCk6IGFsbG93IGBjb25zdCBUbyB0byA9IGJpdHdpc2VfY2FzdDxjb25zdCBUbz4oZnJvbSk7YAor CiAyMDE2LTA5LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgQ2F0Y2hTY29wZSBhbmQgZm9yY2UgYWxsIGV4Y2VwdGlvbiBjaGVja3MgdG8gYmUgdmlhIFRo cm93U2NvcGUgb3IgQ2F0Y2hTY29wZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0ZExp YkV4dHJhcy5oIGIvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKaW5kZXggMTRhYjM4MS4u NzE1ODJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKKysrIGIv U291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKQEAgLTE1MSw3ICsxNTEsNyBAQCBpbmxpbmUg VG9UeXBlIGJpdHdpc2VfY2FzdChGcm9tVHlwZSBmcm9tKQogICAgIHN0YXRpY19hc3NlcnQoX19p c190cml2aWFsbHlfY29weWFibGUoVG9UeXBlKSwgImJpdHdpc2VfY2FzdCBvZiBub24tdHJpdmlh bGx5LWNvcHlhYmxlIHR5cGUhIik7CiAgICAgc3RhdGljX2Fzc2VydChfX2lzX3RyaXZpYWxseV9j b3B5YWJsZShGcm9tVHlwZSksICJiaXR3aXNlX2Nhc3Qgb2Ygbm9uLXRyaXZpYWxseS1jb3B5YWJs ZSB0eXBlISIpOwogI2VuZGlmCi0gICAgVG9UeXBlIHRveyB9OworICAgIHR5cGVuYW1lIHN0ZDo6 cmVtb3ZlX2NvbnN0PFRvVHlwZT46OnR5cGUgdG97IH07CiAgICAgc3RkOjptZW1jcHkoJnRvLCAm ZnJvbSwgc2l6ZW9mKHRvKSk7CiAgICAgcmV0dXJuIHRvOwogfQotLSAKMi45LjMKCg== 288208 2016-09-07 17:03:18 -0700 2016-09-07 17:42:17 -0700 patch 0001-const-to-bitwise-cast.patch text/plain 1532 jfbastien RnJvbSA1ZmFjNTU5MTcyMjA1ZTYzYTU2MGU0MzYyYTNlZTViMzQ4OTkyZWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDcgU2VwIDIwMTYgMTY6NDY6MDYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBjb25zdC10 by1iaXR3aXNlLWNhc3QKCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICAgICAgfCAxMCAr KysrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaCB8ICAyICstCiAyIGZpbGVz IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI1OGFkNDYu Ljg1MTY0ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X VEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDktMDcgIEpGIEJhc3RpZW4gIDxq ZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIGJpdHdpc2VfY2FzdDogYWxsb3cgY29uc3Qg ZGVzdGluYXRpb24gdHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYxNzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvU3RkTGliRXh0cmFzLmg6CisgICAgICAgIChXVEY6OmJpdHdpc2VfY2Fz dCk6IGFsbG93IGBjb25zdCBUbyB0byA9IGJpdHdpc2VfY2FzdDxjb25zdCBUbz4oZnJvbSk7YAor CiAyMDE2LTA5LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgQ2F0Y2hTY29wZSBhbmQgZm9yY2UgYWxsIGV4Y2VwdGlvbiBjaGVja3MgdG8gYmUgdmlhIFRo cm93U2NvcGUgb3IgQ2F0Y2hTY29wZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0ZExp YkV4dHJhcy5oIGIvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKaW5kZXggMTRhYjM4MS4u NTQ4MTkzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKKysrIGIv U291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKQEAgLTE1MSw3ICsxNTEsNyBAQCBpbmxpbmUg VG9UeXBlIGJpdHdpc2VfY2FzdChGcm9tVHlwZSBmcm9tKQogICAgIHN0YXRpY19hc3NlcnQoX19p c190cml2aWFsbHlfY29weWFibGUoVG9UeXBlKSwgImJpdHdpc2VfY2FzdCBvZiBub24tdHJpdmlh bGx5LWNvcHlhYmxlIHR5cGUhIik7CiAgICAgc3RhdGljX2Fzc2VydChfX2lzX3RyaXZpYWxseV9j b3B5YWJsZShGcm9tVHlwZSksICJiaXR3aXNlX2Nhc3Qgb2Ygbm9uLXRyaXZpYWxseS1jb3B5YWJs ZSB0eXBlISIpOwogI2VuZGlmCi0gICAgVG9UeXBlIHRveyB9OworICAgIHR5cGVuYW1lIHN0ZDo6 cmVtb3ZlX2NvbnN0PFRvVHlwZT46OnR5cGUgdG8geyB9OwogICAgIHN0ZDo6bWVtY3B5KCZ0bywg JmZyb20sIHNpemVvZih0bykpOwogICAgIHJldHVybiB0bzsKIH0KLS0gCjIuOS4zCgo=