161718 2016-09-07 16:40:34 -0700 Modernize Debugger to use nullptr 2016-09-07 17:18:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1227405 0 joepeck 2016-09-07 16:40:34 -0700 Modernize Debugger to use nullptr instead of 0 all over the place. 1227406 1 288204 joepeck 2016-09-07 16:41:19 -0700 Created attachment 288204 [PATCH] Proposed Fix 1227416 2 288204 mark.lam 2016-09-07 16:56:23 -0700 Comment on attachment 288204 [PATCH] Proposed Fix r=me 1227427 3 288204 commit-queue 2016-09-07 17:18:38 -0700 Comment on attachment 288204 [PATCH] Proposed Fix Clearing flags on attachment: 288204 Committed r205575: <http://trac.webkit.org/changeset/205575> 1227428 4 commit-queue 2016-09-07 17:18:42 -0700 All reviewed patches have been landed. Closing bug. 288204 2016-09-07 16:41:19 -0700 2016-09-07 17:18:38 -0700 [PATCH] Proposed Fix debugger-2.patch text/plain 3891 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE2MWJiYzIuLjA2MjA3NzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA5LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgTW9kZXJuaXplIERlYnVnZ2VyIHRv IHVzZSBudWxscHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjE3MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAgKEpTQzo6RGVidWdnZXI6OkRl YnVnZ2VyKToKKyAgICAgICAgKEpTQzo6RGVidWdnZXI6On5EZWJ1Z2dlcik6CisgICAgICAgIChK U0M6OkRlYnVnZ2VyOjpkZXRhY2gpOgorICAgICAgICAoSlNDOjpEZWJ1Z2dlcjo6c3RlcE91dE9m RnVuY3Rpb24pOgorICAgICAgICAoSlNDOjpEZWJ1Z2dlcjo6dXBkYXRlQ2FsbEZyYW1lQW5kUGF1 c2VJZk5lZWRlZCk6CisgICAgICAgICogZGVidWdnZXIvRGVidWdnZXIuaDoKKworMjAxNi0wOS0w NyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFJlbW92ZSBhbHdheXMgZmFsc2UgY2FzZSBpbiBEZWJ1Z2dlcgogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNzE3CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCmluZGV4IDg2MzZhNzEuLmY1Zjhm MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcApAQCAt MTI4LDggKzEyOCw2IEBAIERlYnVnZ2VyOjpEZWJ1Z2dlcihWTSYgdm0pCiAgICAgLCBtX3N1cHBy ZXNzQWxsUGF1c2VzKGZhbHNlKQogICAgICwgbV9zdGVwcGluZ01vZGUoU3RlcHBpbmdNb2RlRGlz YWJsZWQpCiAgICAgLCBtX3JlYXNvbkZvclBhdXNlKE5vdFBhdXNlZCkKLSAgICAsIG1fcGF1c2VP bkNhbGxGcmFtZSgwKQotICAgICwgbV9jdXJyZW50Q2FsbEZyYW1lKDApCiAgICAgLCBtX2xhc3RF eGVjdXRlZExpbmUoVUlOVF9NQVgpCiAgICAgLCBtX2xhc3RFeGVjdXRlZFNvdXJjZUlEKG5vU291 cmNlSUQpCiAgICAgLCBtX3RvcEJyZWFrcG9pbnRJRChub0JyZWFrcG9pbnRJRCkKQEAgLTE0MSw3 ICsxMzksNyBAQCBEZWJ1Z2dlcjo6fkRlYnVnZ2VyKCkKIHsKICAgICBIYXNoU2V0PEpTR2xvYmFs T2JqZWN0Kj46Oml0ZXJhdG9yIGVuZCA9IG1fZ2xvYmFsT2JqZWN0cy5lbmQoKTsKICAgICBmb3Ig KEhhc2hTZXQ8SlNHbG9iYWxPYmplY3QqPjo6aXRlcmF0b3IgaXQgPSBtX2dsb2JhbE9iamVjdHMu YmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQotICAgICAgICAoKml0KS0+c2V0RGVidWdnZXIoMCk7 CisgICAgICAgICgqaXQpLT5zZXREZWJ1Z2dlcihudWxscHRyKTsKIH0KIAogdm9pZCBEZWJ1Z2dl cjo6YXR0YWNoKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCkBAIC0xNjgsOCArMTY2LDgg QEAgdm9pZCBEZWJ1Z2dlcjo6ZGV0YWNoKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIFJl YXNvbkZvckRldGFjaCByZWFzb24pCiAgICAgLy8gc3RhY2ssIHNpbmNlIHdlIHdvbid0IGdldCBm dXJ0aGVyIGRlYnVnZ2VyIGNhbGxiYWNrcyB0byBkbyBzby4gQWxzbywgcmVzdW1lIGV4ZWN1dGlv biwKICAgICAvLyBzaW5jZSB0aGVyZSdzIG5vIHBvaW50IGluIHN0YXlpbmcgcGF1c2VkIG9uY2Ug YSB3aW5kb3cgY2xvc2VzLgogICAgIGlmIChtX2lzUGF1c2VkICYmIG1fY3VycmVudENhbGxGcmFt ZSAmJiBtX2N1cnJlbnRDYWxsRnJhbWUtPnZtRW50cnlHbG9iYWxPYmplY3QoKSA9PSBnbG9iYWxP YmplY3QpIHsKLSAgICAgICAgbV9jdXJyZW50Q2FsbEZyYW1lID0gMDsKLSAgICAgICAgbV9wYXVz ZU9uQ2FsbEZyYW1lID0gMDsKKyAgICAgICAgbV9jdXJyZW50Q2FsbEZyYW1lID0gbnVsbHB0cjsK KyAgICAgICAgbV9wYXVzZU9uQ2FsbEZyYW1lID0gbnVsbHB0cjsKICAgICAgICAgY29udGludWVQ cm9ncmFtKCk7CiAgICAgfQogCkBAIC0xODIsNyArMTgwLDcgQEAgdm9pZCBEZWJ1Z2dlcjo6ZGV0 YWNoKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIFJlYXNvbkZvckRldGFjaCByZWFzb24p CiAgICAgaWYgKHJlYXNvbiAhPSBHbG9iYWxPYmplY3RJc0Rlc3RydWN0aW5nKQogICAgICAgICBj bGVhckRlYnVnZ2VyUmVxdWVzdHMoZ2xvYmFsT2JqZWN0KTsKIAotICAgIGdsb2JhbE9iamVjdC0+ c2V0RGVidWdnZXIoMCk7CisgICAgZ2xvYmFsT2JqZWN0LT5zZXREZWJ1Z2dlcihudWxscHRyKTsK IH0KIAogYm9vbCBEZWJ1Z2dlcjo6aXNBdHRhY2hlZChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2Jq ZWN0KQpAQCAtNTk5LDcgKzU5Nyw3IEBAIHZvaWQgRGVidWdnZXI6OnN0ZXBPdXRPZkZ1bmN0aW9u KCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgVk1FbnRyeUZyYW1lKiB0b3BWTUVudHJ5RnJhbWUg PSBtX3ZtLnRvcFZNRW50cnlGcmFtZTsKLSAgICBtX3BhdXNlT25DYWxsRnJhbWUgPSBtX2N1cnJl bnRDYWxsRnJhbWUgPyBtX2N1cnJlbnRDYWxsRnJhbWUtPmNhbGxlckZyYW1lKHRvcFZNRW50cnlG cmFtZSkgOiAwOworICAgIG1fcGF1c2VPbkNhbGxGcmFtZSA9IG1fY3VycmVudENhbGxGcmFtZSA/ IG1fY3VycmVudENhbGxGcmFtZS0+Y2FsbGVyRnJhbWUodG9wVk1FbnRyeUZyYW1lKSA6IG51bGxw dHI7CiAgICAgbm90aWZ5RG9uZVByb2Nlc3NpbmdEZWJ1Z2dlckV2ZW50cygpOwogfQogCkBAIC02 MTgsNyArNjE2LDcgQEAgdm9pZCBEZWJ1Z2dlcjo6dXBkYXRlQ2FsbEZyYW1lQW5kUGF1c2VJZk5l ZWRlZChDYWxsRnJhbWUqIGNhbGxGcmFtZSkKICAgICB1cGRhdGVDYWxsRnJhbWUoY2FsbEZyYW1l KTsKICAgICBwYXVzZUlmTmVlZGVkKGNhbGxGcmFtZSk7CiAgICAgaWYgKCFpc1N0ZXBwaW5nKCkp Ci0gICAgICAgIG1fY3VycmVudENhbGxGcmFtZSA9IDA7CisgICAgICAgIG1fY3VycmVudENhbGxG cmFtZSA9IG51bGxwdHI7CiB9CiAKIHZvaWQgRGVidWdnZXI6OnBhdXNlSWZOZWVkZWQoQ2FsbEZy YW1lKiBjYWxsRnJhbWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5o CmluZGV4IGIxOWNmYWEuLmJlNTk1ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZWJ1Z2dlci9EZWJ1Z2dlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dl ci9EZWJ1Z2dlci5oCkBAIC0yMTksOCArMjE5LDggQEAgcHJpdmF0ZToKIAogICAgIFJlYXNvbkZv clBhdXNlIG1fcmVhc29uRm9yUGF1c2U7CiAgICAgSlNWYWx1ZSBtX2N1cnJlbnRFeGNlcHRpb247 Ci0gICAgQ2FsbEZyYW1lKiBtX3BhdXNlT25DYWxsRnJhbWU7Ci0gICAgQ2FsbEZyYW1lKiBtX2N1 cnJlbnRDYWxsRnJhbWU7CisgICAgQ2FsbEZyYW1lKiBtX3BhdXNlT25DYWxsRnJhbWUgeyBudWxs cHRyIH07CisgICAgQ2FsbEZyYW1lKiBtX2N1cnJlbnRDYWxsRnJhbWUgeyBudWxscHRyIH07CiAg ICAgdW5zaWduZWQgbV9sYXN0RXhlY3V0ZWRMaW5lOwogICAgIFNvdXJjZUlEIG1fbGFzdEV4ZWN1 dGVkU291cmNlSUQ7CiAK