<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>161716</bug_id>
          
          <creation_ts>2016-09-07 15:52:16 -0700</creation_ts>
          <short_desc>Web Inspector: Stepping into a function / program should not require stepping to the first statement</short_desc>
          <delta_ts>2016-09-30 12:36:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>155325</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>bburg</cc>
    
    <cc>joepeck</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mattbaker</cc>
    
    <cc>nvasilyev</cc>
    
    <cc>saam</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1227383</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-07 15:52:16 -0700</bug_when>
    <thetext>Summary:
Stepping into a function should not require stepping to the first statement

Test:
1. &lt;script&gt;
2. function foo() {
3.     console.log(&quot;foo&quot;);
4. }
5. foo();
6. &lt;/script&gt;

Steps to Reproduce:
1. Inspect test page
2. Set a breakpoint on line 5
3. Reload
  =&gt; Hits breakpoint, pauses on line 5
4. Step-in
  =&gt; Pauses on line 2 for the function definition, you have to step to get to line 3
  =&gt; Expected to pause on line 3 which is the first statement in foo

Notes:
- lldb pause on line 3 before the first statement in foo
- Chrome pauses on line 3 before the first statement in foo
- Firefox pauses on line 3 before the first statement in foo
- I think this is us pausing at Debugger::callEvent. Seems we can just not pause there. I&apos;m not sure if there is any reason to pause there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227384</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-09-07 15:52:33 -0700</bug_when>
    <thetext>&lt;rdar://problem/28196590&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227480</commentid>
    <comment_count>2</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-07 19:09:53 -0700</bug_when>
    <thetext>This is the same for stepping into a program.

Test:
1. &lt;script&gt;
2. var before = 1;
3. eval(&quot;1 + 1&quot;);
4. var after = 1;
5. &lt;/script&gt;

There are 3 pauses on line 3 because when we step-into we pause at 3 locations:

    PausedAtStartOfProgram
    PausedAtEndOfProgram
    PausedAtStatement</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227510</commentid>
    <comment_count>3</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-07 20:57:47 -0700</bug_when>
    <thetext>After a long discussion with coworkers I think we all agree that there is very little value in pausing at the start of a program. Since there is nothing you can do that is different from pausing at the first statement within it. However there is value in pausing at the end of a program / end of a function. Since that is the last opportunity  to view the state of things within the function (the value of the last statement for instance).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227515</commentid>
    <comment_count>4</comment_count>
      <attachid>288240</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-07 21:14:58 -0700</bug_when>
    <thetext>Created attachment 288240
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227516</commentid>
    <comment_count>5</comment_count>
      <attachid>288240</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-07 21:15:16 -0700</bug_when>
    <thetext>Comment on attachment 288240
[PATCH] Proposed Fix

cq- this depends on an earlier patch so it won&apos;t apply yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227692</commentid>
    <comment_count>6</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2016-09-08 12:12:27 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; This is the same for stepping into a program.
&gt; 
&gt; Test:
&gt; 1. &lt;script&gt;
&gt; 2. var before = 1;
&gt; 3. eval(&quot;1 + 1&quot;);
&gt; 4. var after = 1;
&gt; 5. &lt;/script&gt;
&gt; 
&gt; There are 3 pauses on line 3 because when we step-into we pause at 3
&gt; locations:
&gt; 
&gt;     PausedAtStartOfProgram
&gt;     PausedAtEndOfProgram
&gt;     PausedAtStatement

&gt;:(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227695</commentid>
    <comment_count>7</comment_count>
      <attachid>288240</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2016-09-08 12:16:19 -0700</bug_when>
    <thetext>Comment on attachment 288240
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288240&amp;action=review

&gt; LayoutTests/inspector/debugger/stepInto-expected.txt:-19
&gt; -PAUSE AT testAlert:6:19

Nice nice.

&gt; Source/JavaScriptCore/debugger/Debugger.h:-95
&gt; -        PausedAfterCall,

Is this completely redundant with PauseBeforeReturn? It doesn&apos;t seem like its removal caused any fewer pauses to happen in the test expectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227704</commentid>
    <comment_count>8</comment_count>
      <attachid>288240</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2016-09-08 12:21:33 -0700</bug_when>
    <thetext>Comment on attachment 288240
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288240&amp;action=review

r=me

&gt;&gt; Source/JavaScriptCore/debugger/Debugger.h:-95
&gt;&gt; -        PausedAfterCall,
&gt; 
&gt; Is this completely redundant with PauseBeforeReturn? It doesn&apos;t seem like its removal caused any fewer pauses to happen in the test expectations.

EDIT: this is for pausing when calling a function but before running the first statement. It&apos;s redundant with PausedAtStatement for the first statement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1228838</commentid>
    <comment_count>9</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-12 12:07:04 -0700</bug_when>
    <thetext>I rewrote everything here in an effort to fix other debugger stepping issues. I&apos;m going to obsolete this patch. And likely duplicate this bug to a more general bug that addresses the larger stepping issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1235346</commentid>
    <comment_count>10</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-09-30 12:36:57 -0700</bug_when>
    <thetext>Fixed as part of bug 155325:
https://trac.webkit.org/changeset/206652

*** This bug has been marked as a duplicate of bug 155325 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>288240</attachid>
            <date>2016-09-07 21:14:58 -0700</date>
            <delta_ts>2016-09-12 12:07:14 -0700</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>stepping-3.patch</filename>
            <type>text/plain</type>
            <size>6807</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAwYWIyNTYwLi43ZmMxOTA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTYtMDkt
MDcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIg
SW5zcGVjdG9yOiBTdGVwcGluZyBpbnRvIGEgZnVuY3Rpb24gLyBwcm9ncmFtIHNob3VsZCBub3Qg
cmVxdWlyZSBzdGVwcGluZyB0byB0aGUgZmlyc3Qgc3RhdGVtZW50CisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE3MTYKKyAgICAgICAgPHJkYXI6Ly9w
cm9ibGVtLzI4MTk2NTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL3N0ZXBJbnRvLWV4cGVjdGVkLnR4dDoKKyAg
ICAgICAgTm8gbG9uZ2VyIHBhdXNlIHdoZW4gZW50ZXJpbmcgYSBmdW5jdGlvbiAvIHByb2dyYW0u
IFdlIGN1cnJlbnRseQorICAgICAgICBndWFyZW50ZWUgYSBwYXVzZSBhdCB0aGUgZmlyc3Qgc3Rh
dGVtZW50IG9yIHdoZW4gZXhpdGluZyB0aGUKKyAgICAgICAgZnVuY3Rpb24gLyBwcm9ncmFtICh3
aGljaCBoYW5kbGVzIGFuIGVtcHR5IGZ1bmN0aW9uIC8gcHJvZ3JhbSkuCisKKzIwMTYtMDktMDcg
IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5z
cGVjdG9yOiBTdGVwcGluZyBhbGwgdGhlIHdheSB0aHJvdWdoIHByb2dyYW0gc2hvdWxkIG5vdCBj
YXVzZSBhIHBhdXNlIG9uIHRoZSBuZXh0IHByb2dyYW0gdGhhdCBleGVjdXRlcwogICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNzIxCiAgICAgICAgIDxy
ZGFyOi8vcHJvYmxlbS8yODE5ODU0Nz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rv
ci9kZWJ1Z2dlci9zdGVwSW50by1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv
ZGVidWdnZXIvc3RlcEludG8tZXhwZWN0ZWQudHh0CmluZGV4IDk3YmFjM2EuLmIxNmQ1NmYgMTAw
NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zdGVwSW50by1leHBlY3Rl
ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3N0ZXBJbnRvLWV4cGVj
dGVkLnR4dApAQCAtMTYsNyArMTYsNiBAQCBQQVVTRUQgKGRlYnVnZ2VyLXN0YXRlbWVudCkKIFBB
VVNFIEFUIGVudHJ5MjoxNzo1CiBQQVVTRSBBVCBlbnRyeTI6MTg6NQogUEFVU0UgQVQgZW50cnky
OjE5OjUKLVBBVVNFIEFUIHRlc3RBbGVydDo2OjE5CiBQQVVTRSBBVCB0ZXN0QWxlcnQ6Nzo1CiBQ
QVVTRSBBVCB0ZXN0QWxlcnQ6ODoyCiBQQVVTRSBBVCBlbnRyeTI6MjA6NQpAQCAtMjksNyArMjgs
NiBAQCBQQVVTRSBBVCBlbnRyeTM6MjQ6NQogUEFVU0UgQVQgZW50cnkzOjI1OjUKIFBBVVNFIEFU
IGVudHJ5MzoyNjo1CiBQQVVTRSBBVCBFdmFsIENvZGU6MToxCi1QQVVTRSBBVCBFdmFsIENvZGU6
MToxCiBQQVVTRSBBVCBFdmFsIENvZGU6MTo2CiBQQVVTRSBBVCBlbnRyeTM6Mjc6NQogUEFVU0Ug
QVQgZW50cnkzOjI4OjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM5ODE3ODcuLjQ4NmM3
YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA5LTA3
ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIElu
c3BlY3RvcjogU3RlcHBpbmcgaW50byBhIGZ1bmN0aW9uIC8gcHJvZ3JhbSBzaG91bGQgbm90IHJl
cXVpcmUgc3RlcHBpbmcgdG8gdGhlIGZpcnN0IHN0YXRlbWVudAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNzE2CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS8yODE5NjU5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAgKEpTQzo6RGVidWdnZXI6
OnN0ZXBPdXRPZkZ1bmN0aW9uKToKKyAgICAgICAgKEpTQzo6RGVidWdnZXI6OmV4Y2VwdGlvbik6
CisgICAgICAgIChKU0M6OkRlYnVnZ2VyOjpjYWxsRXZlbnQpOgorICAgICAgICAoSlNDOjpEZWJ1
Z2dlcjo6cmV0dXJuRXZlbnQpOgorICAgICAgICAoSlNDOjpEZWJ1Z2dlcjo6d2lsbEV4ZWN1dGVQ
cm9ncmFtKTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6RGVidWdnZXI6OmRpZEV4ZWN1dGVQcm9n
cmFtKTogRGVsZXRlZC4KKyAgICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlci5oOgorICAgICAgICAq
IGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAgICAgIChJ
bnNwZWN0b3I6Okluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmRpZFBhdXNlKToKKworMjAxNi0wOS0w
NyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJ
bnNwZWN0b3I6IFN0ZXBwaW5nIGFsbCB0aGUgd2F5IHRocm91Z2ggcHJvZ3JhbSBzaG91bGQgbm90
IGNhdXNlIGEgcGF1c2Ugb24gdGhlIG5leHQgcHJvZ3JhbSB0aGF0IGV4ZWN1dGVzCiAgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE3MjEKICAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzI4MTk4NTQ3PgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dl
ci9EZWJ1Z2dlci5jcHAKaW5kZXggYTBhM2EzYi4uYmUxN2Y5NCAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCkBAIC02MTEsNiArNjExLDEzIEBAIHZvaWQg
RGVidWdnZXI6OnVwZGF0ZUNhbGxGcmFtZShDYWxsRnJhbWUqIGNhbGxGcmFtZSkKICAgICB9CiB9
CiAKK3ZvaWQgRGVidWdnZXI6OnVwZGF0ZUNhbGxGcmFtZVdpdGhvdXRQYXVzZShDYWxsRnJhbWUq
IGNhbGxGcmFtZSkKK3sKKyAgICB1cGRhdGVDYWxsRnJhbWUoY2FsbEZyYW1lKTsKKyAgICBpZiAo
IWlzU3RlcHBpbmcoKSkKKyAgICAgICAgbV9jdXJyZW50Q2FsbEZyYW1lID0gbnVsbHB0cjsKK30K
Kwogdm9pZCBEZWJ1Z2dlcjo6dXBkYXRlQ2FsbEZyYW1lQW5kUGF1c2VJZk5lZWRlZChDYWxsRnJh
bWUqIGNhbGxGcmFtZSkKIHsKICAgICB1cGRhdGVDYWxsRnJhbWUoY2FsbEZyYW1lKTsKQEAgLTcw
Myw4ICs3MTAsNyBAQCB2b2lkIERlYnVnZ2VyOjpjYWxsRXZlbnQoQ2FsbEZyYW1lKiBjYWxsRnJh
bWUpCiAgICAgaWYgKG1faXNQYXVzZWQpCiAgICAgICAgIHJldHVybjsKIAotICAgIFBhdXNlUmVh
c29uRGVjbGFyYXRpb24gcmVhc29uKCp0aGlzLCBQYXVzZWRBZnRlckNhbGwpOwotICAgIHVwZGF0
ZUNhbGxGcmFtZUFuZFBhdXNlSWZOZWVkZWQoY2FsbEZyYW1lKTsKKyAgICB1cGRhdGVDYWxsRnJh
bWVXaXRob3V0UGF1c2UoY2FsbEZyYW1lKTsKIH0KIAogdm9pZCBEZWJ1Z2dlcjo6cmV0dXJuRXZl
bnQoQ2FsbEZyYW1lKiBjYWxsRnJhbWUpCkBAIC03MTUsNyArNzIxLDcgQEAgdm9pZCBEZWJ1Z2dl
cjo6cmV0dXJuRXZlbnQoQ2FsbEZyYW1lKiBjYWxsRnJhbWUpCiAgICAgUGF1c2VSZWFzb25EZWNs
YXJhdGlvbiByZWFzb24oKnRoaXMsIFBhdXNlZEJlZm9yZVJldHVybik7CiAgICAgdXBkYXRlQ2Fs
bEZyYW1lQW5kUGF1c2VJZk5lZWRlZChjYWxsRnJhbWUpOwogCi0gICAgLy8gZGV0YWNoIG1heSBo
YXZlIGJlZW4gY2FsbGVkIGR1cmluZyBwYXVzZUlmTmVlZGVkCisgICAgLy8gRGV0YWNoIG1heSBo
YXZlIGJlZW4gY2FsbGVkIGR1cmluZyBwYXVzZUlmTmVlZGVkLgogICAgIGlmICghbV9jdXJyZW50
Q2FsbEZyYW1lKQogICAgICAgICByZXR1cm47CiAKQEAgLTczNCw4ICs3NDAsNyBAQCB2b2lkIERl
YnVnZ2VyOjp3aWxsRXhlY3V0ZVByb2dyYW0oQ2FsbEZyYW1lKiBjYWxsRnJhbWUpCiAgICAgaWYg
KG1faXNQYXVzZWQpCiAgICAgICAgIHJldHVybjsKIAotICAgIFBhdXNlUmVhc29uRGVjbGFyYXRp
b24gcmVhc29uKCp0aGlzLCBQYXVzZWRBdFN0YXJ0T2ZQcm9ncmFtKTsKLSAgICB1cGRhdGVDYWxs
RnJhbWVBbmRQYXVzZUlmTmVlZGVkKGNhbGxGcmFtZSk7CisgICAgdXBkYXRlQ2FsbEZyYW1lV2l0
aG91dFBhdXNlKGNhbGxGcmFtZSk7CiB9CiAKIHZvaWQgRGVidWdnZXI6OmRpZEV4ZWN1dGVQcm9n
cmFtKENhbGxGcmFtZSogY2FsbEZyYW1lKQpAQCAtNzQ2LDkgKzc1MSwxMSBAQCB2b2lkIERlYnVn
Z2VyOjpkaWRFeGVjdXRlUHJvZ3JhbShDYWxsRnJhbWUqIGNhbGxGcmFtZSkKICAgICBQYXVzZVJl
YXNvbkRlY2xhcmF0aW9uIHJlYXNvbigqdGhpcywgUGF1c2VkQXRFbmRPZlByb2dyYW0pOwogICAg
IHVwZGF0ZUNhbGxGcmFtZUFuZFBhdXNlSWZOZWVkZWQoY2FsbEZyYW1lKTsKIAorICAgIC8vIERl
dGFjaCBtYXkgaGF2ZSBiZWVuIGNhbGxlZCBkdXJpbmcgcGF1c2VJZk5lZWRlZC4KKyAgICBpZiAo
IW1fY3VycmVudENhbGxGcmFtZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gVHJlYXQgc3Rl
cHBpbmcgb3ZlciB0aGUgZW5kIG9mIGEgcHJvZ3JhbSBsaWtlIHN0ZXBwaW5nIG91dC4KLSAgICBp
ZiAoIW1fY3VycmVudENhbGxGcmFtZSkKLSAgICAgICAgcmV0dXJuOwogICAgIGlmIChtX2N1cnJl
bnRDYWxsRnJhbWUgPT0gbV9wYXVzZU9uQ2FsbEZyYW1lKSB7CiAgICAgICAgIFZNRW50cnlGcmFt
ZSogdG9wVk1FbnRyeUZyYW1lID0gbV92bS50b3BWTUVudHJ5RnJhbWU7CiAgICAgICAgIG1fcGF1
c2VPbkNhbGxGcmFtZSA9IG1fY3VycmVudENhbGxGcmFtZS0+Y2FsbGVyRnJhbWUodG9wVk1FbnRy
eUZyYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1
Z2dlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmgKaW5kZXgg
YmU1OTVkOS4uODFmNDhkYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVn
Z2VyL0RlYnVnZ2VyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVn
Z2VyLmgKQEAgLTkyLDkgKzkyLDcgQEAgcHVibGljOgogICAgICAgICBOb3RQYXVzZWQsCiAgICAg
ICAgIFBhdXNlZEZvckV4Y2VwdGlvbiwKICAgICAgICAgUGF1c2VkQXRTdGF0ZW1lbnQsCi0gICAg
ICAgIFBhdXNlZEFmdGVyQ2FsbCwKICAgICAgICAgUGF1c2VkQmVmb3JlUmV0dXJuLAotICAgICAg
ICBQYXVzZWRBdFN0YXJ0T2ZQcm9ncmFtLAogICAgICAgICBQYXVzZWRBdEVuZE9mUHJvZ3JhbSwK
ICAgICAgICAgUGF1c2VkRm9yQnJlYWtwb2ludCwKICAgICAgICAgUGF1c2VkRm9yRGVidWdnZXJT
dGF0ZW1lbnQsCkBAIC0xODYsNiArMTg0LDcgQEAgcHJpdmF0ZToKICAgICAvLyBieXRlY29kZSBQ
QyBrZXknZWQgYnJlYWtwb2ludCwgd2Ugd2lsbCBub3QgbmVlZCB0aGVzZSBhbnltb3JlIGFuZCBz
aG91bGQKICAgICAvLyBiZSBhYmxlIHRvIHJlbW92ZSB0aGVtLgogICAgIHZvaWQgdXBkYXRlQ2Fs
bEZyYW1lKEpTQzo6Q2FsbEZyYW1lKik7CisgICAgdm9pZCB1cGRhdGVDYWxsRnJhbWVXaXRob3V0
UGF1c2UoSlNDOjpDYWxsRnJhbWUqKTsKICAgICB2b2lkIHVwZGF0ZUNhbGxGcmFtZUFuZFBhdXNl
SWZOZWVkZWQoSlNDOjpDYWxsRnJhbWUqKTsKICAgICB2b2lkIHBhdXNlSWZOZWVkZWQoSlNDOjpD
YWxsRnJhbWUqKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv
ci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAppbmRleCBiN2Y0
Yzg0Li5iYzhmMGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y
L2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtNzAz
LDkgKzcwMyw3IEBAIHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGlkUGF1c2UoSlNDOjpF
eGVjU3RhdGUmIHNjcmlwdFN0YXRlLCBKU0M6OkpTVmFsdWUKICAgICAgICAgICAgIG1fYnJlYWtB
dXhEYXRhID0gYnVpbGRFeGNlcHRpb25QYXVzZVJlYXNvbihleGNlcHRpb25PckNhdWdodFZhbHVl
LCBpbmplY3RlZFNjcmlwdCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBKU0M6
OkRlYnVnZ2VyOjpQYXVzZWRBdFN0YXRlbWVudDoKLSAgICAgICAgY2FzZSBKU0M6OkRlYnVnZ2Vy
OjpQYXVzZWRBZnRlckNhbGw6CiAgICAgICAgIGNhc2UgSlNDOjpEZWJ1Z2dlcjo6UGF1c2VkQmVm
b3JlUmV0dXJuOgotICAgICAgICBjYXNlIEpTQzo6RGVidWdnZXI6OlBhdXNlZEF0U3RhcnRPZlBy
b2dyYW06CiAgICAgICAgIGNhc2UgSlNDOjpEZWJ1Z2dlcjo6UGF1c2VkQXRFbmRPZlByb2dyYW06
CiAgICAgICAgICAgICAvLyBQYXVzZSB3YXMganVzdCBzdGVwcGluZy4gTm90aGluZyB0byByZXBv
cnQuCiAgICAgICAgICAgICBicmVhazsK
</data>
<flag name="review"
          id="311615"
          type_id="1"
          status="+"
          setter="bburg"
    />
    <flag name="commit-queue"
          id="311616"
          type_id="3"
          status="-"
          setter="joepeck"
    />
          </attachment>
      

    </bug>

</bugzilla>