161699 2016-09-07 10:59:29 -0700 Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests) 2016-09-14 08:18:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build iPhone / iPad iOS 9.3 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161696 https://bugs.webkit.org/show_bug.cgi?id=161964 P2 Normal --- 1 jbedard jbedard ap commit-queue dbates lforschler oldest_to_newest 1227260 0 jbedard 2016-09-07 10:59:29 -0700 This bug is meant to help debug https://bugs.webkit.org/show_bug.cgi?id=161696. Spindumps are large, so they are only being selectively enabled. 1227261 1 288162 jbedard 2016-09-07 11:00:21 -0700 Created attachment 288162 Patch 1227269 2 288162 dbates 2016-09-07 11:33:25 -0700 Comment on attachment 288162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288162&action=review > Tools/ChangeLog:3 > + Run spindumps on timeout on iOS 9 WK 2release simulators. "iOS 9 WK 2release simulators" => "iOS 9 Simulator Release WK2 (Tests) bots" > Tools/ChangeLog:9 > + (RunWebKitTests): Disable sample on timeout for everything except iOS 9 WK2 release simulators. Do we know how much more time this may introduce for a test cycle? > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:350 > + if WithProperties("%(buildername)s") != "Apple iOS 9 Simulator Release WK2 (Tests)": > + command.append("--no-sample-on-timeout") Does this work? From my understanding the values of Buildbot properties are not available until start() is called. Also, please add a test for this change. The unit tests for Buildbot are in file <https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py>. You can run the tests by invoking "python mastercfg_unittest.py" inside directory Tools/BuildSlaveSupport/build.webkit.org-config. 1227272 3 288162 jbedard 2016-09-07 11:56:56 -0700 Comment on attachment 288162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288162&action=review >> Tools/ChangeLog:9 >> + (RunWebKitTests): Disable sample on timeout for everything except iOS 9 WK2 release simulators. > > Do we know how much more time this may introduce for a test cycle? The issue won't be time (it's about 30 seconds per timeout test, so basically doubling the timeout time) it will be memory >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:350 >> + command.append("--no-sample-on-timeout") > > Does this work? From my understanding the values of Buildbot properties are not available until start() is called. Also, please add a test for this change. The unit tests for Buildbot are in file <https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py>. You can run the tests by invoking "python mastercfg_unittest.py" inside directory Tools/BuildSlaveSupport/build.webkit.org-config. Well, I'm parsing the builder-name instead of the platform. From my understanding, the builder-name is defined in the constructor, after all, we actually use the builder name in the constructor already (line 341). I used the builder-name instead on the platform name since this change is specifically targeting a builder. 1227363 4 288190 jbedard 2016-09-07 14:48:43 -0700 Created attachment 288190 Patch 1227365 5 jbedard 2016-09-07 14:50:32 -0700 Adding Unit Tests for this requires infrastructure we currently do not have. Local testing has confirmed this patch, and a later patch will include Unit Tests for RunWebKitTests more generally. 1227395 6 288190 ap 2016-09-07 16:22:03 -0700 Comment on attachment 288190 Patch Seems like concerns have been addressed, rs=me 1227408 7 288190 dbates 2016-09-07 16:45:08 -0700 Comment on attachment 288190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288190&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:360 > + if WithProperties("%(buildername)s") != "Apple iOS 9 Simulator Release WK2 (Tests)": Is there a way we can do this an avoid hardcoding some or all of the name of this bot? I mean, we will setup bots for iOS 10 soon. On another note, it seems excessive to interpolate the value of a Buildbot property using WithProperties() as a means to gets its value. I suggest we use self.getProperty(X) to get the value directly. 1227419 8 288190 commit-queue 2016-09-07 17:02:39 -0700 Comment on attachment 288190 Patch Clearing flags on attachment: 288190 Committed r205573: <http://trac.webkit.org/changeset/205573> 1227420 9 commit-queue 2016-09-07 17:02:43 -0700 All reviewed patches have been landed. Closing bug. 1227820 10 288190 jbedard 2016-09-08 14:33:04 -0700 Comment on attachment 288190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288190&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:360 >> + if WithProperties("%(buildername)s") != "Apple iOS 9 Simulator Release WK2 (Tests)": > > Is there a way we can do this an avoid hardcoding some or all of the name of this bot? I mean, we will setup bots for iOS 10 soon. > > On another note, it seems excessive to interpolate the value of a Buildbot property using WithProperties() as a means to gets its value. I suggest we use self.getProperty(X) to get the value directly. I'm not sure how long we intend to keep this change. Since it is designed to catch a specific problem, I think for the time being, hardcoding is appropriate. If we determine that these logs are useful more generally, we can use something more general. Looking closer, yes, self.getProperty is probably a better choice and will likely be used when I update this code-path for testing. 288162 2016-09-07 11:00:21 -0700 2016-09-07 14:48:40 -0700 Patch bug-161699-20160907105756.patch text/plain 1854 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTU1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA5LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSdW4gc3BpbmR1bXBzIG9uIHRpbWVvdXQgb24gaU9TIDkgV0sgMnJlbGVh c2Ugc2ltdWxhdG9ycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MTY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVy LmNmZzoKKyAgICAgICAgKFJ1bldlYktpdFRlc3RzKTogRGlzYWJsZSBzYW1wbGUgb24gdGltZW91 dCBmb3IgZXZlcnl0aGluZyBleGNlcHQgaU9TIDkgV0syIHJlbGVhc2Ugc2ltdWxhdG9ycy4KKwog MjAxNi0wOS0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg W1N0cmVhbXMgQVBJXSBTZXBhcmF0ZSBjb21waWxlIGZsYWcgZm9yIFJlYWRhYmxlU3RyZWFtIGFu ZCBXcml0YWJsZVN0cmVhbQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lvbiAyMDU1 NTEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9t YXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0zMzcsNyArMzM3LDYgQEAgY2xhc3MgUnVuV2Vi S2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgICAgICAgICAiLS1uby1idWlsZCIsCiAgICAg ICAgICAgICAgICAiLS1uby1zaG93LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tbm8tbmV3 LXRlc3QtcmVzdWx0cyIsCi0gICAgICAgICAgICAgICAiLS1uby1zYW1wbGUtb24tdGltZW91dCIs CiAgICAgICAgICAgICAgICAiLS1yZXN1bHRzLWRpcmVjdG9yeSIsICJsYXlvdXQtdGVzdC1yZXN1 bHRzIiwKICAgICAgICAgICAgICAgICItLWJ1aWxkZXItbmFtZSIsIFdpdGhQcm9wZXJ0aWVzKCIl KGJ1aWxkZXJuYW1lKXMiKSwKICAgICAgICAgICAgICAgICItLWJ1aWxkLW51bWJlciIsIFdpdGhQ cm9wZXJ0aWVzKCIlKGJ1aWxkbnVtYmVyKXMiKSwKQEAgLTM0Nyw2ICszNDYsOSBAQCBjbGFzcyBS dW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAgICAgICAgICItLWV4aXQtYWZ0ZXIt bi1mYWlsdXJlcyIsICI1MDAiLAogICAgICAgICAgICAgICAgV2l0aFByb3BlcnRpZXMoIi0tJShj b25maWd1cmF0aW9uKXMiKV0KIAorICAgIGlmIFdpdGhQcm9wZXJ0aWVzKCIlKGJ1aWxkZXJuYW1l KXMiKSAhPSAiQXBwbGUgaU9TIDkgU2ltdWxhdG9yIFJlbGVhc2UgV0syIChUZXN0cykiOgorICAg ICAgICBjb21tYW5kLmFwcGVuZCgiLS1uby1zYW1wbGUtb24tdGltZW91dCIpCisKICAgICBkZWYg c3RhcnQoc2VsZik6CiAgICAgICAgIHBsYXRmb3JtID0gc2VsZi5nZXRQcm9wZXJ0eSgncGxhdGZv cm0nKQogICAgICAgICBhcHBlbmRDdXN0b21CdWlsZEZsYWdzKHNlbGYsIHBsYXRmb3JtLCBzZWxm LmdldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nKSkK 288190 2016-09-07 14:48:43 -0700 2016-09-07 17:02:39 -0700 Patch bug-161699-20160907144619.patch text/plain 2141 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTU2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA5LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSdW4gc3BpbmR1bXBzIG9uIHRpbWVvdXQgb24gaU9TIDkgU2ltdWxhdG9y IFJlbGVhc2UgV0syIChUZXN0cykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MTY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgY2hhbmdlIGRvZXMgbm90IGhhdmUgdGVzdGluZyBhc3NvY2lhdGVk IHdpdGggaXQgYmVjYXVzZSB0aGUgdGVzdGluZyBpbmZyYXN0cnVjdHVyZSBkb2VzIG5vdCBleGlz dHMsIHdlIGNhbm5vdCBjdXJyZW50bHkgbW9jayBidWlsZC1ib3QgdmFyaWFibGVzLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNm ZzoKKyAgICAgICAgKFJ1bldlYktpdFRlc3RzKTogRW5hYmxlIHNhbXBsZSBvbiB0aW1lb3V0IGZv ciBldmVyeXRoaW5nLgorICAgICAgICAoUnVuV2ViS2l0VGVzdHMuc3RhcnQpOiBEaXNhYmxlIHNh bXBsZSBvbiB0aW1lb3V0IGZvciBldmVyeXRoaW5nIGV4Y2VwdCBpT1MgOSBXSzIgcmVsZWFzZSBz aW11bGF0b3JzLgorCiAyMDE2LTA5LTA3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBVcGRhdGUgV2ViS2l0U3lzdGVtSW50ZXJmYWNlCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3Rlci5jZmcJKHJldmlzaW9uIDIwNTU1MSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdvcmtpbmcgY29weSkKQEAgLTMz Nyw3ICszMzcsNiBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAg ICAgICAgICItLW5vLWJ1aWxkIiwKICAgICAgICAgICAgICAgICItLW5vLXNob3ctcmVzdWx0cyIs CiAgICAgICAgICAgICAgICAiLS1uby1uZXctdGVzdC1yZXN1bHRzIiwKLSAgICAgICAgICAgICAg ICItLW5vLXNhbXBsZS1vbi10aW1lb3V0IiwKICAgICAgICAgICAgICAgICItLXJlc3VsdHMtZGly ZWN0b3J5IiwgImxheW91dC10ZXN0LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tYnVpbGRl ci1uYW1lIiwgV2l0aFByb3BlcnRpZXMoIiUoYnVpbGRlcm5hbWUpcyIpLAogICAgICAgICAgICAg ICAgIi0tYnVpbGQtbnVtYmVyIiwgV2l0aFByb3BlcnRpZXMoIiUoYnVpbGRudW1iZXIpcyIpLApA QCAtMzU4LDYgKzM1Nyw5IEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAg ICAgICBpZiBwbGF0Zm9ybSA9PSAid2luIjoKICAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChz ZWxmLmNvbW1hbmQgKyBbJy0tYmF0Y2gtc2l6ZScsICcxMDAnLCAnLS1yb290PScgKyBvcy5wYXRo LmpvaW4oIldlYktpdEJ1aWxkIiwgc2VsZi5nZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicpLCAi YmluMzIiKV0pCiAKKyAgICAgICAgaWYgV2l0aFByb3BlcnRpZXMoIiUoYnVpbGRlcm5hbWUpcyIp ICE9ICJBcHBsZSBpT1MgOSBTaW11bGF0b3IgUmVsZWFzZSBXSzIgKFRlc3RzKSI6CisgICAgICAg ICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLW5vLXNhbXBsZS1vbi10aW1l b3V0J10pCisKICAgICAgICAgaWYgYWRkaXRpb25hbEFyZ3VtZW50czoKICAgICAgICAgICAgIHNl bGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBhZGRpdGlvbmFsQXJndW1lbnRzKQogICAgICAg ICByZXR1cm4gc2hlbGwuVGVzdC5zdGFydChzZWxmKQo=