16169 2007-11-28 03:57:29 -0800 GIF ImageDecoder hasAlpha() return value incorrect 2007-11-28 11:57:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Cairo, Gtk P2 Normal --- 1 alp webkit-unassigned pkasting oldest_to_newest 62557 0 alp 2007-11-28 03:57:29 -0800 Commit r28068 to fix #15974 caused a change in the return value of hasAlpha() for GIF animation frames. Frames that have transparency used to return true but now return false. Looks like "replace" frames return true as expected but "combine" frames always return false now where one would expect true, which should probably remain an implementation detail internal to the GIF decoder rather than affecting hasAlpha(). Test case attached. 62558 1 17572 alp 2007-11-28 04:00:10 -0800 Created attachment 17572 Test case Before the changes were made: frame 1 hasAlpha: 1 frame 2 hasAlpha: 1 frame 3 hasAlpha: 1 frame 4 hasAlpha: 1 frame 5 hasAlpha: 1 frame 6 hasAlpha: 1 frame 7 hasAlpha: 1 frame 8 hasAlpha: 1 frame 9 hasAlpha: 1 frame 10 hasAlpha: 1 frame 11 hasAlpha: 1 frame 12 hasAlpha: 1 After the changes: frame 1 hasAlpha: 1 frame 2 hasAlpha: 0 frame 3 hasAlpha: 0 frame 4 hasAlpha: 0 frame 5 hasAlpha: 0 frame 6 hasAlpha: 1 frame 7 hasAlpha: 0 frame 8 hasAlpha: 0 frame 9 hasAlpha: 0 frame 10 hasAlpha: 0 frame 11 hasAlpha: 0 frame 12 hasAlpha: 0 Frames 1 and 6 are replace/background frames -- the rest are combine frames. 62565 2 alp 2007-11-28 04:48:45 -0800 The workaround committed in r28109 should be removed when this issue is resolved. 62587 3 17577 pkasting 2007-11-28 11:26:48 -0800 Created attachment 17577 patch v1 Attempted fix (untested). This was just oversight -- I meant to copy the alpha state from the previous buffer at the same time I copied its bits. The FIXME in ImageSourceCairo is based on IRC discussion with alp. 62588 4 17577 alp 2007-11-28 11:53:59 -0800 Comment on attachment 17577 patch v1 r=me 62589 5 alp 2007-11-28 11:57:48 -0800 Landed in r28114. 17572 2007-11-28 04:00:10 -0800 2007-11-28 04:00:10 -0800 Test case spin_over.gif image/gif 5960 alp R0lGODlhHQAeAPf/APrkd/763P3z2vvpo/rbpvzu1vrqs/774vvjmvnirvqnaP30y/Z1O/31065R XfuGV/788/3yxP776/nIifl1Sv351fram/zzsvzzq/hVO+I0JPzyvPvbi/vjtfvii/rdkvrSg/zj lPbdmvm4d/vmvPSzTfzdhPzpkvCDPfXhpPvdcvvkgfbalPXSgvRlN/zwlv3zpORVRu+WQ/rTe/ve evzsjfhqQ/qcZvrUif76y+6nSfGTQ/35w/zrmfrNfPflqvrba/35vPqtXfroqPfls/nLkvKuS/l9 U/OkSvrqhPqscPu7hPTVif35tfu8a/rRdfujXvnqwe91OfLAU/nmpvqyUvjUY/jovfrBY/bajO9l NfbRY/XNZvrBfvSdSvnrufrVkvquVPXLuPrLdPXMe/vxiK0nKfPKa/XMcvrUafbIW/O7U/uya/TR e+xFKfbAXfvCbfVMNvq6Y++jgfTRbPvnwvq7Wv34rvTTdPrJbPrWnvPKVfnsxvubXfjoxfz34fud VfO0VfqSXPuzW/uzZPd/QPfctO+2TvrqzvvEc/vLZvjNXfipXPSNRfbSkPrFUvCgRvm1k/q5UP3u tu/GVva6WemMd/ephfuTVPfouPWqUvrTW/WyWfamU/mjU/zpqf3qr/nko/a6o/rtyvrnrO+bR/np yP3pwu+ReuxaM8xpbvTGYvrDXPvtzfngqPmiTelGN/S7YfmdS/qWUPzurfqETO6NQfrLVfWZf/3u xexyVe+7UPzmn/jin/qLT/ffnvebUvvtuPSdW/rswv3v0L9DQuycfPCGSP3uyvnsvfzupf3pvf3v vvjAcvvsqP33pfuLQ/eSRvzrufzqyfehXvE/K/bFaveNUPnYbveSVfa0av7sw/3fnvjQnPzr0PaX SfnYgfjos/nXduR9dfzmpvjbefvYY/DLYPfmt/maRverTvzrrO2Hffe0X/RaMblia++yn/WGQe5T MPi/qPnHefjYZ7o5Ovvml/m5a+A/NvKujvmnSvrggve/UfNfSQAAACH/C05FVFNDQVBFMi4wAwEA AAAh+QQFCgD/ACwAAAAAHQAeAAAI/wD/CRxIsKDBgwgTKlzIsOFBRN4KFBAg0aFBU4gyeosokSIi i3VM+RlpytSoUa1aESNWwFtDEldgXokShY9Nm6OQISM2bWGHn0TQobsyk2aUYUi3bUN2SmGCpwmC ZvpyJVmUZMuSSZPGbFuuDghduSKQIsUPIuHQTf3CNpiBrV2XiTlI4JeIX7/M/iAVrq8BA6ACT5rE TBoBgxYsiGAhQkRZs6SGDPm0rjKtwcw+WTCoh4VnxiJ6pQhFRbIzZ7RSX9gwideHeQXBOGLCJEvj 0L1CDfjkTBkGDBcu0OJ170OkgrNb0M7y4QMCXrwGKFMGA8az6T3u3eNwnCCIFuCVM//3EOLEiRro y6Dvkd2DiUsFfZAh06a+OHEqaKxYkaSM/xfs9RCCB+DgUhA9852xihqLbIGNCgD09x+AAnIAzhjs FIRPM7EEssYUDKahwgrovWBiD7wg8AEIY7BhEDCMaGKEESVIwooi4vBzQg8DDDAEOb18gAM9cBxx 0DdeIIGEOlXYgYUP4HATCjmkJOCKHjh0gU8fqhzEQDRIytJJGHIkMgEYBBCQAAF6TNAFG1D4kxAD 8TQSTTqAMIJPFxN042c3E4ygBBQ2LMRAIfFAA80sUCgxwhKQLqHEDX3Y8A5D7jBwaC2+CHLDDQrc IIggR2RwqUPu2GADBRTUcsSrFGQWUIxFBFUTRwa4xpHPrLT26uuvwBoUEAAh+QQFCgD/ACwDAAYA GAAVAAAI/wD/CRxIsKDAVgYJEkH3L9O/KP+GJfxXZ6JAh8mS/dMY5YvAZae2GXT1j2S4hh4HejRA QtopEgV//eslkJSBmwYGkvpHSlqwDnoIivj3KxQVKkN4rvv3iek6UAakkQPzz4IFgR969TKKlGlT Z87W0TIA6sM/Uf/AsMjCAsGvrV0FglVGi9anEB84pP2HIwtbBAh4DUjq7J+ywz3uefDAwYQ+HHyZ +P1wr/K9fyf+Jdm8mLEJcHP+tQDRogU4cOVoCEyyYjPnxZ9nDPSBhsuif2kIuma9+LQPOP+cJPpX 6V8/gVaAAFjROsliDjhAjMmj4B8gIWGqlBi4iI4Kfvw8fIr4kCU6vWZOBsp61WnfvzCS/ll70oIt CzA4JtDDR4hgoVmy/OOJJv+0IxwZjiRYxARdaFNdQYX4MgswgHjyjzYjdNHFBAyOoIQCgExUiy/X zNIHNQooMcIlSnz4Tzb+TOTCEYWMmM0/ffxzgyD/PPBPHBb9A8s/FFDwzxFHCGQkkEEOlI9A7jQp UEAAIfkEBQoA/wAsAwAFABgAFgAACP8A/wkcSLCgt4II/5EgOKwgn3/IEkpMGOXUqWkTKf77opDj sn+GEv6QmOlfuHAdMi3rIDEUKYHhCL582UFagm4Df/371QvhJ1JDSFERSiocN4IiPoggOERg0yFU oA5NwAEHwQ8Ce4X6R+7fkK8DwlKh0qsqDn3/sgj8gJUXV69hw94LkQWc3RmX/lnNwuEDAgQD73nw sIIfjXLlwM1Y/A8EiMZqTZgQyG/FvxUAaBwWJ27GkzGofPiYIVDRloGaAazQXE7ck895nIwTiOWf nUcCN1kBokKFZs6w4ThBWEVgPzWLrKThvHjMGOFyCOka6Emdun/F7bxZlWeMaHr0muFuI8Qo20Bf wDwxYhRGyCA5cuAk6kKvywhtQqAAKlgLEzUoUCggBCHajDDCEvcpoUAfmCRUyzV99EGNAgoo8Y8S Ci4oyDUTUfCAL4IIckMfNwz0gEAZZOSPDUccceKJA6WY0UAxZJCBDf78I6NEAQEAIfkEBQoA/wAs AwAFABgAFgAACP8A/wkcSLDgQEQGEyocNe2fKYUQ/0WJQpBExH9fCl75lykTCRJ1CCYQ6CpiJiJE /nWwaLDXPypDBBr4F67mvx+uEiToUFIgt3/cXJL7N2Tdp3+kbv4IlSJFTguOBn4QgYAXL3JDjn76 NITKv6a/XP3CAQLevw8W/iH4d5Xc1qNUQoXq1esXixYgfAjkwOGDWl4DBrz9Rw5BrxBZWuBBM8PH nH98+661yougiXLi6NBBg2bMGGP/cOCILJAfv38maNAohy0NHS5c8uSxZukfiH9P/qUhqOIfDRWt 0yhSZA0LFnz/4Ai004/VrVuLNm0yVy9Na0VY3sjZTu0flEECJUmMEvjo0fNFimRjsWNnkBAhA18x ChOmyr8q4iU1twbHiRz3jHiCyTsCCQIFI+8JAV4VVQwihxNOsEEII1AAMktBmPShwIZsdOhhhwpU iIlCD/RxgxIKKKGEQBve0IcgvvgC0RGCCHLDDf/g+I8gAtXyTxwR6ULBAw/8U2SRR9hwEUG6+OPP PzY8CQtEAQEAIfkECQoA/wAsAwADABcAGAAACP8A/wkcKLBBhQB/DgQQQLBhwwYQK1QQEADhQm8O B0ZYsADinz8BDEJsIACjw208Njb4yLJBDo7E/k1rOGnDhggkWX4U0CBlrm0OpV24EEGAzo8VFvBg Jm1ZHYKk1mEgKsCozgYLNkwy8A8dQXLOlF3oWHUk1g0X1pFqyI2XMrELeGKNEGRDkwu0hlAJlWAg NwQ9XlwgdhbtnQsYMHwa0isFwQ8h7r3Y0DEC4gt3MCj7NCBUwzYfPpzoMXgB4sSaB/BC0NDHPw7/ PJygFSECBhgvXvT4x08gHoFn/qERyMGDhwEbaNVIsmIFjX/lsP2jw0WgtYEzaNDwwMsDACACVai/ wJZmCxc1q7D8kyPn3xhFrJ58MGFuk7l/Vqxs2bJo1ZtYlbTTzkCDSIKFDz6oQRB6/tlRCSdhECRL hIPAkYgdA0liRyyxtANhJ5684otAvgDiiUCE/FNFGOpUwQkn7TDCiCfAzPJPDAP5ggkUPMroo4zU UFPjNb5o0VAtmAjSRx9Q3BBkH8Jkk801tdSSigMOUfDAA9cI4uWUVB5BAQWwZCSQPzYcoaaaY9rw Dyz2mElQDBlk4I4/GcCST5wOBQQAIfkEBQAA/wAsAAAAAB0AHgAACP8A/wkcSLCgwYMIEypcyLDh wQoBAhyYGMChwRwQIx7QGEBAAYsLMEKcuDFAhZMCvDWMwIMHRAkwJWyskGPBAmLTFk4KEoSHRAkQ IMA0mSNChG3ISCicdKFJjj9AgQo9kIPHBmbLltUxhBDUujtNKsQcGyBHkEkGDHQg0UHMQXLKnoWF KjPiSR53QH1KkKCDq24GufGK20SAhD8mW/K8Q+sTFVeuElhwFBhBjxdB/vypwKNJkzugMTjulSKF BRwtDH4IcQKzZryg78BQNoBcr1+/WLTwkbogBw8eXlz406DJs+MwBvBCgIBFljZo0PggYxCHCQ9J MDRY8OzFixoe+IH3E4eHzpnz5+kZBAHOBD9nES4kAaBCBTY6+M+c27/Kmn+DPswgTjkegHIPEOYk uAUX+1FCyRuxRBhLOwY5MQYWdszAzQdW3LLIHns4SMkUuxxySCCccCKMQYAMEoYkWICBAyuP9DMF iSYeYoQOOnTioy4HpfPKPmE004UdJRih5I486gBJKaXIcMw7BzGQTjqydCJEJ0hA4uWTkMggpi2N NBJDQgzEE000O7C5g5g72CKnLSjUmcpCDBRSSDwo8Fnnn1IEKoU8DjDkDgMMSJGooIFq4agGFv0j jwsuOKpFKpjKo4EZkQ6kgRuguqHBpp2WauqpqAoUEAAh+QQFAAD/ACwDAAMAFwAWAAAI/wD/CRxI 8MBAgwQTEqwQ4N8Bgw8dBhCgcGCOg/8kODwQoGOABhX/5biIEAIECRwDVGhQYUHCDf94XJQAQaBJ lCobLGiQi+CGIEEqaPxXkyjOlQsiLOgwEEMTHg2JSj3ZsUEDZBEiSGv6dKPAhxwrIEXGjBkoPQkZ qhQpcuSCt2QnhQIj8AWMJgz/Af3XpEkQHkpzDQvmjAMHghfEJrxzYUMEwcEGmAAH4t/hGv903hn4 DIYyWsEMDAkBTtyMGQJNeFAWYQOMgSeSrPDggV+5cniejBnzDwS4f7yC0QJAEJvxeti2bOGSpznv GeJMhPIw0Mo/5VvOLVKj5g2Wf4T+JUwSOMYCuC3/bgncM3DKmkAJhVSpIgeEj3/9CO4aaMRISHX4 NFOFfwohMdA3BH2D4D+MGBjSDiH908g/0UD4j4URRohChhwyIAWHAwUEACH5BAUKAP8ALAMAAwAY ABMAAAj/AP8JHCgwwIF/EhISXMhQ4IGDCBNCSBigIcEK/ypKgDBxYkIJFRvyKPiPo0COKCmK/Fdh 40KUHCUcyNEwx0EIL2FCOFAhAkOaB13i1DmxAg9DA2HcCZKjIkSHBz7uNMqNIIx/OSpUyEGTYICN MivcCTGwx4sLWWk2GdiEaVQJFYL08CDq34d7PTAsWBBk4Z0mPAIEyCE3iYlIA084y8UMA4yr/55J /tvkRY0V/P5d+gdOYI9gk178q3Hin4d/K5IAAKBChbgnTwiCQ0BqwAoV/4AQBAIkje80A+kJxAPu A7h6Vqz8Uy5w0b9FrFj9cyJnYR4mMxbt2TOQO8FK/wYRJAzzrxI9em/+TVlYwuLCdvgsItHxz0vD aAI9dWIIqZRAGQwFBAAh+QQFCgD/ACwDAAMAGAAYAAAI/wD/CRwosEGFAAcSBiDIsGEDgwICSEx4 IICAhgQjNFiwwKDEjx8bYPwXoWTHBn8C/Kn48aBIhpM2bODx8I9Niiwr5KgQgaE0ZhE6CrC5Eucf nTwWkCBogBmzkwIirvyYskFSZmIGgqIVMyjHBRUOhrVoVaYFgdx4DVAWU+aGIEEKVmggoEGEDco+ /LNgAcG9AZOCXRh84U4QHjkePlxwIYRAMP8+hOBlYKsyGBgEbvi6ccMJDwJxZOHAAQGVIQN6XIbx 78KGuxuCDQmxgoZAEODAfUjR656HE/9qlHlBvMcAKqE80BA3x8e/Fm2ysMhSDhuQfyoAaE9yr1eo Xx6wPblB9c/HEzR08NA5t+VfvXpAtHtAYOGXBXB5sPzD9y9WoDdnnLGHQItsUk85H7CgYDeOjIEF FANpUkIgscSyxhr9PLIHF2044mERRUwgxyADffMPEkhowokRApVQQiXWTCDjBF1o0wk0DX3jBRJe CISiOpxoM8II2jACTDQjNdLIQDL8800pXggjTDZKujPSPygIFE88/2wZDwqFFMLAlQNJMeZAYzLg wj/VkDmQFm+6Y2WbbmJE55UBAQAh+QQFCgD/ACwDAAMAGAAYAAAI/wD/CRwoEFGBAgISCiDIsKEp RBCJERPQ4E8AAQUaEqxjyo/HUaOILWhQocI/kxr/kbiy8kqUYXwiLFgg0GQFmgw76CSCDp3LYRFk mjwgMEcuhgmSJuCZKVmyDRF45KhAVCAPgq5cEUiR4geRcOG+MNsQJEiOAAdy/Ls6kMAvEb9+df1B KtykSU2aBKFqMsgFgRYsiGAhQgTXueto3bnTJMeBPzmCDNTDojJhuFypfFK2+A6PPxIqNKkx0BGT 05d/9Qo1gPPiIKAbPEuy4p/pFqeZZPkAF0HrZ8CbVPgjm/Y/EC2S49adJYsHDzXKSL/TgCKGJDQu /SPDvU0bPHTCY8AD8k/6swgJG2AAgA3XdjJnVlGi9O/cln9AAEyvnlAZNkXs/NOMQIfssst8/2xi DgAwLDBRQsiEoIgQ/wDDyD9GZGhEgQJtQsM6B2FUQAc+2HHEQF5AAokOLAokiSSKfFCHNwVM0wEI g0SjCkE7/FNKKSr+s88+VcDhiB4EdNOFELJk0JAt/0D5jwzpVOmJEGywwcgs0LigEQMoMBQPNGSS +U8hTqb0jxQMSPEPA3C++aaXahJE5z90ulNnnW7sGRAAIfkEBQoA/wAsBgADABUAGAAACP8A/wkc 6O1fAYEHBypcOLBVAWIFBAj4V5DhQlPTWhHbSKyBgFYWGeYaFQHZgpMNkIUcGGVYrlwnF0SIsODU yi//kg2bSZNnhA4r/31htmFDyQgbmEVYFvLHPwMGJl0wmovohkl6Vg5ZRwvDJKNIN3wKOuQThq5g N9C692GeQBEsFjpThgHDBZrJepzwMDBL3H+9eP1zBgMG3WDJSN2rYUJf338f+J5IUuMf5SEGFK/g 96/NQDzYxKkAYDlJkh5Dwn1CsELcQDX/uGypNzoJAMoDSJFKEEJcHoGBpkzZs8gKENKUef1IkIAA hzGEBpYosUaNojTlViBIkcCVKwJ6QGCDEYikvLoSlbBYe5LFgitDhsAXcQJooJf7ncJwwtfMBxgC /3TzTxEjMOLPQI1Es8M3wHQihDYjLDFBEUUsoQQUNihUSCHxxNPILIBQA4USJCpwQzYuvMMQA/9w WIsv12RzzQO1UBCHigy5848NNjDAAAUU8BiHPUH9U80/cSR5JJEWBQQAIfkEBQoA/wAsBgADABUA GAAACP8A/wkcSLAAwYMIBXrzZrAhooQITY0a1arVP2IFvEEcGOUfn498RiFDRmzaxn9X/kVZOazl tm3ITqJUmWxZMmnSmG3LtRFdpn9fggYzgPPfto2k/oULZ8AAqKeTJjGTRgBi0iGf1mmlFZXZPwsH e/0LJXCIM2e00l74N4nXwCz/RPwTK/CTM2X/MFy4QIvXvQ8EASNw+08ZXhjPDPf4d49DpMAeQpz4 V4NyGco9FnswQVCcOBU0VqxIUqb0i8w9QngAR3DRFmwqAJA2fTo1B3BjBK75p2ZRGhUratR4QbwH LwQfQPxjQ1ASK0Xi+J3oMWDAEHK9PuCgB4eguip2sPhvAMctFDlSCVzpwdEFXx+B3/7J6hRGTqIJ YAgQSEBAz4QubECBUDqAMIJPFxN0o2A3E4wAUTzQQDMLFEqMsMSFSyjxTx82QFRILb4IcsMNCtwg iCBHZLBRhxRQUMsRMFKQQTEy/RNHBjjGkQ+NCQUEADs= 17577 2007-11-28 11:26:48 -0800 2007-11-28 11:53:59 -0800 patch v1 patch text/plain 3939 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODExMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMTEtMjggIFBldGVyIEthc3RpbmcgIDx6ZXJvZHB4QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2OQorICAgICAgICBHSUYg ZGVjb2RlciBuZWVkcyB0byBzZXQgaGFzQWxwaGEoKSBjb3JyZWN0bHkgb24gc3Vic2VxdWVudCBm cmFtZXMuCisgICAgICAgIAorICAgICAgICBUaGlzIGFsc28gcmVtb3ZlcyB0aGUgd29ya2Fyb3Vu ZCBmb3IgdGhpcyBwcm9ibGVtIGluCisgICAgICAgIEltYWdlU291cmNlQ2Fpcm8uY3BwLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VTb3VyY2VDYWlyby5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbWFnZVNvdXJjZTo6ZnJhbWVIYXNBbHBoYUF0SW5kZXgpOgorICAg ICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R0lGSW1hZ2VEZWNvZGVyOjppbml0RnJhbWVCdWZmZXIpOgorCiAy MDA3LTExLTI4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIgYW5kIEFkYW0gUm9iZW4uCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlU291cmNlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VTb3VyY2VDYWlyby5jcHAJKHJldmlz aW9uIDI4MTEyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZVNvdXJj ZUNhaXJvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkzLDM2ICsxOTMsMTUgQEAgZmxvYXQgSW1h Z2VTb3VyY2U6OmZyYW1lRHVyYXRpb25BdEluZGV4KAogCiBib29sIEltYWdlU291cmNlOjpmcmFt ZUhhc0FscGhhQXRJbmRleChzaXplX3QgaW5kZXgpCiB7Ci0gICAgLy8gV2UgYWxtb3N0IGFsd2F5 cyB3YW50IHRvIHN1cHBvcnQgYWxwaGEsIGVzcGVjaWFsbHkgZm9yIGltYWdlcyB0aGF0IGFyZQot ICAgIC8vIG9ubHkgcGFydGlhbGx5IGxvYWRlZC4KLSAgICAvLwotICAgIC8vIFRoZXJlIGlzIG9u ZSBleGNlcHRpb246Ci0gICAgLy8KLSAgICAvLyBBcyBhbiBvcHRpbWl6YXRpb24gd2UgY2FuIGFs bG93IHRoZSBpbWFnZSByZW5kZXJlciB0byBibGl0IHRoZSBpbWFnZQotICAgIC8vIChpbXBsZW1l bnRlZCBhcyBDb21wb3NpdGVDb3B5IGluIEltYWdlQ2Fpcm8pIGJ5IHJldHVybmluZyBmYWxzZSBp ZiBhbmQKLSAgICAvLyBvbmx5IGlmOgotICAgIC8vCi0gICAgLy8gICAqIFRoZSBpbWFnZSBoYXMg YmVlbiBmdWxseSBsb2FkZWQKLSAgICAvLyAgICogVGhlIGJ1ZmZlciBpcyBtYXJrZWQgYXMgbm90 IGhhdmluZyBhbHBoYSB0cmFuc3BhcmVuY3kKLQorICAgIC8vIFdoZW4gYSBmcmFtZSBoYXMgbm90 IGZpbmlzaGVkIGRlY29kaW5nLCBhbHdheXMgbWFyayBpdCBhcyBoYXZpbmcgYWxwaGEsCisgICAg Ly8gc28gd2UgZG9uJ3QgZ2V0IGEgYmxhY2sgYmFja2dyb3VuZCBmb3IgdGhlIHVuZGVjb2RlZCBz ZWN0aW9ucy4KKyAgICAvLyBGSVhNRTogQSBiZXR0ZXIgc29sdXRpb24gaXMgcHJvYmFibHkgdG8g aGF2ZSB0aGUgdW5kZXJseWluZyBidWZmZXIncworICAgIC8vIGhhc0FscGhhKCkgcmV0dXJuIHRy dWUgaW4gdGhlc2UgY2FzZXMsIHNpbmNlIGl0IGlzLCBpbiBmYWN0LCB0ZWNobmljYWxseQorICAg IC8vIHRydWUuCiAgICAgaWYgKCFmcmFtZUlzQ29tcGxldGVBdEluZGV4KGluZGV4KSkKICAgICAg ICAgcmV0dXJuIHRydWU7CiAKLSAgICBBU1NFUlQobV9kZWNvZGVyKTsKLSAgICBSR0JBMzJCdWZm ZXIqIGJ1ZmZlciA9IG1fZGVjb2Rlci0+ZnJhbWVCdWZmZXJBdEluZGV4KGluZGV4KTsKLSAgICBB U1NFUlQoYnVmZmVyKTsKLQotICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgaGFjayB0aGF0IG1ha2Vz IHRoZSB3aG9sZSBvcHRpbWl6YXRpb24gdXNlbGVzcyBpbgotICAgIC8vIG1hbnkgY2FzZXMuIEl0 IGlzIG5lY2Vzc2FyeSBiZWNhdXNlIGJ1ZmZlci0+aGFzQWxwaGEoKSBpbmNvcnJlY3RseQotICAg IC8vIHJldHVybnMgZmFsc2Ugd2hlbiBpdCBzaG91bGQgcmV0dXJuIHRydWUgZm9yIGNlcnRhaW4g R0lGIGltYWdlcy4KLSAgICAvLwotICAgIC8vIFdlIHNob3VsZCBpZGVhbGx5IG5ldmVyIGhhdmUg dG8gY2hlY2sgaWYgdGhlIGRlY29kZXIgc3VwcG9ydHMgYWxwaGEuCi0gICAgLy8KLSAgICAvLyBT ZWUgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNjkKLSAgICBpZiAo bV9kZWNvZGVyLT5zdXBwb3J0c0FscGhhKCkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAg cmV0dXJuIGJ1ZmZlci0+aGFzQWxwaGEoKTsKKyAgICByZXR1cm4gbV9kZWNvZGVyLT5mcmFtZUJ1 ZmZlckF0SW5kZXgoaW5kZXgpLT5oYXNBbHBoYSgpOwogfQogCiB9CkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVjb2Rlci5j cHAJKHJldmlzaW9uIDI4MTEyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9n aWYvR0lGSW1hZ2VEZWNvZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM0LDYgKzIzNCw3IEBA IHZvaWQgR0lGSW1hZ2VEZWNvZGVyOjppbml0RnJhbWVCdWZmZXIodW4KICAgICAgICAgICAgICAg ICAocHJldk1ldGhvZCA9PSBSR0JBMzJCdWZmZXI6OkRpc3Bvc2VLZWVwKSkgewogICAgICAgICAg ICAgLy8gUHJlc2VydmUgdGhlIGxhc3QgZnJhbWUgYXMgdGhlIHN0YXJ0aW5nIHN0YXRlIGZvciB0 aGlzIGZyYW1lLgogICAgICAgICAgICAgYnVmZmVyLT5ieXRlcygpID0gcHJldkJ1ZmZlci0+Ynl0 ZXMoKTsKKyAgICAgICAgICAgIGJ1ZmZlci0+c2V0SGFzQWxwaGEocHJldkJ1ZmZlci0+aGFzQWxw aGEoKSk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBXZSB3YW50IHRvIGNsZWFy IHRoZSBwcmV2aW91cyBmcmFtZSB0byB0cmFuc3BhcmVudCwgd2l0aG91dAogICAgICAgICAgICAg Ly8gYWZmZWN0aW5nIHBpeGVscyBpbiB0aGUgaW1hZ2Ugb3V0c2lkZSBvZiB0aGUgZnJhbWUuCkBA IC0yNDYsNiArMjQ3LDcgQEAgdm9pZCBHSUZJbWFnZURlY29kZXI6OmluaXRGcmFtZUJ1ZmZlcih1 bgogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgLy8gQ29weSB0aGUgd2hvbGUg cHJldmlvdXMgYnVmZmVyLCB0aGVuIGNsZWFyIGp1c3QgaXRzIGZyYW1lLgogICAgICAgICAgICAg ICBidWZmZXItPmJ5dGVzKCkgPSBwcmV2QnVmZmVyLT5ieXRlcygpOworICAgICAgICAgICAgICBi dWZmZXItPnNldEhhc0FscGhhKHByZXZCdWZmZXItPmhhc0FscGhhKCkpOwogICAgICAgICAgICAg ICBmb3IgKGludCB5ID0gcHJldlJlY3QueSgpOyB5IDwgcHJldlJlY3QuYm90dG9tKCk7ICsreSkg ewogICAgICAgICAgICAgICAgICAgdW5zaWduZWQqIGNvbnN0IGN1cnJlbnRSb3cgPQogICAgICAg ICAgICAgICAgICAgICAgIGJ1ZmZlci0+Ynl0ZXMoKS5kYXRhKCkgKyAoeSAqIG1fc2l6ZS53aWR0 aCgpKTsK