161682 2016-09-07 02:01:42 -0700 [Win64] Compile fixes. 2016-09-08 02:22:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1227112 0 pvollan 2016-09-07 02:01:42 -0700 There are currently a few compile errors on Win64. 1227121 1 288125 pvollan 2016-09-07 02:24:35 -0700 Created attachment 288125 Patch 1227156 2 288125 bfulgham 2016-09-07 07:01:49 -0700 Comment on attachment 288125 Patch Thanks for fixing this. We need to get 64-bit on EWS! 1227223 3 288125 achristensen 2016-09-07 10:00:24 -0700 Comment on attachment 288125 Patch My WinCairo bot is doing 64-bit builds. Why isn't that broken if this is needed? 1227573 4 pvollan 2016-09-08 02:16:46 -0700 (In reply to comment #3) > Comment on attachment 288125 [details] > Patch > > My WinCairo bot is doing 64-bit builds. Why isn't that broken if this is > needed? I think this is because we have not enabled 'warning as errors' on WinCairo. 1227574 5 pvollan 2016-09-08 02:18:12 -0700 (In reply to comment #2) > Comment on attachment 288125 [details] > Patch > > Thanks for fixing this. We need to get 64-bit on EWS! Thanks for reviewing :) 1227575 6 pvollan 2016-09-08 02:22:09 -0700 Committed r205611: <http://trac.webkit.org/changeset/205611> 288125 2016-09-07 02:24:35 -0700 2016-09-07 07:01:49 -0700 Patch bug-161682-20160907022211.patch text/plain 3047 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA1NTM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTA5LTA3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2luNjRdIENvbXBpbGUgZml4ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcDoKKyAgICAg ICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZW1pdENhbGwpOgorICAgICAgICAqIGppdC9K SVRDYWxsLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpjb21waWxlT3BDYWxsKToKKyAgICAgICAg KiBydW50aW1lL0FycmF5Q29udmVudGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpjbGVhckFycmF5 TWVtc2V0KToKKwogMjAxNi0wOS0wNiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4K IAogICAgICAgICBQcm94eU9iamVjdCdzIHN0cnVjdHVyZSBzaG91bGQgbm90IGhhdmUgT2JqZWN0 UHJvdG90eXBlIGFzIGl0cyBwcm90b3R5cGUgYW5kIGl0IHNob3VsZCBub3QgaGF2ZSBzcGVjaWFs IGJlaGF2aW9yIGZvciBpbnRlcmNlcHRpbmcgIl9fcHJvdG9fXyIKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24g MjA1NTM3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjkxLDcgKzY5MSw3IEBAIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmVtaXRDYWxsKE5vZGUqIG5vZGUKICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0gICAgR1BS UmVnIGNhbGxlZUdQUjsKKyAgICBHUFJSZWcgY2FsbGVlR1BSID0gSW52YWxpZEdQUlJlZzsKICAg ICBDYWxsRnJhbWVTaHVmZmxlRGF0YSBzaHVmZmxlRGF0YTsKICAgICAKICAgICAvLyBHb3R0YSBs b2FkIHRoZSBhcmd1bWVudHMgc29tZWhvdy4gVmFyYXJncyBpcyB0cmlja2llci4KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ2FsbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxsLmNwcAkocmV2aXNpb24gMjA1NTM3KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU2 LDcgKzE1Niw3IEBAIHZvaWQgSklUOjpjb21waWxlT3BDYWxsKE9wY29kZUlEIG9wY29kZUkKICAg ICBDT01QSUxFX0FTU0VSVChPUENPREVfTEVOR1RIKG9wX2NhbGwpID09IE9QQ09ERV9MRU5HVEgo b3BfdGFpbF9jYWxsX3ZhcmFyZ3MpLCBjYWxsX2FuZF90YWlsX2NhbGxfdmFyYXJnc19vcGNvZGVz X211c3RfYmVfc2FtZV9sZW5ndGgpOwogICAgIENPTVBJTEVfQVNTRVJUKE9QQ09ERV9MRU5HVEgo b3BfY2FsbCkgPT0gT1BDT0RFX0xFTkdUSChvcF90YWlsX2NhbGxfZm9yd2FyZF9hcmd1bWVudHMp LCBjYWxsX2FuZF90YWlsX2NhbGxfZm9yd2FyZF9hcmd1bWVudHNfb3Bjb2Rlc19tdXN0X2JlX3Nh bWVfbGVuZ3RoKTsKIAotICAgIENhbGxMaW5rSW5mbyogaW5mbzsKKyAgICBDYWxsTGlua0luZm8q IGluZm8gPSBudWxscHRyOwogICAgIGlmIChvcGNvZGVJRCAhPSBvcF9jYWxsX2V2YWwpCiAgICAg ICAgIGluZm8gPSBtX2NvZGVCbG9jay0+YWRkQ2FsbExpbmtJbmZvKCk7CiAgICAgaWYgKG9wY29k ZUlEID09IG9wX2NhbGxfdmFyYXJncyB8fCBvcGNvZGVJRCA9PSBvcF9jb25zdHJ1Y3RfdmFyYXJn cyB8fCBvcGNvZGVJRCA9PSBvcF90YWlsX2NhbGxfdmFyYXJncyB8fCBvcGNvZGVJRCA9PSBvcF90 YWlsX2NhbGxfZm9yd2FyZF9hcmd1bWVudHMpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9BcnJheUNvbnZlbnRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9BcnJheUNvbnZlbnRpb25zLmNwcAkocmV2aXNpb24gMjA1NTM3KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlDb252ZW50aW9ucy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTMzLDcgKzMzLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAjaWYgVVNFKEpT VkFMVUU2NCkKIHZvaWQgY2xlYXJBcnJheU1lbXNldChXcml0ZUJhcnJpZXI8VW5rbm93bj4qIGJh c2UsIHVuc2lnbmVkIGNvdW50KQogewotI2lmIENQVShYODZfNjQpCisjaWYgQ1BVKFg4Nl82NCkg JiYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQogICAgIHVpbnQ2NF90IHplcm8gPSAwOwogICAgIGFz bSB2b2xhdGlsZSAoCiAgICAgICAgICJyZXAgc3Rvc3Fcblx0IgpAQCAtNDgsNyArNDgsNyBAQCB2 b2lkIGNsZWFyQXJyYXlNZW1zZXQoV3JpdGVCYXJyaWVyPFVua25vCiAKIHZvaWQgY2xlYXJBcnJh eU1lbXNldChkb3VibGUqIGJhc2UsIHVuc2lnbmVkIGNvdW50KQogewotI2lmIENQVShYODZfNjQp CisjaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQogICAgIHVpbnQ2NF90 IHBuYW4gPSBiaXR3aXNlX2Nhc3Q8dWludDY0X3Q+KFBOYU4pOwogICAgIGFzbSB2b2xhdGlsZSAo CiAgICAgICAgICJyZXAgc3Rvc3Fcblx0Igo=