<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>161654</bug_id>
          
          <creation_ts>2016-09-06 16:20:20 -0700</creation_ts>
          <short_desc>Fetch API fails to send Origin header on Same Origin GET requests</short_desc>
          <delta_ts>2019-06-08 01:49:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>151937</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mohammed Khatib">mkhatib727</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>rbuis</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1226918</commentid>
    <comment_count>0</comment_count>
    <who name="Mohammed Khatib">mkhatib727</who>
    <bug_when>2016-09-06 16:20:20 -0700</bug_when>
    <thetext>Safari Dev Preview seems to successfully set Origin header on these cases:

* Cross Origin GET
* Same Origin POST
* Cross Origin POST

But fails to do the same with Same Origin GET. 

Firefox already successfully implements this and Chrome are working on fixing the same issue in their Fetch implementation.
https://codereview.chromium.org/2290193003/
https://bugs.chromium.org/p/chromium/issues/detail?id=641620#c2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1227053</commentid>
    <comment_count>1</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-09-06 22:43:04 -0700</bug_when>
    <thetext>Thanks for filing this bug.

It seems there is consensus to add the Origin header in cors mode, which would cover XHR.
It is not very clear what happens in no-cors mode, see https://github.com/whatwg/fetch/issues/225</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543070</commentid>
    <comment_count>2</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2019-06-08 01:49:05 -0700</bug_when>
    <thetext>It seems this is fixed; the relevant subtests in api/basic/request-headers.any.js pass and the chromium bug was marked as WontFix.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>