161629 2016-09-06 08:43:06 -0700 [Win] Enable strict runtime stack buffer checks. 2016-09-06 11:57:07 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen benjamin bfulgham cdumez cmarcelo commit-queue dbates webkit-bug-importer oldest_to_newest 1226684 0 pvollan 2016-09-06 08:43:06 -0700 We can use #pragma strict_gs_check(on) to enable buffer checks in more cases than with the compile option /GS. 1226688 1 288027 pvollan 2016-09-06 08:47:04 -0700 Created attachment 288027 Patch 1226691 2 pvollan 2016-09-06 08:49:23 -0700 <rdar://problem/9915569> 1226723 3 288027 bfulgham 2016-09-06 09:57:50 -0700 Comment on attachment 288027 Patch r=me 1226737 4 achristensen 2016-09-06 10:34:48 -0700 Should we remove the compile option /GS then? Will this hurt performance? 1226767 5 pvollan 2016-09-06 11:33:43 -0700 (In reply to comment #4) > Should we remove the compile option /GS then? Will this hurt performance? I believe the /GS option is needed to use the pragma. I don't think it will affect performance much, but it will add a little overhead to the functions where the compiler decides to emit these checks. 1226768 6 288027 pvollan 2016-09-06 11:35:33 -0700 Comment on attachment 288027 Patch Thanks for reviewing :) 1226775 7 288027 commit-queue 2016-09-06 11:57:01 -0700 Comment on attachment 288027 Patch Clearing flags on attachment: 288027 Committed r205497: <http://trac.webkit.org/changeset/205497> 1226776 8 commit-queue 2016-09-06 11:57:07 -0700 All reviewed patches have been landed. Closing bug. 288027 2016-09-06 08:47:04 -0700 2016-09-06 11:57:01 -0700 Patch bug-161629-20160906084448.patch text/plain 1039 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDU0NzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA5LTA2ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBFbmFibGUgc3RyaWN0IHJ1bnRpbWUg c3RhY2sgYnVmZmVyIGNoZWNrcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MTYyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTYtMDgtMzEgIEZpbGlwIFBpemxv ICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBCdXR0ZXJmbGllcyBzaG91bGQgYmUgYWxs b2NhdGVkIGluIEF1eGlsaWFyeSBNYXJrZWRTcGFjZSBpbnN0ZWFkIG9mIENvcGllZFNwYWNlIGFu ZCB3ZSBzaG91bGQgcmV3cml0ZSBhcyBtdWNoIG9mIHRoZSBHQyBhcyBuZWVkZWQgdG8gbWFrZSB0 aGlzIG5vdCBhIHJlZ3Jlc3Npb24KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMjA1MTEwKQor KysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTIyMCw0ICsx MjIwLDkgQEAKICNkZWZpbmUgVVNFX01FRElBUkVNT1RFIDEKICNlbmRpZgogCisjaWYgQ09NUElM RVIoTVNWQykKKy8qIEVuYWJsZSBzdHJpY3QgcnVudGltZSBzdGFjayBidWZmZXIgY2hlY2tzLiAq LworI3ByYWdtYSBzdHJpY3RfZ3NfY2hlY2sob24pCisjZW5kaWYKKwogI2VuZGlmIC8qIFdURl9Q bGF0Zm9ybV9oICovCg==