16162 2007-11-27 11:54:07 -0800 [gtk] parseFloat depends on locale setting 2007-12-16 10:15:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Major --- 1 pierre-luc.beaudoin ap alp ap oldest_to_newest 62503 0 pierre-luc.beaudoin 2007-11-27 11:54:07 -0800 Parsing a float with parseFloat() doesn't return the same result for all locales. Sample script: <script> var input = prompt("Enter 0,5 or 0.5"); var test = 0.5; if(input != null) test = parseFloat(input); alert(eval("test == 0.5")); alert(eval("test == '0.5'")); if(test == 0.5) alert("Works!"); else alert("Pain!"); </script> Tests data: en_US: Entering 0.5 will produce true, true, then Works! fr_CA: Entering 0.5 will produce false, true then Pain! Entering 0,5 will produce true, false, then Works! Expected results (if parseFloat shouldn't use locale): en_US: Entering 0.5 will produce true, true, then Works! fr_CA: Entering 0.5 will produce true, true, then Works! Entering 0,5 will produce false, false, then Pain! (I guess) 62599 1 ap 2007-11-28 12:44:21 -0800 I can see how this can happen if USE_LOCALE is defined. Is it defined on Linux somehow? We should probably just remove USE_LOCALE code from dtoa.cpp. 63754 2 alp 2007-12-09 11:14:06 -0800 ap: USE_LOCALE isn't defined in my build and I don't see immediately how it could be defined. Pierre-Luc: Could I get a bit more information on this? Can you check to see if USE_LOCALE is defined in your dtoa.cpp? 63826 3 pierre-luc.beaudoin 2007-12-10 08:39:51 -0800 I don't have USE_LOCALE define in my build. ( I added #ifdef USE_LOCALE garbage #endif in dtoa.cpp and it still compiles). This bug should affect anyone using a locale that uses a coma as the decimal point: French, Finish... all non-imperial unit locales I guess. 64377 4 ap 2007-12-16 08:49:05 -0800 Actually, I'm quite sure that parseFloat works correctly. It seems that literals are parsed wrong! In lexer.cpp, see: dval = strtod(m_buffer8.data(), 0L); It should be kjs_strtod. I'd also recommend removing USE_LOCALE code from dtoa.cpp, to reduce future confusion. 64378 5 17933 ap 2007-12-16 09:09:17 -0800 Created attachment 17933 proposed fix This bug could affect Mac, too, if an application using JavaScriptCore has set a C locale. We also use strtol in date_object.cpp, but they all seem to be safe (it's only whitespace-skipping that can be affected AFAIK). 64379 6 ap 2007-12-16 09:11:25 -0800 Note: I didn't test this. 64382 7 17933 darin 2007-12-16 09:19:39 -0800 Comment on attachment 17933 proposed fix r=me 64383 8 darin 2007-12-16 09:20:18 -0800 (In reply to comment #6) > Note: I didn't test this. Oh, we should add a regression test then! 64386 9 ap 2007-12-16 09:32:00 -0800 Committed revision 28771. 64388 10 ap 2007-12-16 10:15:23 -0800 I would expect a lot of js tests to fail on Linux with non-U.S. locales before this patch. 17933 2007-12-16 09:09:17 -0800 2007-12-16 09:19:39 -0800 proposed fix 16162r1_patch.txt text/plain 2752 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NzcwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTItMTYgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MTYyCisgICAgICAgIFByb2JsZW1zIHdpdGggZmxvYXQgcGFyc2luZyBvbiBMaW51eCAo bG9jYWxlLWRlcGVuZGVudCBwYXJzaW5nIHdhcyB1c2VkKS4KKworICAgICAgICAqIGtqcy9kdG9h LmNwcDogUmVtb3ZlZCBVU0VfTE9DQUxFIHRvIHJlZHVjZSBmdXR1cmUgY29uZnVzaW9uLgorICAg ICAgICAqIGtqcy9sZXhlci5jcHA6IChLSlM6OkxleGVyOjpsZXgpOiBQYXJzZSB3aXRoIGtqc19z dHJ0b2QsIG5vdCB0aGUgc3lzdGVtIG9uZS4KKwogMjAwNy0xMi0xNCAgQWxwIFRva2VyICA8YWxw QGF0b2tlci5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpJbmRleDogSmF2 YVNjcmlwdENvcmUva2pzL2R0b2EuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tq cy9kdG9hLmNwcAkocmV2aXNpb24gMjg3NjgpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvZHRvYS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MCw3ICsxNTAsNiBAQAogICoJc29tZSBjb21waWxlcnMg YW5kIHdhcyBhbHdheXMgdXNlZCBwcmlvciB0byAxOTk5MDkxNiwgYnV0IGl0CiAgKglpcyBub3Qg c3RyaWN0bHkgbGVnYWwgYW5kIGNhbiBjYXVzZSB0cm91YmxlIHdpdGggYWdncmVzc2l2ZWx5CiAg KglvcHRpbWl6aW5nIGNvbXBpbGVycyAoZS5nLiwgZ2NjIDIuOTUuMSB1bmRlciAtTzIpLgotICog I2RlZmluZSBVU0VfTE9DQUxFIHRvIHVzZSB0aGUgY3VycmVudCBsb2NhbGUncyBkZWNpbWFsX3Bv aW50IHZhbHVlLgogICogI2RlZmluZSBTRVRfSU5FWEFDVCBpZiBJRUVFIGFyaXRobWV0aWMgaXMg YmVpbmcgdXNlZCBhbmQgZXh0cmEKICAqCWNvbXB1dGF0aW9uIHNob3VsZCBiZSBkb25lIHRvIHNl dCB0aGUgaW5leGFjdCBmbGFnIHdoZW4gdGhlCiAgKglyZXN1bHQgaXMgaW5leGFjdCBhbmQgYXZv aWQgc2V0dGluZyBpbmV4YWN0IHdoZW4gdGhlIHJlc3VsdApAQCAtMjAyLDEwICsyMDEsNiBAQCB0 eXBlZGVmIHVuc2lnbmVkIExvbmcgVUxvbmc7CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVk ZSA8c3RyaW5nLmg+CiAKLSNpZmRlZiBVU0VfTE9DQUxFCi0jaW5jbHVkZSA8bG9jYWxlLmg+Ci0j ZW5kaWYKLQogI2lmZGVmIE1BTExPQwogI2lmZGVmIEtSX2hlYWRlcnMKIGV4dGVybiBjaGFyICpN QUxMT0MoKTsKQEAgLTE1NTksOSArMTU1NCw2IEBAIHN0cnRvZAogI2lmZGVmIEhvbm9yX0ZMVF9S T1VORFMKIAlpbnQgcm91bmRpbmc7CiAjZW5kaWYKLSNpZmRlZiBVU0VfTE9DQUxFCi0JQ09OU1Rf IGNoYXIgKnMyOwotI2VuZGlmCiAKIAlzaWduID0gbnowID0gbnogPSAwOwogCWR2YWwocnYpID0g MC47CkBAIC0xNjAwLDI1ICsxNTkyLDYgQEAgc3RydG9kCiAJCWVsc2UgaWYgKG5kIDwgMTYpCiAJ CQl6ID0gMTAqeiArIGMgLSAnMCc7CiAJbmQwID0gbmQ7Ci0jaWZkZWYgVVNFX0xPQ0FMRQotCXMx ID0gbG9jYWxlY29udigpLT5kZWNpbWFsX3BvaW50OwotCWlmIChjID09ICpzMSkgewotCQljID0g Jy4nOwotCQlpZiAoKisrczEpIHsKLQkJCXMyID0gczsKLQkJCWZvcig7OykgewotCQkJCWlmICgq KytzMiAhPSAqczEpIHsKLQkJCQkJYyA9IDA7Ci0JCQkJCWJyZWFrOwotCQkJCQl9Ci0JCQkJaWYg KCEqKytzMSkgewotCQkJCQlzID0gczI7Ci0JCQkJCWJyZWFrOwotCQkJCQl9Ci0JCQkJfQotCQkJ fQotCQl9Ci0jZW5kaWYKIAlpZiAoYyA9PSAnLicpIHsKIAkJYyA9ICorK3M7CiAJCWlmICghbmQp IHsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9sZXhlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUva2pzL2xleGVyLmNwcAkocmV2aXNpb24gMjg3NjgpCisrKyBKYXZhU2NyaXB0 Q29yZS9ranMvbGV4ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2ICsyNCw3IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAibGV4ZXIuaCIKIAorI2luY2x1ZGUgImR0b2EuaCIK ICNpbmNsdWRlICJmdW5jdGlvbi5oIgogI2luY2x1ZGUgIm5vZGVzLmgiCiAjaW5jbHVkZSA8Y3R5 cGUuaD4KQEAgLTQ1OSw3ICs0NjAsNyBAQCBpbnQgTGV4ZXI6OmxleCgpCiAKICAgZG91YmxlIGR2 YWwgPSAwOwogICBpZiAoc3RhdGUgPT0gTnVtYmVyKSB7Ci0gICAgZHZhbCA9IHN0cnRvZChtX2J1 ZmZlcjguZGF0YSgpLCAwTCk7CisgICAgZHZhbCA9IGtqc19zdHJ0b2QobV9idWZmZXI4LmRhdGEo KSwgMEwpOwogICB9IGVsc2UgaWYgKHN0YXRlID09IEhleCkgeyAvLyBzY2FuIGhleCBudW1iZXJz CiAgICAgY29uc3QgY2hhciogcCA9IG1fYnVmZmVyOC5kYXRhKCkgKyAyOwogICAgIHdoaWxlIChj aGFyIGMgPSAqcCsrKSB7Cg==