161608 2016-09-05 09:35:51 -0700 [GTK] Several failing WebViewEditor API tests 2017-02-12 22:42:52 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 168219 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1226452 0 mcatanzaro 2016-09-05 09:35:51 -0700 Almost all of the TestWebViewEditor tests have started failing: TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=21695) /webkit2/WebKitWebView/editable/editable: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:79:gchar* EditorTest::cutSelection(): assertion failed: (canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_CUT)) FAIL GTester: last random seed: R02S5c171cadb5d23ea19dc53f9a9db9f391 (pid=21727) /webkit2/WebKitWebView/cut-copy-paste/non-editable: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:144:void testWebViewEditorCutCopyPasteNonEditable(EditorTest*, gconstpointer): assertion failed: (test->canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_COPY)) FAIL GTester: last random seed: R02S438d2f2e7479860f818b6f505f174bfb (pid=21758) /webkit2/WebKitWebView/cut-copy-paste/editable: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:171:void testWebViewEditorCutCopyPasteEditable(EditorTest*, gconstpointer): assertion failed: (test->canExecuteEditingCommand(WEBKIT_EDITING_COMMAND_CUT)) FAIL GTester: last random seed: R02S9452d8e2fc6d821470701eccd664efef (pid=21789) /webkit2/WebKitWebView/select-all/non-editable: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:194:void testWebViewEditorSelectAllNonEditable(EditorTest*, gconstpointer): assertion failed (clipboardText.get() == "make Jack a dull"): (NULL == "make Jack a dull") FAIL GTester: last random seed: R02S3dc594b867ccb8f2e3ae3a2e15856f36 (pid=21820) /webkit2/WebKitWebView/select-all/editable: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:222:void testWebViewEditorSelectAllEditable(EditorTest*, gconstpointer): assertion failed (clipboardText.get() == "make Jack a dull"): (NULL == "make Jack a dull") FAIL GTester: last random seed: R02S15b54bc3e4058f88cfd510dae39e13f0 (pid=21851) /webkit2/WebKitWebView/editor-state/typing-attributes: OK /webkit2/WebKitWebView/insert/image: OK /webkit2/WebKitWebView/insert/link: OK FAIL: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor Tests skipped. Please unskip when fixed. 1276021 1 301316 mcatanzaro 2017-02-12 13:06:37 -0800 Created attachment 301316 Patch 1276094 2 301316 cgarcia 2017-02-12 22:17:05 -0800 Comment on attachment 301316 Patch Good catch! 1276103 3 301316 commit-queue 2017-02-12 22:42:47 -0800 Comment on attachment 301316 Patch Clearing flags on attachment: 301316 Committed r212224: <http://trac.webkit.org/changeset/212224> 1276104 4 commit-queue 2017-02-12 22:42:52 -0800 All reviewed patches have been landed. Closing bug. 301316 2017-02-12 13:06:37 -0800 2017-02-12 22:42:47 -0800 Patch bug-161608-20170212150406.patch text/plain 3696 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWU5ZTA5ZGRjY2JhODY0OGJjYzVmN2U0ZjZhMzMzZDA5 OWQ3N2VhYi4uMjRjMmUxYTgxYmNmN2M3NTc1MDFhNzQ2MmZiNGJiZTUyMjY1ZjQxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDE3LTAyLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KIAorICAgICAgICBbR1RLXSBTZXZlcmFsIGZhaWxpbmcgV2ViVmlld0VkaXRvciBBUEkgdGVz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTYw OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbGVj dGlvbi5jb2xsYXBzZSgpIHJlcXVpcmVzIGFyZ3VtZW50czsgcGFzc2luZyBubyBhcmd1bWVudHMg bWVhbnMgdGhlIEpTIHRoYXQgc2VsZWN0cyB0aGUKKyAgICAgICAgdGV4dCByYW5nZSBoZXJlIG5l dmVyIGdldHMgZXZhbHVhdGVkLiBQZXJoYXBzIHRoZXJlIHdhcyBhIERPTSBBUEkgY2hhbmdlPyBD aGFuZ2luZyBpdCB0byB1c2UKKyAgICAgICAgU2VsZWN0aW9uLnJlbW92ZUFsbFJhbmdlcygpLCB3 aGljaCBzZWVtcyBsaWtlIGEgYmV0dGVyIGZ1bmN0aW9uIGFueXdheSwgZml4ZXMgYWxsIHRoZSB0 ZXN0cworICAgICAgICBleGNlcHQgdGhlIGZpcnN0IG9uZSwgd2hpY2ggaXMgc3RpbGwgYnJva2Vu IGR1ZSB0byB1bnJlbGF0ZWQgYnVnICMxNTE2NTQuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1n dGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyKToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYlZpZXdFZGl0b3IuY3BwOgorCisyMDE3LTAyLTEyICBN aWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJl dmlld2VkLCBza2lwIGZsYWt5IFdlYktpdFByaW50T3BlcmF0aW9uL2N1c3RvbS13aWRnZXQgdGVz dAogCiAgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCmluZGV4 IDg3MDEyMzM0NWFlYTQ1MDk2ZjQ3OWM1Yjc1MzNlOTE2YjU5ODI4NjIuLjA3MzVjYjZkZWFmNDBl Y2UwOTU3YmE3Zjg3N2IwMzJmNTg2YzlhZjAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVu LWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKQEAgLTc0LDExICs3 NCw2IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyR3Rr L1Rlc3RDb29raWVNYW5hZ2VyIiwgIi93ZWJraXQyL1dlYktpdENvb2tpZU1hbmFnZXIvcGVyc2lz dGVudC1zdG9yYWdlIiwgIlRlc3QgaXMgZmxha3kiLCAxMzQ1ODApLAogICAgICAgICBTa2lwcGVk VGVzdCgiV2ViS2l0Mkd0ay9UZXN0UHJpbnRpbmciLCAiL3dlYmtpdDIvV2ViS2l0UHJpbnRPcGVy YXRpb24vY3VzdG9tLXdpZGdldCIsICJUZXN0IGlzIGZsYWt5IiwgMTY4MTk2KSwKICAgICAgICAg U2tpcHBlZFRlc3QoIldlYktpdDJHdGsvVGVzdFdlYlZpZXdFZGl0b3IiLCAiL3dlYmtpdDIvV2Vi S2l0V2ViVmlldy9lZGl0YWJsZS9lZGl0YWJsZSIsICJUZXN0IGhpdHMgYW4gYXNzZXJ0aW9uIGlu IERlYnVnIGJ1aWxkcyIsIDE1MTY1NCwgIkRlYnVnIiksCi0gICAgICAgIFNraXBwZWRUZXN0KCJX ZWJLaXQyR3RrL1Rlc3RXZWJWaWV3RWRpdG9yIiwgIi93ZWJraXQyL1dlYktpdFdlYlZpZXcvZWRp dGFibGUvZWRpdGFibGUiLCAiU2FtZSB0ZXN0LCBoaXRzIHJlbGVhc2UgYXNzZXJ0aW9uIHRvbyIs IDE2MTYwOCksCi0gICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyR3RrL1Rlc3RXZWJWaWV3RWRp dG9yIiwgIi93ZWJraXQyL1dlYktpdFdlYlZpZXcvY3V0LWNvcHktcGFzdGUvbm9uLWVkaXRhYmxl IiwgIlRlc3QgaGl0cyBhc3NlcnRpb24iLCAxNjE2MDgpLAotICAgICAgICBTa2lwcGVkVGVzdCgi V2ViS2l0Mkd0ay9UZXN0V2ViVmlld0VkaXRvciIsICIvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2N1 dC1jb3B5LXBhc3RlL2VkaXRhYmxlIiwgIlRlc3QgaGl0cyBhc3NlcnRpb24iLCAxNjE2MDgpLAot ICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0V2ViVmlld0VkaXRvciIsICIvd2Vi a2l0Mi9XZWJLaXRXZWJWaWV3L3NlbGVjdC1hbGwvbm9uLWVkaXRhYmxlIiwgIlRlc3QgaGl0cyBh c3NlcnRpb24iLCAxNjE2MDgpLAotICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0 V2ViVmlld0VkaXRvciIsICIvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L3NlbGVjdC1hbGwvZWRpdGFi bGUiLCAiVGVzdCBoaXRzIGFzc2VydGlvbiIsIDE2MTYwOCksCiAgICAgICAgIFNraXBwZWRUZXN0 KCJXZWJLaXQyR3RrL1Rlc3RXZWJFeHRlbnNpb25zIiwgIi93ZWJraXQyL1dlYktpdFdlYkV4dGVu c2lvbi9mb3JtLWNvbnRyb2xzLWFzc29jaWF0ZWQtc2lnbmFsIiwgIlRlc3QgaXMgZmxha3kiLCAx NjgxOTQpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0V2ViRXh0ZW5zaW9u cyIsICIvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L2luc3RhbGwtbWlzc2luZy1wbHVnaW5zLXBlcm1p c3Npb24tcmVxdWVzdCIsICJUZXN0IHRpbWVzIG91dCIsIDE0NzgyMiksCiAgICAgICAgIFNraXBw ZWRUZXN0KCJXZWJLaXQyL1Rlc3RXZWJLaXQyIiwgIldlYktpdDIuTW91c2VNb3ZlQWZ0ZXJDcmFz aCIsICJUZXN0IGlzIGZsYWt5IiwgODUwNjYpLApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RXZWJWaWV3RWRpdG9yLmNwcCBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViVmlld0VkaXRvci5jcHAKaW5kZXggZDIw Yzc5NDRmODA0NDU0YzcxYThkYWQ5OTk4NTllYjJmNjFhOWQ2Yi4uMDBjMDJhZWQyMDZjOTFhN2Q1 YmFmMmJhNDFjZTc3M2NiN2YxZGViMSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyR3RrL1Rlc3RXZWJWaWV3RWRpdG9yLmNwcAorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYlZpZXdFZGl0b3IuY3BwCkBAIC0xMjYsNyAr MTI2LDcgQEAgcHVibGljOgogc3RhdGljIGNvbnN0IGNoYXIqIHNlbGVjdGVkU3BhbkhUTUxGb3Jt YXQgPQogICAgICI8aHRtbD48Ym9keSBjb250ZW50RWRpdGFibGU9XCIlc1wiPiIKICAgICAiPHNw YW4gaWQ9XCJtYWluc3BhblwiPkFsbCB3b3JrIGFuZCBubyBwbGF5IDxzcGFuIGlkPVwic3Vic3Bh blwiPm1ha2UgSmFjayBhIGR1bGw8L3NwYW4+IGJveS48L3NwYW4+IgotICAgICI8c2NyaXB0PmRv Y3VtZW50LmdldFNlbGVjdGlvbigpLmNvbGxhcHNlKCk7XG4iCisgICAgIjxzY3JpcHQ+ZG9jdW1l bnQuZ2V0U2VsZWN0aW9uKCkucmVtb3ZlQWxsUmFuZ2VzKCk7XG4iCiAgICAgImRvY3VtZW50Lmdl dFNlbGVjdGlvbigpLnNlbGVjdEFsbENoaWxkcmVuKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdz dWJzcGFuJykpO1xuIgogICAgICI8L3NjcmlwdD48L2JvZHk+PC9odG1sPiI7CiAK