161598 2016-09-05 01:47:21 -0700 [Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm 2016-09-05 10:21:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue darin jer.noble oldest_to_newest 1226392 0 joepeck 2016-09-05 01:47:21 -0700 Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm: AnalyzeShallow platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:314:9: warning: Value stored to 'systemCode' is never read systemCode = '!mor'; ^ ~~~~~~ Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:323:9: warning: Value stored to 'systemCode' is never read systemCode = '!mor'; ^ ~~~~~~ Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:330:5: warning: Value stored to 'systemCode' is never read systemCode = 0; ^ ~ 3 warnings generated. Seems that in r195410 this parameter accidentally dropped its reference-ness. Lets add it back. 1226393 1 287942 joepeck 2016-09-05 01:48:41 -0700 Created attachment 287942 [PATCH] Proposed Fix Jer, could we write a test for this? 1226457 2 287942 darin 2016-09-05 10:00:00 -0700 Comment on attachment 287942 [PATCH] Proposed Fix Wow, seems like this also fixes a bug, not just a static analyzer warning! I wonder if someone knows how to write a test that would demonstrate the bug. Also, I would like to remind everyone that in new code we should model multiple return values as return value, perhaps using a combination of structures, tuples, pairs, optionals, and variants as needed, not as one return value and two out arguments. 1226458 3 darin 2016-09-05 10:00:20 -0700 I see Joe’s question/request to Jer now. 1226466 4 287942 commit-queue 2016-09-05 10:21:41 -0700 Comment on attachment 287942 [PATCH] Proposed Fix Clearing flags on attachment: 287942 Committed r205456: <http://trac.webkit.org/changeset/205456> 1226467 5 commit-queue 2016-09-05 10:21:45 -0700 All reviewed patches have been landed. Closing bug. 287942 2016-09-05 01:48:41 -0700 2016-09-05 10:21:41 -0700 [PATCH] Proposed Fix ref-1.patch text/plain 2503 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZjJlMjkyLi40Mjk1M2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTYtMDktMDUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBTdGF0aWMgQW5hbHl6ZXIgd2FybmluZ3MgYWJvdXQgdW51c2VkIHZhbHVl cyBpbiBDRE1TZXNzaW9uQVZTdHJlYW1TZXNzaW9uLm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1OTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL0NETVNlc3Npb25BVlN0cmVhbVNlc3Npb24uaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1TZXNzaW9uQVZTdHJlYW1TZXNzaW9uLm1tOgor ICAgICAgICAoV2ViQ29yZTo6Q0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbjo6Z2VuZXJhdGVLZXlS ZWxlYXNlTWVzc2FnZSk6CisgICAgICAgIE1ha2UgdGhpcyBwYXJhbWV0ZXIgYSByZWZlcmVuY2Ug YWdhaW4sIGFjY2lkZW50YWxseSBsb3N0IGluIHIxOTU0MTAuCisgICAgICAgIE5vdyBhc3NpZ25t ZW50cyB0byB0aGUgcGFyYW1ldGVyIG1ha2Ugc2Vuc2UuCisKIDIwMTYtMDktMDQgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgdGhlIENSRUFURV9ET01fV1JB UFBFUiBtYWNybwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbi5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbkFWU3Ry ZWFtU2Vzc2lvbi5oCmluZGV4IDFkY2IyYTAuLjVlOTRmMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0NETVNlc3Npb25BVlN0 cmVhbVNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9DRE1TZXNzaW9uQVZTdHJlYW1TZXNzaW9uLmgKQEAgLTU4LDcgKzU4LDcg QEAgcHVibGljOgogICAgIHZvaWQgc2V0U3RyZWFtU2Vzc2lvbihBVlN0cmVhbVNlc3Npb24qKTsK IAogcHJvdGVjdGVkOgotICAgIFBhc3NSZWZQdHI8VWludDhBcnJheT4gZ2VuZXJhdGVLZXlSZWxl YXNlTWVzc2FnZSh1bnNpZ25lZCBzaG9ydCYgZXJyb3JDb2RlLCB1aW50MzJfdCBzeXN0ZW1Db2Rl KTsKKyAgICBQYXNzUmVmUHRyPFVpbnQ4QXJyYXk+IGdlbmVyYXRlS2V5UmVsZWFzZU1lc3NhZ2Uo dW5zaWduZWQgc2hvcnQmIGVycm9yQ29kZSwgdWludDMyX3QmIHN5c3RlbUNvZGUpOwogCiAgICAg V2Vha1B0ckZhY3Rvcnk8Q0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbj4gbV93ZWFrUHRyRmFjdG9y eTsKICAgICBSZXRhaW5QdHI8QVZTdHJlYW1TZXNzaW9uPiBtX3N0cmVhbVNlc3Npb247CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9DRE1TZXNzaW9uQVZTdHJlYW1TZXNzaW9uLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvQ0RNU2Vzc2lvbkFWU3RyZWFtU2Vzc2lvbi5tbQpp bmRleCA2N2ZiY2VhLi41Y2RmNGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9DRE1TZXNzaW9uQVZTdHJlYW1TZXNzaW9uLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L0NETVNlc3Npb25BVlN0cmVhbVNlc3Npb24ubW0KQEAgLTMwMyw3ICszMDMsNyBAQCB2b2lkIENE TVNlc3Npb25BVlN0cmVhbVNlc3Npb246OnJlbW92ZVBhcnNlcihBVlN0cmVhbURhdGFQYXJzZXIq IHBhcnNlcikKICAgICAgICAgW21fc3RyZWFtU2Vzc2lvbiByZW1vdmVTdHJlYW1EYXRhUGFyc2Vy OnBhcnNlcl07CiB9CiAKLVBhc3NSZWZQdHI8VWludDhBcnJheT4gQ0RNU2Vzc2lvbkFWU3RyZWFt U2Vzc2lvbjo6Z2VuZXJhdGVLZXlSZWxlYXNlTWVzc2FnZSh1bnNpZ25lZCBzaG9ydCYgZXJyb3JD b2RlLCB1aW50MzJfdCBzeXN0ZW1Db2RlKQorUGFzc1JlZlB0cjxVaW50OEFycmF5PiBDRE1TZXNz aW9uQVZTdHJlYW1TZXNzaW9uOjpnZW5lcmF0ZUtleVJlbGVhc2VNZXNzYWdlKHVuc2lnbmVkIHNo b3J0JiBlcnJvckNvZGUsIHVpbnQzMl90JiBzeXN0ZW1Db2RlKQogewogICAgIEFTU0VSVChtX21v ZGUgPT0gS2V5UmVsZWFzZSk7CiAgICAgbV9jZXJ0aWZpY2F0ZSA9IG1faW5pdERhdGE7Cg==