161590 2016-09-04 20:09:37 -0700 [GTK] Layout test editing/inserting/typing-space-to-trigger-smart-link.html fails 2016-09-22 10:59:30 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=85463 https://bugs.webkit.org/show_bug.cgi?id=162081 https://bugs.webkit.org/show_bug.cgi?id=161919 P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply jbedard mcatanzaro rniwa oldest_to_newest 1226335 0 mcatanzaro 2016-09-04 20:09:37 -0700 Layout test editing/inserting/typing-space-to-trigger-smart-link.html has been failing since it was unskipped in r205094 ("WTR needs an implementation of setAutomaticLinkDetectionEnabled"): --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-actual.txt @@ -1,4 +1,4 @@ The www.foo.com should be underlined and there is an anchor node created for it. The www.bar.com should be underlined and there is an anchor node created for it. -PASS: the anchor for 'www.foo.com' has been created. -PASS: the anchor for 'www.bar.com' has been created. +Failed: the expected content was 'The <a href="http://www.foo.com">www.foo.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.foo.com should be underlined and there is an anchor node created for it.'. +Failed: the expected content was 'The <a href="http://www.bar.com">www.bar.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.bar.com should be underlined and there is an anchor node created for it.'. Obviously the link is missing. Updating expectations accordingly. 1230560 1 rniwa 2016-09-16 13:12:10 -0700 GTK+ port doesn't enable smart space, right? So I think we just need to skip the test. 1230561 2 rniwa 2016-09-16 13:12:22 -0700 Sorry, I meant to say smart link. 1230568 3 jbedard 2016-09-16 13:22:13 -0700 Yes, I was closing this bug and noting so when our comments collided. This is caused by a failure to call setAuomaticLinkDetection. However, setAutomaticLinkDetection is an AppKit specific feature. This test should not run on GTK. 1230572 4 mcatanzaro 2016-09-16 13:32:41 -0700 (In reply to comment #3) > Yes, I was closing this bug and noting so when our comments collided. > > This is caused by a failure to call setAuomaticLinkDetection. However, > setAutomaticLinkDetection is an AppKit specific feature. This test should > not run on GTK. Then Ryosuke is right, we need to skip it! 1230583 5 jbedard 2016-09-16 13:41:10 -0700 (In reply to comment #4) > Then Ryosuke is right, we need to skip it! > ... https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change shortly, along with skipping this class of test on iOS, EFL and Windows. 1230731 6 mcatanzaro 2016-09-16 18:02:41 -0700 (In reply to comment #5) > (In reply to comment #4) > > Then Ryosuke is right, we need to skip it! > > ... > > https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change > shortly, along with skipping this class of test on iOS, EFL and Windows. Thanks. Since it's macOS specific, you might skip it in the global test expectations, and add a Pass expectation in the macOS file.