161585 2016-09-04 19:41:57 -0700 [GTK] Layout test accessibility/media-emits-object-replacement.html fails 2016-09-07 10:14:57 -0700 1 1 1 Unclassified WebKit Accessibility Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro webkit-unassigned commit-queue jdiggs mcatanzaro n_wang webkit-bug-importer oldest_to_newest 1226329 0 mcatanzaro 2016-09-04 19:41:57 -0700 Layout test accessibility/media-emits-object-replacement.html has been broken since it was modified in r203913 ("AX: Media controls accessibility improvement): --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-actual.txt @@ -6,14 +6,14 @@ AXRole: AXSection AXValue: a <obj> b AXRole: AXVideo AXRole: AXToolbar - AXRole: AXCheckBox + AXRole: AXButton AXRole: AXSlider AXRole: AXTimer AXValue: 00:00 AXRole: AXSection AXValue: <\n> AXRole: AXSection AXValue: a <obj> b AXRole: AXAudio AXRole: AXToolbar - AXRole: AXCheckBox + AXRole: AXButton AXRole: AXSlider AXRole: AXTimer AXValue: 00:00 AXRole: AXSection AXValue: End of test Updating expectations accordingly. 1226330 1 webkit-bug-importer 2016-09-04 19:42:10 -0700 <rdar://problem/28157032> 1226939 2 288068 n_wang 2016-09-06 17:03:02 -0700 Created attachment 288068 Patch 1226947 3 mcatanzaro 2016-09-06 17:11:55 -0700 Thanks, I didn't realize we just needed to update the expected results file. The patch should remove the failure expectation in LayoutTests/platform/gtk/TestExpectations as well. 1226954 4 288071 n_wang 2016-09-06 17:21:30 -0700 Created attachment 288071 Updated patch Remove the failure expectation in TestExpectations 1227239 5 288071 commit-queue 2016-09-07 10:14:54 -0700 Comment on attachment 288071 Updated patch Clearing flags on attachment: 288071 Committed r205553: <http://trac.webkit.org/changeset/205553> 1227240 6 commit-queue 2016-09-07 10:14:57 -0700 All reviewed patches have been landed. Closing bug. 288068 2016-09-06 17:03:02 -0700 2016-09-06 17:21:30 -0700 Patch patch.txt text/plain 1696 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNTUyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTA2ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgW0dUS10gTGF5b3V0IHRlc3QgYWNjZXNzaWJpbGl0eS9t ZWRpYS1lbWl0cy1vYmplY3QtcmVwbGFjZW1lbnQuaHRtbCBmYWlscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNTg1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yODE1NzAzMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVcGRhdGVkIHRoZSB0ZXN0IGV4cGVjdGF0aW9uLgorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVkaWEtZW1pdHMtb2JqZWN0LXJlcGxhY2VtZW50LWV4 cGVjdGVkLnR4dDoKKwogMjAxNi0wOS0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgogCiAgICAgICAgIFN0cmlrZXRocm91Z2ggcG9zaXRpb25zIGFyZSBlcnJvbmVv dXNseSBzbmFwcGVkIHR3aWNlCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNz aWJpbGl0eS9tZWRpYS1lbWl0cy1vYmplY3QtcmVwbGFjZW1lbnQtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L21lZGlhLWVt aXRzLW9iamVjdC1yZXBsYWNlbWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIwNTUyMikKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L21lZGlhLWVtaXRzLW9iamVj dC1yZXBsYWNlbWVudC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTYsMTQgKzYsMTQg QEAgQVhSb2xlOiBBWFdlYkFyZWEgCiAgICAgQVhSb2xlOiBBWFNlY3Rpb24gQVhWYWx1ZTogYSA8 b2JqPiBiCiAgICAgICAgIEFYUm9sZTogQVhWaWRlbyAKICAgICAgICAgICAgIEFYUm9sZTogQVhU b29sYmFyIAotICAgICAgICAgICAgICAgIEFYUm9sZTogQVhDaGVja0JveCAKKyAgICAgICAgICAg ICAgICBBWFJvbGU6IEFYQnV0dG9uIAogICAgICAgICAgICAgICAgIEFYUm9sZTogQVhTbGlkZXIg CiAgICAgICAgICAgICAgICAgQVhSb2xlOiBBWFRpbWVyIEFYVmFsdWU6IDAwOjAwCiAgICAgQVhS b2xlOiBBWFNlY3Rpb24gQVhWYWx1ZTogPFxuPgogICAgIEFYUm9sZTogQVhTZWN0aW9uIEFYVmFs dWU6IGEgPG9iaj4gYgogICAgICAgICBBWFJvbGU6IEFYQXVkaW8gCiAgICAgICAgICAgICBBWFJv bGU6IEFYVG9vbGJhciAKLSAgICAgICAgICAgICAgICBBWFJvbGU6IEFYQ2hlY2tCb3ggCisgICAg ICAgICAgICAgICAgQVhSb2xlOiBBWEJ1dHRvbiAKICAgICAgICAgICAgICAgICBBWFJvbGU6IEFY U2xpZGVyIAogICAgICAgICAgICAgICAgIEFYUm9sZTogQVhUaW1lciBBWFZhbHVlOiAwMDowMAog ICAgIEFYUm9sZTogQVhTZWN0aW9uIEFYVmFsdWU6IEVuZCBvZiB0ZXN0Cg== 288071 2016-09-06 17:21:30 -0700 2016-09-07 10:14:54 -0700 Updated patch patch.txt text/plain 2412 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNTUyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTA2ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgW0dUS10gTGF5b3V0IHRlc3QgYWNjZXNzaWJpbGl0eS9t ZWRpYS1lbWl0cy1vYmplY3QtcmVwbGFjZW1lbnQuaHRtbCBmYWlscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNTg1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yODE1NzAzMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVcGRhdGVkIHRoZSB0ZXN0IGV4cGVjdGF0aW9uLgorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVkaWEtZW1pdHMtb2JqZWN0LXJlcGxhY2VtZW50LWV4 cGVjdGVkLnR4dDoKKwogMjAxNi0wOS0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgogCiAgICAgICAgIFN0cmlrZXRocm91Z2ggcG9zaXRpb25zIGFyZSBlcnJvbmVv dXNseSBzbmFwcGVkIHR3aWNlCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucwkocmV2aXNpb24gMjA1NTIyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTI2MDksNyArMjYwOSw2IEBAIHdl YmtpdC5vcmcvYi8xNjAyNTEgZmFzdC90ZXh0L2ZvbnQta2VybmkKIAogd2Via2l0Lm9yZy9iLzE2 MTU4MyBhY2Nlc3NpYmlsaXR5L2F1dG8tZmlsbC10eXBlcy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJr aXQub3JnL2IvMTYxNTg0IGFjY2Vzc2liaWxpdHkvY2hpbGRyZW4tY2hhbmdlZC1zZW5kcy1ub3Rp ZmljYXRpb24uaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2MTU4NSBhY2Nlc3NpYmls aXR5L21lZGlhLWVtaXRzLW9iamVjdC1yZXBsYWNlbWVudC5odG1sIFsgRmFpbHVyZSBdCiAKIHdl YmtpdC5vcmcvYi8xNjE1ODcgY3NzMy9mb250LWZlYXR1cmUtc2V0dGluZ3MtcmVuZGVyaW5nLmh0 bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjE1ODggY3NzMy9mb250LXZh cmlhbnQtc3ludGhlc2lzLWpkYWdnZXR0Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L21lZGlhLWVtaXRzLW9iamVj dC1yZXBsYWNlbWVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVkaWEtZW1pdHMtb2JqZWN0LXJlcGxhY2VtZW50LWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMjA1NTIyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvbWVkaWEtZW1pdHMtb2JqZWN0LXJlcGxhY2VtZW50LWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtNiwxNCArNiwxNCBAQCBBWFJvbGU6IEFYV2ViQXJlYSAKICAg ICBBWFJvbGU6IEFYU2VjdGlvbiBBWFZhbHVlOiBhIDxvYmo+IGIKICAgICAgICAgQVhSb2xlOiBB WFZpZGVvIAogICAgICAgICAgICAgQVhSb2xlOiBBWFRvb2xiYXIgCi0gICAgICAgICAgICAgICAg QVhSb2xlOiBBWENoZWNrQm94IAorICAgICAgICAgICAgICAgIEFYUm9sZTogQVhCdXR0b24gCiAg ICAgICAgICAgICAgICAgQVhSb2xlOiBBWFNsaWRlciAKICAgICAgICAgICAgICAgICBBWFJvbGU6 IEFYVGltZXIgQVhWYWx1ZTogMDA6MDAKICAgICBBWFJvbGU6IEFYU2VjdGlvbiBBWFZhbHVlOiA8 XG4+CiAgICAgQVhSb2xlOiBBWFNlY3Rpb24gQVhWYWx1ZTogYSA8b2JqPiBiCiAgICAgICAgIEFY Um9sZTogQVhBdWRpbyAKICAgICAgICAgICAgIEFYUm9sZTogQVhUb29sYmFyIAotICAgICAgICAg ICAgICAgIEFYUm9sZTogQVhDaGVja0JveCAKKyAgICAgICAgICAgICAgICBBWFJvbGU6IEFYQnV0 dG9uIAogICAgICAgICAgICAgICAgIEFYUm9sZTogQVhTbGlkZXIgCiAgICAgICAgICAgICAgICAg QVhSb2xlOiBBWFRpbWVyIEFYVmFsdWU6IDAwOjAwCiAgICAgQVhSb2xlOiBBWFNlY3Rpb24gQVhW YWx1ZTogRW5kIG9mIHRlc3QK