161565 2016-09-02 20:16:57 -0700 Web Inspector: Address ESLint undefined variable errors in UserInterface/Views 2016-09-03 07:40:36 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1226079 0 joepeck 2016-09-02 20:16:57 -0700 Address ESLint undefined variable errors in UserInterface/Views: Source/WebInspectorUI/UserInterface/Views/DataGrid.js 873:19 error 'identifier' is defined but never used no-unused-vars 875:20 error 'columnIdentifier' is not defined no-undef Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 1018:50 error 'breakpoint' is not defined no-undef Source/WebInspectorUI/UserInterface/Views/TextContentView.js 154:13 error 'activated' is defined but never used no-unused-vars 155:47 error 'formatted' is not defined no-undef Real issues that would cause runtime exceptions. 1226080 1 287851 joepeck 2016-09-02 20:17:38 -0700 Created attachment 287851 [PATCH] Proposed Fix 1226124 2 287851 commit-queue 2016-09-03 07:40:33 -0700 Comment on attachment 287851 [PATCH] Proposed Fix Clearing flags on attachment: 287851 Committed r205401: <http://trac.webkit.org/changeset/205401> 1226125 3 commit-queue 2016-09-03 07:40:36 -0700 All reviewed patches have been landed. Closing bug. 287851 2016-09-02 20:17:38 -0700 2016-09-03 07:40:33 -0700 [PATCH] Proposed Fix eslint-4.patch text/plain 3155 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE0YWYxYWQuLmM1MjRhMjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTA5LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkcmVz cyBFU0xpbnQgdW5kZWZpbmVkIHZhcmlhYmxlIGVycm9ycyBpbiBVc2VySW50ZXJmYWNlL1ZpZXdz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NjUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdy aWQucHJvdG90eXBlLmNvbHVtbldpZHRoc01hcCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3Vy Y2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUudGV4dEVkaXRvckd1dHRlckNvbnRleHRNZW51KToK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRDb250ZW50Vmlldy5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0Q29udGVudFZpZXcucHJvdG90eXBlLl90b2dnbGVQcmV0dHlQ cmludCk6CisKKzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSdW4gRVNMaW50IG92ZXIgVXNlckludGVyZmFj ZS9WaWV3cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYxNTY0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGF0YUdyaWQuanMKaW5kZXggMTYxMGQzYi4uMGVmMjc4OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKQEAg LTg3Miw3ICs4NzIsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBl eHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgIHZhciByZXN1bHQgPSB7fTsKICAgICAg ICAgZm9yICh2YXIgW2lkZW50aWZpZXIsIGNvbHVtbl0gb2YgdGhpcy5jb2x1bW5zKSB7CiAgICAg ICAgICAgICB2YXIgd2lkdGggPSB0aGlzLl9oZWFkZXJUYWJsZUNvbHVtbkdyb3VwRWxlbWVudC5j aGlsZHJlbltjb2x1bW5bIm9yZGluYWwiXV0uc3R5bGUud2lkdGg7Ci0gICAgICAgICAgICByZXN1 bHRbY29sdW1uSWRlbnRpZmllcl0gPSBwYXJzZUZsb2F0KHdpZHRoKTsKKyAgICAgICAgICAgIHJl c3VsdFtpZGVudGlmaWVyXSA9IHBhcnNlRmxvYXQod2lkdGgpOwogICAgICAgICB9CiAgICAgICAg IHJldHVybiByZXN1bHQ7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwpp bmRleCAzMWZlNjQ3Li45N2ZhMzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5q cwpAQCAtMTAxNSw3ICsxMDE1LDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9y ID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAg ICAgIGlmICghV2ViSW5zcGVjdG9yLmlzU2hvd2luZ0RlYnVnZ2VyVGFiKCkpIHsKICAgICAgICAg ICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKICAgICAgICAgICAgICAgICBj b250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmV2ZWFsIGluIERl YnVnZ2VyIFRhYiIpLCAoKSA9PiB7Ci0gICAgICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5z aG93RGVidWdnZXJUYWIoYnJlYWtwb2ludCk7CisgICAgICAgICAgICAgICAgICAgIFdlYkluc3Bl Y3Rvci5zaG93RGVidWdnZXJUYWIoYnJlYWtwb2ludHNbMF0pOwogICAgICAgICAgICAgICAgIH0p OwogICAgICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UZXh0Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0Q29udGVudFZpZXcuanMKaW5kZXggMDE0ZDUyNy4u Yzk4ZDUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGV4dENvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RleHRDb250ZW50Vmlldy5qcwpAQCAtMTUyLDcgKzE1Miw3IEBAIFdl Ykluc3BlY3Rvci5UZXh0Q29udGVudFZpZXcgPSBjbGFzcyBUZXh0Q29udGVudFZpZXcgZXh0ZW5k cyBXZWJJbnNwZWN0b3IuQ29udGVuCiAgICAgX3RvZ2dsZVByZXR0eVByaW50KGV2ZW50KQogICAg IHsKICAgICAgICAgdmFyIGFjdGl2YXRlZCA9ICF0aGlzLl9wcmV0dHlQcmludEJ1dHRvbk5hdmln YXRpb25JdGVtLmFjdGl2YXRlZDsKLSAgICAgICAgdGhpcy5fdGV4dEVkaXRvci51cGRhdGVGb3Jt YXR0ZWRTdGF0ZShmb3JtYXR0ZWQpOworICAgICAgICB0aGlzLl90ZXh0RWRpdG9yLnVwZGF0ZUZv cm1hdHRlZFN0YXRlKGFjdGl2YXRlZCk7CiAgICAgfQogCiAgICAgX3RleHRFZGl0b3JGb3JtYXR0 aW5nRGlkQ2hhbmdlKGV2ZW50KQo=