161563 2016-09-02 19:26:41 -0700 Web Inspector: Address ESLint undefined variable errors 2016-09-03 07:42:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1226073 0 joepeck 2016-09-02 19:26:41 -0700 Address ESLint undefined variable errors: Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js 86:65 error 'origin' is not defined no-undef Source/WebInspectorUI/UserInterface/Models/IssueMessage.js 73:52 error 'source' is not defined no-undef Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js 586:169 error 'args' is not defined no-undef These are all legit errors. Fortunately there are in handling error conditions that shouldn't be reached! 1226074 1 287849 joepeck 2016-09-02 19:27:20 -0700 Created attachment 287849 [PATCH] Proposed Fix 1226075 2 commit-queue 2016-09-02 19:29:10 -0700 Attachment 287849 did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:586: Line contains single-quote character. [js/syntax] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1226127 3 287849 commit-queue 2016-09-03 07:42:32 -0700 Comment on attachment 287849 [PATCH] Proposed Fix Clearing flags on attachment: 287849 Committed r205402: <http://trac.webkit.org/changeset/205402> 1226128 4 commit-queue 2016-09-03 07:42:35 -0700 All reviewed patches have been landed. Closing bug. 287849 2016-09-02 19:27:20 -0700 2016-09-03 07:42:32 -0700 [PATCH] Proposed Fix eslint-2.patch text/plain 6660 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOTdmYTMyLi4zYmZlY2UxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDkt MDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBZGRyZXNzIEVTTGludCB1bmRlZmluZWQgdmFyaWFibGUgZXJyb3JzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9w cm90b2NvbC9pbnNwZWN0b3ItYmFja2VuZC1pbnZvY2F0aW9uLXJldHVybi12YWx1ZS1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3Byb3RvY29sL2luc3BlY3Rvci1iYWNrZW5kLWlu dm9jYXRpb24tcmV0dXJuLXZhbHVlLmh0bWw6CisKIDIwMTYtMDktMDIgIEVyaWMgQ2FybHNvbiAg PGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhU3RyZWFtXSBhcHBseUNv bnN0cmFpbnRzIHB0LiAxIC0gbWFuZGF0b3J5IGNvbnN0cmFpbnRzCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvcHJvdG9jb2wvaW5zcGVjdG9yLWJhY2tlbmQtaW52b2NhdGlvbi1y ZXR1cm4tdmFsdWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb3RvY29s L2luc3BlY3Rvci1iYWNrZW5kLWludm9jYXRpb24tcmV0dXJuLXZhbHVlLWV4cGVjdGVkLnR4dApp bmRleCBlYTFiNjI3Li45MjM1M2I4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv cHJvdG9jb2wvaW5zcGVjdG9yLWJhY2tlbmQtaW52b2NhdGlvbi1yZXR1cm4tdmFsdWUtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wcm90b2NvbC9pbnNwZWN0b3ItYmFj a2VuZC1pbnZvY2F0aW9uLXJldHVybi12YWx1ZS1leHBlY3RlZC50eHQKQEAgLTE2LDYgKzE2LDEx IEBAIEVSUk9SOiBQcm90b2NvbCBFcnJvcjogSW52YWxpZCBudW1iZXIgb2YgYXJndW1lbnRzIGZv ciBjb21tYW5kICdSdW50aW1lLmV2YWx1YXRlCiBQQVNTOiBBIGJhY2tlbmQgY29tbWFuZCBzaG91 bGQgcmV0dXJuIGEgUHJvbWlzZSB3aGVuIGludm9rZWQgd2l0aG91dCBhIGNhbGxiYWNrLgogUEFT UzogQW4gaW52YWxpZCBjb21tYW5kIGludm9jYXRpb24ncyBwcm9taXNlIHNob3VsZCBiZSByZWpl Y3RlZC4KIAorLS0gUnVubmluZyB0ZXN0IGNhc2U6IFJlamVjdENvbW1hbmRQcm9taXNlV2l0aEV4 dHJhQXJndW1lbnRUaGF0SXNOb3RDYWxsYmFjaworRVJST1I6IFByb3RvY29sIEVycm9yOiBQcm90 b2NvbCBFcnJvcjogT3B0aW9uYWwgY2FsbGJhY2sgYXJndW1lbnQgZm9yIGNvbW1hbmQgJ1J1bnRp bWUuZW5hYmxlJyBjYWxsIG11c3QgYmUgYSBmdW5jdGlvbiBidXQgaXRzIHR5cGUgaXMgJ251bWJl cicuCitQQVNTOiBBIGJhY2tlbmQgY29tbWFuZCBzaG91bGQgcmV0dXJuIGEgUHJvbWlzZSB3aGVu IGludm9rZWQgd2l0aG91dCBhIGNhbGxiYWNrLgorUEFTUzogQW4gaW52YWxpZCBjb21tYW5kIGlu dm9jYXRpb24ncyBwcm9taXNlIHNob3VsZCBiZSByZWplY3RlZC4KKwogLS0gUnVubmluZyB0ZXN0 IGNhc2U6IFJldHVybk5vdGhpbmdJZkNhbGxiYWNrCiBQQVNTOiBBIGJhY2tlbmQgY29tbWFuZCBz aG91bGQgbm90IGhhdmUgYSByZXR1cm4gdmFsdWUgd2hlbiBpbnZva2VkIHdpdGggYSBjYWxsYmFj ay4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb3RvY29sL2luc3BlY3Rv ci1iYWNrZW5kLWludm9jYXRpb24tcmV0dXJuLXZhbHVlLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvcHJvdG9jb2wvaW5zcGVjdG9yLWJhY2tlbmQtaW52b2NhdGlvbi1yZXR1cm4tdmFsdWUu aHRtbAppbmRleCAwNzg5ODMxLi42ZjllOTBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvcHJvdG9jb2wvaW5zcGVjdG9yLWJhY2tlbmQtaW52b2NhdGlvbi1yZXR1cm4tdmFsdWUu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvdG9jb2wvaW5zcGVjdG9yLWJhY2tl bmQtaW52b2NhdGlvbi1yZXR1cm4tdmFsdWUuaHRtbApAQCAtNzMsNiArNzMsMjcgQEAgZnVuY3Rp b24gdGVzdCgpCiAgICAgICAgIH0KICAgICB9KTsKIAorICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsK KyAgICAgICAgbmFtZTogIlJlamVjdENvbW1hbmRQcm9taXNlV2l0aEV4dHJhQXJndW1lbnRUaGF0 SXNOb3RDYWxsYmFjayIsCisgICAgICAgIGRlc2NyaXB0aW9uOiAiQmFja2VuZCBjb21tYW5kJ3Mg cmV0dXJuZWQgcHJvbWlzZSBzaG91bGQgYmUgcmVqZWN0ZWQgaWYgdGhlIGNvbW1hbmQgaGFzIGFu IGV4dHJhIGFyZ3VtZW50IHRoYXQgaXMgbm90IGEgY2FsbGJhY2suIiwKKyAgICAgICAgdGVzdDog KHJlc29sdmUsIHJlamVjdCkgPT4geworICAgICAgICAgICAgbGV0IHJlc3VsdCA9IFJ1bnRpbWVB Z2VudC5lbmFibGUoMSk7CisKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChy ZXN1bHQgaW5zdGFuY2VvZiBQcm9taXNlLCAiQSBiYWNrZW5kIGNvbW1hbmQgc2hvdWxkIHJldHVy biBhIFByb21pc2Ugd2hlbiBpbnZva2VkIHdpdGhvdXQgYSBjYWxsYmFjay4iKTsKKyAgICAgICAg ICAgIC8vIElmIGEgcHJvbWlzZSB3YXNuJ3QgcmV0dXJuZWQsIHdlIGNhbid0IHRlc3QgdGhlIHJl c3Qgc28ganVzdCBkaWUuCisgICAgICAgICAgICBpZiAoIShyZXN1bHQgaW5zdGFuY2VvZiBQcm9t aXNlKSkKKyAgICAgICAgICAgICAgICByZWplY3QoKTsKKworICAgICAgICAgICAgcmVzdWx0LnRo ZW4oZnVuY3Rpb24gcmVzb2x2ZWQocmVzdWx0KSB7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5sb2coIkZBSUw6IEFuIGludmFsaWQgY29tbWFuZCBpbnZvY2F0aW9uJ3MgcHJvbWlzZSBz aG91bGQgYmUgcmVqZWN0ZWQuIik7CisgICAgICAgICAgICAgICAgcmVqZWN0KCk7CisgICAgICAg ICAgICB9LCBmdW5jdGlvbiByZWplY3RlZChyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmxvZygiUEFTUzogQW4gaW52YWxpZCBjb21tYW5kIGludm9jYXRpb24ncyBwcm9t aXNlIHNob3VsZCBiZSByZWplY3RlZC4iKTsKKyAgICAgICAgICAgICAgICByZXNvbHZlKCk7Cisg ICAgICAgICAgICB9KTsKKyAgICAgICAgfQorICAgIH0pOworCiAgICAgLy8gVGVzdCBiZWhhdmlv ciBmb3IgZnVuY3Rpb24tYmFzZWQgY2FsbGJhY2tzLgogCiAgICAgc3VpdGUuYWRkVGVzdENhc2Uo ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggYjAwZjM1ZS4uYmYxODY1MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTYtMDktMDIgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGRy ZXNzIEVTTGludCB1bmRlZmluZWQgdmFyaWFibGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv Q1NTU3R5bGVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlTWFuYWdl ci5wcm90b2NvbE1lZGlhU291cmNlVG9FbnVtKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01v ZGVscy9Jc3N1ZU1lc3NhZ2UuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSXNzdWVNZXNzYWdl KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanM6 CisKKzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBVcGRhdGUgRVNMaW50IHJ1bGVzIGFuZCBydW4gaXQgb3Zl ciBtb3N0IG9mIFVzZXJJbnRlcmZhY2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MTU2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DU1NTdHlsZU1hbmFnZXIuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9DU1NTdHlsZU1hbmFnZXIu anMKaW5kZXggMjc4NDQzZi4uZWFiMGM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ1NTU3R5bGVNYW5hZ2VyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NTU1N0eWxlTWFu YWdlci5qcwpAQCAtODMsNyArODMsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVNYW5hZ2VyID0g Y2xhc3MgQ1NTU3R5bGVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAg ICBjYXNlIENTU0FnZW50LkNTU01lZGlhU291cmNlLklubGluZVNoZWV0OgogICAgICAgICAgICAg cmV0dXJuIFdlYkluc3BlY3Rvci5DU1NNZWRpYS5UeXBlLklubGluZVN0eWxlU2hlZXQ7CiAgICAg ICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBjb25zb2xlLmFzc2VydChmYWxzZSwgIlVua25vd24g Q1NTLkNTU01lZGlhU291cmNlIiwgb3JpZ2luKTsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0 KGZhbHNlLCAiVW5rbm93biBDU1MuQ1NTTWVkaWFTb3VyY2UiLCBzb3VyY2UpOwogICAgICAgICAg ICAgcmV0dXJuIFdlYkluc3BlY3Rvci5DU1NNZWRpYS5UeXBlLk1lZGlhUnVsZTsKICAgICAgICAg fQogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9Jc3N1ZU1lc3NhZ2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvSXNzdWVNZXNzYWdlLmpzCmluZGV4IDJiNDJmYTkuLjQzYWNkNzMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Jc3N1ZU1l c3NhZ2UuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0lzc3VlTWVzc2FnZS5qcwpAQCAtNzAsNyArNzAsNyBAQCBXZWJJbnNwZWN0b3IuSXNzdWVNZXNz YWdlID0gY2xhc3MgSXNzdWVNZXNzYWdlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGNvbnNvbGUu ZXJyb3IoIlVua25vd24gaXNzdWUgc291cmNlOiIsIHNvdXJjZSk7CisgICAgICAgICAgICBjb25z b2xlLmVycm9yKCJVbmtub3duIGlzc3VlIHNvdXJjZToiLCB0aGlzLl9jb25zb2xlTWVzc2FnZS5z b3VyY2UpOwogICAgICAgICAgICAgdGhpcy5fdHlwZSA9IFdlYkluc3BlY3Rvci5Jc3N1ZU1lc3Nh Z2UuVHlwZS5PdGhlcklzc3VlOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNr ZW5kLmpzCmluZGV4IGI1ZmZiZTQuLjUxMzE1NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFj a2VuZC5qcwpAQCAtNTgzLDcgKzU4Myw3IEBAIEluc3BlY3RvckJhY2tlbmQuQ29tbWFuZC5wcm90 b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIWNhbGxiYWNrICYmIGNvbW1hbmRB cmd1bWVudHMubGVuZ3RoID09PSAxICYmIGNvbW1hbmRBcmd1bWVudHNbMF0gIT09IHVuZGVmaW5l ZCkKLSAgICAgICAgICAgIHJldHVybiBkZWxpdmVyRmFpbHVyZShgUHJvdG9jb2wgRXJyb3I6IE9w dGlvbmFsIGNhbGxiYWNrIGFyZ3VtZW50IGZvciBjb21tYW5kICcke2luc3RhbmNlLnF1YWxpZmll ZE5hbWV9JyBjYWxsIG11c3QgYmUgYSBmdW5jdGlvbiBidXQgaXRzIHR5cGUgaXMgJyR7dHlwZW9m IGFyZ3NbMF19Jy5gKTsKKyAgICAgICAgICAgIHJldHVybiBkZWxpdmVyRmFpbHVyZShgUHJvdG9j b2wgRXJyb3I6IE9wdGlvbmFsIGNhbGxiYWNrIGFyZ3VtZW50IGZvciBjb21tYW5kICcke2luc3Rh bmNlLnF1YWxpZmllZE5hbWV9JyBjYWxsIG11c3QgYmUgYSBmdW5jdGlvbiBidXQgaXRzIHR5cGUg aXMgJyR7dHlwZW9mIGNvbW1hbmRBcmd1bWVudHNbMF19Jy5gKTsKIAogICAgICAgICBpZiAoY2Fs bGJhY2spCiAgICAgICAgICAgICBpbnN0YW5jZS5fYmFja2VuZC5fc2VuZENvbW1hbmRUb0JhY2tl bmRXaXRoQ2FsbGJhY2soaW5zdGFuY2UsIHBhcmFtZXRlcnMsIGNhbGxiYWNrKTsK