161562 2016-09-02 19:00:45 -0700 Unbreak customElements.whenDefined after r205383 with a crash fix 2016-09-03 16:27:50 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 154907 1 rniwa rniwa cdumez commit-queue dbates esprehn+autocc ggaren kangil.han kling koivisto webkit-bug-importer ysuzuki oldest_to_newest 1226066 0 rniwa 2016-09-02 19:00:45 -0700 Fix whenDefined with a crash fix after https://trac.webkit.org/changeset/205383. 1226067 1 webkit-bug-importer 2016-09-02 19:01:43 -0700 <rdar://problem/28146962> 1226071 2 287848 rniwa 2016-09-02 19:10:18 -0700 Created attachment 287848 Reverts r205383 and fixes the crash 1226184 3 287848 rniwa 2016-09-03 16:06:35 -0700 Comment on attachment 287848 Reverts r205383 and fixes the crash Thanks for the review! I'll monitor https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FAttr%2Faccess-after-element-destruction.html to make sure this doesn't reintroduce the crash. 1226187 4 287848 commit-queue 2016-09-03 16:27:43 -0700 Comment on attachment 287848 Reverts r205383 and fixes the crash Clearing flags on attachment: 287848 Committed r205410: <http://trac.webkit.org/changeset/205410> 1226188 5 commit-queue 2016-09-03 16:27:50 -0700 All reviewed patches have been landed. Closing bug. 287848 2016-09-02 19:10:18 -0700 2016-09-03 16:27:43 -0700 Reverts r205383 and fixes the crash bug-161562-20160902190801.patch text/plain 6737 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTM4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTA5LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFVuYnJlYWsgY3VzdG9tRWxlbWVu dHMud2hlbkRlZmluZWQgYWZ0ZXIgcjIwNTM4MyB3aXRoIGEgY3Jhc2ggZml4CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NjIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggd2FzIGNhdXNl ZCBieSBEZWZlcnJlZFdyYXBwZXI6OmNvbnRleHREZXN0cm95ZWQgbm90IGNhbGxpbmcgQ29udGV4 dERlc3RydWN0aW9uT2JzZXJ2ZXI6OmNvbnRleHREZXN0cm95ZWQuCisKKyAgICAgICAgVGhpcyBj YXVzZWQgbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0IHRvIG5vdCBiZWluZyBzZXQgdG8gbnVsbHB0 ciB3aGVuIHRoZSBEb2N1bWVudCB3YXMgZGVzdHJveWVkIGJlZm9yZSBET01XaW5kb3cKKyAgICAg ICAgZHVyaW5nIGEgc2luZ2xlIEdDIHN3ZWVwaW5nLCBhbmQgcmVzdWx0ZWQgaW4gYSB1c2UtYWZ0 ZXItZnJlZSBpbiBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcidzIGRlc3RydWN0b3IuCisKKyAg ICAgICAgRml4ZWQgdGhlIGNyYXNoIGFuZCByZXZlcnRlZCByMjA1MzgzLgorCisgICAgICAgIFRl c3RzOiBmYXN0L2N1c3RvbS1lbGVtZW50cy9DdXN0b21FbGVtZW50UmVnaXN0cnkuaHRtbAorCisg ICAgICAgICogYmluZGluZ3MvanMvSlNDdXN0b21FbGVtZW50UmVnaXN0cnlDdXN0b20uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6d2hlbkRlZmluZWRQcm9taXNlKToKKyAgICAgICAgKiBiaW5kaW5n cy9qcy9KU0RPTVByb21pc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVmZXJyZWRXcmFwcGVy Ojpjb250ZXh0RGVzdHJveWVkKTogRml4ZWQgdGhlIGNyYXNoLgorICAgICAgICAqIGRvbS9DdXN0 b21FbGVtZW50UmVnaXN0cnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJl Z2lzdHJ5OjphZGRFbGVtZW50RGVmaW5pdGlvbik6CisgICAgICAgICogZG9tL0N1c3RvbUVsZW1l bnRSZWdpc3RyeS5oOgorICAgICAgICAoV2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJlZ2lzdHJ5Ojpw cm9taXNlTWFwKToKKwogMjAxNi0wOS0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBBZGQgdmFsaWRhdGlvbnMgZm9yIGEgc3luY2hyb25vdXNseSBjb25zdHJ1 Y3RlZCBjdXN0b20gZWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlND dXN0b21FbGVtZW50UmVnaXN0cnlDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5Q3VzdG9tLmNwcAkocmV2aXNp b24gMjA1Mzg2KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21FbGVtZW50 UmVnaXN0cnlDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODIsNyArMTgyLDExIEBAIHN0 YXRpYyBKU1ZhbHVlIHdoZW5EZWZpbmVkUHJvbWlzZShFeGVjU3QKICAgICAgICAgcmV0dXJuIGpz UHJvbWlzZS5wcm9taXNlKCk7CiAgICAgfQogCi0gICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Cisg ICAgYXV0byByZXN1bHQgPSByZWdpc3RyeS5wcm9taXNlTWFwKCkuZW5zdXJlKGxvY2FsTmFtZSwg WyZdIHsKKyAgICAgICAgcmV0dXJuIERlZmVycmVkV3JhcHBlcjo6Y3JlYXRlKCZzdGF0ZSwgJmds b2JhbE9iamVjdCwgSlNQcm9taXNlRGVmZXJyZWQ6OmNyZWF0ZSgmc3RhdGUsICZnbG9iYWxPYmpl Y3QpKTsKKyAgICB9KTsKKworICAgIHJldHVybiByZXN1bHQuaXRlcmF0b3ItPnZhbHVlLT5wcm9t aXNlKCk7CiB9CiAKIEpTVmFsdWUgSlNDdXN0b21FbGVtZW50UmVnaXN0cnk6OndoZW5EZWZpbmVk KEV4ZWNTdGF0ZSYgc3RhdGUpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RP TVByb21pc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NUHJvbWlzZS5jcHAJKHJldmlzaW9uIDIwNTM4NikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTRE9NUHJvbWlzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5LDYgKzU5LDcgQEAg dm9pZCBEZWZlcnJlZFdyYXBwZXI6OmNsZWFyKCkKIAogdm9pZCBEZWZlcnJlZFdyYXBwZXI6OmNv bnRleHREZXN0cm95ZWQoKQogeworICAgIEFjdGl2ZURPTUNhbGxiYWNrOjpjb250ZXh0RGVzdHJv eWVkKCk7CiAgICAgY2xlYXIoKTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0N1c3Rv bUVsZW1lbnRSZWdpc3RyeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0N1 c3RvbUVsZW1lbnRSZWdpc3RyeS5jcHAJKHJldmlzaW9uIDIwNTM4NikKKysrIFNvdXJjZS9XZWJD b3JlL2RvbS9DdXN0b21FbGVtZW50UmVnaXN0cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2 ICs3OCw5IEBAIHZvaWQgQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5OjphZGRFbGVtZW50RGUKIAogICAg IGlmIChhdXRvKiBkb2N1bWVudCA9IG1fd2luZG93LmRvY3VtZW50KCkpCiAgICAgICAgIGVucXVl dWVVcGdyYWRlSW5TaGFkb3dJbmNsdWRpbmdUcmVlT3JkZXIoKmRvY3VtZW50LCBlbGVtZW50SW50 ZXJmYWNlLmdldCgpKTsKKworICAgIGlmIChhdXRvIHByb21pc2UgPSBtX3Byb21pc2VNYXAudGFr ZShsb2NhbE5hbWUpKQorICAgICAgICBwcm9taXNlLnZhbHVlKCktPnJlc29sdmUobnVsbHB0cik7 CiB9CiAKIEpTQ3VzdG9tRWxlbWVudEludGVyZmFjZSogQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5Ojpm aW5kSW50ZXJmYWNlKGNvbnN0IEVsZW1lbnQmIGVsZW1lbnQpIGNvbnN0CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5oCShyZXZpc2lvbiAyMDUzODYpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LmgJKHdvcmtpbmcgY29w eSkKQEAgLTY2LDEyICs2NiwxNSBAQCBwdWJsaWM6CiAKICAgICBKU0M6OkpTVmFsdWUgZ2V0KGNv bnN0IEF0b21pY1N0cmluZyYpOwogCisgICAgSGFzaE1hcDxBdG9taWNTdHJpbmcsIFJlZjxEZWZl cnJlZFdyYXBwZXI+PiYgcHJvbWlzZU1hcCgpIHsgcmV0dXJuIG1fcHJvbWlzZU1hcDsgfQorCiBw cml2YXRlOgogICAgIEN1c3RvbUVsZW1lbnRSZWdpc3RyeShET01XaW5kb3cmKTsKIAogICAgIERP TVdpbmRvdyYgbV93aW5kb3c7CiAgICAgSGFzaE1hcDxBdG9taWNTdHJpbmcsIFJlZjxKU0N1c3Rv bUVsZW1lbnRJbnRlcmZhY2U+PiBtX25hbWVNYXA7CiAgICAgSGFzaE1hcDxjb25zdCBKU0M6OkpT T2JqZWN0KiwgSlNDdXN0b21FbGVtZW50SW50ZXJmYWNlKj4gbV9jb25zdHJ1Y3Rvck1hcDsKKyAg ICBIYXNoTWFwPEF0b21pY1N0cmluZywgUmVmPERlZmVycmVkV3JhcHBlcj4+IG1fcHJvbWlzZU1h cDsKIAogICAgIGJvb2wgbV9lbGVtZW50RGVmaW5pdGlvbklzUnVubmluZyB7IGZhbHNlIH07CiAK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNTM4NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA5LTAyICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFVuYnJlYWsgY3VzdG9tRWxlbWVudHMud2hlbkRl ZmluZWQgYWZ0ZXIgcjIwNTM4MyB3aXRoIGEgY3Jhc2ggZml4CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgcjIwNTM4MyBub3cgdGhhdCBhbGwg dGVzdCBjYXNlcyBwYXNzLgorCisgICAgICAgICogZmFzdC9jdXN0b20tZWxlbWVudHMvQ3VzdG9t RWxlbWVudFJlZ2lzdHJ5LWV4cGVjdGVkLnR4dDoKKwogMjAxNi0wOS0wMiAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgdmFsaWRhdGlvbnMgZm9yIGEgc3lu Y2hyb25vdXNseSBjb25zdHJ1Y3RlZCBjdXN0b20gZWxlbWVudApJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jdXN0b20tZWxlbWVudHMvQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2N1c3RvbS1lbGVtZW50cy9DdXN0b21FbGVt ZW50UmVnaXN0cnktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMDUzODYpCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2N1c3RvbS1lbGVtZW50cy9DdXN0b21FbGVtZW50UmVnaXN0cnktZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMSArMjksMTEgQEAgUEFTUyBDdXN0b21FbGVtZW50UmVn aXN0cnkgaW50ZXJmYWNlIG11cwogUEFTUyBjdXN0b21FbGVtZW50cy5nZXQgbXVzdCByZXR1cm4g dW5kZWZpbmVkIHdoZW4gdGhlIHJlZ2lzdHJ5IGRvZXMgbm90IGNvbnRhaW4gYW4gZW50cnkgd2l0 aCB0aGUgZ2l2ZW4gbmFtZSAKIFBBU1MgY3VzdG9tRWxlbWVudHMuZ2V0IG11c3QgcmV0dXJuIHVu ZGVmaW5lZCB3aGVuIHRoZSByZWdpc3RyeSBkb2VzIG5vdCBjb250YWluIGFuIGVudHJ5IHdpdGgg dGhlIGdpdmVuIG5hbWUgZXZlbiBpZiB0aGUgbmFtZSB3YXMgbm90IGEgdmFsaWQgY3VzdG9tIGVs ZW1lbnQgbmFtZSAKIFBBU1MgY3VzdG9tRWxlbWVudHMuZ2V0IHJldHVybiB0aGUgY29uc3RydWN0 b3Igb2YgdGhlIGVudHJ5IHdpdGggdGhlIGdpdmVuIG5hbWUgd2hlbiB0aGVyZSBpcyBhIG1hdGNo aW5nIGVudHJ5LiAKLUZBSUwgY3VzdG9tRWxlbWVudHMud2hlbkRlZmluZWQgbXVzdCByZXR1cm4g YSBwcm9taXNlIGZvciBhIHZhbGlkIGN1c3RvbSBlbGVtZW50IG5hbWUgYXNzZXJ0X3RydWU6IGV4 cGVjdGVkIHRydWUgZ290IGZhbHNlCitQQVNTIGN1c3RvbUVsZW1lbnRzLndoZW5EZWZpbmVkIG11 c3QgcmV0dXJuIGEgcHJvbWlzZSBmb3IgYSB2YWxpZCBjdXN0b20gZWxlbWVudCBuYW1lIAogUEFT UyBjdXN0b21FbGVtZW50cy53aGVuRGVmaW5lZCBtdXN0IHJldHVybiB0aGUgc2FtZSBwcm9taXNl IGVhY2ggdGltZSBpbnZva2VkIGZvciBhIHZhbGlkIGN1c3RvbSBlbGVtZW50IG5hbWUgd2hpY2gg aGFzIG5vdCBiZWVuIGRlZmluZWQgCi1GQUlMIGN1c3RvbUVsZW1lbnRzLndoZW5EZWZpbmVkIG11 c3QgcmV0dXJuIGFuIHVucmVzb2x2ZWQgcHJvbWlzZSB3aGVuIHRoZSByZWdpc3RyeSBkb2VzIG5v dCBjb250YWluIHRoZSBlbnRyeSB3aXRoIHRoZSBnaXZlbiBuYW1lIHVuZGVmaW5lZCBpcyBub3Qg YW4gb2JqZWN0IChldmFsdWF0aW5nICdjdXN0b21FbGVtZW50cy53aGVuRGVmaW5lZCgnYS1iJyku dGhlbicpCitQQVNTIGN1c3RvbUVsZW1lbnRzLndoZW5EZWZpbmVkIG11c3QgcmV0dXJuIGFuIHVu cmVzb2x2ZWQgcHJvbWlzZSB3aGVuIHRoZSByZWdpc3RyeSBkb2VzIG5vdCBjb250YWluIHRoZSBl bnRyeSB3aXRoIHRoZSBnaXZlbiBuYW1lIAogUEFTUyBjdXN0b21FbGVtZW50cy53aGVuRGVmaW5l ZCBtdXN0IHJldHVybiBhIHJlamVjdGVkIHByb21pc2Ugd2hlbiB0aGUgZ2l2ZW4gbmFtZSBpcyBu b3QgYSB2YWxpZCBjdXN0b20gZWxlbWVudCBuYW1lIAogUEFTUyBjdXN0b21FbGVtZW50cy53aGVu RGVmaW5lZCBtdXN0IHJldHVybiBhIHJlc29sdmVkIHByb21pc2Ugd2hlbiB0aGUgcmVnaXN0cnkg Y29udGFpbnMgdGhlIGVudHJ5IHdpdGggdGhlIGdpdmVuIG5hbWUgCiBQQVNTIGN1c3RvbUVsZW1l bnRzLndoZW5EZWZpbmVkIG11c3QgcmV0dXJuIGEgbmV3IHJlc29sdmVkIHByb21pc2UgZWFjaCB0 aW1lIGludm9rZWQgd2hlbiB0aGUgcmVnaXN0cnkgY29udGFpbnMgdGhlIGVudHJ5IHdpdGggdGhl IGdpdmVuIG5hbWUgCi1GQUlMIEEgcHJvbWlzZSByZXR1cm5lZCBieSBjdXN0b21FbGVtZW50cy53 aGVuRGVmaW5lZCBtdXN0IGJlIHJlc29sdmVkIGJ5ICJkZWZpbmUiIHVuZGVmaW5lZCBpcyBub3Qg YW4gb2JqZWN0IChldmFsdWF0aW5nICdwcm9taXNlLnRoZW4nKQorUEFTUyBBIHByb21pc2UgcmV0 dXJuZWQgYnkgY3VzdG9tRWxlbWVudHMud2hlbkRlZmluZWQgbXVzdCBiZSByZXNvbHZlZCBieSAi ZGVmaW5lIiAKIAo=