161554 2016-09-02 16:16:47 -0700 Object.preventExtensions(window) should throw a TypeError 2020-11-23 23:45:16 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161486 https://bugs.webkit.org/show_bug.cgi?id=219270 https://tc39.github.io/ecma262/#sec-object.preventextensions WebExposed P2 Normal --- 1 cdumez cdumez ashvayka cdumez commit-queue ggaren mark.lam rniwa saam oldest_to_newest 1226013 0 cdumez 2016-09-02 16:16:47 -0700 Object.preventExtensions() should throw a TypeError if [[PreventExtensions]] returns false: - https://tc39.github.io/ecma262/#sec-object.preventextensions We currently do not throw. 1226068 1 287845 cdumez 2016-09-02 19:02:08 -0700 Created attachment 287845 Patch 1226117 2 287845 darin 2016-09-03 07:25:43 -0700 Comment on attachment 287845 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287845&action=review The code here doesn’t make sense to me. > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:349 > + throwTypeError(exec, scope, ASCIILiteral("Cannot prevent extensions on this object")); Should the message be more specific than "this object"? 1226131 3 287845 commit-queue 2016-09-03 07:46:54 -0700 Comment on attachment 287845 Patch Clearing flags on attachment: 287845 Committed r205404: <http://trac.webkit.org/changeset/205404> 1226132 4 commit-queue 2016-09-03 07:46:57 -0700 All reviewed patches have been landed. Closing bug. 287845 2016-09-02 19:02:08 -0700 2016-09-03 07:46:54 -0700 Patch bug-161554-20160902185952.patch text/plain 5909 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDA5NjE4OWYxMDIwMzhk Njc1YWU2NDNjNzdmNTMyNzQ3MzBlOTM3OC4uODcxYjg3NGQ2MTYyNTE5OTU4NjE4MTQwODQyOWFj ZWRiOWZkMzUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE2LTA5LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgT2JqZWN0LnByZXZlbnRFeHRl bnNpb25zKHdpbmRvdykgc2hvdWxkIHRocm93IGEgVHlwZUVycm9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPYmplY3QucHJldmVudEV4dGVuc2lvbnMo d2luZG93KSBzaG91bGQgdGhyb3cgYSBUeXBlRXJyb3IuCisKKyAgICAgICAgW1tQcmV2ZW50RXh0 ZW5zaW9uc11dIHNob3VsZCByZXR1cm4gZmFsc2UgZm9yIFdpbmRvdzoKKyAgICAgICAgLSBodHRw czovL2h0bWwuc3BlYy53aGF0d2cub3JnLyN3aW5kb3dwcm94eS1wcmV2ZW50ZXh0ZW5zaW9ucwor CisgICAgICAgIEVjbWFTY3JpcHQgc2F5cyB0aGF0IE9iamVjdC5wcmV2ZW50RXh0ZW5zaW9ucygp IHNob3VsZCB0aHJvdyBhIFR5cGVFcnJvcgorICAgICAgICBpZiBbW1ByZXZlbnRFeHRlbnNpb25d XSByZXR1cm5zIGZhbHNlOgorICAgICAgICAtIGh0dHBzOi8vdGMzOS5naXRodWIuaW8vZWNtYTI2 Mi8jc2VjLW9iamVjdC5wcmV2ZW50ZXh0ZW5zaW9ucworCisgICAgICAgIE5vIG5ldyB0ZXN0cywg dXBkYXRlZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01XaW5k b3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5kb3c6OnByZXZlbnRFeHRl bnNpb25zKToKKworMjAxNi0wOS0wMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGwgb3V0IHIyMDUzNTQgYmVjYXVzZSBpdCBjYXVzZWQg SlNDIHRlc3QgZmFpbHVyZXMKIAogICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFz ZS5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRv d0N1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3Rv bS5jcHAKaW5kZXggNzlhNGE3MGQ0YzE2YWZjZDhjNDNkM2FmNDhmMDgwNTQzNWUzNjIxZS4uYzJh ZDNmZWZjMmQ0NDM1OTdjOTJlNTIyNjA0NWQwODVkZjI5ZmQwMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcApAQCAtMzQyLDExICszNDIs MTEgQEAgYm9vbCBKU0RPTVdpbmRvdzo6ZGVmaW5lT3duUHJvcGVydHkoSlNDOjpKU09iamVjdCog b2JqZWN0LCBKU0M6OkV4ZWNTdGF0ZSogZXhlYywKICAgICByZXR1cm4gQmFzZTo6ZGVmaW5lT3du UHJvcGVydHkodGhpc09iamVjdCwgZXhlYywgcHJvcGVydHlOYW1lLCBkZXNjcmlwdG9yLCBzaG91 bGRUaHJvdyk7CiB9CiAKLWJvb2wgSlNET01XaW5kb3c6OnByZXZlbnRFeHRlbnNpb25zKEpTT2Jq ZWN0KiBvYmplY3QsIEV4ZWNTdGF0ZSogZXhlYykKK2Jvb2wgSlNET01XaW5kb3c6OnByZXZlbnRF eHRlbnNpb25zKEpTT2JqZWN0KiwgRXhlY1N0YXRlKiBleGVjKQogewotICAgIEpTRE9NV2luZG93 KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTRE9NV2luZG93Kj4ob2JqZWN0KTsKLSAgICBpZiAoIUJp bmRpbmdTZWN1cml0eTo6c2hvdWxkQWxsb3dBY2Nlc3NUb0RPTVdpbmRvdyhleGVjLCB0aGlzT2Jq ZWN0LT53cmFwcGVkKCksIFRocm93U2VjdXJpdHlFcnJvcikpCi0gICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRShleGVjLT52bSgpKTsKKwor ICAgIHRocm93VHlwZUVycm9yKGV4ZWMsIHNjb3BlLCBBU0NJSUxpdGVyYWwoIkNhbm5vdCBwcmV2 ZW50IGV4dGVuc2lvbnMgb24gdGhpcyBvYmplY3QiKSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggMjk3MTEyNmQ5NDJkNjE0Mzc2MmNhZDJlZTc1NjA3OWY4NTU5MmNmZS4uNjU0YzRh ZGFlYWMxZTVmZmIwMzkxMjc1ZGUxNjFlMTFhN2FhYzcyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBA CiAyMDE2LTA5LTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAg T2JqZWN0LnByZXZlbnRFeHRlbnNpb25zKHdpbmRvdykgc2hvdWxkIHRocm93IGEgVHlwZUVycm9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1NTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAv dGVzdHMvc2VjdXJpdHkvcHJldmVudEV4dGVuc2lvbnMtd2luZG93LWxvY2F0aW9uLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L3ByZXZlbnRFeHRlbnNpb25zLXdp bmRvdy1sb2NhdGlvbi5odG1sOgorCisyMDE2LTA5LTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbCBvdXQgcjIwNTM1NCBiZWNhdXNl IGl0IGNhdXNlZCBKU0MgdGVzdCBmYWlsdXJlcwogCiAgICAgICAgICogZmFzdC9kb20vV2luZG93 L3NjcmlwdC10ZXN0cy93aW5kb3ctY3VzdG9tLXByb3RvdHlwZS5qczogQWRkZWQuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3ByZXZlbnRFeHRlbnNpb25zLXdp bmRvdy1sb2NhdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L3ByZXZlbnRFeHRlbnNpb25zLXdpbmRvdy1sb2NhdGlvbi1leHBlY3RlZC50eHQKaW5kZXgg MjA2YzI0OWZlNzExMWM2ZDYyOGY2YzJhYmZlZjRjMWZiZTA5YTRmYS4uYWU3NDNkMWJmZjViN2Q4 OTk0M2ZjN2YzZWViYjdiM2Y1ODE1YTE4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zZWN1cml0eS9wcmV2ZW50RXh0ZW5zaW9ucy13aW5kb3ctbG9jYXRpb24tZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcHJldmVudEV4dGVuc2lv bnMtd2luZG93LWxvY2F0aW9uLWV4cGVjdGVkLnR4dApAQCAtNSw3ICs1LDcgQEAgT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUKIAogKiBDcm9zcyBvcmlnaW4KIFBBU1MgT2JqZWN0LmlzRXh0ZW5zaWJs ZShmcmFtZXNbMF0pIGlzIHRydWUKLVBBU1MgT2JqZWN0LnByZXZlbnRFeHRlbnNpb25zKGZyYW1l c1swXSkgdGhyZXcgZXhjZXB0aW9uIFNlY3VyaXR5RXJyb3IgKERPTSBFeGNlcHRpb24gMTgpOiBC bG9ja2VkIGEgZnJhbWUgd2l0aCBvcmlnaW4gImh0dHA6Ly8xMjcuMC4wLjE6ODAwMCIgZnJvbSBh Y2Nlc3NpbmcgYSBmcmFtZSB3aXRoIG9yaWdpbiAiaHR0cDovL2xvY2FsaG9zdDo4MDAwIi4gUHJv dG9jb2xzLCBkb21haW5zLCBhbmQgcG9ydHMgbXVzdCBtYXRjaC4uCitQQVNTIE9iamVjdC5wcmV2 ZW50RXh0ZW5zaW9ucyhmcmFtZXNbMF0pIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IENhbm5v dCBwcmV2ZW50IGV4dGVuc2lvbnMgb24gdGhpcyBvYmplY3QuCiBQQVNTIE9iamVjdC5pc0V4dGVu c2libGUoZnJhbWVzWzBdKSBpcyB0cnVlCiBQQVNTIE9iamVjdC5pc0V4dGVuc2libGUoZnJhbWVz WzBdLmxvY2F0aW9uKSBpcyB0cnVlCiBQQVNTIE9iamVjdC5wcmV2ZW50RXh0ZW5zaW9ucyhmcmFt ZXNbMF0ubG9jYXRpb24pIHRocmV3IGV4Y2VwdGlvbiBTZWN1cml0eUVycm9yIChET00gRXhjZXB0 aW9uIDE4KTogQmxvY2tlZCBhIGZyYW1lIHdpdGggb3JpZ2luICJodHRwOi8vMTI3LjAuMC4xOjgw MDAiIGZyb20gYWNjZXNzaW5nIGEgZnJhbWUgd2l0aCBvcmlnaW4gImh0dHA6Ly9sb2NhbGhvc3Q6 ODAwMCIuIFByb3RvY29scywgZG9tYWlucywgYW5kIHBvcnRzIG11c3QgbWF0Y2guLgpAQCAtMTMs NyArMTMsNyBAQCBQQVNTIE9iamVjdC5pc0V4dGVuc2libGUoZnJhbWVzWzBdLmxvY2F0aW9uKSBp cyB0cnVlCiAKICogU2FtZSBvcmlnaW4KIFBBU1MgT2JqZWN0LmlzRXh0ZW5zaWJsZSh3aW5kb3cp IGlzIHRydWUKLUZBSUwgT2JqZWN0LnByZXZlbnRFeHRlbnNpb25zKHdpbmRvdykgc2hvdWxkIHRo cm93IGEgVHlwZUVycm9yLiBEaWQgbm90IHRocm93LgorUEFTUyBPYmplY3QucHJldmVudEV4dGVu c2lvbnMod2luZG93KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBDYW5ub3QgcHJldmVudCBl eHRlbnNpb25zIG9uIHRoaXMgb2JqZWN0LgogUEFTUyBPYmplY3QuaXNFeHRlbnNpYmxlKHdpbmRv dykgaXMgdHJ1ZQogUEFTUyBPYmplY3QuaXNFeHRlbnNpYmxlKHdpbmRvdy5sb2NhdGlvbikgaXMg dHJ1ZQogRkFJTCBPYmplY3QucHJldmVudEV4dGVuc2lvbnMod2luZG93LmxvY2F0aW9uKSBzaG91 bGQgdGhyb3cgYSBUeXBlRXJyb3IuIERpZCBub3QgdGhyb3cuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3ByZXZlbnRFeHRlbnNpb25zLXdpbmRvdy1sb2NhdGlv bi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wcmV2ZW50RXh0ZW5zaW9u cy13aW5kb3ctbG9jYXRpb24uaHRtbAppbmRleCA4N2NiN2M0OTU0MDRiZjVjNDg5MzM4M2FkMWJm NWUwMGUwMjNiN2I3Li5mMzliZTYyNTU3YjM3NTJmYjE3Nzc4ZjZhNTI1NjRkMDU4YTg4NWNhIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3ByZXZlbnRFeHRlbnNp b25zLXdpbmRvdy1sb2NhdGlvbi5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2Vj dXJpdHkvcHJldmVudEV4dGVuc2lvbnMtd2luZG93LWxvY2F0aW9uLmh0bWwKQEAgLTEwLDEwICsx MCwxMSBAQCBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIG9ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAg IGRlYnVnICgiKiBDcm9zcyBvcmlnaW4iKTsKICAgICBzaG91bGRCZVRydWUoIk9iamVjdC5pc0V4 dGVuc2libGUoZnJhbWVzWzBdKSIpOwotICAgIHNob3VsZFRocm93RXJyb3JOYW1lKCJPYmplY3Qu cHJldmVudEV4dGVuc2lvbnMoZnJhbWVzWzBdKSIsICJTZWN1cml0eUVycm9yIik7CisgICAgc2hv dWxkVGhyb3dFcnJvck5hbWUoIk9iamVjdC5wcmV2ZW50RXh0ZW5zaW9ucyhmcmFtZXNbMF0pIiwg IlR5cGVFcnJvciIpOwogICAgIHNob3VsZEJlVHJ1ZSgiT2JqZWN0LmlzRXh0ZW5zaWJsZShmcmFt ZXNbMF0pIik7CiAKICAgICBzaG91bGRCZVRydWUoIk9iamVjdC5pc0V4dGVuc2libGUoZnJhbWVz WzBdLmxvY2F0aW9uKSIpOworICAgIC8vIEZJWE1FOiBTaG91bGQgdGhyb3cgYSBUeXBlRXJyb3Ig b25jZSB3ZSBzdGFydCB0aHJvdyBpbiB0aGUgc2FtZSBvcmlnaW4gY2FzZSBhcyB3ZWxsLgogICAg IHNob3VsZFRocm93RXJyb3JOYW1lKCJPYmplY3QucHJldmVudEV4dGVuc2lvbnMoZnJhbWVzWzBd LmxvY2F0aW9uKSIsICJTZWN1cml0eUVycm9yIik7CiAgICAgc2hvdWxkQmVUcnVlKCJPYmplY3Qu aXNFeHRlbnNpYmxlKGZyYW1lc1swXS5sb2NhdGlvbikiKTsKIAo=