161553 2016-09-02 15:25:36 -0700 [Mac] Remove unnecessary RetainPtr in NeverDestroyed value 2016-09-03 07:26:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dbates oldest_to_newest 1225985 0 joepeck 2016-09-02 15:25:36 -0700 Remove unnecessary RetainPtr in NeverDestroyed value: WebCore/platform/ios/WebCoreMotionManager.mm 72: static NeverDestroyed<RetainPtr<WebCoreMotionManager>> sharedMotionManager([[WebCoreMotionManager alloc] init]); The NeverDestroyed can just hold the allocated pointer. 1225986 1 287825 joepeck 2016-09-02 15:26:37 -0700 Created attachment 287825 [PATCH] Proposed Fix 1225987 2 287825 joepeck 2016-09-02 15:27:53 -0700 Comment on attachment 287825 [PATCH] Proposed Fix Typo. 1225994 3 287827 joepeck 2016-09-02 15:42:06 -0700 Created attachment 287827 [PATCH] Proposed Fix 1225996 4 287827 joepeck 2016-09-02 15:43:07 -0700 Comment on attachment 287827 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287827&action=review > Source/WebCore/platform/ios/WebCoreMotionManager.mm:71 > + static NeverDestroyed<WebCoreMotionManager *> sharedMotionManager([[WebCoreMotionManager alloc] init]); > + return sharedMotionManager.get(); Alternatively this could just be: static WebCoreMotionManager* sharedManager = [[WebCoreMotionManager alloc] init]; return sharedMotionManager; Which I think is probably the best. So I'll just write a patch for that! 1225999 5 287829 joepeck 2016-09-02 15:44:47 -0700 Created attachment 287829 [PATCH] Proposed Fix 1226048 6 287829 commit-queue 2016-09-02 17:36:20 -0700 Comment on attachment 287829 [PATCH] Proposed Fix Clearing flags on attachment: 287829 Committed r205391: <http://trac.webkit.org/changeset/205391> 1226049 7 commit-queue 2016-09-02 17:36:24 -0700 All reviewed patches have been landed. Closing bug. 1226118 8 287829 darin 2016-09-03 07:26:42 -0700 Comment on attachment 287829 [PATCH] Proposed Fix Should we grep for NeverDestroyed and RetainPtr on the same line? 287825 2016-09-02 15:26:37 -0700 2016-09-02 15:42:06 -0700 [PATCH] Proposed Fix core-motion-1.patch text/plain 1505 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYzUyNWJjLi4zZmM2MDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBSZW1vdmUgdW5uZWNlc3NhcnkgUmV0YWluUHRyIGluIE5ldmVyRGVzdHJv eWVkIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjE1NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbToKKyAgICAgICAgKCtbV2Vi Q29yZU1vdGlvbk1hbmFnZXIgc2hhcmVkTWFuYWdlcl0pOgorCiAyMDE2LTA5LTAyICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIW1f Y29tbWl0dGVkV2lkdGggaW4gV2ViQ29yZTo6TGluZVdpZHRoOjpmaXRCZWxvd0Zsb2F0cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2Vy Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2VyLm1t CmluZGV4IDFiNWM4NWUuLjhjNWMzNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFnZXIubW0KQEAgLTMyLDggKzMyLDYgQEAKICNpbXBv cnQgPG9iamMvb2JqYy1ydW50aW1lLmg+CiAjaW1wb3J0IDx3dGYvTWF0aEV4dHJhcy5oPgogI2lt cG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+Ci0jaW1wb3J0IDx3dGYvUGFzc1JlZlB0ci5oPgot I2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiAjaWYgUExBVEZPUk0oSU9TKQogCkBAIC02OSw4 ICs2Nyw4IEBAIHN0YXRpYyBjb25zdCBkb3VibGUga0dyYXZpdHkgPSA5LjgwNjY1OwogCiArIChX ZWJDb3JlTW90aW9uTWFuYWdlciAqKXNoYXJlZE1hbmFnZXIKIHsKLSAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8UmV0YWluUHRyPFdlYkNvcmVNb3Rpb25NYW5hZ2VyPj4gc2hhcmVkTW90aW9uTWFu YWdlcihbW1dlYkNvcmVNb3Rpb25NYW5hZ2VyIGFsbG9jXSBpbml0XSk7Ci0gICAgcmV0dXJuIHNo YXJlZE1vdGlvbk1hbmFnZXIuZ2V0KCkuZ2V0KCk7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVk PFdlYkNvcmVNb3Rpb25NYW5hZ2VyPiBzaGFyZWRNb3Rpb25NYW5hZ2VyKFtbV2ViQ29yZU1vdGlv bk1hbmFnZXIgYWxsb2NdIGluaXRdKTsKKyAgICByZXR1cm4gc2hhcmVkTW90aW9uTWFuYWdlci5n ZXQoKTsKIH0KIAogLSAoaWQpaW5pdAo= 287827 2016-09-02 15:42:06 -0700 2016-09-02 15:44:47 -0700 [PATCH] Proposed Fix core-motion-2.patch text/plain 1507 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYzUyNWJjLi4zZmM2MDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBSZW1vdmUgdW5uZWNlc3NhcnkgUmV0YWluUHRyIGluIE5ldmVyRGVzdHJv eWVkIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjE1NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbToKKyAgICAgICAgKCtbV2Vi Q29yZU1vdGlvbk1hbmFnZXIgc2hhcmVkTWFuYWdlcl0pOgorCiAyMDE2LTA5LTAyICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIW1f Y29tbWl0dGVkV2lkdGggaW4gV2ViQ29yZTo6TGluZVdpZHRoOjpmaXRCZWxvd0Zsb2F0cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2Vy Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2VyLm1t CmluZGV4IDFiNWM4NWUuLjRjODY0NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFnZXIubW0KQEAgLTMyLDggKzMyLDYgQEAKICNpbXBv cnQgPG9iamMvb2JqYy1ydW50aW1lLmg+CiAjaW1wb3J0IDx3dGYvTWF0aEV4dHJhcy5oPgogI2lt cG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+Ci0jaW1wb3J0IDx3dGYvUGFzc1JlZlB0ci5oPgot I2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiAjaWYgUExBVEZPUk0oSU9TKQogCkBAIC02OSw4 ICs2Nyw4IEBAIHN0YXRpYyBjb25zdCBkb3VibGUga0dyYXZpdHkgPSA5LjgwNjY1OwogCiArIChX ZWJDb3JlTW90aW9uTWFuYWdlciAqKXNoYXJlZE1hbmFnZXIKIHsKLSAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8UmV0YWluUHRyPFdlYkNvcmVNb3Rpb25NYW5hZ2VyPj4gc2hhcmVkTW90aW9uTWFu YWdlcihbW1dlYkNvcmVNb3Rpb25NYW5hZ2VyIGFsbG9jXSBpbml0XSk7Ci0gICAgcmV0dXJuIHNo YXJlZE1vdGlvbk1hbmFnZXIuZ2V0KCkuZ2V0KCk7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVk PFdlYkNvcmVNb3Rpb25NYW5hZ2VyICo+IHNoYXJlZE1vdGlvbk1hbmFnZXIoW1tXZWJDb3JlTW90 aW9uTWFuYWdlciBhbGxvY10gaW5pdF0pOworICAgIHJldHVybiBzaGFyZWRNb3Rpb25NYW5hZ2Vy LmdldCgpOwogfQogCiAtIChpZClpbml0Cg== 287829 2016-09-02 15:44:47 -0700 2016-09-02 17:36:20 -0700 [PATCH] Proposed Fix core-motion-3.patch text/plain 1485 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYzUyNWJjLi4zZmM2MDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBSZW1vdmUgdW5uZWNlc3NhcnkgUmV0YWluUHRyIGluIE5ldmVyRGVzdHJv eWVkIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjE1NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbToKKyAgICAgICAgKCtbV2Vi Q29yZU1vdGlvbk1hbmFnZXIgc2hhcmVkTWFuYWdlcl0pOgorCiAyMDE2LTA5LTAyICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIW1f Y29tbWl0dGVkV2lkdGggaW4gV2ViQ29yZTo6TGluZVdpZHRoOjpmaXRCZWxvd0Zsb2F0cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2Vy Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNvcmVNb3Rpb25NYW5hZ2VyLm1t CmluZGV4IDFiNWM4NWUuLmNiOTVjZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFnZXIubW0KQEAgLTMyLDggKzMyLDYgQEAKICNpbXBv cnQgPG9iamMvb2JqYy1ydW50aW1lLmg+CiAjaW1wb3J0IDx3dGYvTWF0aEV4dHJhcy5oPgogI2lt cG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+Ci0jaW1wb3J0IDx3dGYvUGFzc1JlZlB0ci5oPgot I2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiAjaWYgUExBVEZPUk0oSU9TKQogCkBAIC02OSw4 ICs2Nyw4IEBAIHN0YXRpYyBjb25zdCBkb3VibGUga0dyYXZpdHkgPSA5LjgwNjY1OwogCiArIChX ZWJDb3JlTW90aW9uTWFuYWdlciAqKXNoYXJlZE1hbmFnZXIKIHsKLSAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8UmV0YWluUHRyPFdlYkNvcmVNb3Rpb25NYW5hZ2VyPj4gc2hhcmVkTW90aW9uTWFu YWdlcihbW1dlYkNvcmVNb3Rpb25NYW5hZ2VyIGFsbG9jXSBpbml0XSk7Ci0gICAgcmV0dXJuIHNo YXJlZE1vdGlvbk1hbmFnZXIuZ2V0KCkuZ2V0KCk7CisgICAgc3RhdGljIFdlYkNvcmVNb3Rpb25N YW5hZ2VyICpzaGFyZWRNb3Rpb25NYW5hZ2VyID0gW1tXZWJDb3JlTW90aW9uTWFuYWdlciBhbGxv Y10gaW5pdF07CisgICAgcmV0dXJuIHNoYXJlZE1vdGlvbk1hbmFnZXI7CiB9CiAKIC0gKGlkKWlu aXQK