161551 2016-09-02 15:04:38 -0700 [Mac] RetainPtr misuse, DDActionContext leaks 2016-09-02 15:44:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue thorton oldest_to_newest 1225974 0 joepeck 2016-09-02 15:04:38 -0700 RetainPtr misuse, DDActionContext leaks $ ack 'RetainPtr.*?alloc' | grep -v adopt WebKit2/Platform/mac/MenuUtilities.mm:56: RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init]; WebKit2/Platform/mac/MenuUtilities.mm:87: RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init]; These should be adopted. 1225975 1 287821 joepeck 2016-09-02 15:05:12 -0700 Created attachment 287821 [PATCH] Proposed Fix 1225997 2 287821 commit-queue 2016-09-02 15:44:26 -0700 Comment on attachment 287821 [PATCH] Proposed Fix Clearing flags on attachment: 287821 Committed r205377: <http://trac.webkit.org/changeset/205377> 1225998 3 commit-queue 2016-09-02 15:44:30 -0700 All reviewed patches have been landed. Closing bug. 287821 2016-09-02 15:05:12 -0700 2016-09-02 15:44:26 -0700 [PATCH] Proposed Fix adopt-1.patch text/plain 2207 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMjk2Mzk3Li5iMGFkMDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbTWFjXSBSZXRhaW5QdHIgbWlzdXNlLCBEREFjdGlvbkNvbnRleHQgbGVha3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTU1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0v bWFjL01lbnVVdGlsaXRpZXMubW06CisgICAgICAgIChXZWJLaXQ6Om1lbnVJdGVtRm9yVGVsZXBo b25lTnVtYmVyKToKKyAgICAgICAgKFdlYktpdDo6bWVudUZvclRlbGVwaG9uZU51bWJlcik6CisK KzIwMTYtMDktMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBGaXggTWFjIENNYWtlIGJ1aWxkLCBtaXNzaW5nIF9XS1JlbW90ZVdlYkluc3BlY3RvclZp ZXdDb250cm9sbGVyLm1tCiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvTWVudVV0aWxpdGllcy5tbSBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9NZW51VXRpbGl0aWVzLm1tCmluZGV4IDU2YWJhNzAuLjA3 YTc3YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9NZW51VXRpbGl0 aWVzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9NZW51VXRpbGl0aWVzLm1t CkBAIC01Myw3ICs1Myw3IEBAIE5TTWVudUl0ZW0gKm1lbnVJdGVtRm9yVGVsZXBob25lTnVtYmVy KGNvbnN0IFN0cmluZyYgdGVsZXBob25lTnVtYmVyKQogICAgIGlmICghRGF0YURldGVjdG9yc0xp YnJhcnkoKSkKICAgICAgICAgcmV0dXJuIG5pbDsKIAotICAgIFJldGFpblB0cjxEREFjdGlvbkNv bnRleHQ+IGFjdGlvbkNvbnRleHQgPSBbW2dldEREQWN0aW9uQ29udGV4dENsYXNzKCkgYWxsb2Nd IGluaXRdOworICAgIFJldGFpblB0cjxEREFjdGlvbkNvbnRleHQ+IGFjdGlvbkNvbnRleHQgPSBh ZG9wdE5TKFtbZ2V0RERBY3Rpb25Db250ZXh0Q2xhc3MoKSBhbGxvY10gaW5pdF0pOwogICAgIFth Y3Rpb25Db250ZXh0IHNldEFsbG93ZWRBY3Rpb25VVElzOkBbIEAiY29tLmFwcGxlLmRpYWwiIF1d OwogCiAgICAgTlNBcnJheSAqcHJvcG9zZWRNZW51SXRlbXMgPSBbW2dldEREQWN0aW9uc01hbmFn ZXJDbGFzcygpIHNoYXJlZE1hbmFnZXJdIG1lbnVJdGVtc0ZvclZhbHVlOihOU1N0cmluZyAqKXRl bGVwaG9uZU51bWJlciB0eXBlOmdldEREQmluZGVyUGhvbmVOdW1iZXJLZXkoKSBzZXJ2aWNlOm5p bCBjb250ZXh0OmFjdGlvbkNvbnRleHQuZ2V0KCldOwpAQCAtODQsNyArODQsNyBAQCBSZXRhaW5Q dHI8TlNNZW51PiBtZW51Rm9yVGVsZXBob25lTnVtYmVyKGNvbnN0IFN0cmluZyYgdGVsZXBob25l TnVtYmVyKQogICAgIE5TTXV0YWJsZUFycmF5ICpmYWNlVGltZUl0ZW1zID0gW05TTXV0YWJsZUFy cmF5IGFycmF5XTsKICAgICBOU01lbnVJdGVtICpkaWFsSXRlbSA9IG5pbDsKIAotICAgIFJldGFp blB0cjxEREFjdGlvbkNvbnRleHQ+IGFjdGlvbkNvbnRleHQgPSBbW2dldEREQWN0aW9uQ29udGV4 dENsYXNzKCkgYWxsb2NdIGluaXRdOworICAgIFJldGFpblB0cjxEREFjdGlvbkNvbnRleHQ+IGFj dGlvbkNvbnRleHQgPSBhZG9wdE5TKFtbZ2V0RERBY3Rpb25Db250ZXh0Q2xhc3MoKSBhbGxvY10g aW5pdF0pOwogICAgIFthY3Rpb25Db250ZXh0IHNldEFsbG93ZWRBY3Rpb25VVElzOkBbIEAiY29t LmFwcGxlLmRpYWwiLCBAImNvbS5hcHBsZS5mYWNldGltZSIsIEAiY29tLmFwcGxlLmZhY2V0aW1l YXVkaW8iIF1dOwogCiAgICAgTlNBcnJheSAqcHJvcG9zZWRNZW51SXRlbXMgPSBbW2dldEREQWN0 aW9uc01hbmFnZXJDbGFzcygpIHNoYXJlZE1hbmFnZXJdIG1lbnVJdGVtc0ZvclZhbHVlOihOU1N0 cmluZyAqKXRlbGVwaG9uZU51bWJlciB0eXBlOmdldEREQmluZGVyUGhvbmVOdW1iZXJLZXkoKSBz ZXJ2aWNlOm5pbCBjb250ZXh0OmFjdGlvbkNvbnRleHQuZ2V0KCldOwo=