161549 2016-09-02 14:46:42 -0700 REGRESSION: LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure 2017-06-23 12:10:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173779 InRadar P2 Normal --- 1 ryanhaddad cdumez ap cdumez jonlee simon.fraser webkit-bug-importer oldest_to_newest 1225964 0 ryanhaddad 2016-09-02 14:46:42 -0700 LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/14759 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fscrolling%2Farrow-key-scroll-in-rtl-document.html --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-actual.txt @@ -1 +1 @@ -PASS: scrollLeft is -120 +FAIL: scrollLeft is 0, expected -120 1225966 1 ryanhaddad 2016-09-02 14:47:55 -0700 The first failure according to the dashboard is ~r204242, but that change itself seems unrelated. 1227754 2 ap 2016-09-08 13:55:33 -0700 <rdar://problem/28213429> 1231977 3 ap 2016-09-20 21:54:34 -0700 I see failures older than that, but they definitely became more frequent recently. 1298390 4 ryanhaddad 2017-04-18 12:42:52 -0700 According to the flakiness dashboard, this test is still flaky on Sierra WK2 with the same diff. 1315156 5 311843 cdumez 2017-06-02 12:12:35 -0700 Created attachment 311843 Patch 1315157 6 cdumez 2017-06-02 12:13:31 -0700 Was able to reproduce the flakiness locally via: Tools/Scripts/run-webkit-tests --release --repeat-each=100 fast/scrolling/arrow-key-scroll-in-rtl-document.html -g Flakiness is gone with proposed change. 1315172 7 311843 cdumez 2017-06-02 12:57:19 -0700 Comment on attachment 311843 Patch Clearing flags on attachment: 311843 Committed r217731: <http://trac.webkit.org/changeset/217731> 1315173 8 cdumez 2017-06-02 12:57:20 -0700 All reviewed patches have been landed. Closing bug. 1315193 9 ap 2017-06-02 13:41:42 -0700 Is it understood why delaying on a timer is necessary here? Can we make tests resilient against this kind of mistake? 311843 2017-06-02 12:12:35 -0700 2017-06-02 12:57:19 -0700 Patch bug-161549-20170602121235.patch text/plain 2524 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjI4ODc1OWQ1OWJmNzk3ZTdmMWJj OWQxOGE1YjM4N2Y4ODFkNTQ0MS4uODMwMGJkMjExNjJjZmRkYWJkNTE3ZTQ4ODU4ZGI5ZGU1N2Fi M2E5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTAyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogTGF5b3V0VGVzdCBmYXN0L3Nj cm9sbGluZy9hcnJvdy1rZXktc2Nyb2xsLWluLXJ0bC1kb2N1bWVudC5odG1sIGlzIGEgZmxha3kg ZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYxNTQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODIxMzQyOT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qvc2Nyb2xsaW5nL2Fycm93 LWtleS1zY3JvbGwtaW4tcnRsLWRvY3VtZW50Lmh0bWw6CisgICAgICAgIENhbGwgZXZlbnRTZW5k ZXIuY2FsbEFmdGVyU2Nyb2xsaW5nQ29tcGxldGVzKCkgaW4gdGhlIG5leHQgZXZlbnQgbG9vcCBp dGVyYXRpb24gdG8KKyAgICAgICAgYWRkcmVzcyB0aGUgZmxha2luZXNzLgorCisgICAgICAgICog cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBVbnNraXAgdGVzdC4K KwogMjAxNy0wNi0wMiAgTWF0dCBMZXdpcyAgPGpsZXdpczNAYXBwbGUuY29tPgogCiAgICAgICAg IE1hcmtlZCBmYXN0L2ltYWdlcy9zbG93ZXItZGVjb2RpbmctdGhhbi1hbmltYXRpb24taW1hZ2Uu aHRtbCBhcyBmbGFreS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2Fy cm93LWtleS1zY3JvbGwtaW4tcnRsLWRvY3VtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3Nj cm9sbGluZy9hcnJvdy1rZXktc2Nyb2xsLWluLXJ0bC1kb2N1bWVudC5odG1sCmluZGV4IDMwODkx ODBmNDhhOTU4YTY2Zjc0NzI0NmU4Y2ExN2Y4YWM5OTRjMGYuLmZiZDEyNTQyN2U0MTY5MDdjNjU1 NDIxZTBjODY4MzIzODkxMGMwNmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xs aW5nL2Fycm93LWtleS1zY3JvbGwtaW4tcnRsLWRvY3VtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9zY3JvbGxpbmcvYXJyb3cta2V5LXNjcm9sbC1pbi1ydGwtZG9jdW1lbnQuaHRtbApA QCAtNDMsNyArNDMsOSBAQAogICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oImxl ZnRBcnJvdyIpOwogICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oImxlZnRBcnJv dyIpOwogICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oImxlZnRBcnJvdyIpOwot ICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmNhbGxBZnRlclNjcm9sbGluZ0NvbXBsZXRlcyhj aGVja0ZvclNjcm9sbCk7CisgICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsK KyAgICAgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIuY2FsbEFmdGVyU2Nyb2xsaW5nQ29tcGxl dGVzKGNoZWNrRm9yU2Nyb2xsKTsKKyAgICAgICAgICAgICAgICB9LCAwKTsKICAgICAgICAgICAg IH0KICAgICAgICAgfQogICAgICAgICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIv VGVzdEV4cGVjdGF0aW9ucwppbmRleCA4Y2I1M2VkMzJkMzE0YzNiMzAyODA0M2MzNjViNDJmYjE1 MjNiMTM4Li4yZjQ3YTI4NWMxNmE1ODVjYTQ2NzNiOTdiYWU1NzZkZDJjZWIzOTcyIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC01NjQsOCAr NTY0LDYgQEAgd2Via2l0Lm9yZy9iLzE2MTc0MiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9JbmRleGVkREIva2V5b3JkZXIKIAogd2Via2l0Lm9yZy9iLzE2MTU0NyBb IERlYnVnIF0gdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvZml4ZWQvZm91ci1iYXJzLXpvb21lZC5o dG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE2MTU0OSBmYXN0L3Njcm9sbGlu Zy9hcnJvdy1rZXktc2Nyb2xsLWluLXJ0bC1kb2N1bWVudC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K LQogd2Via2l0Lm9yZy9iLzE2MjA4MSBlZGl0aW5nL2luc2VydGluZy90eXBpbmctc3BhY2UtdG8t dHJpZ2dlci1zbWFydC1saW5rLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjIwODEg ZWRpdGluZy9pbnNlcnRpbmcvc21hcnQtcXVvdGUtd2l0aC1hbGwtY29uZmlndXJhdGlvbnMuaHRt bCBbIEZhaWx1cmUgXQogCg==