161541 2016-09-02 12:02:20 -0700 GetByValWithThis: fix opInfo in DFG creation 2016-09-02 12:19:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1225866 0 jfbastien 2016-09-02 12:02:20 -0700 See: https://bugs.webkit.org/show_bug.cgi?id=160922#c7 Saam points out that I addToGraph with the first opInfo instead of the second. IIUC that pipes into DFG's Node class, whose getHeapPrediction() does: return m_opInfo2.as<SpeculatedType>(); 1225869 1 287792 jfbastien 2016-09-02 12:05:30 -0700 Created attachment 287792 patch Perf numbers are pretty noisy, it seems 1.0148x faster or so. 1225882 2 287792 commit-queue 2016-09-02 12:19:21 -0700 Comment on attachment 287792 patch Clearing flags on attachment: 287792 Committed r205361: <http://trac.webkit.org/changeset/205361> 1225883 3 commit-queue 2016-09-02 12:19:26 -0700 All reviewed patches have been landed. Closing bug. 287792 2016-09-02 12:05:30 -0700 2016-09-02 12:19:21 -0700 patch 0001-opinfo.patch text/plain 2020 jfbastien RnJvbSBlMTY5MDdmYzYyZjAyYWY1YWExYzE5Mjg0MjhmZDAyMTBhMmJlNzRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDIgU2VwIDIwMTYgMTI6MDI6MjAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBvcGluZm8K Ci0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAx MiArKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJz ZXIuY3BwIHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhjNTliZDIuLjNlMDRhYmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTAyICBKRiBC YXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBHZXRCeVZhbFdpdGhUaGlz OiBmaXggb3BJbmZvIGluIERGRyBjcmVhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgc3VwZXItZ2V0LWJ5LXZhbC13aXRoLXRoaXMtbW9ub21vcnBo aWMgbWlnaHQgYmUgMS4wMTQ4eCBmYXN0ZXIgYWZ0ZXIgdGhpcyBjaGFuZ2UuCisKKyAgICAgICAg KiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2Rl UGFyc2VyOjpwYXJzZUJsb2NrKTogZml4IE9wSW5mbworCiAyMDE2LTA5LTAyICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWxpZ24gcHJvdG8gZ2V0dGVyIC8gc2V0 dGVyIGJlaGF2aW9yIHdpdGggb3RoZXIgYnJvd3NlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKaW5kZXggYzU4YTBlZC4uZjgwNjBlNSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKQEAg LTQxMzQsNyArNDEzNCw3IEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWdu ZWQgbGltaXQpCiAgICAgICAgICAgICBOb2RlKiBiYXNlID0gZ2V0KFZpcnR1YWxSZWdpc3Rlcihj dXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kKSk7CiAgICAgICAgICAgICBOb2RlKiB0aGlz VmFsdWUgPSBnZXQoVmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJh bmQpKTsKICAgICAgICAgICAgIE5vZGUqIHByb3BlcnR5ID0gZ2V0KFZpcnR1YWxSZWdpc3Rlcihj dXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5vcGVyYW5kKSk7Ci0gICAgICAgICAgICBOb2RlKiBnZXRC eVZhbFdpdGhUaGlzID0gYWRkVG9HcmFwaChHZXRCeVZhbFdpdGhUaGlzLCBPcEluZm8ocHJlZGlj dGlvbiksIGJhc2UsIHRoaXNWYWx1ZSwgcHJvcGVydHkpOworICAgICAgICAgICAgTm9kZSogZ2V0 QnlWYWxXaXRoVGhpcyA9IGFkZFRvR3JhcGgoR2V0QnlWYWxXaXRoVGhpcywgT3BJbmZvKCksIE9w SW5mbyhwcmVkaWN0aW9uKSwgYmFzZSwgdGhpc1ZhbHVlLCBwcm9wZXJ0eSk7CiAgICAgICAgICAg ICBzZXQoVmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9wZXJhbmQpLCBn ZXRCeVZhbFdpdGhUaGlzKTsKIAogICAgICAgICAgICAgTkVYVF9PUENPREUob3BfZ2V0X2J5X3Zh bF93aXRoX3RoaXMpOwotLSAKMi45LjMKCg==