161513 2016-09-01 15:30:53 -0700 jsc: provide printErr() 2016-10-26 16:06:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1225568 0 jfbastien 2016-09-01 15:30:53 -0700 SpiderMonkey provides print / printErr to print to stdout / stderr. Node has console.log / console.error. jsc has print, the emscripten shell would like to have printErr. 1225569 1 287691 jfbastien 2016-09-01 15:33:32 -0700 Created attachment 287691 patch 1225570 2 jfbastien 2016-09-01 15:35:01 -0700 I'm not sure where / if to test this. I did the following locally: $ ./current/bin/jsc >>> print([1,2,3]) 1,2,3 undefined >>> printErr([3,4,5]) 3,4,5 undefined >>> ^Dundefined $ ./current/bin/jsc 1> /dev/null print("hello") printErr("hi!") hi! 1225575 3 287691 mark.lam 2016-09-01 15:40:48 -0700 Comment on attachment 287691 patch r=me 1225637 4 287691 commit-queue 2016-09-01 18:03:25 -0700 Comment on attachment 287691 patch Clearing flags on attachment: 287691 Committed r205328: <http://trac.webkit.org/changeset/205328> 1225638 5 commit-queue 2016-09-01 18:03:32 -0700 All reviewed patches have been landed. Closing bug. 1225643 6 keith_miller 2016-09-01 18:21:37 -0700 Committed r205330: <http://trac.webkit.org/changeset/205330> 1225654 7 mark.lam 2016-09-01 19:16:01 -0700 (In reply to comment #6) > Committed r205330: <http://trac.webkit.org/changeset/205330> I think Keith meant this comment for https://bugs.webkit.org/show_bug.cgi?id=161471. Due to a ChangeLog mixup, he added it here. 287691 2016-09-01 15:33:32 -0700 2016-09-01 18:03:25 -0700 patch 0001-printErr.patch text/plain 3820 jfbastien RnJvbSA4NzUzNGFiNzk5OWUzODY3NTVmYTZkODI5OTAzNTRiYjMwYjQ5OTA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUaHUsIDEgU2VwIDIwMTYgMTU6MzA6MzkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBwcmludEVy cgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIHwgMTQgKysrKysrKysrKysr KysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwICAgfCAyMiArKysrKysrKysrKysrKyst LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMjIyMDIxNi4uZDUzN2NlZSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMDktMDEgIEpGIEJhc3RpZW4g IDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIGpzYzogcHJvdmlkZSBwcmludEVycigp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE1MTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5j cHA6CisgICAgICAgIChHbG9iYWxPYmplY3Q6OmZpbmlzaENyZWF0aW9uKToKKyAgICAgICAgKHBy aW50SW50ZXJuYWwpOiByZW5hbWVkIGZyb20gZnVuY3Rpb25QcmludCwgYWRkIGVycm9yIGNoZWNr aW5nCisgICAgICAgIChmdW5jdGlvblByaW50U3RkT3V0KTogcHVudCB0byBwcmludEludGVybmFs CisgICAgICAgIChmdW5jdGlvblByaW50U3RkRXJyKTogcHVudCB0byBwcmludEludGVybmFsCisg ICAgICAgIChmdW5jdGlvblByaW50KTogRGVsZXRlZC4KKwogMjAxNi0wOS0wMSAgS2VpdGggTWls bGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgV0FTTSBjbGFz c2VzIGRyb3BwaW5nIHRoZSBXQVNNIHByZWZpeApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2pzYy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCAxMTAx OWM1Li5kMzZmOWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcApAQCAtNTc4LDcgKzU3OCw4IEBAIHN0 YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uR2V0RWxlbWVudChFeGVj U3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uQ3Jl YXRlU2ltcGxlT2JqZWN0KEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgZnVuY3Rpb25HZXRIaWRkZW5WYWx1ZShFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uU2V0SGlkZGVuVmFsdWUoRXhlY1N0YXRl Kik7Ci1zdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblByaW50KEV4 ZWNTdGF0ZSopOworc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25Q cmludFN0ZE91dChFeGVjU3RhdGUqKTsKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9D QUxMIGZ1bmN0aW9uUHJpbnRTdGRFcnIoRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5jb2RlZEpTVmFs dWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlYnVnKEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29k ZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25EZXNjcmliZShFeGVjU3RhdGUqKTsKIHN0 YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRGVzY3JpYmVBcnJheShF eGVjU3RhdGUqKTsKQEAgLTc3OSw3ICs3ODAsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIGFkZEZ1 bmN0aW9uKHZtLCAiZGVidWciLCBmdW5jdGlvbkRlYnVnLCAxKTsKICAgICAgICAgYWRkRnVuY3Rp b24odm0sICJkZXNjcmliZSIsIGZ1bmN0aW9uRGVzY3JpYmUsIDEpOwogICAgICAgICBhZGRGdW5j dGlvbih2bSwgImRlc2NyaWJlQXJyYXkiLCBmdW5jdGlvbkRlc2NyaWJlQXJyYXksIDEpOwotICAg ICAgICBhZGRGdW5jdGlvbih2bSwgInByaW50IiwgZnVuY3Rpb25QcmludCwgMSk7CisgICAgICAg IGFkZEZ1bmN0aW9uKHZtLCAicHJpbnQiLCBmdW5jdGlvblByaW50U3RkT3V0LCAxKTsKKyAgICAg ICAgYWRkRnVuY3Rpb24odm0sICJwcmludEVyciIsIGZ1bmN0aW9uUHJpbnRTdGRFcnIsIDEpOwog ICAgICAgICBhZGRGdW5jdGlvbih2bSwgInF1aXQiLCBmdW5jdGlvblF1aXQsIDApOwogICAgICAg ICBhZGRGdW5jdGlvbih2bSwgImFib3J0IiwgZnVuY3Rpb25BYm9ydCwgMCk7CiAgICAgICAgIGFk ZEZ1bmN0aW9uKHZtLCAiZ2MiLCBmdW5jdGlvbkdDQW5kU3dlZXAsIDApOwpAQCAtMTE1Miw3ICsx MTU0LDcgQEAgSlNJbnRlcm5hbFByb21pc2UqIEdsb2JhbE9iamVjdDo6bW9kdWxlTG9hZGVyRmV0 Y2goSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwKIH0KIAogCi1FbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGZ1bmN0aW9uUHJpbnQoRXhlY1N0YXRlKiBleGVjKQorc3RhdGljIEVuY29k ZWRKU1ZhbHVlIHByaW50SW50ZXJuYWwoRXhlY1N0YXRlKiBleGVjLCBGSUxFKiBvdXQpCiB7CiAg ICAgaWYgKHRlc3QyNjJBc3luY1Rlc3QpIHsKICAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IGV4ZWMt PmFyZ3VtZW50KDApOwpAQCAtMTE2MywxNiArMTE2NSwyMiBAQCBFbmNvZGVkSlNWYWx1ZSBKU0Nf SE9TVF9DQUxMIGZ1bmN0aW9uUHJpbnQoRXhlY1N0YXRlKiBleGVjKQogCiAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGV4ZWMtPmFyZ3VtZW50Q291bnQoKTsgKytpKSB7CiAgICAgICAgIGlm IChpKQotICAgICAgICAgICAgcHV0Y2hhcignICcpOworICAgICAgICAgICAgaWYgKEVPRiA9PSBm cHV0YygnICcsIG91dCkpCisgICAgICAgICAgICAgICAgZ290byBmYWlsOwogCi0gICAgICAgIHBy aW50ZigiJXMiLCBleGVjLT51bmNoZWNrZWRBcmd1bWVudChpKS50b1N0cmluZyhleGVjKS0+dmll dyhleGVjKS5nZXQoKS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgaWYgKGZwcmludGYob3V0LCAi JXMiLCBleGVjLT51bmNoZWNrZWRBcmd1bWVudChpKS50b1N0cmluZyhleGVjKS0+dmlldyhleGVj KS5nZXQoKS51dGY4KCkuZGF0YSgpKSA8IDApCisgICAgICAgICAgICBnb3RvIGZhaWw7CiAgICAg fQogCi0gICAgcHV0Y2hhcignXG4nKTsKLSAgICBmZmx1c2goc3Rkb3V0KTsKKyAgICBmcHV0Yygn XG4nLCBvdXQpOworZmFpbDoKKyAgICBmZmx1c2gob3V0KTsKICAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogfQogCitFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGZ1bmN0aW9uUHJpbnRTdGRPdXQoRXhlY1N0YXRlKiBleGVjKSB7IHJldHVybiBwcmludEludGVy bmFsKGV4ZWMsIHN0ZG91dCk7IH0KK0VuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rp b25QcmludFN0ZEVycihFeGVjU3RhdGUqIGV4ZWMpIHsgcmV0dXJuIHByaW50SW50ZXJuYWwoZXhl Yywgc3RkZXJyKTsgfQorCiAjaWZuZGVmIE5ERUJVRwogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1Rf Q0FMTCBmdW5jdGlvbkR1bXBDYWxsRnJhbWUoRXhlY1N0YXRlKiBleGVjKQogewotLSAKMi45LjMK Cg==