161512 2016-09-01 15:04:09 -0700 Use BlockPtr::fromCallable in WorkQueue::dispatch and WorkQueue::dispatchAfter 2016-09-01 15:47:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cdumez cmarcelo commit-queue dbates oldest_to_newest 1225553 0 andersca 2016-09-01 15:04:09 -0700 Use BlockPtr::fromCallable in WorkQueue::dispatch and WorkQueue::dispatchAfter 1225556 1 287688 andersca 2016-09-01 15:05:07 -0700 Created attachment 287688 Patch 1225558 2 commit-queue 2016-09-01 15:06:21 -0700 Attachment 287688 did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1225578 3 andersca 2016-09-01 15:47:46 -0700 Committed r205325: <http://trac.webkit.org/changeset/205325> 287688 2016-09-01 15:05:07 -0700 2016-09-01 15:14:17 -0700 Patch bug-161512-20160901150253.patch text/plain 3690 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM3YjU4Y2JjNDkwYmFhNGMwZWIxNDk1 YWUxOTVjN2Q2MTU1NTNmNzkuLjlkMWViNmI1MmJjNWM4Y2Q5ZDlkN2Y3YWExMDk0NjBlOGNhZDhk NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTYtMDktMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBVc2UgQmxvY2tQdHI6OmZyb21DYWxsYWJsZSBp biBXb3JrUXVldWU6OmRpc3BhdGNoIGFuZCBXb3JrUXVldWU6OmRpc3BhdGNoQWZ0ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTUxMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbGV0cyB1cyBn ZXQgcmlkIG9mIGxlYWtDYWxsYWJsZSBhbmQgYWRvcHRDYWxsYWJsZS4KKworICAgICAgICAqIHd0 Zi9CbG9ja1B0ci5oOgorICAgICAgICAqIHd0Zi9GdW5jdGlvbi5oOgorICAgICAgICAqIHd0Zi9j b2NvYS9Xb3JrUXVldWVDb2NvYS5jcHA6CisgICAgICAgIChXVEY6OldvcmtRdWV1ZTo6ZGlzcGF0 Y2gpOgorICAgICAgICAoV1RGOjpXb3JrUXVldWU6OmRpc3BhdGNoQWZ0ZXIpOgorCisyMDE2LTA5 LTAxICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgYWRk IEJsb2NrUHRyOjpmcm9tQ2FsbGFibGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MTUwNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9CbG9j a1B0ci5oIGIvU291cmNlL1dURi93dGYvQmxvY2tQdHIuaAppbmRleCA0ZWU5NDkzZDNjMDk5N2Ey NjExZWVmY2UzNzE1MzQzZDZiZGYyZTg5Li4xYjc5ZDQxNzhmZTFmYTcwZWQ3MDdmY2JmYWFhOTZk YmM3YmMwZTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9CbG9ja1B0ci5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL0Jsb2NrUHRyLmgKQEAgLTkwLDcgKzkwLDcgQEAgcHVibGljOgogICAgICAg ICBuZXcgKCZibG9jay0+ZikgRiB7IHN0ZDo6bW92ZShmdW5jdGlvbikgfTsKIAogICAgICAgICBC bG9ja1B0ciBibG9ja1B0cjsKLSAgICAgICAgYmxvY2tQdHIubV9ibG9jayA9IHN0YXRpY19jYXN0 PEJsb2NrVHlwZT4oYmxvY2spOworICAgICAgICBibG9ja1B0ci5tX2Jsb2NrID0gcmVpbnRlcnBy ZXRfY2FzdDxCbG9ja1R5cGU+KGJsb2NrKTsKIAogICAgICAgICByZXR1cm4gYmxvY2tQdHI7CiAg ICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRnVuY3Rpb24uaCBiL1NvdXJjZS9XVEYv d3RmL0Z1bmN0aW9uLmgKaW5kZXggNWI3MDBjNzIzNDdjNDI1NzczMzc4YmYwN2VkMGI3N2E2N2Zh ZmVjYS4uMWM5NTg1NjIzOGU0N2M1ZDhiMzhkODYxYzBiZjcxZGJlZDhiZGNlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvRnVuY3Rpb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GdW5jdGlv bi5oCkBAIC02Niw2ICs2Niw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAg IH0KIAorcHJpdmF0ZToKICAgICBjbGFzcyBDYWxsYWJsZVdyYXBwZXJCYXNlIHsKICAgICAgICAg V1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiAgICAgcHVibGljOgpAQCAtNzQsMTkgKzc1LDYgQEAg cHVibGljOgogICAgICAgICB2aXJ0dWFsIE91dCBjYWxsKEluLi4uKSA9IDA7CiAgICAgfTsKIAot ICAgIENhbGxhYmxlV3JhcHBlckJhc2UqIGxlYWtDYWxsYWJsZSgpIFdBUk5fVU5VU0VEX1JFVFVS TgotICAgIHsKLSAgICAgICAgcmV0dXJuIG1fY2FsbGFibGVXcmFwcGVyLnJlbGVhc2UoKTsKLSAg ICB9Ci0KLSAgICBzdGF0aWMgRnVuY3Rpb24gYWRvcHRDYWxsYWJsZShDYWxsYWJsZVdyYXBwZXJC YXNlKiBjYWxsYWJsZSkKLSAgICB7Ci0gICAgICAgIEZ1bmN0aW9uIGZ1bmN0aW9uOwotICAgICAg ICBmdW5jdGlvbi5tX2NhbGxhYmxlV3JhcHBlci5yZXNldChjYWxsYWJsZSk7Ci0gICAgICAgIHJl dHVybiBmdW5jdGlvbjsKLSAgICB9Ci0KLXByaXZhdGU6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUg Q2FsbGFibGVUeXBlPgogICAgIGNsYXNzIENhbGxhYmxlV3JhcHBlciA6IHB1YmxpYyBDYWxsYWJs ZVdyYXBwZXJCYXNlIHsKICAgICBwdWJsaWM6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9j b2NvYS9Xb3JrUXVldWVDb2NvYS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9Xb3JrUXVldWVD b2NvYS5jcHAKaW5kZXggOTI2M2FlNTg3Yjg3NTA2YWE2NzNmNWY1ODZkZmI1MzA0MmI3MGQ0My4u OGVkYmYyM2M1NTg4ODgyOTZjMTRjOGM5ZDBlZTBjNGY2MzMwYjMyMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvY29jb2EvV29ya1F1ZXVlQ29jb2EuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L2NvY29hL1dvcmtRdWV1ZUNvY29hLmNwcApAQCAtMjUsMjkgKzI1LDIzIEBACiAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJXb3JrUXVldWUuaCIKKyNpbmNsdWRlICJCbG9ja1B0ci5o IgorI2luY2x1ZGUgIlJlZi5oIgogCiBuYW1lc3BhY2UgV1RGIHsKIAogdm9pZCBXb3JrUXVldWU6 OmRpc3BhdGNoKEZ1bmN0aW9uPHZvaWQgKCk+JiYgZnVuY3Rpb24pCiB7Ci0gICAgcmVmKCk7Ci0g ICAgYXV0byogY2FsbGFibGUgPSBmdW5jdGlvbi5sZWFrQ2FsbGFibGUoKTsKLSAgICBkaXNwYXRj aF9hc3luYyhtX2Rpc3BhdGNoUXVldWUsIF57Ci0gICAgICAgIGF1dG8gZnVuY3Rpb24gPSBGdW5j dGlvbjx2b2lkICgpPjo6YWRvcHRDYWxsYWJsZShjYWxsYWJsZSk7CisgICAgZGlzcGF0Y2hfYXN5 bmMobV9kaXNwYXRjaFF1ZXVlLCBCbG9ja1B0cjx2b2lkICgpPjo6ZnJvbUNhbGxhYmxlKFtwcm90 ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGZ1bmN0aW9uID0gV1RGTW92ZShmdW5jdGlvbild IHsKICAgICAgICAgZnVuY3Rpb24oKTsKLSAgICAgICAgZGVyZWYoKTsKLSAgICB9KTsKKyAgICB9 KS5nZXQoKSk7CiB9CiAKIHZvaWQgV29ya1F1ZXVlOjpkaXNwYXRjaEFmdGVyKHN0ZDo6Y2hyb25v OjpuYW5vc2Vjb25kcyBkdXJhdGlvbiwgRnVuY3Rpb248dm9pZCAoKT4mJiBmdW5jdGlvbikKIHsK LSAgICByZWYoKTsKLSAgICBhdXRvKiBjYWxsYWJsZSA9IGZ1bmN0aW9uLmxlYWtDYWxsYWJsZSgp OwotICAgIGRpc3BhdGNoX2FmdGVyKGRpc3BhdGNoX3RpbWUoRElTUEFUQ0hfVElNRV9OT1csIGR1 cmF0aW9uLmNvdW50KCkpLCBtX2Rpc3BhdGNoUXVldWUsIF57Ci0gICAgICAgIGF1dG8gZnVuY3Rp b24gPSBGdW5jdGlvbjx2b2lkICgpPjo6YWRvcHRDYWxsYWJsZShjYWxsYWJsZSk7CisgICAgZGlz cGF0Y2hfYWZ0ZXIoZGlzcGF0Y2hfdGltZShESVNQQVRDSF9USU1FX05PVywgZHVyYXRpb24uY291 bnQoKSksIG1fZGlzcGF0Y2hRdWV1ZSwgQmxvY2tQdHI8dm9pZCAoKT46OmZyb21DYWxsYWJsZShb cHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBmdW5jdGlvbiA9IFdURk1vdmUoZnVuY3Rp b24pXSB7CiAgICAgICAgIGZ1bmN0aW9uKCk7Ci0gICAgICAgIGRlcmVmKCk7Ci0gICAgfSk7Cisg ICAgfSkuZ2V0KCkpOwogfQogCiAjaWYgSEFWRShRT1NfQ0xBU1NFUykK