161510 2016-09-01 14:25:08 -0700 Web Inspector: NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined 2016-09-02 10:48:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jj webkit-unassigned bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1225534 0 jj 2016-09-01 14:25:08 -0700 WebInspector.NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined which causes new network record bars to be always be dumped on the next row in the NetworkTimelineOverview instead of rows where they might be able to fit in. 1225535 1 webkit-bug-importer 2016-09-01 14:25:30 -0700 <rdar://problem/28123169> 1225539 2 287682 jj 2016-09-01 14:36:49 -0700 Created attachment 287682 Patch 1225612 3 287682 bburg 2016-09-01 16:28:03 -0700 Comment on attachment 287682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287682&action=review r=me > Source/WebInspectorUI/ChangeLog:12 > + by using MinimumWidthPixel, MinimumMarginPixel and MinimumDurationPerPixel as the secondsPerPixel value. I do not know if similar values are used by network overview, as it is a different algorithm. But it seems more sensible that giving up. 1225821 4 287682 commit-queue 2016-09-02 10:48:08 -0700 Comment on attachment 287682 Patch Clearing flags on attachment: 287682 Committed r205349: <http://trac.webkit.org/changeset/205349> 1225822 5 commit-queue 2016-09-02 10:48:20 -0700 All reviewed patches have been landed. Closing bug. 287682 2016-09-01 14:36:49 -0700 2016-09-02 10:48:08 -0700 Patch bug-161510-20160901143435.patch text/plain 5038 jj U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx OWFkMmI3NGRkYjhlNzYyMjJiMmUwZmQ2ZGQ3ZmFhNjBlNGI2MGYwLi5iNWNkZDEyYWQ2YzZiMDlh MjBjYzRhMGY2OWI1MGVkY2YyMTQ4ZTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wOS0wMSAgSm9oYW4gSy4gSmVuc2VuICA8am9oYW5famVuc2VuQGFw cGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrVGltZWxpbmVPdmVydmll d0dyYXBoLk1pbmltdW1CYXJQYWRkaW5nVGltZSBpcyB1bmRlZmluZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTUxMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9O ZXR3b3JrVGltZWxpbmVPdmVydmlld0dyYXBoLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5l dHdvcmtUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJvdG90eXBlLl9uZXR3b3JrVGltZWxpbmVSZWNv cmRBZGRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lT3ZlcnZpZXdH cmFwaCk6CisgICAgICAgIENhbGN1bGF0ZSB0aGUgbWluaW11bUJhclBhZGRpbmdUaW1lIGluIHNp bWlsYXIgd2F5cyB0byBUaW1lbGluZVJlY29yZEJhciwKKyAgICAgICAgYnkgdXNpbmcgTWluaW11 bVdpZHRoUGl4ZWwsIE1pbmltdW1NYXJnaW5QaXhlbCBhbmQgTWluaW11bUR1cmF0aW9uUGVyUGl4 ZWwgYXMgdGhlIHNlY29uZHNQZXJQaXhlbCB2YWx1ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZU92ZXJ2aWV3KToKKyAgICAgICAgTWFrZSBNaW5pbXVtL01heGltdW1EdXJhdGlvblBlclBp eGVsIHB1YmxpYyBwcm9wZXJ0aWVzLgorCiAyMDE2LTA4LTMwICBKb2hhbiBLLiBKZW5zZW4gIDxq b2hhbl9qZW5zZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCByZXNv dXJjZSB0aW1pbmcgbW9kZWwgd2l0aCB0aW1pbmcgaW5mb3JtYXRpb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZU92 ZXJ2aWV3R3JhcGguanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrVGltZWxpbmVPdmVydmlld0dyYXBoLmpzCmluZGV4IDIxZGFiMGEyNTkwYWJmYTFl ZjA4MWQ5M2RjN2M0M2EzMWE0NzQwYTMuLmI0NDEwYzlkZmVlYWEwMDZhMDNiMzlmN2Y3YzM3MmI5 MmRlOGYwNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL05ldHdvcmtUaW1lbGluZU92ZXJ2aWV3R3JhcGguanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lT3ZlcnZpZXdHcmFw aC5qcwpAQCAtMTE0LDEzICsxMTQsMTUgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtUaW1lbGluZU92 ZXJ2aWV3R3JhcGggPSBjbGFzcyBOZXR3b3JrVGltZWxpbmVPdmVydmlld0dyYXBoIGUKICAgICAg ICAgICAgIHJldHVybiBhLnN0YXJ0VGltZSAtIGIuc3RhcnRUaW1lOwogICAgICAgICB9CiAKKyAg ICAgICAgbGV0IG1pbmltdW1CYXJQYWRkaW5nVGltZSA9IFdlYkluc3BlY3Rvci5UaW1lbGluZU92 ZXJ2aWV3Lk1pbmltdW1EdXJhdGlvblBlclBpeGVsICogKFdlYkluc3BlY3Rvci5UaW1lbGluZVJl Y29yZEJhci5NaW5pbXVtV2lkdGhQaXhlbHMgKyBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRC YXIuTWluaW11bU1hcmdpblBpeGVscykKKwogICAgICAgICAvLyBUcnkgdG8gZmluZCBhIHJvdyB0 aGF0IGhhcyByb29tIGFuZCBkb2VzIG5vdCBvdmVybGFwIGEgcHJldmlvdXMgcmVjb3JkLgogICAg ICAgICB2YXIgZm91bmRSb3dGb3JSZWNvcmQgPSBmYWxzZTsKICAgICAgICAgZm9yICh2YXIgaSA9 IDA7IGkgPCB0aGlzLl90aW1lbGluZVJlY29yZEdyaWRSb3dzLmxlbmd0aDsgKytpKSB7CiAgICAg ICAgICAgICB2YXIgcm93UmVjb3JkcyA9IHRoaXMuX3RpbWVsaW5lUmVjb3JkR3JpZFJvd3NbaV07 CiAgICAgICAgICAgICB2YXIgbGFzdFJlY29yZCA9IHJvd1JlY29yZHMubGFzdFZhbHVlOwogCi0g ICAgICAgICAgICBpZiAoIWxhc3RSZWNvcmQgfHwgbGFzdFJlY29yZC5lbmRUaW1lICsgV2ViSW5z cGVjdG9yLk5ldHdvcmtUaW1lbGluZU92ZXJ2aWV3R3JhcGguTWluaW11bUJhclBhZGRpbmdUaW1l IDw9IHJlc291cmNlVGltZWxpbmVSZWNvcmQuc3RhcnRUaW1lKSB7CisgICAgICAgICAgICBpZiAo IWxhc3RSZWNvcmQgfHwgbGFzdFJlY29yZC5lbmRUaW1lICsgbWluaW11bUJhclBhZGRpbmdUaW1l IDw9IHJlc291cmNlVGltZWxpbmVSZWNvcmQuc3RhcnRUaW1lKSB7CiAgICAgICAgICAgICAgICAg aW5zZXJ0T2JqZWN0SW50b1NvcnRlZEFycmF5KHJlc291cmNlVGltZWxpbmVSZWNvcmQsIHJvd1Jl Y29yZHMsIGNvbXBhcmVCeVN0YXJ0VGltZSk7CiAgICAgICAgICAgICAgICAgdGhpcy5fbmV4dER1 bXBSb3cgPSBpICsgMTsKICAgICAgICAgICAgICAgICBmb3VuZFJvd0ZvclJlY29yZCA9IHRydWU7 CkBAIC0xMzUsNyArMTM3LDcgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtUaW1lbGluZU92ZXJ2aWV3 R3JhcGggPSBjbGFzcyBOZXR3b3JrVGltZWxpbmVPdmVydmlld0dyYXBoIGUKICAgICAgICAgICAg ICAgICB2YXIgbGFzdFJlY29yZCA9IHJvd1JlY29yZHMubGFzdFZhbHVlOwogICAgICAgICAgICAg ICAgIGNvbnNvbGUuYXNzZXJ0KGxhc3RSZWNvcmQpOwogCi0gICAgICAgICAgICAgICAgaWYgKGxh c3RSZWNvcmQuYWN0aXZlU3RhcnRUaW1lICsgV2ViSW5zcGVjdG9yLk5ldHdvcmtUaW1lbGluZU92 ZXJ2aWV3R3JhcGguTWluaW11bUJhclBhZGRpbmdUaW1lIDw9IHJlc291cmNlVGltZWxpbmVSZWNv cmQuc3RhcnRUaW1lKSB7CisgICAgICAgICAgICAgICAgaWYgKGxhc3RSZWNvcmQuYWN0aXZlU3Rh cnRUaW1lICsgbWluaW11bUJhclBhZGRpbmdUaW1lIDw9IHJlc291cmNlVGltZWxpbmVSZWNvcmQu c3RhcnRUaW1lKSB7CiAgICAgICAgICAgICAgICAgICAgIGluc2VydE9iamVjdEludG9Tb3J0ZWRB cnJheShyZXNvdXJjZVRpbWVsaW5lUmVjb3JkLCByb3dSZWNvcmRzLCBjb21wYXJlQnlTdGFydFRp bWUpOwogICAgICAgICAgICAgICAgICAgICB0aGlzLl9uZXh0RHVtcFJvdyA9IGkgKyAxOwogICAg ICAgICAgICAgICAgICAgICBmb3VuZFJvd0ZvclJlY29yZCA9IHRydWU7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3 LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVP dmVydmlldy5qcwppbmRleCAyZTgzYzc5YmI4YjdhNzkxZDY4NDk5MzlkNjMyYWFjZDYxYTZmM2U0 Li5lNjQ5NTkzOTdhMzFlZTFjZmY2YzVjMTBlM2QyM2Y0Mzg0ZGQwMzdiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lT3ZlcnZpZXcuanMKQEAgLTMxLDcgKzMxLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3Zl cnZpZXcgPSBjbGFzcyBUaW1lbGluZU92ZXJ2aWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcK IAogICAgICAgICBjb25zb2xlLmFzc2VydCh0aW1lbGluZVJlY29yZGluZyBpbnN0YW5jZW9mIFdl Ykluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZyk7CiAKLSAgICAgICAgdGhpcy5fdGltZWxpbmVz Vmlld01vZGVTZXR0aW5ncyA9IHRoaXMuX2NyZWF0ZVZpZXdNb2RlU2V0dGluZ3MoV2ViSW5zcGVj dG9yLlRpbWVsaW5lT3ZlcnZpZXcuVmlld01vZGUuVGltZWxpbmVzLCAwLjAwMDEsIDYwLCAwLjAx LCAwLCAxNSk7CisgICAgICAgIHRoaXMuX3RpbWVsaW5lc1ZpZXdNb2RlU2V0dGluZ3MgPSB0aGlz Ll9jcmVhdGVWaWV3TW9kZVNldHRpbmdzKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlZp ZXdNb2RlLlRpbWVsaW5lcywgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcuTWluaW11bUR1 cmF0aW9uUGVyUGl4ZWwsIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3Lk1heGltdW1EdXJh dGlvblBlclBpeGVsLCAwLjAxLCAwLCAxNSk7CiAgICAgICAgIHRoaXMuX2luc3RydW1lbnRUeXBl cyA9IFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuYXZhaWxhYmxlVGltZWxpbmVUeXBlcygp OwogCiAgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuRlBTSW5zdHJ1bWVudC5zdXBwb3J0ZWQoKSkg ewpAQCAtOTk1LDYgKzk5NSw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlBsYWNl aG9sZGVyT3ZlcnZpZXdHcmFwaCA9IFN5bWJvbCgicGxhY2Vob2xkZXItb3ZlCiAKIFdlYkluc3Bl Y3Rvci5UaW1lbGluZU92ZXJ2aWV3LlNjcm9sbERlbHRhRGVub21pbmF0b3IgPSA1MDA7CiBXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlldy5FZGl0SW5zdHJ1bWVudHNTdHlsZUNsYXNzTmFtZSA9 ICJlZGl0LWluc3RydW1lbnRzIjsKK1dlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3Lk1pbmlt dW1EdXJhdGlvblBlclBpeGVsID0gMC4wMDAxOworV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZp ZXcuTWF4aW11bUR1cmF0aW9uUGVyUGl4ZWwgPSA2MDsKIAogV2ViSW5zcGVjdG9yLlRpbWVsaW5l T3ZlcnZpZXcuVmlld01vZGUgPSB7CiAgICAgVGltZWxpbmVzOiAidGltZWxpbmUtb3ZlcnZpZXct dmlldy1tb2RlLXRpbWVsaW5lcyIsCg==