161484 2016-09-01 04:28:04 -0700 [GTK] GL_PACK_ROW_LENGTH is not available in GLES2 2016-09-05 07:24:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihailescu2m gustavo bugs-noreply emanuele.aina gustavo oldest_to_newest 1225308 0 mihailescu2m 2016-09-01 04:28:04 -0700 Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp AcceleratedBackingStoreWayland::paint makes use of GL_PACK_ROW_LENGTH, which is missing in many (egl/gles) platforms 1225309 1 mihailescu2m 2016-09-01 04:54:14 -0700 for my GPU (mali 768) i found GL_PACK_ROW_LENGTH is a GLES3 function in GLES3/gl3.h: #ifndef GL_ES_VERSION_3_0 #define GL_ES_VERSION_3_0 1 typedef unsigned short GLhalf; #define GL_READ_BUFFER 0x0C02 #define GL_UNPACK_ROW_LENGTH 0x0CF2 #define GL_UNPACK_SKIP_ROWS 0x0CF3 #define GL_UNPACK_SKIP_PIXELS 0x0CF4 #define GL_PACK_ROW_LENGTH 0x0D02 ... but maybe it should be replaced by a GLES2 function for better compatibility. 1225862 2 287790 gustavo 2016-09-02 11:43:26 -0700 Created attachment 287790 Patch 1226425 3 gustavo 2016-09-05 07:24:16 -0700 Committed r205452: <http://trac.webkit.org/changeset/205452> 287790 2016-09-02 11:43:26 -0700 2016-09-02 22:12:34 -0700 Patch bug-161484-20160902154109.patch text/plain 3023 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDcwOTUzNjUwNjE0ODM1 ZDlkNmI5MDA0NWZjYWQzOGViMTEyYWU3YS4uZDBmYjcwYzIxMzZhM2FkM2E5NDQ3ZjlkMmFmZDdk OGZlYzIwMDAxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTAyICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisg ICAgICAgIFtHVEtdIEdMX1BBQ0tfUk9XX0xFTkdUSCBpcyBub3QgYXZhaWxhYmxlIGluIEdMRVMy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE0ODQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmNwcDoKKyAgICAgICAgKFdl YktpdDo6QWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kOjpwYWludCk6IHdoZW4gdW5kZXIg R0xFUzIgd2UgY2Fubm90IHJlbHkgb24KKyAgICAgICAgR0xfUEFDS19ST1dfTEVOR1RIOyB1c2Ug Z2xSZWFkUGl4ZWwgZGlyZWN0bHkgd2hlbiBzdHJpZGUgbWF0Y2hlcyB3aWR0aCwgcmVhZCBsaW5l CisgICAgICAgIGJ5IGxpbmUgbWFudWFsbHkgb3RoZXJ3aXNlLiBDb2xvdXIgY29udmVyc2lvbiBp cyBhbHNvIHJlcXVpcmVkIHRvIGdldCB0aGUgZGF0YSBvdXQKKyAgICAgICAgY29ycmVjdGx5Lgor CiAyMDE2LTA5LTAyICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAg ICAgICBGaXggR09iamVjdCBiaW5kaW5ncyBidWlsZCBicmVha2FnZSB3aGVuIGNvbXBpbGluZyB3 aXRoIEVOQUJMRV9VU0VSX1RJTUlORyBkaXNhYmxlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5k LmNwcAppbmRleCAyZjZiYTYzNTVkN2ZlMjJhNzQ4ZjgxZWY3NTM4N2U0NTY5ZDZkMzU0Li5mOGIy YjUwYjc1NjZhOGNiMzliZWZjMTg3Mzg3OTI3NzA2MGE0MjlmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9y ZVdheWxhbmQuY3BwCkBAIC04OSwxMyArODksMjggQEAgYm9vbCBBY2NlbGVyYXRlZEJhY2tpbmdT dG9yZVdheWxhbmQ6OnBhaW50KGNhaXJvX3QqIGNyLCBjb25zdCBJbnRSZWN0JiBjbGlwUmVjdCkK ICAgICBnbEZyYW1lYnVmZmVyVGV4dHVyZTJEKEdMX0ZSQU1FQlVGRkVSLCBHTF9DT0xPUl9BVFRB Q0hNRU5UMCwgR0xfVEVYVFVSRV8yRCwgdGV4dHVyZSwgMCk7CiAKICAgICBnbFBpeGVsU3RvcmVp KEdMX1BBQ0tfQUxJR05NRU5ULCA0KTsKLSAgICBnbFBpeGVsU3RvcmVpKEdMX1BBQ0tfUk9XX0xF TkdUSCwgY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfc3RyaWRlKG1fc3VyZmFjZS5nZXQoKSkgLyA0 KTsKKwogI2lmIFVTRShPUEVOR0xfRVNfMikKLSAgICBnbFJlYWRQaXhlbHMoMCwgMCwgdGV4dHVy ZVNpemUud2lkdGgoKSwgdGV4dHVyZVNpemUuaGVpZ2h0KCksIEdMX1JHQkEsIEdMX1VOU0lHTkVE X0JZVEUsIGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2RhdGEobV9zdXJmYWNlLmdldCgpKSk7Cisg ICAgdW5zaWduZWQgY2hhciogZGF0YSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2RhdGEobV9z dXJmYWNlLmdldCgpKTsKKyAgICBpZiAoY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfc3RyaWRlKG1f c3VyZmFjZS5nZXQoKSkgPT0gc2l6ZS53aWR0aCgpICogNCkKKyAgICAgICAgZ2xSZWFkUGl4ZWxz KDAsIDAsIHRleHR1cmVTaXplLndpZHRoKCksIHRleHR1cmVTaXplLmhlaWdodCgpLCBHTF9SR0JB LCBHTF9VTlNJR05FRF9CWVRFLCBkYXRhKTsKKyAgICBlbHNlIHsKKyAgICAgICAgaW50IHN0cmlk ZUJ5dGVzID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfc3RyaWRlKG1fc3VyZmFjZS5nZXQoKSk7 CisgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgdGV4dHVyZVNpemUuaGVpZ2h0KCk7IGkrKykg eworICAgICAgICAgICAgdW5zaWduZWQgY2hhciogZGF0YU9mZnNldCA9IGRhdGEgKyBpICogc3Ry aWRlQnl0ZXM7CisgICAgICAgICAgICBnbFJlYWRQaXhlbHMoMCwgaSwgdGV4dHVyZVNpemUud2lk dGgoKSwgMSwgR0xfUkdCQSwgR0xfVU5TSUdORURfQllURSwgZGF0YU9mZnNldCk7CisgICAgICAg IH0KKyAgICB9CisKKyAgICAvLyBDb252ZXJ0IHRvIEJHUkEuCisgICAgaW50IHRvdGFsQnl0ZXMg PSBzaXplLndpZHRoKCkgKiBzaXplLmhlaWdodCgpICogNDsKKyAgICBmb3IgKGludCBpID0gMDsg aSA8IHRvdGFsQnl0ZXM7IGkgKz0gNCkKKyAgICAgICAgc3RkOjpzd2FwKGRhdGFbaV0sIGRhdGFb aSArIDJdKTsKICNlbHNlCisgICAgZ2xQaXhlbFN0b3JlaShHTF9QQUNLX1JPV19MRU5HVEgsIGNh aXJvX2ltYWdlX3N1cmZhY2VfZ2V0X3N0cmlkZShtX3N1cmZhY2UuZ2V0KCkpIC8gNCk7CiAgICAg Z2xSZWFkUGl4ZWxzKDAsIDAsIHRleHR1cmVTaXplLndpZHRoKCksIHRleHR1cmVTaXplLmhlaWdo dCgpLCBHTF9CR1JBLCBHTF9VTlNJR05FRF9JTlRfOF84XzhfOF9SRVYsIGNhaXJvX2ltYWdlX3N1 cmZhY2VfZ2V0X2RhdGEobV9zdXJmYWNlLmdldCgpKSk7Ci0jZW5kaWYKICAgICBnbFBpeGVsU3Rv cmVpKEdMX1BBQ0tfUk9XX0xFTkdUSCwgMCk7CisjZW5kaWYKIAogICAgIGdsQmluZEZyYW1lYnVm ZmVyKEdMX0ZSQU1FQlVGRkVSLCAwKTsKICAgICBnbERlbGV0ZUZyYW1lYnVmZmVycygxLCAmZmIp Owo=