161475 2016-08-31 22:48:13 -0700 webkit-gtk 2.13.90 fails to configure on darwin without wayland 2016-09-01 10:33:56 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyhu webkit-unassigned bugs-noreply commit-queue oldest_to_newest 1225255 0 jeremyhu 2016-08-31 22:48:13 -0700 ---> Configuring webkit2-gtk-devel Executing: cd "/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX=/opt/local -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/usr" -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_FIND_FRAMEWORK=LAST -Wno-dev -DPORT=GTK -DUSE_SYSTEM_MALLOC=ON -DENABLE_INTROSPECTION=ON -DENABLE_MINIBROWSER=OFF -DENABLE_VIDEO=ON -DENABLE_GTKDOC=OFF -DENABLE_QUARTZ_TARGET=OFF -DENABLE_X11_TARGET=ON -DENABLE_OPENGL=ON -DENABLE_PLUGIN_PROCESS_GTK2=ON -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.12" -DCMAKE_OSX_SYSROOT="/" ../webkitgtk-2.13.90 ... -- Enabled features: -- ENABLE_ACCELERATED_2D_CANVAS .......... OFF -- ENABLE_CREDENTIAL_STORAGE ON -- ENABLE_DRAG_SUPPORT ................... ON -- ENABLE_GEOLOCATION ON -- ENABLE_GLES2 .......................... OFF -- ENABLE_GTKDOC OFF -- ENABLE_ICONDATABASE ................... ON -- ENABLE_INTROSPECTION ON -- ENABLE_JIT ............................ ON -- ENABLE_MEMORY_SAMPLER OFF -- ENABLE_MINIBROWSER .................... OFF -- ENABLE_OPENGL ON -- ENABLE_PLUGIN_PROCESS_GTK2 ............ ON -- ENABLE_QUARTZ_TARGET OFF -- ENABLE_SAMPLING_PROFILER .............. ON -- ENABLE_SPELLCHECK ON -- ENABLE_TOUCH_EVENTS ................... ON -- ENABLE_VIDEO ON -- ENABLE_WAYLAND_TARGET ................. OFF -- ENABLE_WEB_AUDIO ON -- ENABLE_X11_TARGET ..................... ON -- USE_LIBHYPHEN ON -- USE_LIBNOTIFY ......................... ON -- USE_SYSTEM_MALLOC ON -- Configuring done CMake Error at Source/cmake/WebKitMacros.cmake:225 (add_library): Cannot find source file: /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/webkit2gtk/WebKit2WaylandClientProtocol.c Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx Call Stack (most recent call first): Source/WebKit2/CMakeLists.txt:853 (WEBKIT_FRAMEWORK) --- It looks like you're missing a bunch of 'if (ENABLE_WAYLAND_TARGET)' around appropriate places in Source/WebKit2/PlatformGTK.cmake 1225265 1 287603 jeremyhu 2016-08-31 23:32:26 -0700 Created attachment 287603 0001-GTK-Fix-configuration-without-wayland-support.patch 1225269 2 287603 cgarcia 2016-08-31 23:36:57 -0700 Comment on attachment 287603 0001-GTK-Fix-configuration-without-wayland-support.patch View in context: https://bugs.webkit.org/attachment.cgi?id=287603&action=review Thanks > Source/WebKit2/ChangeLog:8 > + > + * PlatformGTK.cmake: Please, explain the problem here, you can just copy the description from the bug report. > Source/WebKit2/PlatformGTK.cmake:383 > +list(APPEND WebKit2_DERIVED_SOURCES This is not correctly indented. 1225272 3 jeremyhu 2016-08-31 23:38:52 -0700 Ok, thanks for the feedback. It's late and I need to wake up early tomorrow, so I'll cleanup the patch and resubmit tomorrow. 1225358 4 287624 jeremyhu 2016-09-01 09:52:08 -0700 Created attachment 287624 0001-GTK-Fix-configuration-without-wayland-support.patch (review comments addressed) 1225377 5 287624 commit-queue 2016-09-01 10:33:52 -0700 Comment on attachment 287624 0001-GTK-Fix-configuration-without-wayland-support.patch (review comments addressed) Clearing flags on attachment: 287624 Committed r205294: <http://trac.webkit.org/changeset/205294> 1225378 6 commit-queue 2016-09-01 10:33:56 -0700 All reviewed patches have been landed. Closing bug. 287603 2016-08-31 23:32:26 -0700 2016-09-01 09:52:08 -0700 0001-GTK-Fix-configuration-without-wayland-support.patch 0001-GTK-Fix-configuration-without-wayland-support.patch text/plain 2033 jeremyhu RnJvbSBhNjZmY2E1YmZkOWM3MWRlY2ExMzQxYWFhN2Q3ZmFmNmYxMWI5OWIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IFdlZCwgMzEgQXVnIDIwMTYgMjM6Mjk6MjQgLTA3MDAKU3ViamVjdDog W1BBVENIXSBbR1RLXSBGaXggY29uZmlndXJhdGlvbiB3aXRob3V0IHdheWxhbmQgc3VwcG9ydAoK aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQ3NQoKU2lnbmVkLW9m Zi1ieTogSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSA8amVyZW15aHVAYXBwbGUuY29tPgotLS0K IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgIHwgOSArKysrKysrKysKIFNvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIHwgNyArKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE1 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjNhM2RlMC4uM2Yz YzY3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA4LTMxICBKZXJlbXkgSHVk ZGxlc3RvbiBTZXF1b2lhICA8amVyZW15aHVAYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdIEZp eCBjb25maWd1cmF0aW9uIHdpdGhvdXQgd2F5bGFuZCBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE0NzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAy MDE2LTA4LTMxICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJLaXQgc2hvdWxkIHNldCBhIHN1YnN5c3RlbSBmb3Igb3NfbG9nIHNvIGl0J3MgZWFzaWVyIHRv IGZpbHRlciBmb3IgV2ViS2l0IGxvZyBtZXNzYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZQpp bmRleCBjMDAxYTExLi4wMGE3MjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMzc0 LDEyICszNzQsMTcgQEAgbGlzdChBUFBFTkQgV2ViS2l0Ml9ERVJJVkVEX1NPVVJDRVMKICAgICAk e0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0RJUn0vSW5zcGVjdG9yR1Jlc291cmNlQnVuZGxl LmMKICAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0RJUn0vV2ViS2l0Mkluc3BlY3Rv ckdSZXNvdXJjZUJ1bmRsZS5jCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9 L1dlYktpdDJSZXNvdXJjZXNHUmVzb3VyY2VCdW5kbGUuYwotICAgICR7REVSSVZFRF9TT1VSQ0VT X1dFQktJVDJHVEtfRElSfS9XZWJLaXQyV2F5bGFuZENsaWVudFByb3RvY29sLmMKIAogICAgICR7 REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfQVBJX0RJUn0vV2ViS2l0RW51bVR5cGVzLmNwcAog ICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfQVBJX0RJUn0vV2ViS2l0TWFyc2hhbC5j cHAKICkKIAoraWYgKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCkKK2xpc3QoQVBQRU5EIFdlYktpdDJf REVSSVZFRF9TT1VSQ0VTCisgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9L1dl YktpdDJXYXlsYW5kQ2xpZW50UHJvdG9jb2wuYworKQorZW5kaWYgKCkKKwogc2V0KFdlYktpdDJH VEtfSU5TVEFMTEVEX0hFQURFUlMKICAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0FQ SV9ESVJ9L1dlYktpdEVudW1UeXBlcy5oCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdU S19BUElfRElSfS9XZWJLaXRWZXJzaW9uLmgKLS0gCjIuOS4zCgo= 287624 2016-09-01 09:52:08 -0700 2016-09-01 10:33:52 -0700 0001-GTK-Fix-configuration-without-wayland-support.patch (review comments addressed) 0001-GTK-Fix-configuration-without-wayland-support.patch text/plain 2410 jeremyhu RnJvbSAxZmNmOWViNWQyOGVjMGE1YmQ0NDgwOWU2NmY0MGMwMDAwMDdkMWJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IFdlZCwgMzEgQXVnIDIwMTYgMjM6Mjk6MjQgLTA3MDAKU3ViamVjdDog W1BBVENIXSBbR1RLXSBGaXggY29uZmlndXJhdGlvbiB3aXRob3V0IHdheWxhbmQgc3VwcG9ydAoK aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQ3NQoKU2lnbmVkLW9m Zi1ieTogSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSA8amVyZW15aHVAYXBwbGUuY29tPgotLS0K IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIFNv dXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIHwgIDcgKysrKysrLQogMiBmaWxlcyBjaGFu Z2VkLCAyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGYzYTNk ZTAuLjg3NGQ2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNi0wOC0zMSAgSmVy ZW15IEh1ZGRsZXN0b24gU2VxdW9pYSAgPGplcmVteWh1QGFwcGxlLmNvbT4KKworICAgICAgICBb R1RLXSBGaXggY29uZmlndXJhdGlvbiB3aXRob3V0IHdheWxhbmQgc3VwcG9ydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNDc1CisKKyAgICAgICAg V2ViS2l0MldheWxhbmRDbGllbnRQcm90b2NvbC5jIGlzIGEgZGVyaXZlZCBzb3VyY2UgdGhhdCBp cyBjcmVhdGVkCisgICAgICAgIGNvbmRpdGlvbmFsbHkgb24gRU5BQkxFX1dBWUxBTkRfVEFSR0VU LiAgSXQgd2FzIGJlaW5nIGluY2x1ZGVkCisgICAgICAgIGluIHRoZSBzb3VyY2VzIGxpc3QgdW5j b25kaXRpb25hbGx5LCBzbyBjb25maWd1cmUgZmFpbGVkIHdoZW5ldmVyCisgICAgICAgIHdheWxh bmQgc3VwcG9ydCB3YXMgdW5hdmFpbGFibGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogSW5jbHVkZSBXZWJLaXQy V2F5bGFuZENsaWVudFByb3RvY29sLmMgaW4gc291cmNlIGxpc3QgY29uZGl0aW9uYWwgb24gRU5B QkxFX1dBWUxBTkRfVEFSR0VUCisKIDIwMTYtMDgtMzEgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdCBzaG91bGQgc2V0IGEgc3Vic3lzdGVtIGZvciBv c19sb2cgc28gaXQncyBlYXNpZXIgdG8gZmlsdGVyIGZvciBXZWJLaXQgbG9nIG1lc3NhZ2VzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGMwMDFhMTEuLjc3MzQwYmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtR1RLLmNtYWtlCkBAIC0zNzQsMTIgKzM3NCwxNyBAQCBsaXN0KEFQUEVORCBXZWJLaXQy X0RFUklWRURfU09VUkNFUwogICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfRElSfS9J bnNwZWN0b3JHUmVzb3VyY2VCdW5kbGUuYwogICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJH VEtfRElSfS9XZWJLaXQySW5zcGVjdG9yR1Jlc291cmNlQnVuZGxlLmMKICAgICAke0RFUklWRURf U09VUkNFU19XRUJLSVQyR1RLX0RJUn0vV2ViS2l0MlJlc291cmNlc0dSZXNvdXJjZUJ1bmRsZS5j Ci0gICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9L1dlYktpdDJXYXlsYW5kQ2xp ZW50UHJvdG9jb2wuYwogCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19BUElfRElS fS9XZWJLaXRFbnVtVHlwZXMuY3BwCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19B UElfRElSfS9XZWJLaXRNYXJzaGFsLmNwcAogKQogCitpZiAoRU5BQkxFX1dBWUxBTkRfVEFSR0VU KQorICAgIGxpc3QoQVBQRU5EIFdlYktpdDJfREVSSVZFRF9TT1VSQ0VTCisgICAgICAgICR7REVS SVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfRElSfS9XZWJLaXQyV2F5bGFuZENsaWVudFByb3RvY29s LmMKKyAgICApCitlbmRpZiAoKQorCiBzZXQoV2ViS2l0MkdUS19JTlNUQUxMRURfSEVBREVSUwog ICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfQVBJX0RJUn0vV2ViS2l0RW51bVR5cGVz LmgKICAgICAke0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0FQSV9ESVJ9L1dlYktpdFZlcnNp b24uaAotLSAKMi45LjMKCg==