<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>161474</bug_id>
          
          <creation_ts>2016-08-31 22:23:51 -0700</creation_ts>
          <short_desc>[CMake] Decouple generating bindings of WebCore and WebCoreTestSupport</short_desc>
          <delta_ts>2016-09-06 15:08:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lforschler</cc>
    
    <cc>ossy</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1225253</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-08-31 22:23:51 -0700</bug_when>
    <thetext>[CMake] Decouple generating bindings of WebCore and WebCoreTestSupport

Generating bindings of WebCore and WebCoreTestSupport shares a single supplementalDependencyFile.
But, nothing supplements any IDL of WebCoreTestSupport.
This introduces unnecessary dependencies.

Generating bindings of WebCoreTestSupport does not need a supplementalDependencyFile at the moment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225254</commentid>
    <comment_count>1</comment_count>
      <attachid>287601</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-08-31 22:43:45 -0700</bug_when>
    <thetext>Created attachment 287601
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225292</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-09-01 01:42:15 -0700</bug_when>
    <thetext>win-ews failed:

&gt; C:\cygwin\home\buildbot\WebKit\Source\WebCore\page\Settings.h(33): fatal error C1083: Cannot open include file: &apos;SettingsMacros.h&apos;: No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\StyleBuilder.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]
&gt; C:\cygwin\home\buildbot\WebKit\Source\WebCore\page\Settings.h(33): fatal error C1083: Cannot open include file: &apos;SettingsMacros.h&apos;: No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\Source\WebCore\DerivedSources.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]

WebCoreDerivedSources did not have a dependency to SettingsMacros.h.
According to the CMake document, I need to add SettingsMacros.h as the source file.

https://cmake.org/cmake/help/v3.0/prop_sf/OBJECT_DEPENDS.html

&gt; This property need not be used to specify the dependency of a source
&gt; file on a generated header file that it includes. Although the
&gt; property was originally introduced for this purpose, it is no longer
&gt; necessary. If the generated header file is created by a custom command
&gt; in the same target as the source file, the automatic dependency
&gt; scanning process will recognize the dependency. If the generated
&gt; header file is created by another target, an inter-target dependency
&gt; should be created with the add_dependencies command (if one does not
&gt; already exist due to linking relationships).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225293</commentid>
    <comment_count>3</comment_count>
      <attachid>287609</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-09-01 01:43:58 -0700</bug_when>
    <thetext>Created attachment 287609
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225473</commentid>
    <comment_count>4</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-09-01 12:52:06 -0700</bug_when>
    <thetext>What is the motivation for this change?  What does it fix?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225630</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-09-01 17:27:22 -0700</bug_when>
    <thetext>There are three problems:

1) This unnecessary dependency causes unnecessary recompilation

Updating supplementalDependencyFile triggers unnecessarily
regenerating bindings of WebCoreTestSupport.  This is actually a tiny
problem because WebCoreTestSupport doesn&apos;t have many IDL files.

2) VisualStudio projects generated by CMake triggers preprocess-idls.pl twice

Both WebCoreDerivedSources and WebCoreTestSupport projects trigger
preprocess-idls.pl because they depend on it.
This seems to cause following problems:

  Bug 155872 – [Win] CMake seems to build all generated files every time
  Bug 154938 – Generated sources triggers when not required

Unfortunately, This this patch solve this problem because both
WebCoreDerivedSources and WebCoreTestSupport projects still trigger
make-settings.pl. But, I think this is the right direction to go.

3) Unnecessarily complicated 

This change can simplify the build rule.  I have a plan to generate
bindings outside of CMake. This change can help so much.

  Bug 161433 – [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1226149</commentid>
    <comment_count>6</comment_count>
      <attachid>287609</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-09-03 12:10:01 -0700</bug_when>
    <thetext>Comment on attachment 287609
Patch

Wish I was more of a CMake expert. This patch looks great, but I don’t think I am qualified to say review+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1226855</commentid>
    <comment_count>7</comment_count>
      <attachid>287609</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-09-06 15:08:31 -0700</bug_when>
    <thetext>Comment on attachment 287609
Patch

Clearing flags on attachment: 287609

Committed r205512: &lt;http://trac.webkit.org/changeset/205512&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1226856</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-09-06 15:08:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>287601</attachid>
            <date>2016-08-31 22:43:45 -0700</date>
            <delta_ts>2016-09-01 01:43:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-161474-20160831224131.patch</filename>
            <type>text/plain</type>
            <size>6301</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQwZjE4NzBlNDkxY2Uw
ZjU4MmM3YmIyZTExM2M5ZGY4MjBhMGQ4NS4uYzM1ZWI3ZDQ2ODVjNTBkZGExYzVjNDczOTU1ZjNk
Yzc3NDcwNTVhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA4LTMxICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0g
RGVjb3VwbGUgZ2VuZXJhdGluZyBiaW5kaW5ncyBvZiBXZWJDb3JlIGFuZCBXZWJDb3JlVGVzdFN1
cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2
MTQ3NAorCisgICAgICAgIEdlbmVyYXRpbmcgYmluZGluZ3Mgb2YgV2ViQ29yZSBhbmQgV2ViQ29y
ZVRlc3RTdXBwb3J0IHNoYXJlcyBhCisgICAgICAgIHNpbmdsZSBzdXBwbGVtZW50YWxEZXBlbmRl
bmN5RmlsZS4gIEJ1dCwgbm90aGluZyBzdXBwbGVtZW50cyBhbnkKKyAgICAgICAgSURMIG9mIFdl
YkNvcmVUZXN0U3VwcG9ydC4gIFRoaXMgaW50cm9kdWNlcyB1bm5lY2Vzc2FyeQorICAgICAgICBk
ZXBlbmRlbmNpZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBDTWFrZUxpc3RzLnR4dDogRG8gbm90IGlucHV0IGFueSBJREwgb2YgV2ViQ29yZVRl
c3RTdXBwb3J0IHRvCisgICAgICAgIHByZXByb2Nlc3MtaWRscy5wbC4gIERvIG5vdCB1c2Ugc3Vw
cGxlbWVudGFsRGVwZW5kZW5jeUZpbGUgdG8KKyAgICAgICAgZ2VuZXJhdGUgYmluZGluZ3Mgb2Yg
V2ViQ29yZVRlc3RTdXBwb3J0LiAgQWRkIGEgc291cmNlIGRlcGVuZGVuY3kKKyAgICAgICAgZnJv
bSBwYWdlL1BhZ2UuY3BwIHRvIFNldHRpbmdzTWFjcm9zLmggdG8gZW5zdXJlIG1ha2Vfc2V0dGlu
Z3MucGwKKyAgICAgICAgaXMgZmluaXNoZWQgYmVmb3JlIGNvbXBpbGluZyBXZWJDb3JlLgorCiAy
MDE2LTA4LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgRml4IFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjIwNTE2MQpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4
dAppbmRleCA2ZjRkMDhjZDA1MWExODllMjU5YTUxOWVmY2Q5MTQ2NTFkMDBkNWI2Li5mZjJmMzU1
ZTY5Mjk3YWNjNGJmMjk1Njk5M2FiOGJkMzE2ZWYxZTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApA
QCAtMzY2OCwxMCArMzY2OCw2IEBAIGZvcmVhY2ggKF9pbmNsdWRlICR7V2ViQ29yZV9JRExfSU5D
TFVERVN9KQogICAgIGxpc3QoQVBQRU5EIElETF9JTkNMVURFUyAtLWluY2x1ZGU9JHtXRUJDT1JF
X0RJUn0vJHtfaW5jbHVkZX0pCiBlbmRmb3JlYWNoICgpCiAKLWZvcmVhY2ggKF9pbmNsdWRlICR7
V2ViQ29yZVRlc3RTdXBwb3J0X0lETF9JTkNMVURFU30pCi0gICAgbGlzdChBUFBFTkQgSURMX0lO
Q0xVREVTIC0taW5jbHVkZT0ke1dFQkNPUkVfRElSfS8ke19pbmNsdWRlfSkKLWVuZGZvcmVhY2gg
KCkKLQogc2V0KEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICJMQU5HVUFHRV9KQVZBU0NSSVBU
PTEgJHtGRUFUVVJFX0RFRklORVNfV0lUSF9TUEFDRV9TRVBBUkFUT1J9IikKIAogIyBDcmVhdGUg
SmF2YVNjcmlwdCBDKysgY29kZSBnaXZlbiBhbiBJREwgaW5wdXQKQEAgLTM2NzksMTEgKzM2NzUs
NiBAQCBmb3JlYWNoIChfaWRsICR7V2ViQ29yZV9JRExfRklMRVN9KQogICAgIHNldChJRExfRklM
RVNfTElTVCAiJHtJRExfRklMRVNfTElTVH0ke1dFQkNPUkVfRElSfS8ke19pZGx9XG4iKQogZW5k
Zm9yZWFjaCAoKQogCi1mb3JlYWNoIChfaWRsICR7V2ViQ29yZVRlc3RTdXBwb3J0X0lETF9GSUxF
U30pCi0gICAgc2V0KElETF9GSUxFU19MSVNUICIke0lETF9GSUxFU19MSVNUfSR7V0VCQ09SRV9E
SVJ9LyR7X2lkbH1cbiIpCi1lbmRmb3JlYWNoICgpCi0KLXNldChJRExfRklMRVNfTElTVCAiJHtJ
RExfRklMRVNfTElTVH0ke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vSW50ZXJuYWxTZXR0
aW5nc0dlbmVyYXRlZC5pZGxcbiIpCiBsaXN0KEFQUEVORCBJRExfSU5DTFVERVMgLS1pbmNsdWRl
PSR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfSkKIGxpc3QoQVBQRU5EIFdlYkNvcmVUZXN0
U3VwcG9ydF9JRExfRklMRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0ludGVybmFs
U2V0dGluZ3NHZW5lcmF0ZWQuaWRsKQogCkBAIC0zNjkxLDcgKzM2ODIsNyBAQCBmaWxlKFdSSVRF
ICR7SURMX0ZJTEVTX1RNUH0gJHtJRExfRklMRVNfTElTVH0pCiAKIGFkZF9jdXN0b21fY29tbWFu
ZCgKICAgICBPVVRQVVQgJHtTVVBQTEVNRU5UQUxfREVQRU5ERU5DWV9GSUxFfSAke1dJTkRPV19D
T05TVFJVQ1RPUlNfRklMRX0gJHtXT1JLRVJHTE9CQUxTQ09QRV9DT05TVFJVQ1RPUlNfRklMRX0g
JHtERURJQ0FURURXT1JLRVJHTE9CQUxTQ09QRV9DT05TVFJVQ1RPUlNfRklMRX0KLSAgICBERVBF
TkRTICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsICR7
U0NSSVBUU19QUkVQUk9DRVNTX0lETFN9ICR7V2ViQ29yZV9JRExfRklMRVN9ICR7V2ViQ29yZVRl
c3RTdXBwb3J0X0lETF9GSUxFU30gJHtXRUJDT1JFX0RJUn0vQ01ha2VMaXN0cy50eHQKKyAgICBE
RVBFTkRTICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBs
ICR7U0NSSVBUU19QUkVQUk9DRVNTX0lETFN9ICR7V2ViQ29yZV9JRExfRklMRVN9ICR7V0VCQ09S
RV9ESVJ9L0NNYWtlTGlzdHMudHh0CiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gLUkk
e1dFQkNPUkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3Nj
cmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsIC0tZGVmaW5lcyAiJHtGRUFUVVJFX0RFRklORVNfSkFW
QVNDUklQVH0iIC0taWRsRmlsZXNMaXN0ICR7SURMX0ZJTEVTX1RNUH0gLS1zdXBwbGVtZW50YWxE
ZXBlbmRlbmN5RmlsZSAke1NVUFBMRU1FTlRBTF9ERVBFTkRFTkNZX0ZJTEV9IC0td2luZG93Q29u
c3RydWN0b3JzRmlsZSAke1dJTkRPV19DT05TVFJVQ1RPUlNfRklMRX0gLS13b3JrZXJHbG9iYWxT
Y29wZUNvbnN0cnVjdG9yc0ZpbGUgJHtXT1JLRVJHTE9CQUxTQ09QRV9DT05TVFJVQ1RPUlNfRklM
RX0KIC0tZGVkaWNhdGVkV29ya2VyR2xvYmFsU2NvcGVDb25zdHJ1Y3RvcnNGaWxlICR7REVESUNB
VEVEV09SS0VSR0xPQkFMU0NPUEVfQ09OU1RSVUNUT1JTX0ZJTEV9CiAgICAgVkVSQkFUSU0pCkBA
IC0zNzEyLDE1ICszNzAzLDE3IEBAIEdFTkVSQVRFX0JJTkRJTkdTKFdlYkNvcmVfREVSSVZFRF9T
T1VSQ0VTCiAgICAgJHtTVVBQTEVNRU5UQUxfREVQRU5ERU5DWV9GSUxFfQogICAgICR7QURESVRJ
T05BTF9CSU5ESU5HU19ERVBFTkRFTkNJRVN9KQogCitmb3JlYWNoIChfaW5jbHVkZSAke1dlYkNv
cmVUZXN0U3VwcG9ydF9JRExfSU5DTFVERVN9KQorICAgIGxpc3QoQVBQRU5EIElETF9JTkNMVURF
UyAtLWluY2x1ZGU9JHtXRUJDT1JFX0RJUn0vJHtfaW5jbHVkZX0pCitlbmRmb3JlYWNoICgpCisK
IEdFTkVSQVRFX0JJTkRJTkdTKFdlYkNvcmVUZXN0U3VwcG9ydF9TT1VSQ0VTCiAgICAgIiR7V2Vi
Q29yZVRlc3RTdXBwb3J0X0lETF9GSUxFU30iCiAgICAgIiR7V0VCQ09SRV9ESVJ9IgogICAgICIk
e0lETF9JTkNMVURFU30iCiAgICAgIiR7RkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFR9IgogICAg
ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfSBKUyBKUyBjcHAKLSAgICAke0lETF9BVFRS
SUJVVEVTX0ZJTEV9Ci0gICAgJHtTVVBQTEVNRU5UQUxfREVQRU5ERU5DWV9GSUxFfQotICAgICR7
QURESVRJT05BTF9CSU5ESU5HU19ERVBFTkRFTkNJRVN9KQorICAgICR7SURMX0FUVFJJQlVURVNf
RklMRX0pCiAKICMgV2ViQ29yZSBKUyBCdWlsdGlucwogCkBAIC0zODEyLDYgKzM4MDUsNyBAQCBs
aXN0KEFQUEVORCBXZWJDb3JlX0RFUklWRURfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19XRUJD
T1JFX0RJUn0vRXhjZXB0aW9uQ29kZQogCiAKIEdFTkVSQVRFX1NFVFRJTkdTX01BQ1JPUygke1dF
QkNPUkVfRElSfS9wYWdlL1NldHRpbmdzLmluIFNldHRpbmdzTWFjcm9zLmgpCitBRERfU09VUkNF
X1dFQkNPUkVfREVSSVZFRF9ERVBFTkRFTkNJRVMoJHtXRUJDT1JFX0RJUn0vcGFnZS9QYWdlLmNw
cCBTZXR0aW5nc01hY3Jvcy5oKQogbGlzdChBUFBFTkQgV2ViQ29yZVRlc3RTdXBwb3J0X1NPVVJD
RVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0ludGVybmFsU2V0dGluZ3NHZW5lcmF0
ZWQuY3BwKQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2Ug
Yi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCmluZGV4IDMxNDVjMDY3OWVlYjQ0NzU5
ZjZhZDhjODQ5NzUxOWI1MmE0MjBlNzcuLmUyYzI1NThjMzRjMzIxZThhYmQ0MWU0YjI1ZGY0MmVh
ZTRkZDlhNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKKysr
IGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQpAQCAtNTIsNiArNTIsOSBAQCBlbmRt
YWNybygpCiAjICAgX2dlbmVyYXRvciBpcyBhIHZhbHVlIG9mIC0tZ2VuZXJhdG9yIGFyZ3VtZW50
LgogIyAgIF9zdXBwbGVtZW50YWxfZGVwZW5kZW5jeV9maWxlIGlzIGEgdmFsdWUgb2YgLS1zdXBw
bGVtZW50YWxEZXBlbmRlbmN5RmlsZS4gKG9wdGlvbmFsKQogbWFjcm8oR0VORVJBVEVfQklORElO
R1MgX291dHB1dF9zb3VyY2UgX2lucHV0X2ZpbGVzIF9iYXNlX2RpciBfaWRsX2luY2x1ZGVzIF9m
ZWF0dXJlcyBfZGVzdGluYXRpb24gX3ByZWZpeCBfZ2VuZXJhdG9yIF9leHRlbnNpb24gX2lkbF9h
dHRyaWJ1dGVzX2ZpbGUpCisgICAgc2V0KF9zdXBwbGVtZW50YWxfZGVwZW5kZW5jeSkKKyAgICBz
ZXQoX3N1cHBsZW1lbnRhbF9kZXBlbmRlbmN5X2ZpbGUpCisgICAgc2V0KF9hZGRpdGlvbmFsX2Rl
cGVuZGVuY2llcykKICAgICBzZXQoQklORElOR19HRU5FUkFUT1IgJHtXRUJDT1JFX0RJUn0vYmlu
ZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCkKICAgICBzZXQoX2FyZ3MgJHtBUkdO
fSkKICAgICBsaXN0KExFTkdUSCBfYXJncyBfYXJnQ291bnQpCmRpZmYgLS1naXQgYS9DaGFuZ2VM
b2cgYi9DaGFuZ2VMb2cKaW5kZXggZTcwYzI5MzI5MGI1OTA2ZDQ1Y2M5MzE4OGVjOTE2NDcwN2Ji
YjFjOS4uYTYyMjcyZGY5NTllYWQ0ZjI1ZTk3M2Y5YWYyYzUxYWYyYzI2OGQyMCAxMDA2NDQKLS0t
IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA4LTMx
ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtD
TWFrZV0gRGVjb3VwbGUgZ2VuZXJhdGluZyBiaW5kaW5ncyBvZiBXZWJDb3JlIGFuZCBXZWJDb3Jl
VGVzdFN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE2MTQ3NAorCisgICAgICAgIEdlbmVyYXRpbmcgYmluZGluZ3Mgb2YgV2ViQ29yZSBhbmQg
V2ViQ29yZVRlc3RTdXBwb3J0IHNoYXJlcyBhCisgICAgICAgIHNpbmdsZSBzdXBwbGVtZW50YWxE
ZXBlbmRlbmN5RmlsZS4gIEJ1dCwgbm90aGluZyBzdXBwbGVtZW50cyBhbnkKKyAgICAgICAgSURM
IG9mIFdlYkNvcmVUZXN0U3VwcG9ydC4gIFRoaXMgaW50cm9kdWNlcyB1bm5lY2Vzc2FyeQorICAg
ICAgICBkZXBlbmRlbmNpZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlOgorICAgICAgICAo
R0VORVJBVEVfQklORElOR1MpOiBDbGVhciB1bmluaXRpYWxpemVkIHZhcmlhYmxlcyBiZWZvcmUK
KyAgICAgICAgdXNlLiBUaGlzIGNhdXNlcyBhIHByb2JsZW0gaW4gdGhlIHNlY29uZCB0aW1lIG9m
IGNhbGxpbmcKKyAgICAgICAgR0VORVJBVEVfQklORElOR1MuCisKIDIwMTYtMDgtMjkgIFBlciBB
cm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4
IFdpbkNhaXJvIGJ1aWxkIGFmdGVyIHIyMDUwOTAuCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>287609</attachid>
            <date>2016-09-01 01:43:58 -0700</date>
            <delta_ts>2016-09-06 15:08:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-161474-20160901174144.patch</filename>
            <type>text/plain</type>
            <size>6326</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFhMzVlNjNjNDQwNmMy
NDQxOWYyZjk5ODMzMGI3ZmE4NGUxYjk1MC4uMzAxOTNiYTlkODkzODQ4YzM4MmEyMTA0MWM0NWQ3
YmU5NjI0ZTEzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA4LTMxICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0g
RGVjb3VwbGUgZ2VuZXJhdGluZyBiaW5kaW5ncyBvZiBXZWJDb3JlIGFuZCBXZWJDb3JlVGVzdFN1
cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2
MTQ3NAorCisgICAgICAgIEdlbmVyYXRpbmcgYmluZGluZ3Mgb2YgV2ViQ29yZSBhbmQgV2ViQ29y
ZVRlc3RTdXBwb3J0IHNoYXJlcyBhCisgICAgICAgIHNpbmdsZSBzdXBwbGVtZW50YWxEZXBlbmRl
bmN5RmlsZS4gIEJ1dCwgbm90aGluZyBzdXBwbGVtZW50cyBhbnkKKyAgICAgICAgSURMIG9mIFdl
YkNvcmVUZXN0U3VwcG9ydC4gIFRoaXMgaW50cm9kdWNlcyB1bm5lY2Vzc2FyeQorICAgICAgICBk
ZXBlbmRlbmNpZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBDTWFrZUxpc3RzLnR4dDogRG8gbm90IGlucHV0IGFueSBJREwgb2YgV2ViQ29yZVRl
c3RTdXBwb3J0IHRvCisgICAgICAgIHByZXByb2Nlc3MtaWRscy5wbC4gIERvIG5vdCB1c2Ugc3Vw
cGxlbWVudGFsRGVwZW5kZW5jeUZpbGUgdG8KKyAgICAgICAgZ2VuZXJhdGUgYmluZGluZ3Mgb2Yg
V2ViQ29yZVRlc3RTdXBwb3J0LiAgQWRkIFNldHRpbmdzTWFjcm9zLmggYXMKKyAgICAgICAgYSBz
b3VyY2UgZmlsZSBvZiBXZWJDb3JlRGVyaXZlZFNvdXJjZXMgdG8gZW5zdXJlIG1ha2Vfc2V0dGlu
Z3MucGwKKyAgICAgICAgaXMgZmluaXNoZWQgYmVmb3JlIGNvbXBpbGluZyBXZWJDb3JlRGVyaXZl
ZFNvdXJjZXMuCisKIDIwMTYtMDgtMzEgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp
bC5jb20+CiAKICAgICAgICAgW0pTQ10gQWRkIGluaXRpYXRvciBwYXJhbWV0ZXIgdG8gbW9kdWxl
IHBpcGVsaW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1Nv
dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IGFiNjY2YjM4ZWY2ZjZkZTQxYzZlOGYz
MmIxZGVmOTI0ODlmZjEzZTUuLjliOTY3ZmZjMTk2ODM4NGRlNjlkY2NiYTU0OGUwMjY0MjM4NDk1
MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJj
ZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0zNjY5LDEwICszNjY5LDYgQEAgZm9yZWFjaCAo
X2luY2x1ZGUgJHtXZWJDb3JlX0lETF9JTkNMVURFU30pCiAgICAgbGlzdChBUFBFTkQgSURMX0lO
Q0xVREVTIC0taW5jbHVkZT0ke1dFQkNPUkVfRElSfS8ke19pbmNsdWRlfSkKIGVuZGZvcmVhY2gg
KCkKIAotZm9yZWFjaCAoX2luY2x1ZGUgJHtXZWJDb3JlVGVzdFN1cHBvcnRfSURMX0lOQ0xVREVT
fSkKLSAgICBsaXN0KEFQUEVORCBJRExfSU5DTFVERVMgLS1pbmNsdWRlPSR7V0VCQ09SRV9ESVJ9
LyR7X2luY2x1ZGV9KQotZW5kZm9yZWFjaCAoKQotCiBzZXQoRkVBVFVSRV9ERUZJTkVTX0pBVkFT
Q1JJUFQgIkxBTkdVQUdFX0pBVkFTQ1JJUFQ9MSAke0ZFQVRVUkVfREVGSU5FU19XSVRIX1NQQUNF
X1NFUEFSQVRPUn0iKQogCiAjIENyZWF0ZSBKYXZhU2NyaXB0IEMrKyBjb2RlIGdpdmVuIGFuIElE
TCBpbnB1dApAQCAtMzY4MCwxMSArMzY3Niw2IEBAIGZvcmVhY2ggKF9pZGwgJHtXZWJDb3JlX0lE
TF9GSUxFU30pCiAgICAgc2V0KElETF9GSUxFU19MSVNUICIke0lETF9GSUxFU19MSVNUfSR7V0VC
Q09SRV9ESVJ9LyR7X2lkbH1cbiIpCiBlbmRmb3JlYWNoICgpCiAKLWZvcmVhY2ggKF9pZGwgJHtX
ZWJDb3JlVGVzdFN1cHBvcnRfSURMX0ZJTEVTfSkKLSAgICBzZXQoSURMX0ZJTEVTX0xJU1QgIiR7
SURMX0ZJTEVTX0xJU1R9JHtXRUJDT1JFX0RJUn0vJHtfaWRsfVxuIikKLWVuZGZvcmVhY2ggKCkK
LQotc2V0KElETF9GSUxFU19MSVNUICIke0lETF9GSUxFU19MSVNUfSR7REVSSVZFRF9TT1VSQ0VT
X1dFQkNPUkVfRElSfS9JbnRlcm5hbFNldHRpbmdzR2VuZXJhdGVkLmlkbFxuIikKIGxpc3QoQVBQ
RU5EIElETF9JTkNMVURFUyAtLWluY2x1ZGU9JHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9
KQogbGlzdChBUFBFTkQgV2ViQ29yZVRlc3RTdXBwb3J0X0lETF9GSUxFUyAke0RFUklWRURfU09V
UkNFU19XRUJDT1JFX0RJUn0vSW50ZXJuYWxTZXR0aW5nc0dlbmVyYXRlZC5pZGwpCiAKQEAgLTM2
OTIsNyArMzY4Myw3IEBAIGZpbGUoV1JJVEUgJHtJRExfRklMRVNfVE1QfSAke0lETF9GSUxFU19M
SVNUfSkKIAogYWRkX2N1c3RvbV9jb21tYW5kKAogICAgIE9VVFBVVCAke1NVUFBMRU1FTlRBTF9E
RVBFTkRFTkNZX0ZJTEV9ICR7V0lORE9XX0NPTlNUUlVDVE9SU19GSUxFfSAke1dPUktFUkdMT0JB
TFNDT1BFX0NPTlNUUlVDVE9SU19GSUxFfSAke0RFRElDQVRFRFdPUktFUkdMT0JBTFNDT1BFX0NP
TlNUUlVDVE9SU19GSUxFfQotICAgIERFUEVORFMgJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2Ny
aXB0cy9wcmVwcm9jZXNzLWlkbHMucGwgJHtTQ1JJUFRTX1BSRVBST0NFU1NfSURMU30gJHtXZWJD
b3JlX0lETF9GSUxFU30gJHtXZWJDb3JlVGVzdFN1cHBvcnRfSURMX0ZJTEVTfSAke1dFQkNPUkVf
RElSfS9DTWFrZUxpc3RzLnR4dAorICAgIERFUEVORFMgJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mv
c2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwgJHtTQ1JJUFRTX1BSRVBST0NFU1NfSURMU30gJHtX
ZWJDb3JlX0lETF9GSUxFU30gJHtXRUJDT1JFX0RJUn0vQ01ha2VMaXN0cy50eHQKICAgICBDT01N
QU5EICR7UEVSTF9FWEVDVVRBQkxFfSAtSSR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMg
JHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwgLS1kZWZp
bmVzICIke0ZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUfSIgLS1pZGxGaWxlc0xpc3QgJHtJRExf
RklMRVNfVE1QfSAtLXN1cHBsZW1lbnRhbERlcGVuZGVuY3lGaWxlICR7U1VQUExFTUVOVEFMX0RF
UEVOREVOQ1lfRklMRX0gLS13aW5kb3dDb25zdHJ1Y3RvcnNGaWxlICR7V0lORE9XX0NPTlNUUlVD
VE9SU19GSUxFfSAtLXdvcmtlckdsb2JhbFNjb3BlQ29uc3RydWN0b3JzRmlsZSAke1dPUktFUkdM
T0JBTFNDT1BFX0NPTlNUUlVDVE9SU19GSUxFfQogLS1kZWRpY2F0ZWRXb3JrZXJHbG9iYWxTY29w
ZUNvbnN0cnVjdG9yc0ZpbGUgJHtERURJQ0FURURXT1JLRVJHTE9CQUxTQ09QRV9DT05TVFJVQ1RP
UlNfRklMRX0KICAgICBWRVJCQVRJTSkKQEAgLTM3MTMsMTUgKzM3MDQsMTcgQEAgR0VORVJBVEVf
QklORElOR1MoV2ViQ29yZV9ERVJJVkVEX1NPVVJDRVMKICAgICAke1NVUFBMRU1FTlRBTF9ERVBF
TkRFTkNZX0ZJTEV9CiAgICAgJHtBRERJVElPTkFMX0JJTkRJTkdTX0RFUEVOREVOQ0lFU30pCiAK
K2ZvcmVhY2ggKF9pbmNsdWRlICR7V2ViQ29yZVRlc3RTdXBwb3J0X0lETF9JTkNMVURFU30pCisg
ICAgbGlzdChBUFBFTkQgSURMX0lOQ0xVREVTIC0taW5jbHVkZT0ke1dFQkNPUkVfRElSfS8ke19p
bmNsdWRlfSkKK2VuZGZvcmVhY2ggKCkKKwogR0VORVJBVEVfQklORElOR1MoV2ViQ29yZVRlc3RT
dXBwb3J0X1NPVVJDRVMKICAgICAiJHtXZWJDb3JlVGVzdFN1cHBvcnRfSURMX0ZJTEVTfSIKICAg
ICAiJHtXRUJDT1JFX0RJUn0iCiAgICAgIiR7SURMX0lOQ0xVREVTfSIKICAgICAiJHtGRUFUVVJF
X0RFRklORVNfSkFWQVNDUklQVH0iCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9
IEpTIEpTIGNwcAotICAgICR7SURMX0FUVFJJQlVURVNfRklMRX0KLSAgICAke1NVUFBMRU1FTlRB
TF9ERVBFTkRFTkNZX0ZJTEV9Ci0gICAgJHtBRERJVElPTkFMX0JJTkRJTkdTX0RFUEVOREVOQ0lF
U30pCisgICAgJHtJRExfQVRUUklCVVRFU19GSUxFfSkKIAogIyBXZWJDb3JlIEpTIEJ1aWx0aW5z
CiAKQEAgLTM4MTMsNiArMzgwNiw3IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfREVSSVZFRF9TT1VS
Q0VTICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9FeGNlcHRpb25Db2RlCiAKIAogR0VO
RVJBVEVfU0VUVElOR1NfTUFDUk9TKCR7V0VCQ09SRV9ESVJ9L3BhZ2UvU2V0dGluZ3MuaW4gU2V0
dGluZ3NNYWNyb3MuaCkKK2xpc3QoQVBQRU5EIFdlYkNvcmVfREVSSVZFRF9TT1VSQ0VTICR7REVS
SVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9TZXR0aW5nc01hY3Jvcy5oKQogbGlzdChBUFBFTkQg
V2ViQ29yZVRlc3RTdXBwb3J0X1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9
L0ludGVybmFsU2V0dGluZ3NHZW5lcmF0ZWQuY3BwKQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9j
bWFrZS9XZWJLaXRNYWNyb3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtl
CmluZGV4IDMxNDVjMDY3OWVlYjQ0NzU5ZjZhZDhjODQ5NzUxOWI1MmE0MjBlNzcuLmUyYzI1NThj
MzRjMzIxZThhYmQ0MWU0YjI1ZGY0MmVhZTRkZDlhNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr
ZS9XZWJLaXRNYWNyb3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFr
ZQpAQCAtNTIsNiArNTIsOSBAQCBlbmRtYWNybygpCiAjICAgX2dlbmVyYXRvciBpcyBhIHZhbHVl
IG9mIC0tZ2VuZXJhdG9yIGFyZ3VtZW50LgogIyAgIF9zdXBwbGVtZW50YWxfZGVwZW5kZW5jeV9m
aWxlIGlzIGEgdmFsdWUgb2YgLS1zdXBwbGVtZW50YWxEZXBlbmRlbmN5RmlsZS4gKG9wdGlvbmFs
KQogbWFjcm8oR0VORVJBVEVfQklORElOR1MgX291dHB1dF9zb3VyY2UgX2lucHV0X2ZpbGVzIF9i
YXNlX2RpciBfaWRsX2luY2x1ZGVzIF9mZWF0dXJlcyBfZGVzdGluYXRpb24gX3ByZWZpeCBfZ2Vu
ZXJhdG9yIF9leHRlbnNpb24gX2lkbF9hdHRyaWJ1dGVzX2ZpbGUpCisgICAgc2V0KF9zdXBwbGVt
ZW50YWxfZGVwZW5kZW5jeSkKKyAgICBzZXQoX3N1cHBsZW1lbnRhbF9kZXBlbmRlbmN5X2ZpbGUp
CisgICAgc2V0KF9hZGRpdGlvbmFsX2RlcGVuZGVuY2llcykKICAgICBzZXQoQklORElOR19HRU5F
UkFUT1IgJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5w
bCkKICAgICBzZXQoX2FyZ3MgJHtBUkdOfSkKICAgICBsaXN0KExFTkdUSCBfYXJncyBfYXJnQ291
bnQpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzlhNzc1YjNmMzM4
ZThkMDE3MGQ3NjQ0Njc4MzM0NmNlODRhMWQxMy4uNzI4NGUyNmYyMDE0MTkyMzNmMDY0YzdiMGEw
MzY3YmJkYTc3NmQxMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDIwIEBACisyMDE2LTA4LTMxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlp
QHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gRGVjb3VwbGUgZ2VuZXJhdGluZyBiaW5kaW5n
cyBvZiBXZWJDb3JlIGFuZCBXZWJDb3JlVGVzdFN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQ3NAorCisgICAgICAgIEdlbmVyYXRpbmcg
YmluZGluZ3Mgb2YgV2ViQ29yZSBhbmQgV2ViQ29yZVRlc3RTdXBwb3J0IHNoYXJlcyBhCisgICAg
ICAgIHNpbmdsZSBzdXBwbGVtZW50YWxEZXBlbmRlbmN5RmlsZS4gIEJ1dCwgbm90aGluZyBzdXBw
bGVtZW50cyBhbnkKKyAgICAgICAgSURMIG9mIFdlYkNvcmVUZXN0U3VwcG9ydC4gIFRoaXMgaW50
cm9kdWNlcyB1bm5lY2Vzc2FyeQorICAgICAgICBkZXBlbmRlbmNpZXMuCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlOgorICAgICAgICAoR0VORVJBVEVfQklORElOR1MpOiBDbGVhciB1bmluaXRp
YWxpemVkIHZhcmlhYmxlcyBiZWZvcmUKKyAgICAgICAgdXNlLiBUaGlzIGNhdXNlcyBhIHByb2Js
ZW0gaW4gdGhlIHNlY29uZCB0aW1lIG9mIGNhbGxpbmcKKyAgICAgICAgR0VORVJBVEVfQklORElO
R1MuCisKIDIwMTYtMDgtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu
Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEJ1bXAgR1RLKyB2ZXJzaW9ucyBudW1iZXJzLgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>