161465 2016-08-31 16:38:42 -0700 [Mac] Web Inspector: Remove stale inspector process termination code 2016-09-01 11:10:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1225151 0 joepeck 2016-08-31 16:38:42 -0700 Summary: Remove stale inspector process termination code This code doesn't appear to get run when the WebContentProcess inside of an Inspector Process gets killed. Instead the general WebInspectorProxy webProcessDidCrash closes the proxy. So this code appears to be unreachable and stale. 1225152 1 webkit-bug-importer 2016-08-31 16:39:17 -0700 <rdar://problem/28106584> 1225154 2 287564 joepeck 2016-08-31 16:41:12 -0700 Created attachment 287564 [PATCH] Proposed Fix 1225388 3 287564 bburg 2016-09-01 10:49:48 -0700 Comment on attachment 287564 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287564&action=review r=me > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:-165 > -- (void)_didRelaunchProcess This is an override from WKWebViewPrivate, but the base implementation only does anything for iOS, and it's only called from PageClientImplIOS.mm. I wonder why we went this route... 1225405 4 287564 commit-queue 2016-09-01 11:10:47 -0700 Comment on attachment 287564 [PATCH] Proposed Fix Clearing flags on attachment: 287564 Committed r205299: <http://trac.webkit.org/changeset/205299> 1225406 5 commit-queue 2016-09-01 11:10:51 -0700 All reviewed patches have been landed. Closing bug. 287564 2016-08-31 16:41:12 -0700 2016-09-01 11:10:47 -0700 [PATCH] Proposed Fix stale-1.patch text/plain 3800 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZWFjMjAzLi5hY2IwZDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTYtMDgtMzEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgc3RhbGUgaW5zcGVjdG9yIHByb2Nl c3MgdGVybWluYXRpb24gY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYxNDY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODEwNjU4ND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9XZWJJbnNwZWN0b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclBy b3h5OjpkaWRSZWxhdW5jaEluc3BlY3RvclBhZ2VQcm9jZXNzKTogRGVsZXRlZC4KKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFj L1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoLVtXS1dlYkluc3BlY3RvclByb3h5 T2JqQ0FkYXB0ZXIgZGlkUmVsYXVuY2hQcm9jZXNzXSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dL V2ViSW5zcGVjdG9yV0tXZWJWaWV3IF9kaWRSZWxhdW5jaFByb2Nlc3NdKTogRGVsZXRlZC4KKyAg ICAgICAgVGhpcyBjb2RlIGRvZXNuJ3QgYXBwZWFyIHRvIGJlIHJ1biB3aGVuIHRoZSBXZWJDb250 ZW50IHByb2Nlc3MgaW5zaWRlCisgICAgICAgIG9mIGFuIEluc3BlY3RvciBwcm9jZXNzIGNyYXNo ZXMuIFRoZSBnZW5lcmFsIFdlYkluc3BlY3RvclByb3h5IGhhcyBpdHMKKyAgICAgICAgb3duIGhh bmRsaW5nIG9mIHdoZW4gdGhlIHBhZ2UgaW5zaWRlIGFuIGluc3BlY3RvciBwcm9jZXNzIGNyYXNo ZXMsIHNvCisgICAgICAgIHRoaXMgTWFjIHNwZWNpZmljIHBhdGggYXBwZWFycyB0byBiZSB1bnVz ZWQgYW5kIHN0YWxlLgorCiAyMDE2LTA4LTMxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHJ1bnRpbWUgZmxhZyBmb3IgdXNpbmcgVVJM UGFyc2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9y UHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNw cAppbmRleCBlNDY1NzJkLi45OTQ2MjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKQEAgLTE3OCwxNyArMTc4LDYgQEAgdm9pZCBXZWJJbnNw ZWN0b3JQcm94eTo6Y2xvc2UoKQogICAgIGRpZENsb3NlKCk7CiB9CiAKLXZvaWQgV2ViSW5zcGVj dG9yUHJveHk6OmRpZFJlbGF1bmNoSW5zcGVjdG9yUGFnZVByb2Nlc3MoKQotewotICAgIG1faW5z cGVjdG9yUGFnZS0+cHJvY2VzcygpLmFkZE1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6V2ViSW5z cGVjdG9yUHJveHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV9pbnNwZWN0ZWRQYWdlLT5wYWdl SUQoKSwgKnRoaXMpOwotICAgIG1faW5zcGVjdG9yUGFnZS0+cHJvY2VzcygpLmFzc3VtZVJlYWRB Y2Nlc3NUb0Jhc2VVUkwoV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvckJhc2VVUkwoKSk7Ci0K LSAgICAvLyBXaGVuIGRpZFJlbGF1bmNoSW5zcGVjdG9yUGFnZVByb2Nlc3MgaXMgY2FsbGVkIHdl IGNhbiBhc3N1bWUgaXQgaXMgZHVyaW5nIGEgbG9hZCByZXF1ZXN0LgotICAgIC8vIEFueSBtZXNz YWdlcyB3ZSB3b3VsZCBoYXZlIHNlbnQgdG8gYSB0ZXJtaW5hdGVkIHByb2Nlc3MgbmVlZCB0byBi ZSByZS1zZW50LgotCi0gICAgbV9pbnNwZWN0b3JQYWdlLT5wcm9jZXNzKCkuc2VuZChNZXNzYWdl czo6V2ViSW5zcGVjdG9yVUk6OkVzdGFibGlzaENvbm5lY3Rpb24obV9jb25uZWN0aW9uSWRlbnRp ZmllciwgbV9pbnNwZWN0ZWRQYWdlLT5wYWdlSUQoKSwgbV91bmRlclRlc3QsIGluc3BlY3Rpb25M ZXZlbCgpKSwgbV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQoKSk7Ci19Ci0KIHZvaWQgV2ViSW5zcGVj dG9yUHJveHk6OnNob3dDb25zb2xlKCkKIHsKICAgICBpZiAoIW1faW5zcGVjdGVkUGFnZSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmgKaW5kZXggODkzZWVl NS4uMTgyN2IzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3Bl Y3RvclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclBy b3h5LmgKQEAgLTkyLDggKzkyLDYgQEAgcHVibGljOgogICAgIHZvaWQgaGlkZSgpOwogICAgIHZv aWQgY2xvc2UoKTsKIAotICAgIHZvaWQgZGlkUmVsYXVuY2hJbnNwZWN0b3JQYWdlUHJvY2Vzcygp OwotCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBXS19BUElfRU5BQkxFRAogICAgIHZvaWQgY3JlYXRl SW5zcGVjdG9yV2luZG93KCk7CiAgICAgdm9pZCB1cGRhdGVJbnNwZWN0b3JXaW5kb3dUaXRsZSgp IGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNw ZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVj dG9yUHJveHlNYWMubW0KaW5kZXggZWUwZDEwMC4uYzFjMDBlMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCkBAIC03MSw3 ICs3MSw2IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCB3ZWJWaWV3Q2xvc2VUaW1lb3V0ID0gNjA7 CiAKIC0gKGlkKWluaXRXaXRoV2ViSW5zcGVjdG9yUHJveHk6KFdlYkluc3BlY3RvclByb3h5Kilp bnNwZWN0b3JQcm94eTsKIC0gKHZvaWQpY2xvc2U7Ci0tICh2b2lkKWRpZFJlbGF1bmNoUHJvY2Vz czsKIAogQGVuZAogCkBAIC05OSwxMSArOTgsNiBAQCBzdGF0aWMgY29uc3QgdW5zaWduZWQgd2Vi Vmlld0Nsb3NlVGltZW91dCA9IDYwOwogICAgIF9pbnNwZWN0b3JQcm94eSA9IG51bGxwdHI7CiB9 CiAKLS0gKHZvaWQpZGlkUmVsYXVuY2hQcm9jZXNzCi17Ci0gICAgc3RhdGljX2Nhc3Q8V2ViSW5z cGVjdG9yUHJveHkqPihfaW5zcGVjdG9yUHJveHkpLT5kaWRSZWxhdW5jaEluc3BlY3RvclBhZ2VQ cm9jZXNzKCk7Ci19Ci0KIC0gKHZvaWQpd2luZG93RGlkTW92ZTooTlNOb3RpZmljYXRpb24gKilu b3RpZmljYXRpb24KIHsKICAgICBzdGF0aWNfY2FzdDxXZWJJbnNwZWN0b3JQcm94eSo+KF9pbnNw ZWN0b3JQcm94eSktPndpbmRvd0ZyYW1lRGlkQ2hhbmdlKCk7CkBAIC0xNjIsMTEgKzE1Niw2IEBA IHN0YXRpYyBjb25zdCB1bnNpZ25lZCB3ZWJWaWV3Q2xvc2VUaW1lb3V0ID0gNjA7CiAgICAgcmV0 dXJuIFdLSW5zcGVjdG9yVmlld1RhZzsKIH0KIAotLSAodm9pZClfZGlkUmVsYXVuY2hQcm9jZXNz Ci17Ci0gICAgW3NlbGYuaW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlciBkaWRSZWxhdW5jaFByb2Nl c3NdOwotfQotCiBAZW5kCiAKIG5hbWVzcGFjZSBXZWJLaXQgewo=